arvados.git
9 years ago3036: Fix #updating collection objects. Fixed database seed for empty_collection.
Peter Amstutz [Wed, 20 Aug 2014 02:09:02 +0000 (22:09 -0400)]
3036: Fix #updating collection objects.  Fixed database seed for empty_collection.

9 years ago3610: Move live log display into its own tab, avoid clobbering with tab reload.
Tom Clegg [Wed, 20 Aug 2014 00:57:46 +0000 (20:57 -0400)]
3610: Move live log display into its own tab, avoid clobbering with tab reload.

* PipelineInstances#show gets a Log tab dedicated to the live log
  window, rather than hiding it below the components table.

* Jobs#show uses its Log tab to show a live log window (instead of a
  teaser) when the log is not yet finished/written to disk.

* In both cases, the live log window's tab pane intercepts and ignores
  the arv:tab:reload event. (Previously, in addition to appending log
  entries to the live window, websocket events would trigger a
  "refresh all tabs" event, which would blow away the whole log viewer
  anyway.)

* Behave sensibly when multiple lines of stderr arrive in a single
  websocket update event.

* Stop displaying "update {pipeline-uuid}" messages that have no
  additional content.

* Stop scrolling to bottom every time an ajax:complete fires
  somewhere. (Previously, seeing anything above the last page of logs
  was somewhere between annoying and impossible.)

* Make the log window taller.

9 years agoMerge branch 'master' into 3153-auto-setup-user
radhika [Tue, 19 Aug 2014 21:30:26 +0000 (17:30 -0400)]
Merge branch 'master' into 3153-auto-setup-user

9 years ago3153: auto-setup user during creation.
radhika [Tue, 19 Aug 2014 21:29:46 +0000 (17:29 -0400)]
3153: auto-setup user during creation.

9 years ago3036: Fix merge mistakes in collection_controller.
Peter Amstutz [Tue, 19 Aug 2014 17:19:52 +0000 (13:19 -0400)]
3036: Fix merge mistakes in collection_controller.

9 years ago3036: Fixed migration to migrate modified_by_client_uuid and
Peter Amstutz [Tue, 19 Aug 2014 15:37:24 +0000 (11:37 -0400)]
3036: Fixed migration to migrate modified_by_client_uuid and
modified_by_user_uuid (because modified_by isn't a column, whoops).  Also fills
in in useless updated_at column because it has a NOT NULL constraint.

9 years agoMerge branch 'master' into 3036-collection-uuids
Peter Amstutz [Tue, 19 Aug 2014 15:36:15 +0000 (11:36 -0400)]
Merge branch 'master' into 3036-collection-uuids

Conflicts:
services/api/app/controllers/arvados/v1/collections_controller.rb
services/api/app/models/collection.rb

9 years ago3036: Updated migration to set modified_at instead of updated_at, added modified_by.
Peter Amstutz [Tue, 19 Aug 2014 15:07:00 +0000 (11:07 -0400)]
3036: Updated migration to set modified_at instead of updated_at, added modified_by.

9 years agoMerge branch 'master' into 3504-clients-compatible-with-3036
Peter Amstutz [Tue, 19 Aug 2014 15:05:33 +0000 (11:05 -0400)]
Merge branch 'master' into 3504-clients-compatible-with-3036

9 years ago3504: Fix collection chooser. Fix generic link render to use uuid if nothing
Peter Amstutz [Tue, 19 Aug 2014 13:40:07 +0000 (09:40 -0400)]
3504: Fix collection chooser.  Fix generic link render to use uuid if nothing
else is available.  Fix tags for objects other than collections.

9 years ago3504: Fix collection page rendering to work with collections as regular uuids.
Peter Amstutz [Tue, 19 Aug 2014 03:13:19 +0000 (23:13 -0400)]
3504: Fix collection page rendering to work with collections as regular uuids.
Render tags onn project page.  Improve helper function for rendering links to
Arvados objects.

9 years agoMerge branch '3114-copy-to-project' closes #3114
Tom Clegg [Mon, 18 Aug 2014 22:58:06 +0000 (18:58 -0400)]
Merge branch '3114-copy-to-project' closes #3114

9 years ago3114: Follow return_to param, if given, when redirecting users#show to projects#show.
Tom Clegg [Mon, 18 Aug 2014 22:19:29 +0000 (18:19 -0400)]
3114: Follow return_to param, if given, when redirecting users#show to projects#show.

Don't redirect non-html requests.

9 years ago3114: Update test case: searching for own uuid now shows home project.
Tom Clegg [Mon, 18 Aug 2014 22:18:55 +0000 (18:18 -0400)]
3114: Update test case: searching for own uuid now shows home project.

9 years ago3114: Merge branch 'master' into 3114-copy-to-project
Tom Clegg [Mon, 18 Aug 2014 22:02:47 +0000 (18:02 -0400)]
3114: Merge branch 'master' into 3114-copy-to-project

9 years ago3593: Add explanatory comment about Workbench's user cache.
Brett Smith [Mon, 18 Aug 2014 18:38:57 +0000 (14:38 -0400)]
3593: Add explanatory comment about Workbench's user cache.

Refs #3593.

9 years ago3114: Fix href in json response for generic #create action too. See 7485476.
Tom Clegg [Mon, 18 Aug 2014 20:51:13 +0000 (16:51 -0400)]
3114: Fix href in json response for generic #create action too. See 7485476.

9 years agoMerge branch '2800-pgs' refs #2800
Tom Clegg [Mon, 18 Aug 2014 18:26:59 +0000 (14:26 -0400)]
Merge branch '2800-pgs' refs #2800

9 years ago2800: Sort import statements.
Tom Clegg [Mon, 18 Aug 2014 18:25:47 +0000 (14:25 -0400)]
2800: Sort import statements.

9 years agoMerge branch '3604-theme-and-new-user-process' closes #3604
Tom Clegg [Mon, 18 Aug 2014 18:17:49 +0000 (14:17 -0400)]
Merge branch '3604-theme-and-new-user-process' closes #3604

9 years ago3036: Ruby style change, use :search_up and :search_down symbols instead of UP and...
Peter Amstutz [Mon, 18 Aug 2014 18:07:59 +0000 (14:07 -0400)]
3036: Ruby style change, use :search_up and :search_down symbols instead of UP and DOWN constants.

9 years ago2800: Restore deleted comment which is still relevant.
Tom Clegg [Mon, 18 Aug 2014 18:02:42 +0000 (14:02 -0400)]
2800: Restore deleted comment which is still relevant.

9 years ago2800: Remove unnecessary sha1. Just use the tuple as an array key.
Tom Clegg [Mon, 18 Aug 2014 18:01:54 +0000 (14:01 -0400)]
2800: Remove unnecessary sha1. Just use the tuple as an array key.

9 years ago3188: add data-toggle to link
radhika [Mon, 18 Aug 2014 17:39:41 +0000 (13:39 -0400)]
3188: add data-toggle to link

9 years ago3604: Remove useless slice.
Tom Clegg [Mon, 18 Aug 2014 17:37:21 +0000 (13:37 -0400)]
3604: Remove useless slice.

9 years ago3604: Remove useless loop.
Tom Clegg [Mon, 18 Aug 2014 17:35:59 +0000 (13:35 -0400)]
3604: Remove useless loop.

9 years agoDo not try to predict uuid of new collection. refs #3261 refs #3504
Tom Clegg [Mon, 18 Aug 2014 17:23:03 +0000 (13:23 -0400)]
Do not try to predict uuid of new collection. refs #3261 refs #3504

9 years agoDo not throw away permission hints when writing data. refs #3261
Tom Clegg [Mon, 18 Aug 2014 17:15:13 +0000 (13:15 -0400)]
Do not throw away permission hints when writing data. refs #3261

9 years ago3036: API server unit tests pass again after adding uniqueness constraints.
Peter Amstutz [Mon, 18 Aug 2014 17:09:14 +0000 (13:09 -0400)]
3036: API server unit tests pass again after adding uniqueness constraints.

9 years ago3604: Update comment to reflect lack of built-in default.
Tom Clegg [Mon, 18 Aug 2014 16:52:53 +0000 (12:52 -0400)]
3604: Update comment to reflect lack of built-in default.

9 years ago3604: Remove unused style.
Tom Clegg [Mon, 18 Aug 2014 16:51:27 +0000 (12:51 -0400)]
3604: Remove unused style.

9 years agoDisplay progress by default when writing to regular files and stderr isatty. No issue #
Tom Clegg [Mon, 18 Aug 2014 15:39:49 +0000 (11:39 -0400)]
Display progress by default when writing to regular files and stderr isatty. No issue #

9 years ago3112: add caret to email address dropdown in topnav.
radhika [Mon, 18 Aug 2014 15:36:55 +0000 (11:36 -0400)]
3112: add caret to email address dropdown in topnav.

9 years agoMerge branch 'master' into 3112-report-bug
radhika [Mon, 18 Aug 2014 15:15:42 +0000 (11:15 -0400)]
Merge branch 'master' into 3112-report-bug

9 years ago3112: use alert-success and alert-danger when reporting ajax events after submitting...
radhika [Mon, 18 Aug 2014 15:15:06 +0000 (11:15 -0400)]
3112: use alert-success and alert-danger when reporting ajax events after submitting a report.

9 years agoMerge branch '3441-python-keep-log-level' refs #3441
Peter Amstutz [Mon, 18 Aug 2014 13:39:22 +0000 (09:39 -0400)]
Merge branch '3441-python-keep-log-level' refs #3441

9 years ago3036: Migration will rename rows if necessary to ensure (owner_uuid, name) uniqueness
Peter Amstutz [Mon, 18 Aug 2014 12:44:20 +0000 (08:44 -0400)]
3036: Migration will rename rows if necessary to ensure (owner_uuid, name) uniqueness

9 years ago3604: Fix user deactivation test.
Tom Clegg [Sun, 17 Aug 2014 21:14:35 +0000 (17:14 -0400)]
3604: Fix user deactivation test.

9 years ago3604: Fix tests, and restore ability to view user agreement before completing profile.
Tom Clegg [Sun, 17 Aug 2014 20:40:46 +0000 (16:40 -0400)]
3604: Fix tests, and restore ability to view user agreement before completing profile.

9 years ago3604: Fix up profile and redirect handling.
Tom Clegg [Sun, 17 Aug 2014 19:26:53 +0000 (15:26 -0400)]
3604: Fix up profile and redirect handling.

9 years ago3604: Fix user_agreements behavior, update tests to expect redirects.
Tom Clegg [Sun, 17 Aug 2014 18:34:26 +0000 (14:34 -0400)]
3604: Fix user_agreements behavior, update tests to expect redirects.

9 years ago3604: Add test for redirect to welcome page
Tom Clegg [Sun, 17 Aug 2014 18:10:20 +0000 (14:10 -0400)]
3604: Add test for redirect to welcome page

9 years ago3604: Verify permission cache behavior in unsetup test
Tom Clegg [Sun, 17 Aug 2014 18:10:08 +0000 (14:10 -0400)]
3604: Verify permission cache behavior in unsetup test

9 years ago3604: Remove test for persistent/cache switch on wrong page.
Tom Clegg [Sun, 17 Aug 2014 18:05:11 +0000 (14:05 -0400)]
3604: Remove test for persistent/cache switch on wrong page.

9 years ago3604: Do not check for notifications if user is not even activated.
Tom Clegg [Sun, 17 Aug 2014 18:02:19 +0000 (14:02 -0400)]
3604: Do not check for notifications if user is not even activated.

9 years ago3604: Fix stale permission cache by using destroy instead of delete.
Tom Clegg [Sun, 17 Aug 2014 17:59:13 +0000 (13:59 -0400)]
3604: Fix stale permission cache by using destroy instead of delete.

9 years ago3604: Fix theme support for welcome page
Tom Clegg [Sun, 17 Aug 2014 17:50:05 +0000 (13:50 -0400)]
3604: Fix theme support for welcome page

9 years ago3036: Migration adding (owner_uuid, name) uniqueness constraints to
Peter Amstutz [Sun, 17 Aug 2014 04:05:58 +0000 (00:05 -0400)]
3036: Migration adding (owner_uuid, name) uniqueness constraints to
collections, pipeline_templates, pipeline_instances, jobs, groups.

9 years ago3036: API server tests pass
Peter Amstutz [Sun, 17 Aug 2014 03:44:06 +0000 (23:44 -0400)]
3036: API server tests pass

9 years ago3441: Change logging level of nonfatal Keep errors to "debug".
Peter Amstutz [Sun, 17 Aug 2014 01:22:56 +0000 (21:22 -0400)]
3441: Change logging level of nonfatal Keep errors to "debug".

9 years ago2800: Clean up exceptions, variable names, handling of discoveryServiceUrl vs host...
Tom Clegg [Sat, 16 Aug 2014 22:55:20 +0000 (18:55 -0400)]
2800: Clean up exceptions, variable names, handling of discoveryServiceUrl vs host args.

9 years ago2800: Merge branch 'master' into 2800-pgs
Tom Clegg [Sat, 16 Aug 2014 22:23:25 +0000 (18:23 -0400)]
2800: Merge branch 'master' into 2800-pgs

9 years agoMerge branch '2800-python-global-state' into 2800-pgs
Tom Clegg [Sat, 16 Aug 2014 06:06:20 +0000 (02:06 -0400)]
Merge branch '2800-python-global-state' into 2800-pgs

Conflicts:
sdk/python/arvados/api.py

9 years ago3036: Restored normalize_collection_uuids removed in 22457e1
Peter Amstutz [Sat, 16 Aug 2014 03:08:31 +0000 (23:08 -0400)]
3036: Restored normalize_collection_uuids removed in 22457e1

9 years ago3036: Remove include_linked from project contents method because 'name' links
Peter Amstutz [Sat, 16 Aug 2014 02:37:59 +0000 (22:37 -0400)]
3036: Remove include_linked from project contents method because 'name' links
are obsolete.  Remove tests related to include_linked.  Fix docker image lookups.

9 years ago3112: trailing white space
radhika [Sat, 16 Aug 2014 01:15:00 +0000 (21:15 -0400)]
3112: trailing white space

9 years ago3112: update tests to test ajax success and associated popup changes when a report...
radhika [Sat, 16 Aug 2014 01:09:15 +0000 (21:09 -0400)]
3112: update tests to test ajax success and associated popup changes when a report is sent.

9 years ago3112: improve errors test to exercise the report issue button.
radhika [Sat, 16 Aug 2014 00:15:25 +0000 (20:15 -0400)]
3112: improve errors test to exercise the report issue button.

9 years agoMerge branch 'master' into 3112-report-bug
radhika [Fri, 15 Aug 2014 23:47:18 +0000 (19:47 -0400)]
Merge branch 'master' into 3112-report-bug

9 years ago3112: add test to check the existence of "report issue" button in fiddlesticks error...
radhika [Fri, 15 Aug 2014 21:36:13 +0000 (17:36 -0400)]
3112: add test to check the existence of "report issue" button in fiddlesticks error page

9 years ago3036: Test fixing work in progress.
Peter Amstutz [Fri, 15 Aug 2014 21:11:34 +0000 (17:11 -0400)]
3036: Test fixing work in progress.

9 years ago3112: add "report issue" button to fiddlesticks error page
radhika [Fri, 15 Aug 2014 20:58:55 +0000 (16:58 -0400)]
3112: add "report issue" button to fiddlesticks error page

9 years agodocker: be a bit smarter in the make clean target, so that we also
Ward Vandewege [Fri, 15 Aug 2014 20:56:34 +0000 (16:56 -0400)]
docker: be a bit smarter in the make clean target, so that we also
accomodate diretories underneath the generated directory.

refs #3551

9 years agoMerge branch '3593-workbench-exception-rendering'
Brett Smith [Fri, 15 Aug 2014 20:45:21 +0000 (16:45 -0400)]
Merge branch '3593-workbench-exception-rendering'

Closes #3593, #3595.

9 years agoMerge branch 'master' into 3112-report-bug
radhika [Fri, 15 Aug 2014 20:44:46 +0000 (16:44 -0400)]
Merge branch 'master' into 3112-report-bug

9 years ago3593: Another round of hardening Workbench's render_exception.
Brett Smith [Thu, 14 Aug 2014 17:59:18 +0000 (13:59 -0400)]
3593: Another round of hardening Workbench's render_exception.

render_exception was counting on session[:user] to help render the
error page.  We recently excised that, which is turning exceptions
into 500s.  This commit restores the session user object, but uses it
only for error rendering, in keeping with the spirit of the previous
revert.  This commit also defends against more possible failure cases
in render_exception, and adds a basic test for it.

9 years agoMerge branch 'master' into 3112-report-bug
radhika [Fri, 15 Aug 2014 18:37:17 +0000 (14:37 -0400)]
Merge branch 'master' into 3112-report-bug

9 years ago3112: add ajax event handling
radhika [Fri, 15 Aug 2014 17:22:18 +0000 (13:22 -0400)]
3112: add ajax event handling

9 years agogitignore sdk/cli/vendor. refs #3551
Tom Clegg [Fri, 15 Aug 2014 14:06:32 +0000 (10:06 -0400)]
gitignore sdk/cli/vendor. refs #3551

9 years agoRestore trailing newline in manifest format sanity check.
Tom Clegg [Fri, 15 Aug 2014 14:05:01 +0000 (10:05 -0400)]
Restore trailing newline in manifest format sanity check.

Amends 3cc80b447efcaf416ea4d6857d6d40583e462ff8
No issue #

9 years ago3036: Adding pre-validation callback to set the portable_data_hash if necessay.
Peter Amstutz [Fri, 15 Aug 2014 02:55:11 +0000 (22:55 -0400)]
3036: Adding pre-validation callback to set the portable_data_hash if necessay.
Added validation callback to check that portable_data_hash matches manifest_text.

9 years ago3036: ensure_owner_uuid_is_permitted checks that owner_uuid is a User or Group.
Peter Amstutz [Fri, 15 Aug 2014 02:53:24 +0000 (22:53 -0400)]
3036: ensure_owner_uuid_is_permitted checks that owner_uuid is a User or Group.
Added comments on permission logic.

9 years ago3036: Fixing uuid -> portable_data_hash in collections controller tests.
Peter Amstutz [Fri, 15 Aug 2014 01:48:26 +0000 (21:48 -0400)]
3036: Fixing uuid -> portable_data_hash in collections controller tests.

9 years ago3036: Remove obsolete 'name' link tests.
Peter Amstutz [Fri, 15 Aug 2014 01:47:48 +0000 (21:47 -0400)]
3036: Remove obsolete 'name' link tests.

9 years ago3036: Split out logic to determine if a user is actually allowed to set the
Peter Amstutz [Thu, 14 Aug 2014 21:07:12 +0000 (17:07 -0400)]
3036: Split out logic to determine if a user is actually allowed to set the
uuid into validate_uuid.  Fix docker/collection/job tests to use
portable_data_hash instead of uuid where appropriate.

9 years ago3112: minor label updates
radhika [Thu, 14 Aug 2014 20:07:15 +0000 (16:07 -0400)]
3112: minor label updates

9 years agoMerge branch '3551-go-layout' closes #3551
Tom Clegg [Thu, 14 Aug 2014 19:30:28 +0000 (15:30 -0400)]
Merge branch '3551-go-layout' closes #3551

9 years ago3551: Merge branch 'master' into 3551-go-layout
Tom Clegg [Thu, 14 Aug 2014 19:23:43 +0000 (15:23 -0400)]
3551: Merge branch 'master' into 3551-go-layout

9 years ago3112: log when an issue is reported
radhika [Thu, 14 Aug 2014 19:12:17 +0000 (15:12 -0400)]
3112: log when an issue is reported

9 years ago3036: Removed special case normalize_collection_uuids. Removed special case
Peter Amstutz [Thu, 14 Aug 2014 18:48:32 +0000 (14:48 -0400)]
3036: Removed special case normalize_collection_uuids.  Removed special case
'name' links granting read permission.  Renamed helper function
"collection_uuid" to "stripped_portable_data_hash" and moved to helpers
directory.

9 years ago3036: Removed special case find_object_by_uuid. Converted some queries that
Peter Amstutz [Thu, 14 Aug 2014 18:47:07 +0000 (14:47 -0400)]
3036: Removed special case find_object_by_uuid.  Converted some queries that
interact with jobs to use portable_data_hash instead of uuid.

9 years ago3112: trailing white spaces
radhika [Thu, 14 Aug 2014 18:46:07 +0000 (14:46 -0400)]
3112: trailing white spaces

9 years agoMerge branch 'master' into 3112-report-bug
radhika [Thu, 14 Aug 2014 18:44:17 +0000 (14:44 -0400)]
Merge branch 'master' into 3112-report-bug

9 years ago3112: report issue works for no user and inactive user cases.
radhika [Thu, 14 Aug 2014 18:43:24 +0000 (14:43 -0400)]
3112: report issue works for no user and inactive user cases.

9 years agoMerge branch '3505-virtual-work-dir' refs #3505
Peter Amstutz [Thu, 14 Aug 2014 18:20:07 +0000 (14:20 -0400)]
Merge branch '3505-virtual-work-dir' refs #3505

9 years ago3036: Removed special case uuid_like_pattern. Removed special case in
Peter Amstutz [Thu, 14 Aug 2014 18:19:40 +0000 (14:19 -0400)]
3036: Removed special case uuid_like_pattern.  Removed special case in
resource_class_for_uuid.  Removed special cases for "name" links.

9 years ago3036: Removed "add can_read link after creating collection record" logic.
Peter Amstutz [Thu, 14 Aug 2014 18:18:42 +0000 (14:18 -0400)]
3036: Removed "add can_read link after creating collection record" logic.

9 years ago3036: Manually migrated collections and name links on test fixtures.
Peter Amstutz [Thu, 14 Aug 2014 18:16:01 +0000 (14:16 -0400)]
3036: Manually migrated collections and name links on test fixtures.

9 years ago3112: add tests for the new show version info and report problem buttons in help...
radhika [Thu, 14 Aug 2014 18:15:07 +0000 (14:15 -0400)]
3112: add tests for the new show version info and report problem buttons in help menu. yes, the tests did uncover a couple edge cases not covered by manual testing.

9 years agoMerge branch 'master' into 3505-virtual-work-dir
Peter Amstutz [Thu, 14 Aug 2014 17:23:49 +0000 (13:23 -0400)]
Merge branch 'master' into 3505-virtual-work-dir

9 years ago3505: tinker with logging
Peter Amstutz [Thu, 14 Aug 2014 17:17:06 +0000 (13:17 -0400)]
3505: tinker with logging

9 years ago3505: Fix typo in run-command
Peter Amstutz [Thu, 14 Aug 2014 15:41:45 +0000 (11:41 -0400)]
3505: Fix typo in run-command

9 years ago3505: Move helper scripts into crunchutil module. In run-command, added
Peter Amstutz [Thu, 14 Aug 2014 15:35:06 +0000 (11:35 -0400)]
3505: Move helper scripts into crunchutil module.  In run-command, added
task.stdin redirection, and renamed save.stdout to task.stdout for consistency.
Stylistic change "x == None" and "x != None" to "x is None" and "x is not
None".

9 years ago3036: More work on migration. Converts collection->collection provenance links into...
Peter Amstutz [Thu, 14 Aug 2014 15:15:01 +0000 (11:15 -0400)]
3036: More work on migration.  Converts collection->collection provenance links into jobs.  Handles orphan collections;

9 years ago3112: add "report issue" button to 404 error page
radhika [Thu, 14 Aug 2014 14:35:51 +0000 (10:35 -0400)]
3112: add "report issue" button to 404 error page

9 years ago3551: Revert "3551: When testing keep clients, write keepstore/keepproxy logs to"
Tom Clegg [Thu, 14 Aug 2014 14:05:41 +0000 (10:05 -0400)]
3551: Revert "3551: When testing keep clients, write keepstore/keepproxy logs to"

This reverts commit 63871346153fea194b169eec38f6efae3061ebf6.

The default Popen behavior is to use stderr, and that's fine. This was
a mistaken attempt to reveal missing logs, the real solution for which
is 5fcff4c13ae17527ee1efd6fa01d08133212085b.

9 years ago3551: Remove superfluous chmod(). Umask is 022 here.
Tom Clegg [Thu, 14 Aug 2014 13:49:34 +0000 (09:49 -0400)]
3551: Remove superfluous chmod(). Umask is 022 here.

9 years ago3112: simplify report message send logic
radhika [Thu, 14 Aug 2014 13:40:33 +0000 (09:40 -0400)]
3112: simplify report message send logic

9 years ago3112: when you experience a git error, that is when you see it's true colors!!
radhika [Thu, 14 Aug 2014 12:58:47 +0000 (08:58 -0400)]
3112: when you experience a git error, that is when you see it's true colors!!

9 years ago3114: bug fix: when rendering JSON response to a generic #show action, correctly...
Phil Hodgson [Thu, 14 Aug 2014 11:51:35 +0000 (07:51 -0400)]
3114: bug fix: when rendering JSON response to a generic #show action, correctly set an 'href' attribute in the response to be the #show url for the object