projects / arvados.git / commit
summary | shortlog | log | commit | commitdiff | tree
(parent: b5a2787) | patch
3593: Another round of hardening Workbench's render_exception.
authorBrett Smith <brett@curoverse.com>
Thu, 14 Aug 2014 17:59:18 +0000 (13:59 -0400)
committerBrett Smith <brett@curoverse.com>
Fri, 15 Aug 2014 20:36:29 +0000 (16:36 -0400)
commitd3427aea4532d247b71b5ebfc5f5eb527e8835a2
tree7304a88c82e4f4e67a977e9122305a704d2e816btree | snapshot
parentb5a278786165ebbbd63044cf9b5b64b949fe88edcommit | diff
3593: Another round of hardening Workbench's render_exception.

render_exception was counting on session[:user] to help render the
error page.  We recently excised that, which is turning exceptions
into 500s.  This commit restores the session user object, but uses it
only for error rendering, in keeping with the spirit of the previous
revert.  This commit also defends against more possible failure cases
in render_exception, and adds a basic test for it.
apps/workbench/app/controllers/application_controller.rb diff | blob | history
apps/workbench/test/functional/application_controller_test.rb diff | blob | history