arvados.git
10 years ago3036: Removed special case normalize_collection_uuids. Removed special case
Peter Amstutz [Thu, 14 Aug 2014 18:48:32 +0000 (14:48 -0400)]
3036: Removed special case normalize_collection_uuids.  Removed special case
'name' links granting read permission.  Renamed helper function
"collection_uuid" to "stripped_portable_data_hash" and moved to helpers
directory.

10 years ago3036: Removed special case find_object_by_uuid. Converted some queries that
Peter Amstutz [Thu, 14 Aug 2014 18:47:07 +0000 (14:47 -0400)]
3036: Removed special case find_object_by_uuid.  Converted some queries that
interact with jobs to use portable_data_hash instead of uuid.

10 years ago3112: trailing white spaces
radhika [Thu, 14 Aug 2014 18:46:07 +0000 (14:46 -0400)]
3112: trailing white spaces

10 years agoMerge branch 'master' into 3112-report-bug
radhika [Thu, 14 Aug 2014 18:44:17 +0000 (14:44 -0400)]
Merge branch 'master' into 3112-report-bug

10 years ago3112: report issue works for no user and inactive user cases.
radhika [Thu, 14 Aug 2014 18:43:24 +0000 (14:43 -0400)]
3112: report issue works for no user and inactive user cases.

10 years agoMerge branch '3505-virtual-work-dir' refs #3505
Peter Amstutz [Thu, 14 Aug 2014 18:20:07 +0000 (14:20 -0400)]
Merge branch '3505-virtual-work-dir' refs #3505

10 years ago3036: Removed special case uuid_like_pattern. Removed special case in
Peter Amstutz [Thu, 14 Aug 2014 18:19:40 +0000 (14:19 -0400)]
3036: Removed special case uuid_like_pattern.  Removed special case in
resource_class_for_uuid.  Removed special cases for "name" links.

10 years ago3036: Removed "add can_read link after creating collection record" logic.
Peter Amstutz [Thu, 14 Aug 2014 18:18:42 +0000 (14:18 -0400)]
3036: Removed "add can_read link after creating collection record" logic.

10 years ago3036: Manually migrated collections and name links on test fixtures.
Peter Amstutz [Thu, 14 Aug 2014 18:16:01 +0000 (14:16 -0400)]
3036: Manually migrated collections and name links on test fixtures.

10 years ago3112: add tests for the new show version info and report problem buttons in help...
radhika [Thu, 14 Aug 2014 18:15:07 +0000 (14:15 -0400)]
3112: add tests for the new show version info and report problem buttons in help menu. yes, the tests did uncover a couple edge cases not covered by manual testing.

10 years agoMerge branch 'master' into 3505-virtual-work-dir
Peter Amstutz [Thu, 14 Aug 2014 17:23:49 +0000 (13:23 -0400)]
Merge branch 'master' into 3505-virtual-work-dir

10 years ago3505: tinker with logging
Peter Amstutz [Thu, 14 Aug 2014 17:17:06 +0000 (13:17 -0400)]
3505: tinker with logging

10 years ago3505: Fix typo in run-command
Peter Amstutz [Thu, 14 Aug 2014 15:41:45 +0000 (11:41 -0400)]
3505: Fix typo in run-command

10 years ago3505: Move helper scripts into crunchutil module. In run-command, added
Peter Amstutz [Thu, 14 Aug 2014 15:35:06 +0000 (11:35 -0400)]
3505: Move helper scripts into crunchutil module.  In run-command, added
task.stdin redirection, and renamed save.stdout to task.stdout for consistency.
Stylistic change "x == None" and "x != None" to "x is None" and "x is not
None".

10 years ago3036: More work on migration. Converts collection->collection provenance links into...
Peter Amstutz [Thu, 14 Aug 2014 15:15:01 +0000 (11:15 -0400)]
3036: More work on migration.  Converts collection->collection provenance links into jobs.  Handles orphan collections;

10 years ago3112: add "report issue" button to 404 error page
radhika [Thu, 14 Aug 2014 14:35:51 +0000 (10:35 -0400)]
3112: add "report issue" button to 404 error page

10 years ago3551: Revert "3551: When testing keep clients, write keepstore/keepproxy logs to"
Tom Clegg [Thu, 14 Aug 2014 14:05:41 +0000 (10:05 -0400)]
3551: Revert "3551: When testing keep clients, write keepstore/keepproxy logs to"

This reverts commit 63871346153fea194b169eec38f6efae3061ebf6.

The default Popen behavior is to use stderr, and that's fine. This was
a mistaken attempt to reveal missing logs, the real solution for which
is 5fcff4c13ae17527ee1efd6fa01d08133212085b.

10 years ago3551: Remove superfluous chmod(). Umask is 022 here.
Tom Clegg [Thu, 14 Aug 2014 13:49:34 +0000 (09:49 -0400)]
3551: Remove superfluous chmod(). Umask is 022 here.

10 years ago3112: simplify report message send logic
radhika [Thu, 14 Aug 2014 13:40:33 +0000 (09:40 -0400)]
3112: simplify report message send logic

10 years ago3112: when you experience a git error, that is when you see it's true colors!!
radhika [Thu, 14 Aug 2014 12:58:47 +0000 (08:58 -0400)]
3112: when you experience a git error, that is when you see it's true colors!!

10 years ago3354: try again with edit (pencil) icon to the _right_ of the editable textile-render...
Phil Hodgson [Thu, 14 Aug 2014 12:12:28 +0000 (08:12 -0400)]
3354: try again with edit (pencil) icon to the _right_ of the editable textile-rendered text

(Neither to the right nor underneath look perfect in all circumstances, but to the right is the better compromise.)

10 years ago3114: bug fix: when rendering JSON response to a generic #show action, correctly...
Phil Hodgson [Thu, 14 Aug 2014 11:51:35 +0000 (07:51 -0400)]
3114: bug fix: when rendering JSON response to a generic #show action, correctly set an 'href' attribute in the response to be the #show url for the object

10 years agoMerge branch 'master' into 3112-report-bug
radhika [Thu, 14 Aug 2014 02:21:30 +0000 (22:21 -0400)]
Merge branch 'master' into 3112-report-bug

10 years ago3112: config settings, mailer, popup display
radhika [Thu, 14 Aug 2014 02:20:23 +0000 (22:20 -0400)]
3112: config settings, mailer, popup display

10 years agoIncrease Capybara timeout to accommodate slow test server. No issue #
Tom Clegg [Wed, 13 Aug 2014 22:15:46 +0000 (18:15 -0400)]
Increase Capybara timeout to accommodate slow test server. No issue #

10 years agoReport unexpected slurm states as "down". No issue #
Tom Clegg [Wed, 13 Aug 2014 21:09:08 +0000 (17:09 -0400)]
Report unexpected slurm states as "down". No issue #

10 years ago3551: Use FileUtils.rm_r so deleting stale generated/{dir} works.
Tom Clegg [Wed, 13 Aug 2014 20:47:50 +0000 (16:47 -0400)]
3551: Use FileUtils.rm_r so deleting stale generated/{dir} works.

10 years agoMerge branch '3421-wide-project-tables-wip'
Brett Smith [Wed, 13 Aug 2014 20:39:40 +0000 (16:39 -0400)]
Merge branch '3421-wide-project-tables-wip'

Closes #3421, #3584.

10 years ago3421: Make Workbench project contents tables variable width.
Brett Smith [Wed, 13 Aug 2014 16:07:06 +0000 (12:07 -0400)]
3421: Make Workbench project contents tables variable width.

This change will ensure that users can see the "edit name" buttons, by
letting a table row grow as needed to accommodate long names.  It puts
each row's buttons in dedicated cells to try to stay true to the
original layout as much as possible.

10 years agoMerge branch '3405-pipeline-error-logging-wip'
Brett Smith [Wed, 13 Aug 2014 20:36:42 +0000 (16:36 -0400)]
Merge branch '3405-pipeline-error-logging-wip'

Closes #3405, #3582.

10 years ago3405: Mark pipeline instances failed when they're aborted.
Brett Smith [Tue, 12 Aug 2014 18:48:32 +0000 (14:48 -0400)]
3405: Mark pipeline instances failed when they're aborted.

10 years ago3405: Log errors about launching pipeline instances.
Brett Smith [Tue, 12 Aug 2014 18:41:55 +0000 (14:41 -0400)]
3405: Log errors about launching pipeline instances.

There's a couple of components to this:

* Do some basic checks on the organization of the pipeline instance
  before we start running it, and abort if any of them fail.

* If the pipeline runner aborts for any reason, send that as pipeline
  instance stderr to the API server, so other tools like Workbench can
  render it for users' benefit.

10 years ago3551: Remove chmod 755, no longer necessary now that config.rb does that.
Tom Clegg [Wed, 13 Aug 2014 20:23:43 +0000 (16:23 -0400)]
3551: Remove chmod 755, no longer necessary now that config.rb does that.

10 years ago3551: Set mode of generated files more aggressively (overrule umask).
Tom Clegg [Wed, 13 Aug 2014 19:36:30 +0000 (15:36 -0400)]
3551: Set mode of generated files more aggressively (overrule umask).

10 years ago3551: Handle missing GOPATH and multiple-entry GOPATH sensibly.
Tom Clegg [Wed, 13 Aug 2014 19:22:00 +0000 (15:22 -0400)]
3551: Handle missing GOPATH and multiple-entry GOPATH sensibly.

10 years ago3551: Merge branch 'master' into 3551-go-layout
Tom Clegg [Wed, 13 Aug 2014 19:13:43 +0000 (15:13 -0400)]
3551: Merge branch 'master' into 3551-go-layout

10 years ago3551: When invoking run_test_server.py during tests, pass stderr
Tom Clegg [Wed, 13 Aug 2014 19:10:13 +0000 (15:10 -0400)]
3551: When invoking run_test_server.py during tests, pass stderr
through to caller instead of discarding.

10 years ago3551: Behave correctly when Read() yields some data along with the EOF condition.
Tom Clegg [Wed, 13 Aug 2014 19:02:51 +0000 (15:02 -0400)]
3551: Behave correctly when Read() yields some data along with the EOF condition.

"a Reader returning a non-zero number of bytes at the end of the input
stream may return either err == EOF or err == nil."

-- http://golang.org/pkg/io/#Reader

10 years ago3505: Fixed typo comparison of list against 0 instead of len(list).
Peter Amstutz [Wed, 13 Aug 2014 18:44:27 +0000 (14:44 -0400)]
3505: Fixed typo comparison of list against 0 instead of len(list).

10 years ago3551: When invoking run_test_server.py during tests, pass stderr
Tom Clegg [Wed, 13 Aug 2014 18:34:29 +0000 (14:34 -0400)]
3551: When invoking run_test_server.py during tests, pass stderr
through to caller instead of discarding.

10 years ago3551: When testing keep clients, write keepstore/keepproxy logs to
Tom Clegg [Wed, 13 Aug 2014 18:32:40 +0000 (14:32 -0400)]
3551: When testing keep clients, write keepstore/keepproxy logs to
tmp/run_test_server.log instead of discarding.

10 years ago3505: Adjust order of initialization to reflect potential side effects (e.g. file
Peter Amstutz [Wed, 13 Aug 2014 18:25:44 +0000 (14:25 -0400)]
3505: Adjust order of initialization to reflect potential side effects (e.g. file
creation) on using functions such as $(glob) in the command.

10 years agoFix degenerate case exponential runtime in regular expression use by
Peter Amstutz [Wed, 13 Aug 2014 18:06:40 +0000 (14:06 -0400)]
Fix degenerate case exponential runtime in regular expression use by
CollectionReader to validate locators and manifests.  no issue #

10 years agoMerge branch '3457-pysdk-logging-wip'
Brett Smith [Wed, 13 Aug 2014 16:15:24 +0000 (12:15 -0400)]
Merge branch '3457-pysdk-logging-wip'

Closes #3457, #3577.

10 years ago3457: Make arv-get display interface messages directly.
Brett Smith [Wed, 13 Aug 2014 14:32:45 +0000 (10:32 -0400)]
3457: Make arv-get display interface messages directly.

The logger isn't appropriate for this.

10 years ago3457: Revamp Python SDK and tool logging.
Brett Smith [Tue, 12 Aug 2014 21:43:28 +0000 (17:43 -0400)]
3457: Revamp Python SDK and tool logging.

The primary goal of this commit is to introduce a dedicated logging
object to the arvados module, which we configure to our
specifications, and use it consistently throughout the SDK and tools.
This lets us handle our logging configuration consistently in one
place, and avoid interfering with logging in SDK users.  I made some
minor style changes to logging calls while I was at it.

10 years ago3114: When current user, show root/home project rather than user attributes when...
Phil Hodgson [Wed, 13 Aug 2014 15:12:36 +0000 (11:12 -0400)]
3114: When current user, show root/home project rather than user attributes when landing on show user page.
(This is meant to be a compromise due to the fact that a home project's uuid has "user" as its arvados type, rather than "group".)

10 years ago3114: bug fix: 'Copy' button is now disabled until a project has been selected for...
Phil Hodgson [Wed, 13 Aug 2014 15:09:55 +0000 (11:09 -0400)]
3114: bug fix: 'Copy' button is now disabled until a project has been selected for copying to

10 years agoAdded virtual working directory "task.vwd" option to run-command. Added
Peter Amstutz [Wed, 13 Aug 2014 15:04:52 +0000 (11:04 -0400)]
Added virtual working directory "task.vwd" option to run-command.  Added
"task.cwd" to set the starting directory.  Refactored upload retry logic from
run-command into robust_put.py and modified decompress-all to use it.  no issue #

10 years ago3551: Fix more package paths.
Tom Clegg [Wed, 13 Aug 2014 15:02:25 +0000 (11:02 -0400)]
3551: Fix more package paths.

10 years agoUpdate Gemfile to use crunch-job from latest arvados-cli gem. refs #3570
Tom Clegg [Wed, 13 Aug 2014 13:32:45 +0000 (09:32 -0400)]
Update Gemfile to use crunch-job from latest arvados-cli gem. refs #3570

10 years ago3354: Also render specified attributes as textile when content is read-only
Phil Hodgson [Wed, 13 Aug 2014 12:44:55 +0000 (08:44 -0400)]
3354: Also render specified attributes as textile when content is read-only

10 years ago3354: Put edit (pencil) icon _below_ textile rather than to the right of it.
Phil Hodgson [Wed, 13 Aug 2014 12:44:24 +0000 (08:44 -0400)]
3354: Put edit (pencil) icon _below_ textile rather than to the right of it.

10 years ago3036: More work verifying that migration does the right thing.
Peter Amstutz [Tue, 12 Aug 2014 20:53:13 +0000 (16:53 -0400)]
3036: More work verifying that migration does the right thing.

10 years ago3354: Redirect link#show to "show named object".
Tom Clegg [Tue, 12 Aug 2014 20:43:45 +0000 (16:43 -0400)]
3354: Redirect link#show to "show named object".

This way, if you put a text link like "foo":{uuid-of-name-link} in a
textile description field, it leads to the named object rather than
the generic "show attributes" page for the link object.

10 years agoMerge branch 'master' into 3112-report-bug
radhika [Tue, 12 Aug 2014 20:40:10 +0000 (16:40 -0400)]
Merge branch 'master' into 3112-report-bug

Conflicts:
services/api/config/application.default.yml

10 years agocloses #3296
radhika [Tue, 12 Aug 2014 20:28:50 +0000 (16:28 -0400)]
closes #3296
Merge branch '3296-user-profile'

10 years ago3296: fix test issue
radhika [Tue, 12 Aug 2014 20:25:34 +0000 (16:25 -0400)]
3296: fix test issue

10 years ago3296: fix tests
radhika [Tue, 12 Aug 2014 19:49:21 +0000 (15:49 -0400)]
3296: fix tests

10 years agoMerge branch 'master' into 3296-user-profile
radhika [Tue, 12 Aug 2014 19:10:46 +0000 (15:10 -0400)]
Merge branch 'master' into 3296-user-profile

10 years agoMerge branch 'master' into 3112-report-bug
radhika [Tue, 12 Aug 2014 19:08:59 +0000 (15:08 -0400)]
Merge branch 'master' into 3112-report-bug

10 years ago3112: add source_version to discovery document.
radhika [Tue, 12 Aug 2014 19:05:11 +0000 (15:05 -0400)]
3112: add source_version to discovery document.

10 years agoFix repositories.get_all_permissions to report manage, write, and read. refs #3525
Tom Clegg [Tue, 12 Aug 2014 18:57:10 +0000 (14:57 -0400)]
Fix repositories.get_all_permissions to report manage, write, and read. refs #3525

10 years agoMerge branch '3531-sort-jobs-with-pipelines' closes #3531
Tom Clegg [Tue, 12 Aug 2014 18:19:48 +0000 (14:19 -0400)]
Merge branch '3531-sort-jobs-with-pipelines' closes #3531

10 years agoFix "undefined method `uuid' for nil:NilClass". closes #3576
Tom Clegg [Tue, 12 Aug 2014 18:15:51 +0000 (14:15 -0400)]
Fix "undefined method `uuid' for nil:NilClass". closes #3576

10 years agoFix regular expression in decompress-all.py refs #3373
Peter Amstutz [Tue, 12 Aug 2014 17:16:04 +0000 (13:16 -0400)]
Fix regular expression in decompress-all.py  refs #3373

10 years agoFix syntax error in decompress-all.py refs #3373
Peter Amstutz [Tue, 12 Aug 2014 17:07:12 +0000 (13:07 -0400)]
Fix syntax error in decompress-all.py  refs #3373

10 years ago3531: Pass through tab_pane to reused partials, so element IDs are really unique
Tom Clegg [Tue, 12 Aug 2014 16:19:06 +0000 (12:19 -0400)]
3531: Pass through tab_pane to reused partials, so element IDs are really unique
across tabs.

10 years ago3531: Fix ordering of combined results, add test. Anchor "desc" regexp.
Tom Clegg [Tue, 12 Aug 2014 16:15:45 +0000 (12:15 -0400)]
3531: Fix ordering of combined results, add test. Anchor "desc" regexp.

10 years agoMerge branch '3373-improve-gatk3-snv-pipeline' closes #3373
Peter Amstutz [Tue, 12 Aug 2014 15:42:55 +0000 (11:42 -0400)]
Merge branch '3373-improve-gatk3-snv-pipeline' closes #3373

10 years ago3373: Test filename extension before attempting to call dtrx. Non-zero dtrx exit...
Peter Amstutz [Tue, 12 Aug 2014 15:42:09 +0000 (11:42 -0400)]
3373: Test filename extension before attempting to call dtrx.  Non-zero dtrx exit code is now treated as failure.

10 years ago3036: More work on migration code. Now updates links table. SQL syntax errors fixed.
Peter Amstutz [Tue, 12 Aug 2014 15:35:27 +0000 (11:35 -0400)]
3036: More work on migration code.  Now updates links table.  SQL syntax errors fixed.

10 years agoDelete obsolete, undesirable HTML page templates.
Peter Amstutz [Tue, 12 Aug 2014 15:33:34 +0000 (11:33 -0400)]
Delete obsolete, undesirable HTML page templates.

10 years agoMerge branch 'master' into 3296-user-profile
radhika [Tue, 12 Aug 2014 14:20:55 +0000 (10:20 -0400)]
Merge branch 'master' into 3296-user-profile

10 years agoMerge branch '3178-discoverable-parameters' closes #3178
Tom Clegg [Tue, 12 Aug 2014 14:11:32 +0000 (10:11 -0400)]
Merge branch '3178-discoverable-parameters' closes #3178

10 years ago3572: Set state to RunningOnServer if --submit given. closes #3572
Tom Clegg [Tue, 12 Aug 2014 14:09:41 +0000 (10:09 -0400)]
3572: Set state to RunningOnServer if --submit given. closes #3572

10 years agoMerge branch '3570-crunch-race' closes #3570
Tom Clegg [Tue, 12 Aug 2014 13:12:27 +0000 (09:12 -0400)]
Merge branch '3570-crunch-race' closes #3570

10 years agoMerge branch '3412-full-collections-index'
Brett Smith [Tue, 12 Aug 2014 12:59:23 +0000 (08:59 -0400)]
Merge branch '3412-full-collections-index'

Closes #3412, #3534.

10 years agoMerge branch 'master' into 3296-user-profile
radhika [Tue, 12 Aug 2014 12:59:05 +0000 (08:59 -0400)]
Merge branch 'master' into 3296-user-profile

10 years ago3296: add span tag to profile message in config to serve as an example for admins.
radhika [Tue, 12 Aug 2014 12:52:38 +0000 (08:52 -0400)]
3296: add span tag to profile message in config to serve as an example for admins.

10 years ago3412: Make manifest_text selectable from Collections index API.
Brett Smith [Mon, 11 Aug 2014 19:49:52 +0000 (15:49 -0400)]
3412: Make manifest_text selectable from Collections index API.

10 years ago3412: Make non-database fields selectable from API server.
Brett Smith [Mon, 11 Aug 2014 19:48:09 +0000 (15:48 -0400)]
3412: Make non-database fields selectable from API server.

This makes it possible to pass method-back field names, like
"data_size" and "files" from Collections, to the select parameter.

10 years ago3412: Refactor common manifest munging in API Collections controller.
Brett Smith [Thu, 7 Aug 2014 19:15:57 +0000 (15:15 -0400)]
3412: Refactor common manifest munging in API Collections controller.

10 years ago3412: Clean API Collections controller trailing whitespace.
Brett Smith [Thu, 7 Aug 2014 19:14:36 +0000 (15:14 -0400)]
3412: Clean API Collections controller trailing whitespace.

10 years ago3296: cover the case where prefs was there but no profile in profile check.
radhika [Tue, 12 Aug 2014 12:41:03 +0000 (08:41 -0400)]
3296: cover the case where prefs was there but no profile in profile check.

10 years agoUpdate more PGP web links. No issue #
Tom Clegg [Tue, 12 Aug 2014 04:14:09 +0000 (00:14 -0400)]
Update more PGP web links. No issue #

10 years agoUpdate PGP download link. No issue #
Tom Clegg [Tue, 12 Aug 2014 03:49:26 +0000 (23:49 -0400)]
Update PGP download link. No issue #

10 years ago3178: Merge bogus _setup_requires_parameters into existing class method.
Tom Clegg [Mon, 11 Aug 2014 23:01:08 +0000 (19:01 -0400)]
3178: Merge bogus _setup_requires_parameters into existing class method.

10 years ago3570: Use exit code 75 to mean "temporary locking failure". Add comments.
Tom Clegg [Mon, 11 Aug 2014 22:33:52 +0000 (18:33 -0400)]
3570: Use exit code 75 to mean "temporary locking failure". Add comments.

10 years agoMerge branch 'master' into 3296-user-profile
radhika [Mon, 11 Aug 2014 22:21:12 +0000 (18:21 -0400)]
Merge branch 'master' into 3296-user-profile

10 years ago3296: break the tests into multiple tests
radhika [Mon, 11 Aug 2014 22:20:39 +0000 (18:20 -0400)]
3296: break the tests into multiple tests

10 years ago3296: minor updates to profile page display
radhika [Mon, 11 Aug 2014 22:00:22 +0000 (18:00 -0400)]
3296: minor updates to profile page display

10 years agoMerge branch '3489-indicate-initial-project-filter' closes #3489
Tom Clegg [Mon, 11 Aug 2014 21:54:39 +0000 (17:54 -0400)]
Merge branch '3489-indicate-initial-project-filter' closes #3489

10 years ago3296: split profile config into two parameters: one for fields and one for message.
radhika [Mon, 11 Aug 2014 21:47:54 +0000 (17:47 -0400)]
3296: split profile config into two parameters: one for fields and one for message.

10 years ago3531: Move the tab_line_buttons sections out of the tab pane partials
Tom Clegg [Mon, 11 Aug 2014 21:34:44 +0000 (17:34 -0400)]
3531: Move the tab_line_buttons sections out of the tab pane partials
into the appropriate "index" and "show" pages.

Until now, we have been predicting which tab pane will be rendered
with the initial page view, and putting content_for :tab_line_buttons
in that pane. But the tab_line_buttons aren't really in that tab pane,
so they really don't deserve to be in that partial.

This worked as long as the initial tabs were being rendered in a
different way than subsequent tab loads. Now that we render all tab
pane contents using the same helper method, we have to clean this up.

10 years agoMerge branch '3570-crunch-race' closes #3570
Tom Clegg [Mon, 11 Aug 2014 21:06:46 +0000 (17:06 -0400)]
Merge branch '3570-crunch-race' closes #3570

10 years ago3036: Work on migration code for 'name' and 'can_read' links to distinct collection...
Peter Amstutz [Mon, 11 Aug 2014 21:02:21 +0000 (17:02 -0400)]
3036: Work on migration code for 'name' and 'can_read' links to distinct collection entries.

10 years ago3296: check for prefs_changed instead of cycling through all changes.
radhika [Mon, 11 Aug 2014 20:36:18 +0000 (16:36 -0400)]
3296: check for prefs_changed instead of cycling through all changes.

10 years ago3531: Make test case less confusing.
Tom Clegg [Mon, 11 Aug 2014 20:36:12 +0000 (16:36 -0400)]
3531: Make test case less confusing.

10 years ago3531: Add large limit parameter to ensure we get all of the user/group objects
Tom Clegg [Mon, 11 Aug 2014 20:34:28 +0000 (16:34 -0400)]
3531: Add large limit parameter to ensure we get all of the user/group objects
we want (within reason).