Peter Amstutz [Wed, 9 Aug 2023 20:27:51 +0000 (16:27 -0400)]
20454: Consolidate cost display to a single 'Cost' field
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Thu, 3 Aug 2023 16:08:19 +0000 (12:08 -0400)]
Merge branch '20219-log-api' into main. Closes #20219
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 3 Aug 2023 15:36:14 +0000 (11:36 -0400)]
20219: Log with level error and with promise rejection reason when polling fails
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 3 Aug 2023 15:09:12 +0000 (11:09 -0400)]
20219: Move dev dependencies into devDependencies
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 2 Aug 2023 22:27:38 +0000 (18:27 -0400)]
20219: Better variable name
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 2 Aug 2023 21:48:36 +0000 (17:48 -0400)]
20219: Pass through promise rejections from getLogFileContents
* No longer returns undefined for failed log fragments
* initProcessLogsPanel added catch to handle errors, on failure it shows a
toast and initializes the store empty, allowing polling to run and retry if
the container is running
* Add note to pollProcessLogs error console.log that the promise rejection is
ignored currently
* loadContainerLogFileContents now handles errors from getLogFileContents
* Switched from Promise.all to Promise.allSettled, which allows some promises
to fail and still return a result
* Replace undefined fragment & subfragment filtering with top level promise
status filtering, subfragments can no longer have some failures due to
sub-promises using .all which rejects on any failure
* Add es2020 to typescript lib array for Promise.allSettled
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Wed, 2 Aug 2023 13:25:40 +0000 (09:25 -0400)]
Merge branch '20688-redirect-urldecode' refs #20688
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Wed, 2 Aug 2023 01:47:53 +0000 (21:47 -0400)]
20219: Start / stop log polling when container is running
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 2 Aug 2023 01:30:28 +0000 (21:30 -0400)]
20219: Add console log to process log polling failure since promise rejection
is currently unhandled
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 2 Aug 2023 01:26:37 +0000 (21:26 -0400)]
20219: Rearrange non-sortable logs to top of merged all logs view
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 2 Aug 2023 01:20:49 +0000 (21:20 -0400)]
20219: Perform log file root path filtering in listLogFiles
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 2 Aug 2023 01:19:09 +0000 (21:19 -0400)]
20219: Adjust logFileToLogType argument type to only CollectionFile and adjust
loadContainerLogFileList filter type hint to satisfy type
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 2 Aug 2023 00:40:13 +0000 (20:40 -0400)]
20219: Improve useAsyncInterval testability, add unit test
* Combines useRefs for easier mocking
* Wraps callback execution in promise chain to prevent halting on non-async
callbacks
* Clean up now unused async contexts
* Add explicit promise resolve/reject on PollProcessLogs
* Add catch block to continue polling on error
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Mon, 31 Jul 2023 20:00:45 +0000 (16:00 -0400)]
20688: Update test for uri encoding/decoding of PDH
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 31 Jul 2023 19:24:00 +0000 (15:24 -0400)]
20688: Make sure ARVADOS_DIRECTORY is set when it is needed
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Fri, 28 Jul 2023 15:18:20 +0000 (11:18 -0400)]
20219: Replace API & websocket log loading with webdav polling
* Add apiWebdavClient to log service for making webdav requests to the API and
differentiate from keepWebdavClient
* Add listLogFiles and getLogFileContents methods to log service, contents can
be fetched with range request
* Add loadContainerLogFileContents to load logs using webdav range requests
* Files larger than the chunk limit (128k) are loaded as beginning and end
in 2 64k fragments, snipline is appended to the last line of the first
fragment
* The chunks are all requested in parallel
* Add sorting of timestamped log types in combined log views (Main/All)
* Lines without timestamps are merged with previous lines with timestamps
* If no preceding lines of a sortable type exist, the leading lines are
removed from combined log views - they can still be seen in the single
log type filter
* Non-timestamped log types (node-info/contaner) are pushed to the bottom
with original ordering in All view
* Merging & sorting is not applied to single log type view
* Remove snipline LogEventType as all sniplines now belong to specific log
event types
* Update logs panel store and reducer to remember the last log byte requested
* Add polling useAsyncInterval utility function to poll log file sizes
* Polling awaits for callback to finish to prevent race conditions
* Update process log code snippet style to remove gap between array of loglines
* Remove websocket handling of log events
* Replaced cypress log manipulation commands with webdav log helpers
* Add tests for polling, line sorting, correctly sized/positioned chunks, and
snipline
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Tue, 18 Jul 2023 17:46:50 +0000 (13:46 -0400)]
20688: urldecode the redirect path before storing it
Necessary because nginx url rewrites will turn the "+" into a "%2B",
so we need to turn it back. After more than an hour of messing with
it, it's easier to fix workbench 2 than to fix nginx.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Fri, 16 Jun 2023 14:24:32 +0000 (10:24 -0400)]
Add note that available RAM is limited to requested RAM
closes #20635
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Mon, 5 Jun 2023 19:06:24 +0000 (15:06 -0400)]
Merge branch '20031-collection-files-batch-operations' into main. Closes #20031
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Fri, 2 Jun 2023 20:54:45 +0000 (16:54 -0400)]
Merge branch '20449-processes-refresh' refs #20449
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Fri, 2 Jun 2023 14:20:59 +0000 (10:20 -0400)]
Set document title on navigation to url path, refs #19369
This is very simplistic, but we can make it better later.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 1 Jun 2023 21:22:51 +0000 (17:22 -0400)]
20449: Examine websocket messages before reloading process pages
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Wed, 31 May 2023 14:36:12 +0000 (10:36 -0400)]
20031: Cypress wait for re-render
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 31 May 2023 13:50:30 +0000 (09:50 -0400)]
20031: Try to fix unit test
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 31 May 2023 13:42:54 +0000 (09:42 -0400)]
20031: Change Tree component to functional, use react hooks to track selected tree item ref and scroll to item when it changes
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Tue, 30 May 2023 14:45:03 +0000 (10:45 -0400)]
Merge branch '20538-delete-process-error-handling' into main. Closes #20538
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 25 May 2023 19:25:07 +0000 (15:25 -0400)]
20031: Move stop loading actions into finally block in collection batch operation actions
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 25 May 2023 19:05:14 +0000 (15:05 -0400)]
20031: Remove console log
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 25 May 2023 19:04:38 +0000 (15:04 -0400)]
20031: Rename vertical more icon and add horizontal variant. Correct usage in collection files panel
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 25 May 2023 18:40:02 +0000 (14:40 -0400)]
20031: Add icons to collection files action set
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 20:35:06 +0000 (16:35 -0400)]
20538: Change confirmation dialog divs to block spans to get rid of warning
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 20:32:43 +0000 (16:32 -0400)]
20538: Add 403 error handling to remove process action and suppress errors from the containerRequestService
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 16:17:10 +0000 (12:17 -0400)]
20031: Try to fix tests
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 15:46:23 +0000 (11:46 -0400)]
20031: Try to improve tests
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 13:38:19 +0000 (09:38 -0400)]
20031: Avoid expanding pre-selected picker tree item until loaded
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 03:59:01 +0000 (23:59 -0400)]
20031: Prevent movng collection items to itself, show error toast if attempted
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 03:46:12 +0000 (23:46 -0400)]
20031: Cancel submit spinner on collection file move/copy error
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 01:39:58 +0000 (21:39 -0400)]
20031: Fix tests
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 01:03:24 +0000 (21:03 -0400)]
20031: Fix tests
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 24 May 2023 00:13:14 +0000 (20:13 -0400)]
20031: Fix move to separate collection test, requires selecting multiple files
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Tue, 23 May 2023 23:41:25 +0000 (19:41 -0400)]
20031: Add single file context menu move/copy actions
Refactors copy/move actions to pass file selection through dialog.data to allow
single selected file to be passed from context menu
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Mon, 22 May 2023 13:50:30 +0000 (09:50 -0400)]
20031: Navigate to destination project when copying/moving files to separate collections
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Mon, 22 May 2023 13:45:31 +0000 (09:45 -0400)]
20031: Add multiple/single collection files context menu to selectively show actions for multiple selected files
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 18 May 2023 14:57:53 +0000 (10:57 -0400)]
20031: Remove unused imports
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Thu, 11 May 2023 18:50:11 +0000 (14:50 -0400)]
Merge branch '20493-optional-array' refs #20493
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 11 May 2023 18:49:19 +0000 (14:49 -0400)]
Merge branch '20377-dataexplorer-paging-bug' refs #20377
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 11 May 2023 18:23:52 +0000 (14:23 -0400)]
20493: isArrayOfType handles union type (optional) arrays
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Thu, 11 May 2023 17:35:31 +0000 (13:35 -0400)]
20377: Removed unused imports
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 11 May 2023 17:12:44 +0000 (13:12 -0400)]
20377: Treat NaN page as page 0 when checking whether to reject dataexplorere page updates
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 11 May 2023 16:25:08 +0000 (12:25 -0400)]
Merge branch 'main' of git.arvados.org:arvados-workbench2 into 20377-dataexplorer-paging-bug
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 10 May 2023 20:57:12 +0000 (16:57 -0400)]
Merge branch '20424-io-panel-performance' into main. Closes #20420
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Wed, 10 May 2023 17:44:54 +0000 (13:44 -0400)]
Merge branch '20487-inputs-display' refs #20487
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 10 May 2023 17:43:17 +0000 (13:43 -0400)]
20487: Use === instead of ==
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Wed, 10 May 2023 13:52:58 +0000 (09:52 -0400)]
20377: Update browserdb to get rid of warning
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 10 May 2023 12:59:37 +0000 (08:59 -0400)]
20377: Reject dataexplorer updates to incorrect page, allows dataexplorer to retry with correct page
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Wed, 10 May 2023 00:17:11 +0000 (20:17 -0400)]
20487: Wait for the snackbar to appear & go away
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 10 May 2023 00:09:08 +0000 (20:09 -0400)]
20487: Try make tests more reliable
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 9 May 2023 21:56:30 +0000 (17:56 -0400)]
20487: Correctly dispatch loadProject from openProjectPanel
Also fix it to recognize PDH in the files panel.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 9 May 2023 19:39:16 +0000 (15:39 -0400)]
20487: loadProject doesn't call openProjectPanel
The bug was was that loading the registered workflow panel would call
loadProject() which would call openProjectPanel() which would dispatch
REQUEST_ITEMS for the project (which is 100% wasteful, because we're
not displaying the project contents).
However, the results from REQUEST_ITEMS (which excludes some fields in
the standard query) would replace the result that previously got the
complete workflow object. As a result the "definition" field went
away, which cause the inputs/outputs panels to go blank.
This switches the navigation action to call "openProjectPanel", and
have that begin by calling "loadProject". As a result, other places
that call loadProject no longer call openProjectPanel.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 9 May 2023 16:17:45 +0000 (12:17 -0400)]
Merge branch '20452-collection-view-fix' refs #20452
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 9 May 2023 15:25:08 +0000 (11:25 -0400)]
20452: don't set path if currentItemUuid is not a collection
Also fixes bug when clicking "refresh" on collection.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Tue, 9 May 2023 14:42:04 +0000 (10:42 -0400)]
20424: Process io parameter parsing in single loop to optimize performance
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Tue, 9 May 2023 14:40:20 +0000 (10:40 -0400)]
20424: Memoize process io card preview to reduce unnecessary re-renders
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Fri, 5 May 2023 17:14:49 +0000 (13:14 -0400)]
Merge branch '20469-contents-select' refs #20469
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 3 May 2023 02:11:29 +0000 (22:11 -0400)]
20469: Provide select parameter to contents to avoid loading mounts
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Stephen Smith [Tue, 2 May 2023 13:05:14 +0000 (09:05 -0400)]
20031: Try to fix test
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Tue, 2 May 2023 13:01:34 +0000 (09:01 -0400)]
20031: Verify files in all copy/move batch operation tests
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Mon, 1 May 2023 18:38:00 +0000 (14:38 -0400)]
20031: Add tests for copy/move files to existing/new/separate collections
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Mon, 1 May 2023 18:36:45 +0000 (14:36 -0400)]
20031: Fix incorect const used for closing dialog, tweak copy/move file wording
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 27 Apr 2023 14:36:19 +0000 (10:36 -0400)]
20031: Preselect current collection in move/copy to existing collection tree picker
* Add collection support to ancestor service
* Initialize copy/move to existing collection form with current collection
* Use initial form value and ancestor service to preload tree picker with initial selection
* Add refresh action to tree picker search actions to populate initial expanded tree picker items after preselection
* Allow pristine copy/move to existing form to be submitted with initial value (relies on form validation to disable submit if no initial value)
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Tue, 25 Apr 2023 14:52:10 +0000 (10:52 -0400)]
20031: Add type for collection file operation location for form field
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Tue, 25 Apr 2023 14:44:16 +0000 (10:44 -0400)]
20031: Remove redundant collection copy/move form initializations
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 19 Apr 2023 00:44:19 +0000 (20:44 -0400)]
20031: Add split files into separate collection move/copy actions
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 19 Apr 2023 00:12:11 +0000 (20:12 -0400)]
20031: Navigate to new collections when copying/moving to new collection
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Mon, 17 Apr 2023 19:39:53 +0000 (15:39 -0400)]
20031: Add includeDirectories flag to ProjectsTreePicker and add collection/directory only picker
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Wed, 12 Apr 2023 13:38:27 +0000 (09:38 -0400)]
20031: Add ability to create and update collections during replace_files, moveFiles, copyFiles.
Used to optimize move/copy to new to reduce api calls
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Mon, 10 Apr 2023 19:29:32 +0000 (15:29 -0400)]
20031: Use replace files api for copy to new collection
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Mon, 10 Apr 2023 19:16:39 +0000 (15:16 -0400)]
20031: Add collection partial move/copy to new/existing collection
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Thu, 6 Apr 2023 14:49:22 +0000 (10:49 -0400)]
Merge branch '20306-sharing-dialog' refs #20306
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 6 Apr 2023 14:48:29 +0000 (10:48 -0400)]
20306: Revert sharing dialog to 'sm' width
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 6 Apr 2023 14:26:17 +0000 (10:26 -0400)]
20306: Reworked dialog layout to hopefully be less confusing
Tweaked to mimic the Google docs sharing dialog.
Put the "Add users" input box at the top, so people start there.
Added section headings.
Adusted the "general access" text to hopefully be more clear.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 4 Apr 2023 21:02:00 +0000 (17:02 -0400)]
Merge branch '20085-Sharing-Dialog-Form-Validation-Error' refs #20085
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 4 Apr 2023 19:03:37 +0000 (15:03 -0400)]
20085: Fix tests
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 4 Apr 2023 17:37:36 +0000 (13:37 -0400)]
20085: Fix quirky behavior when removing share with public/all users row
Fix some runtime warnings
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 3 Apr 2023 21:16:04 +0000 (17:16 -0400)]
20085: Sharing dialog immediately saves changes
Added ALL_USERS as a sharing level distinct from PUBLIC. Don't hide
the all users / public link in the permission list. Switching between
PUBLIC/ALL_USERS/SHARED/PRIVATE have clearly distinct actions.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Fri, 31 Mar 2023 21:59:16 +0000 (17:59 -0400)]
20085: Make the public/private/shared dropdown save on change
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Fri, 31 Mar 2023 21:24:23 +0000 (17:24 -0400)]
20085: Almost works, needs to save on change to share/public/private
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Fri, 31 Mar 2023 19:39:23 +0000 (15:39 -0400)]
20085: Moving the (+) button trying to restyle it
Typescript is fighting me every step of the way, something that should
take like 15 minutes is taking 3 hours, argh.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Daniel Kutyła [Fri, 31 Mar 2023 15:32:08 +0000 (17:32 +0200)]
Merge branch '20085-Sharing-Dialog-Form-Validation-Error-fix' into main
closes #20085
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Stephen Smith [Fri, 31 Mar 2023 15:05:14 +0000 (11:05 -0400)]
Merge branch '20252-subprocess-panel-refresh-bug' into main. Closes #20252
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Daniel Kutyła [Thu, 30 Mar 2023 23:24:18 +0000 (01:24 +0200)]
200085: Added changes to share dialog layout
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Stephen Smith [Thu, 30 Mar 2023 18:58:39 +0000 (14:58 -0400)]
20252: Clean up imports
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Stephen Smith [Thu, 30 Mar 2023 18:58:15 +0000 (14:58 -0400)]
20252: Avoid clearing subprocess data explorer when refreshing process panel
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
Peter Amstutz [Wed, 29 Mar 2023 18:31:11 +0000 (14:31 -0400)]
Fix tests refs #19295
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 29 Mar 2023 18:17:13 +0000 (14:17 -0400)]
Merge branch '19295-reused' refs #19295
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 29 Mar 2023 18:06:16 +0000 (14:06 -0400)]
19295: Adjust type filter defaults
Move order of "Workflow Definition" after runs because that's the
current sort order (which is imposed by the "contents" API so it is
nontrivial to change).
Hide "intermediate" and "log" output collections by default because
they are usually clutter and you generally find them by navigating
from the workflow run.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 29 Mar 2023 17:52:33 +0000 (13:52 -0400)]
19295: Add "Cancelling" state.
Tweak "cancel" button styling from discussion with Sarah.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 28 Mar 2023 17:28:41 +0000 (13:28 -0400)]
19295: Add "Reused" state to container status display
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 28 Mar 2023 13:47:12 +0000 (09:47 -0400)]
Merge branch '19482-wf-panel' refs #19482
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Daniel Kutyła [Mon, 27 Mar 2023 21:43:38 +0000 (23:43 +0200)]
200085: Fix for sharing dialog, clear on blur
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
projects / arvados-workbench2.git / log