20487: loadProject doesn't call openProjectPanel
authorPeter Amstutz <peter.amstutz@curii.com>
Tue, 9 May 2023 19:39:16 +0000 (15:39 -0400)
committerPeter Amstutz <peter.amstutz@curii.com>
Tue, 9 May 2023 19:47:42 +0000 (15:47 -0400)
commitbe33bc8c17b2e12b96d176d16e60f8ebe3fe1c06
tree67114aaa54b343cd63bed12417132e3c52852900
parent877cfadcbed1ebae8c94c8867bac2c25086d7ed4
20487: loadProject doesn't call openProjectPanel

The bug was was that loading the registered workflow panel would call
loadProject() which would call openProjectPanel() which would dispatch
REQUEST_ITEMS for the project (which is 100% wasteful, because we're
not displaying the project contents).

However, the results from REQUEST_ITEMS (which excludes some fields in
the standard query) would replace the result that previously got the
complete workflow object.  As a result the "definition" field went
away, which cause the inputs/outputs panels to go blank.

This switches the navigation action to call "openProjectPanel", and
have that begin by calling "loadProject".  As a result, other places
that call loadProject no longer call openProjectPanel.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
package.json
src/routes/route-change-handlers.ts
src/store/project-panel/project-panel-action.ts
src/store/store.ts
src/store/workbench/workbench-actions.ts
yarn.lock