20031: Rename vertical more icon and add horizontal variant. Correct usage in collect...
authorStephen Smith <stephen@curii.com>
Thu, 25 May 2023 19:04:38 +0000 (15:04 -0400)
committerStephen Smith <stephen@curii.com>
Thu, 25 May 2023 19:04:38 +0000 (15:04 -0400)
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

src/components/collection-panel-files/collection-panel-files.tsx
src/components/data-explorer/data-explorer.tsx
src/components/icon/icon.tsx
src/views/collection-panel/collection-panel.tsx
src/views/keep-service-panel/keep-service-panel-root.tsx
src/views/process-panel/process-details-card.tsx
src/views/repositories-panel/repositories-panel.tsx
src/views/ssh-key-panel/ssh-key-panel-root.tsx
src/views/user-profile-panel/user-profile-panel-root.tsx
src/views/virtual-machine-panel/virtual-machine-admin-panel.tsx
src/views/workflow-panel/registered-workflow-panel.tsx

index fb36ebce549d25171e38fed562db654d887a79ed..84b37a70013e5f40337b14749aacb587b813a5bc 100644 (file)
@@ -8,7 +8,7 @@ import { connect } from 'react-redux';
 import { FixedSizeList } from "react-window";
 import AutoSizer from "react-virtualized-auto-sizer";
 import servicesProvider from 'common/service-provider';
-import { CustomizeTableIcon, DownloadIcon, MoreOptionsIcon } from 'components/icon/icon';
+import { DownloadIcon, MoreHorizontalIcon, MoreVerticalIcon } from 'components/icon/icon';
 import { SearchInput } from 'components/search-input/search-input';
 import {
     ListItemIcon,
@@ -495,7 +495,7 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
                     onClick={(ev) => {
                         onOptionsMenuOpen(ev, isWritable);
                     }}>
-                    <CustomizeTableIcon />
+                    <MoreVerticalIcon />
                 </IconButton>
             </Tooltip>
         </div>
@@ -577,7 +577,7 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
                                         <IconButton data-id='moreOptions'
                                             data-cy='file-item-options-btn'
                                             className={classes.moreOptionsButton}>
-                                            <MoreOptionsIcon
+                                            <MoreHorizontalIcon
                                                 data-id='moreOptions'
                                                 className={classes.moreOptions} />
                                         </IconButton>
index fcee0c54deedcefaf5f9ed3282bfa757ccaadd4b..dc097c390ef110fa2ff262d300e48d5fcaf62657 100644 (file)
@@ -16,7 +16,7 @@ import {
     IconType,
     MaximizeIcon,
     UnMaximizeIcon,
-    MoreOptionsIcon
+    MoreVerticalIcon
 } from 'components/icon/icon';
 import { PaperProps } from '@material-ui/core/Paper';
 import { MPVPanelProps } from 'components/multi-panel-view/multi-panel-view';
@@ -255,7 +255,7 @@ export const DataExplorer = withStyles(styles)(
             <Grid container justify="center">
                 <Tooltip title="More options" disableFocusListener>
                     <IconButton className={this.props.classes.moreOptionsButton} onClick={event => this.props.onContextMenu(event, item)}>
-                        <MoreOptionsIcon />
+                        <MoreVerticalIcon />
                     </IconButton>
                 </Tooltip>
             </Grid>
index b71dc5a4059af666f8f20b7a14df718e0e4e26e3..65ef3b8b0d4f41a2e19b072cf518adc942f1c792 100644 (file)
@@ -44,6 +44,7 @@ import LibraryBooks from '@material-ui/icons/LibraryBooks';
 import ListAlt from '@material-ui/icons/ListAlt';
 import Menu from '@material-ui/icons/Menu';
 import MoreVert from '@material-ui/icons/MoreVert';
+import MoreHoriz from '@material-ui/icons/MoreHoriz';
 import Mail from '@material-ui/icons/Mail';
 import Notifications from '@material-ui/icons/Notifications';
 import OpenInNew from '@material-ui/icons/OpenInNew';
@@ -190,7 +191,8 @@ export const MailIcon: IconType = (props) => <Mail {...props} />;
 export const MaximizeIcon: IconType = (props) => <FullscreenSharp {...props} />;
 export const MemoryIcon: IconType = (props) => <Memory {...props} />;
 export const UnMaximizeIcon: IconType = (props) => <FullscreenExitSharp {...props} />;
-export const MoreOptionsIcon: IconType = (props) => <MoreVert {...props} />;
+export const MoreVerticalIcon: IconType = (props) => <MoreVert {...props} />;
+export const MoreHorizontalIcon: IconType = (props) => <MoreHoriz {...props} />;
 export const MoveToIcon: IconType = (props) => <Input {...props} />;
 export const NewProjectIcon: IconType = (props) => <CreateNewFolder {...props} />;
 export const NotificationIcon: IconType = (props) => <Notifications {...props} />;
index 54b7134ee42966bd29333e12770e575201247e6b..79cf07bfb46c1db297f8998123c5266ca497cbcc 100644 (file)
@@ -17,7 +17,7 @@ import { connect, DispatchProp } from "react-redux";
 import { RouteComponentProps } from 'react-router';
 import { ArvadosTheme } from 'common/custom-theme';
 import { RootState } from 'store/store';
-import { MoreOptionsIcon, CollectionIcon, ReadOnlyIcon, CollectionOldVersionIcon } from 'components/icon/icon';
+import { MoreVerticalIcon, CollectionIcon, ReadOnlyIcon, CollectionOldVersionIcon } from 'components/icon/icon';
 import { DetailsAttribute } from 'components/details-attribute/details-attribute';
 import { CollectionResource, getCollectionUrl } from 'models/collection';
 import { CollectionPanelFiles } from 'views-components/collection-panel-files/collection-panel-files';
@@ -200,7 +200,7 @@ export const CollectionPanel = withStyles(styles)(connect(
                                                 data-cy='collection-panel-options-btn'
                                                 aria-label="Actions"
                                                 onClick={this.handleContextMenu}>
-                                                <MoreOptionsIcon />
+                                                <MoreVerticalIcon />
                                             </IconButton>
                                         </Tooltip>
                                     }
index dee6ee77813008840042ae34ce36101e18c13523..7cc7795648c971fbc7ba9122e0e185ecf03a0b62 100644 (file)
@@ -5,7 +5,7 @@
 import React from 'react';
 import { StyleRulesCallback, WithStyles, withStyles, Card, CardContent, Grid, Table, TableHead, TableRow, TableCell, TableBody, Tooltip, IconButton, Checkbox } from '@material-ui/core';
 import { ArvadosTheme } from 'common/custom-theme';
-import { MoreOptionsIcon } from 'components/icon/icon';
+import { MoreVerticalIcon } from 'components/icon/icon';
 import { KeepServiceResource } from 'models/keep-services';
 
 type CssRules = 'root' | 'tableRow';
@@ -34,7 +34,7 @@ export interface KeepServicePanelRootDataProps {
 type KeepServicePanelRootProps = KeepServicePanelRootActionProps & KeepServicePanelRootDataProps & WithStyles<CssRules>;
 
 export const KeepServicePanelRoot = withStyles(styles)(
-    ({ classes, hasKeepSerices, keepServices, openRowOptions }: KeepServicePanelRootProps) => 
+    ({ classes, hasKeepSerices, keepServices, openRowOptions }: KeepServicePanelRootProps) =>
         <Card className={classes.root}>
             <CardContent>
                 {hasKeepSerices && <Grid container direction="row">
@@ -73,7 +73,7 @@ export const KeepServicePanelRoot = withStyles(styles)(
                                         <TableCell>
                                             <Tooltip title="More options" disableFocusListener>
                                                 <IconButton onClick={event => openRowOptions(event, keepService)}>
-                                                    <MoreOptionsIcon />
+                                                    <MoreVerticalIcon />
                                                 </IconButton>
                                             </Tooltip>
                                         </TableCell>
@@ -84,4 +84,4 @@ export const KeepServicePanelRoot = withStyles(styles)(
                 </Grid>}
             </CardContent>
         </Card>
-);
\ No newline at end of file
+);
index abcbcdb4c3a6d30129da50c0e490b02c46cb1901..37f01dd70163c2a51c9a5c08220dada138f853ba 100644 (file)
@@ -16,7 +16,7 @@ import {
     Button,
 } from '@material-ui/core';
 import { ArvadosTheme } from 'common/custom-theme';
-import { CloseIcon, MoreOptionsIcon, ProcessIcon, StartIcon, StopIcon } from 'components/icon/icon';
+import { CloseIcon, MoreVerticalIcon, ProcessIcon, StartIcon, StopIcon } from 'components/icon/icon';
 import { Process, isProcessRunnable, isProcessResumable, isProcessCancelable } from 'store/processes/process';
 import { MPVPanelProps } from 'components/multi-panel-view/multi-panel-view';
 import { ProcessDetailsAttributes } from './process-details-attributes';
@@ -139,7 +139,7 @@ export const ProcessDetailsCard = withStyles(styles)(
                             <IconButton
                                 aria-label="More options"
                                 onClick={event => onContextMenu(event)}>
-                                <MoreOptionsIcon />
+                                <MoreVerticalIcon />
                             </IconButton>
                         </Tooltip>
                         {doHidePanel &&
index 996c7bdf49f07dd6e83eb124e39ba50673f3144f..3ec5c56c62b12e5f4ff69e9410c6dc2ad1c21a1f 100644 (file)
@@ -10,7 +10,7 @@ import { ArvadosTheme } from 'common/custom-theme';
 import { Link } from 'react-router-dom';
 import { Dispatch, compose } from 'redux';
 import { RootState } from 'store/store';
-import { HelpIcon, AddIcon, MoreOptionsIcon } from 'components/icon/icon';
+import { HelpIcon, AddIcon, MoreVerticalIcon } from 'components/icon/icon';
 import { loadRepositoriesData, openRepositoriesSampleGitDialog, openRepositoryCreateDialog } from 'store/repositories/repositories-actions';
 import { RepositoryResource } from 'models/repositories';
 import { openRepositoryContextMenu } from 'store/context-menu/context-menu-actions';
@@ -138,7 +138,7 @@ export const RepositoriesPanel = compose(
                                                 <TableCell className={classes.moreOptions}>
                                                     <Tooltip title="More options" disableFocusListener>
                                                         <IconButton onClick={event => onOptionsMenuOpen(event, repository)} className={classes.moreOptionsButton}>
-                                                            <MoreOptionsIcon />
+                                                            <MoreVerticalIcon />
                                                         </IconButton>
                                                     </Tooltip>
                                                 </TableCell>
@@ -151,4 +151,4 @@ export const RepositoriesPanel = compose(
                 );
             }
         }
-    );
\ No newline at end of file
+    );
index 99ad1bffd356bf5994f83a58e606ece74143f822..8a266d00c6f146cc7bb0a5853e236224262f8f8f 100644 (file)
@@ -6,7 +6,7 @@ import React from 'react';
 import { StyleRulesCallback, WithStyles, withStyles, Card, CardContent, Button, Typography, Grid, Table, TableHead, TableRow, TableCell, TableBody, Tooltip, IconButton } from '@material-ui/core';
 import { ArvadosTheme } from 'common/custom-theme';
 import { SshKeyResource } from 'models/ssh-key';
-import { AddIcon, MoreOptionsIcon, KeyIcon } from 'components/icon/icon';
+import { AddIcon, MoreVerticalIcon, KeyIcon } from 'components/icon/icon';
 
 type CssRules = 'root' | 'link' | 'buttonContainer' | 'table' | 'tableRow' | 'keyIcon';
 
@@ -103,7 +103,7 @@ export const SshKeyPanelRoot = withStyles(styles)(
                                     <TableCell>
                                         <Tooltip title="More options" disableFocusListener>
                                             <IconButton onClick={event => openRowOptions(event, sshKey)}>
-                                                <MoreOptionsIcon />
+                                                <MoreVerticalIcon />
                                             </IconButton>
                                         </Tooltip>
                                     </TableCell>
@@ -113,4 +113,4 @@ export const SshKeyPanelRoot = withStyles(styles)(
                 </Grid>
             </CardContent>
         </Card>
-    );
\ No newline at end of file
+    );
index 6a55651678d8964c8be29ffcd18f9c3fa3a83e32..85eaaf0c985fb6c604e101fb37be4e56f6786fb1 100644 (file)
@@ -27,7 +27,7 @@ import { ArvadosTheme } from 'common/custom-theme';
 import { PROFILE_EMAIL_VALIDATION, PROFILE_URL_VALIDATION } from "validators/validators";
 import { USER_PROFILE_PANEL_ID } from 'store/user-profile/user-profile-actions';
 import { noop } from 'lodash';
-import { DetailsIcon, GroupsIcon, MoreOptionsIcon } from 'components/icon/icon';
+import { DetailsIcon, GroupsIcon, MoreVerticalIcon } from 'components/icon/icon';
 import { DataColumns } from 'components/data-table/data-table';
 import { ResourceLinkHeadUuid, ResourceLinkHeadPermissionLevel, ResourceLinkHead, ResourceLinkDelete, ResourceLinkTailIsVisible, UserResourceAccountStatus } from 'views-components/data-explorer/renderers';
 import { createTree } from 'models/tree';
@@ -220,7 +220,7 @@ export const UserProfilePanelRoot = withStyles(styles)(
                                                     data-cy='user-profile-panel-options-btn'
                                                     aria-label="Actions"
                                                     onClick={(event) => this.handleContextMenu(event, this.props.userUuid)}>
-                                                    <MoreOptionsIcon />
+                                                    <MoreVerticalIcon />
                                                 </IconButton>
                                             </Tooltip>
                                         </Grid>
index 864218e4a17a17b9d531a8087bacb73757a06d7a..20665f178d1d80dae898357244738790faa6e0ee 100644 (file)
@@ -11,7 +11,7 @@ import { compose, Dispatch } from 'redux';
 import { loadVirtualMachinesAdminData, openAddVirtualMachineLoginDialog, openRemoveVirtualMachineLoginDialog, openEditVirtualMachineLoginDialog } from 'store/virtual-machines/virtual-machines-actions';
 import { RootState } from 'store/store';
 import { ListResults } from 'services/common-service/common-service';
-import { MoreOptionsIcon, AddUserIcon } from 'components/icon/icon';
+import { MoreVerticalIcon, AddUserIcon } from 'components/icon/icon';
 import { VirtualMachineLogins, VirtualMachinesResource } from 'models/virtual-machines';
 import { openVirtualMachinesContextMenu } from 'store/context-menu/context-menu-actions';
 import { ResourceUuid, VirtualMachineHostname, VirtualMachineLogin } from 'views-components/data-explorer/renderers';
@@ -139,7 +139,7 @@ const virtualMachinesTable = (props: VirtualMachineProps) =>
                     <TableCell className={props.classes.moreOptions}>
                         <Tooltip title="More options" disableFocusListener>
                             <IconButton onClick={event => props.onOptionsMenuOpen(event, machine)} className={props.classes.moreOptionsButton}>
-                                <MoreOptionsIcon />
+                                <MoreVerticalIcon />
                             </IconButton>
                         </Tooltip>
                     </TableCell>
index 0963de35e8ad703fc5b426c779cfa13656b351d2..5973efedc8fe0626e10cd13ad5465e36baab79f4 100644 (file)
@@ -18,7 +18,7 @@ import { connect, DispatchProp } from "react-redux";
 import { RouteComponentProps } from 'react-router';
 import { ArvadosTheme } from 'common/custom-theme';
 import { RootState } from 'store/store';
-import { WorkflowIcon, MoreOptionsIcon } from 'components/icon/icon';
+import { WorkflowIcon, MoreVerticalIcon } from 'components/icon/icon';
 import { WorkflowResource } from 'models/workflow';
 import { ProcessOutputCollectionFiles } from 'views/process-panel/process-output-collection-files';
 import { WorkflowDetailsAttributes, RegisteredWorkflowPanelDataProps, getRegisteredWorkflowPanelData } from 'views-components/details-panel/workflow-details';
@@ -167,7 +167,7 @@ export const RegisteredWorkflowPanel = withStyles(styles)(connect(
                                             <IconButton
                                                 aria-label="More options"
                                                 onClick={event => this.handleContextMenu(event)}>
-                                                <MoreOptionsIcon />
+                                                <MoreVerticalIcon />
                                             </IconButton>
                                         </Tooltip>}