4 Check lesson files and their contents.
12 from optparse import OptionParser
14 from util import Reporter, read_markdown, load_yaml, check_unwanted_files
18 # Where to look for source Markdown files.
19 SOURCE_DIRS = ['', '_episodes', '_extras']
21 # Required files: each entry is ('path': YAML_required).
22 # FIXME: We do not yet validate whether any files have the required
23 # YAML headers, but should in the future.
24 # The '%' is replaced with the source directory path for checking.
25 # Episodes are handled specially, and extra files in '_extras' are also handled specially.
26 # This list must include all the Markdown files listed in the 'bin/initialize' script.
29 '%/CONTRIBUTING.md': False,
32 '%/_extras/discuss.md': True,
33 '%/_extras/figures.md': True,
34 '%/_extras/guide.md': True,
36 '%/reference.md': True,
40 # Episode filename pattern.
41 P_EPISODE_FILENAME = re.compile(r'/_episodes/(\d\d)-[-\w]+.md$')
43 # Pattern to match lines ending with whitespace.
44 P_TRAILING_WHITESPACE = re.compile(r'\s+$')
46 # Pattern to match figure references in HTML.
47 P_FIGURE_REFS = re.compile(r'<img[^>]+src="([^"]+)"[^>]*>')
49 # What kinds of blockquotes are allowed?
63 # What kinds of code fragments are allowed?
75 # What fields are required in teaching episode metadata?
76 TEACHING_METADATA_FIELDS = {
85 # What fields are required in break episode metadata?
86 BREAK_METADATA_FIELDS = {
92 # How long are lines allowed to be?
99 args.reporter = Reporter()
100 check_config(args.reporter, args.source_dir)
101 docs = read_all_markdown(args.source_dir, args.parser)
102 check_fileset(args.source_dir, args.reporter, docs.keys())
103 check_unwanted_files(args.source_dir, args.reporter)
104 for filename in docs.keys():
105 checker = create_checker(args, filename, docs[filename])
107 check_figures(args.source_dir, args.reporter)
108 args.reporter.report()
112 """Parse command-line arguments."""
114 parser = OptionParser()
115 parser.add_option('-l', '--linelen',
119 help='Check line lengths')
120 parser.add_option('-p', '--parser',
123 help='path to Markdown parser')
124 parser.add_option('-s', '--source',
127 help='source directory')
128 parser.add_option('-w', '--whitespace',
131 dest='trailing_whitespace',
132 help='Check for trailing whitespace')
134 args, extras = parser.parse_args()
135 require(args.parser is not None,
136 'Path to Markdown parser not provided')
138 'Unexpected trailing command-line arguments "{0}"'.format(extras))
143 def check_config(reporter, source_dir):
144 """Check configuration file."""
146 config_file = os.path.join(source_dir, '_config.yml')
147 config = load_yaml(config_file)
148 reporter.check_field(config_file, 'configuration', config, 'kind', 'lesson')
151 def read_all_markdown(source_dir, parser):
152 """Read source files, returning
153 {path : {'metadata':yaml, 'metadata_len':N, 'text':text, 'lines':[(i, line, len)], 'doc':doc}}
156 all_dirs = [os.path.join(source_dir, d) for d in SOURCE_DIRS]
157 all_patterns = [os.path.join(d, '*.md') for d in all_dirs]
159 for pat in all_patterns:
160 for filename in glob.glob(pat):
161 data = read_markdown(parser, filename)
163 result[filename] = data
167 def check_fileset(source_dir, reporter, filenames_present):
168 """Are all required files present? Are extraneous files present?"""
170 # Check files with predictable names.
171 required = [p.replace('%', source_dir) for p in REQUIRED_FILES]
172 missing = set(required) - set(filenames_present)
174 reporter.add(None, 'Missing required file {0}', m)
176 # Check episode files' names.
178 for filename in filenames_present:
179 if '_episodes' not in filename:
181 m = P_EPISODE_FILENAME.search(filename)
183 seen.append(m.group(1))
185 reporter.add(None, 'Episode {0} has badly-formatted filename', filename)
187 # Check for duplicate episode numbers.
188 reporter.check(len(seen) == len(set(seen)),
190 'Duplicate episode numbers {0} vs {1}',
191 sorted(seen), sorted(set(seen)))
193 # Check that numbers are consecutive.
194 seen = [int(s) for s in seen]
197 for i in range(len(seen) - 1):
198 clean = clean and ((seen[i+1] - seen[i]) == 1)
199 reporter.check(clean,
201 'Missing or non-consecutive episode numbers {0}',
205 def check_figures(source_dir, reporter):
206 """Check that all figures are present and referenced."""
210 all_figures_html = os.path.join(source_dir, '_includes', 'all_figures.html')
211 with open(all_figures_html, 'r') as reader:
213 figures = P_FIGURE_REFS.findall(text)
214 referenced = [os.path.split(f)[1] for f in figures if '/fig/' in f]
215 except FileNotFoundError as e:
216 reporter.add(all_figures_html,
221 fig_dir_path = os.path.join(source_dir, 'fig')
222 actual = [f for f in os.listdir(fig_dir_path) if not f.startswith('.')]
224 # Report differences.
225 unexpected = set(actual) - set(referenced)
226 reporter.check(not unexpected,
228 'Unexpected image files: {0}',
229 ', '.join(sorted(unexpected)))
230 missing = set(referenced) - set(actual)
231 reporter.check(not missing,
233 'Missing image files: {0}',
234 ', '.join(sorted(missing)))
237 def create_checker(args, filename, info):
238 """Create appropriate checker for file."""
240 for (pat, cls) in CHECKERS:
241 if pat.search(filename):
242 return cls(args, filename, **info)
245 def require(condition, message):
246 """Fail if condition not met."""
249 print(message, file=sys.stderr)
253 class CheckBase(object):
254 """Base class for checking Markdown files."""
256 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
257 """Cache arguments for checking."""
259 super(CheckBase, self).__init__()
261 self.reporter = self.args.reporter # for convenience
262 self.filename = filename
263 self.metadata = metadata
264 self.metadata_len = metadata_len
273 """Run tests on metadata."""
275 self.check_metadata()
276 self.check_line_lengths()
277 self.check_trailing_whitespace()
278 self.check_blockquote_classes()
279 self.check_codeblock_classes()
282 def check_metadata(self):
283 """Check the YAML metadata."""
285 self.reporter.check(self.metadata is not None,
287 'Missing metadata entirely')
289 if self.metadata and (self.layout is not None):
290 self.reporter.check_field(self.filename, 'metadata', self.metadata, 'layout', self.layout)
293 def check_line_lengths(self):
294 """Check the raw text of the lesson body."""
296 if self.args.line_lengths:
297 over = [i for (i, l, n) in self.lines if (n > MAX_LINE_LEN) and (not l.startswith('!'))]
298 self.reporter.check(not over,
300 'Line(s) are too long: {0}',
301 ', '.join([str(i) for i in over]))
304 def check_trailing_whitespace(self):
305 """Check for whitespace at the ends of lines."""
307 if self.args.trailing_whitespace:
308 trailing = [i for (i, l, n) in self.lines if P_TRAILING_WHITESPACE.match(l)]
309 self.reporter.check(not trailing,
311 'Line(s) end with whitespace: {0}',
312 ', '.join([str(i) for i in trailing]))
315 def check_blockquote_classes(self):
316 """Check that all blockquotes have known classes."""
318 for node in self.find_all(self.doc, {'type' : 'blockquote'}):
319 cls = self.get_val(node, 'attr', 'class')
320 self.reporter.check(cls in KNOWN_BLOCKQUOTES,
321 (self.filename, self.get_loc(node)),
322 'Unknown or missing blockquote type {0}',
326 def check_codeblock_classes(self):
327 """Check that all code blocks have known classes."""
329 for node in self.find_all(self.doc, {'type' : 'codeblock'}):
330 cls = self.get_val(node, 'attr', 'class')
331 self.reporter.check(cls in KNOWN_CODEBLOCKS,
332 (self.filename, self.get_loc(node)),
333 'Unknown or missing code block type {0}',
337 def find_all(self, node, pattern, accum=None):
338 """Find all matches for a pattern."""
340 assert type(pattern) == dict, 'Patterns must be dictionaries'
343 if self.match(node, pattern):
345 for child in node.get('children', []):
346 self.find_all(child, pattern, accum)
350 def match(self, node, pattern):
351 """Does this node match the given pattern?"""
360 elif type(val) == dict:
361 if not self.match(node[key], val):
366 def get_val(self, node, *chain):
367 """Get value one or more levels down."""
370 for selector in chain:
371 curr = curr.get(selector, None)
377 def get_loc(self, node):
378 """Convenience method to get node's line number."""
380 result = self.get_val(node, 'options', 'location')
381 if self.metadata_len is not None:
382 result += self.metadata_len
386 class CheckNonJekyll(CheckBase):
387 """Check a file that isn't translated by Jekyll."""
389 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
390 super(CheckNonJekyll, self).__init__(args, filename, metadata, metadata_len, text, lines, doc)
393 def check_metadata(self):
394 self.reporter.check(self.metadata is None,
396 'Unexpected metadata')
399 class CheckIndex(CheckBase):
400 """Check the main index page."""
402 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
403 super(CheckIndex, self).__init__(args, filename, metadata, metadata_len, text, lines, doc)
404 self.layout = 'lesson'
407 class CheckEpisode(CheckBase):
408 """Check an episode page."""
410 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
411 super(CheckEpisode, self).__init__(args, filename, metadata, metadata_len, text, lines, doc)
413 def check_metadata(self):
414 super(CheckEpisode, self).check_metadata()
416 if 'layout' in self.metadata:
417 if self.metadata['layout'] == 'break':
418 self.check_metadata_fields(BREAK_METADATA_FIELDS)
420 self.reporter.add(self.filename,
421 'Unknown episode layout "{0}"',
422 self.metadata['layout'])
424 self.check_metadata_fields(TEACHING_METADATA_FIELDS)
427 def check_metadata_fields(self, expected):
428 for (name, type_) in expected:
429 if name not in self.metadata:
430 self.reporter.add(self.filename,
431 'Missing metadata field {0}',
433 elif type(self.metadata[name]) != type_:
434 self.reporter.add(self.filename,
435 '"{0}" has wrong type in metadata ({1} instead of {2})',
436 name, type(self.metadata[name]), type_)
439 class CheckReference(CheckBase):
440 """Check the reference page."""
442 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
443 super(CheckReference, self).__init__(args, filename, metadata, metadata_len, text, lines, doc)
444 self.layout = 'reference'
447 class CheckGeneric(CheckBase):
448 """Check a generic page."""
450 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
451 super(CheckGeneric, self).__init__(args, filename, metadata, metadata_len, text, lines, doc)
456 (re.compile(r'CONTRIBUTING\.md'), CheckNonJekyll),
457 (re.compile(r'README\.md'), CheckNonJekyll),
458 (re.compile(r'index\.md'), CheckIndex),
459 (re.compile(r'reference\.md'), CheckReference),
460 (re.compile(r'_episodes/.*\.md'), CheckEpisode),
461 (re.compile(r'.*\.md'), CheckGeneric)
465 if __name__ == '__main__':