4 Check lesson files and their contents.
11 from optparse import OptionParser
13 from util import (Reporter, read_markdown, load_yaml, check_unwanted_files,
18 # Where to look for source Markdown files.
19 SOURCE_DIRS = ['', '_episodes', '_extras']
21 # Required files: each entry is ('path': YAML_required).
22 # FIXME: We do not yet validate whether any files have the required
23 # YAML headers, but should in the future.
24 # The '%' is replaced with the source directory path for checking.
25 # Episodes are handled specially, and extra files in '_extras' are also handled
26 # specially. This list must include all the Markdown files listed in the
27 # 'bin/initialize' script.
30 '%/CONTRIBUTING.md': False,
33 '%/_extras/discuss.md': True,
34 '%/_extras/guide.md': True,
36 '%/reference.md': True,
40 # Episode filename pattern.
41 P_EPISODE_FILENAME = re.compile(r'/_episodes/(\d\d)-[-\w]+.md$')
43 # Pattern to match lines ending with whitespace.
44 P_TRAILING_WHITESPACE = re.compile(r'\s+$')
46 # Pattern to match figure references in HTML.
47 P_FIGURE_REFS = re.compile(r'<img[^>]+src="([^"]+)"[^>]*>')
49 # Pattern to match internally-defined Markdown links.
50 P_INTERNAL_LINK_REF = re.compile(r'\[([^\]]+)\]\[([^\]]+)\]')
52 # Pattern to match reference links (to resolve internally-defined references).
53 P_INTERNAL_LINK_DEF = re.compile(r'^\[([^\]]+)\]:\s*(.+)')
55 # What kinds of blockquotes are allowed?
69 # What kinds of code fragments are allowed?
84 # What fields are required in teaching episode metadata?
85 TEACHING_METADATA_FIELDS = {
94 # What fields are required in break episode metadata?
95 BREAK_METADATA_FIELDS = {
101 # How long are lines allowed to be?
109 args.reporter = Reporter()
110 check_config(args.reporter, args.source_dir)
111 args.references = read_references(args.reporter, args.reference_path)
113 docs = read_all_markdown(args.source_dir, args.parser)
114 check_fileset(args.source_dir, args.reporter, list(docs.keys()))
115 check_unwanted_files(args.source_dir, args.reporter)
116 for filename in list(docs.keys()):
117 checker = create_checker(args, filename, docs[filename])
120 args.reporter.report()
121 if args.reporter.messages:
126 """Parse command-line arguments."""
128 parser = OptionParser()
129 parser.add_option('-l', '--linelen',
133 help='Check line lengths')
134 parser.add_option('-p', '--parser',
137 help='path to Markdown parser')
138 parser.add_option('-r', '--references',
140 dest='reference_path',
141 help='path to Markdown file of external references')
142 parser.add_option('-s', '--source',
145 help='source directory')
146 parser.add_option('-w', '--whitespace',
149 dest='trailing_whitespace',
150 help='Check for trailing whitespace')
152 args, extras = parser.parse_args()
153 require(args.parser is not None,
154 'Path to Markdown parser not provided')
156 'Unexpected trailing command-line arguments "{0}"'.format(extras))
161 def check_config(reporter, source_dir):
162 """Check configuration file."""
164 config_file = os.path.join(source_dir, '_config.yml')
165 config = load_yaml(config_file)
166 reporter.check_field(config_file, 'configuration',
167 config, 'kind', 'lesson')
168 reporter.check_field(config_file, 'configuration',
169 config, 'carpentry', ('swc', 'dc', 'lc'))
170 reporter.check_field(config_file, 'configuration', config, 'title')
171 reporter.check_field(config_file, 'configuration', config, 'email')
173 reporter.check({'values': {'root': '..'}} in config.get('defaults', []),
175 '"root" not set to ".." in configuration')
178 def read_references(reporter, ref_path):
179 """Read shared file of reference links, returning dictionary of valid references
180 {symbolic_name : URL}
186 with open(ref_path, 'r') as reader:
187 for (num, line) in enumerate(reader):
189 m = P_INTERNAL_LINK_DEF.search(line)
191 '{0}:{1} not valid reference:\n{2}'.format(ref_path, line_num, line.rstrip()))
195 'Empty reference at {0}:{1}'.format(ref_path, line_num))
196 reporter.check(name not in result,
198 'Duplicate reference {0} at line {1}',
200 reporter.check(url not in urls_seen,
202 'Duplicate definition of URL {0} at line {1}',
209 def read_all_markdown(source_dir, parser):
210 """Read source files, returning
211 {path : {'metadata':yaml, 'metadata_len':N, 'text':text, 'lines':[(i, line, len)], 'doc':doc}}
214 all_dirs = [os.path.join(source_dir, d) for d in SOURCE_DIRS]
215 all_patterns = [os.path.join(d, '*.md') for d in all_dirs]
217 for pat in all_patterns:
218 for filename in glob.glob(pat):
219 data = read_markdown(parser, filename)
221 result[filename] = data
225 def check_fileset(source_dir, reporter, filenames_present):
226 """Are all required files present? Are extraneous files present?"""
228 # Check files with predictable names.
229 required = [p.replace('%', source_dir) for p in REQUIRED_FILES]
230 missing = set(required) - set(filenames_present)
232 reporter.add(None, 'Missing required file {0}', m)
234 # Check episode files' names.
236 for filename in filenames_present:
237 if '_episodes' not in filename:
239 m = P_EPISODE_FILENAME.search(filename)
241 seen.append(m.group(1))
244 None, 'Episode {0} has badly-formatted filename', filename)
246 # Check for duplicate episode numbers.
247 reporter.check(len(seen) == len(set(seen)),
249 'Duplicate episode numbers {0} vs {1}',
250 sorted(seen), sorted(set(seen)))
252 # Check that numbers are consecutive.
253 seen = sorted([int(s) for s in seen])
255 for i in range(len(seen) - 1):
256 clean = clean and ((seen[i+1] - seen[i]) == 1)
257 reporter.check(clean,
259 'Missing or non-consecutive episode numbers {0}',
263 def create_checker(args, filename, info):
264 """Create appropriate checker for file."""
266 for (pat, cls) in CHECKERS:
267 if pat.search(filename):
268 return cls(args, filename, **info)
271 class CheckBase(object):
272 """Base class for checking Markdown files."""
274 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
275 """Cache arguments for checking."""
277 super(CheckBase, self).__init__()
279 self.reporter = self.args.reporter # for convenience
280 self.filename = filename
281 self.metadata = metadata
282 self.metadata_len = metadata_len
292 self.check_metadata()
293 self.check_line_lengths()
294 self.check_trailing_whitespace()
295 self.check_blockquote_classes()
296 self.check_codeblock_classes()
297 self.check_defined_link_references()
299 def check_metadata(self):
300 """Check the YAML metadata."""
302 self.reporter.check(self.metadata is not None,
304 'Missing metadata entirely')
306 if self.metadata and (self.layout is not None):
307 self.reporter.check_field(
308 self.filename, 'metadata', self.metadata, 'layout', self.layout)
310 def check_line_lengths(self):
311 """Check the raw text of the lesson body."""
313 if self.args.line_lengths:
314 over = [i for (i, l, n) in self.lines if (
315 n > MAX_LINE_LEN) and (not l.startswith('!'))]
316 self.reporter.check(not over,
318 'Line(s) are too long: {0}',
319 ', '.join([str(i) for i in over]))
321 def check_trailing_whitespace(self):
322 """Check for whitespace at the ends of lines."""
324 if self.args.trailing_whitespace:
326 i for (i, l, n) in self.lines if P_TRAILING_WHITESPACE.match(l)]
327 self.reporter.check(not trailing,
329 'Line(s) end with whitespace: {0}',
330 ', '.join([str(i) for i in trailing]))
332 def check_blockquote_classes(self):
333 """Check that all blockquotes have known classes."""
335 for node in self.find_all(self.doc, {'type': 'blockquote'}):
336 cls = self.get_val(node, 'attr', 'class')
337 self.reporter.check(cls in KNOWN_BLOCKQUOTES,
338 (self.filename, self.get_loc(node)),
339 'Unknown or missing blockquote type {0}',
342 def check_codeblock_classes(self):
343 """Check that all code blocks have known classes."""
345 for node in self.find_all(self.doc, {'type': 'codeblock'}):
346 cls = self.get_val(node, 'attr', 'class')
347 self.reporter.check(cls in KNOWN_CODEBLOCKS,
348 (self.filename, self.get_loc(node)),
349 'Unknown or missing code block type {0}',
352 def check_defined_link_references(self):
353 """Check that defined links resolve in the file.
355 Internally-defined links match the pattern [text][label].
359 for node in self.find_all(self.doc, {'type': 'text'}):
360 for match in P_INTERNAL_LINK_REF.findall(node['value']):
363 if link not in self.args.references:
364 result.add('"{0}"=>"{1}"'.format(text, link))
365 self.reporter.check(not result,
367 'Internally-defined links may be missing definitions: {0}',
368 ', '.join(sorted(result)))
370 def find_all(self, node, pattern, accum=None):
371 """Find all matches for a pattern."""
373 assert isinstance(pattern, dict), 'Patterns must be dictionaries'
376 if self.match(node, pattern):
378 for child in node.get('children', []):
379 self.find_all(child, pattern, accum)
382 def match(self, node, pattern):
383 """Does this node match the given pattern?"""
389 if isinstance(val, str):
392 elif isinstance(val, dict):
393 if not self.match(node[key], val):
397 def get_val(self, node, *chain):
398 """Get value one or more levels down."""
401 for selector in chain:
402 curr = curr.get(selector, None)
407 def get_loc(self, node):
408 """Convenience method to get node's line number."""
410 result = self.get_val(node, 'options', 'location')
411 if self.metadata_len is not None:
412 result += self.metadata_len
416 class CheckNonJekyll(CheckBase):
417 """Check a file that isn't translated by Jekyll."""
419 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
420 super(CheckNonJekyll, self).__init__(
421 args, filename, metadata, metadata_len, text, lines, doc)
423 def check_metadata(self):
424 self.reporter.check(self.metadata is None,
426 'Unexpected metadata')
429 class CheckIndex(CheckBase):
430 """Check the main index page."""
432 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
433 super(CheckIndex, self).__init__(args, filename,
434 metadata, metadata_len, text, lines, doc)
435 self.layout = 'lesson'
437 def check_metadata(self):
438 super(CheckIndex, self).check_metadata()
439 self.reporter.check(self.metadata.get('root', '') == '.',
441 'Root not set to "."')
444 class CheckEpisode(CheckBase):
445 """Check an episode page."""
447 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
448 super(CheckEpisode, self).__init__(args, filename,
449 metadata, metadata_len, text, lines, doc)
452 """Run extra tests."""
454 super(CheckEpisode, self).check()
455 self.check_reference_inclusion()
457 def check_metadata(self):
458 super(CheckEpisode, self).check_metadata()
460 if 'layout' in self.metadata:
461 if self.metadata['layout'] == 'break':
462 self.check_metadata_fields(BREAK_METADATA_FIELDS)
464 self.reporter.add(self.filename,
465 'Unknown episode layout "{0}"',
466 self.metadata['layout'])
468 self.check_metadata_fields(TEACHING_METADATA_FIELDS)
470 def check_metadata_fields(self, expected):
471 for (name, type_) in expected:
472 if name not in self.metadata:
473 self.reporter.add(self.filename,
474 'Missing metadata field {0}',
476 elif not isinstance(self.metadata[name], type_):
477 self.reporter.add(self.filename,
478 '"{0}" has wrong type in metadata ({1} instead of {2})',
479 name, type(self.metadata[name]), type_)
481 def check_reference_inclusion(self):
482 """Check that links file has been included."""
484 if not self.args.reference_path:
487 for (i, last_line, line_len) in reversed(self.lines):
492 'No non-empty lines in {0}'.format(self.filename))
494 include_filename = os.path.split(self.args.reference_path)[-1]
495 if include_filename not in last_line:
496 self.reporter.add(self.filename,
497 'episode does not include "{0}"',
501 class CheckReference(CheckBase):
502 """Check the reference page."""
504 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
505 super(CheckReference, self).__init__(
506 args, filename, metadata, metadata_len, text, lines, doc)
507 self.layout = 'reference'
510 class CheckGeneric(CheckBase):
511 """Check a generic page."""
513 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
514 super(CheckGeneric, self).__init__(args, filename,
515 metadata, metadata_len, text, lines, doc)
520 (re.compile(r'CONTRIBUTING\.md'), CheckNonJekyll),
521 (re.compile(r'README\.md'), CheckNonJekyll),
522 (re.compile(r'index\.md'), CheckIndex),
523 (re.compile(r'reference\.md'), CheckReference),
524 (re.compile(r'_episodes/.*\.md'), CheckEpisode),
525 (re.compile(r'.*\.md'), CheckGeneric)
529 if __name__ == '__main__':