Brett Smith [Fri, 1 May 2015 18:07:04 +0000 (14:07 -0400)]
5752: arv-copy preserves properties of docker_image links.
The properties include the image_timestamp, which tells Arvados when
the source image was created, rather than the containing collection.
The API server uses this information to determine which image is
newest.
Radhika Chippada [Fri, 1 May 2015 15:36:30 +0000 (11:36 -0400)]
closes #4458
Merge branch '4458-breadcrumbs-in-small-screens'
Radhika Chippada [Fri, 1 May 2015 15:35:17 +0000 (11:35 -0400)]
Merge branch 'master' into 4458-breadcrumbs-in-small-screens
Radhika Chippada [Fri, 1 May 2015 14:26:40 +0000 (10:26 -0400)]
closes #5843
Merge branch '5843-subproject-deletion-owner-name-constraint'
Radhika Chippada [Fri, 1 May 2015 14:26:01 +0000 (10:26 -0400)]
Merge branch 'master' into 5843-subproject-deletion-owner-name-constraint
Peter Amstutz [Thu, 30 Apr 2015 20:38:24 +0000 (16:38 -0400)]
run-command list correct directory to be uploaded when $(task.cwd) != $(task.outdir)
no issue #
Peter Amstutz [Thu, 30 Apr 2015 20:07:12 +0000 (16:07 -0400)]
Merge branch '3145-missing-content-length-error' closes #3145
Peter Amstutz [Thu, 30 Apr 2015 18:30:09 +0000 (14:30 -0400)]
Merge branch '5856-read-exact' closes #5856
Peter Amstutz [Thu, 30 Apr 2015 18:21:41 +0000 (14:21 -0400)]
5856: Tweak tests. Fix typo.
Radhika Chippada [Thu, 30 Apr 2015 18:19:42 +0000 (14:19 -0400)]
4458: breadcrumbs now visible in small window sizes; also, use user icon instead of email for my account menu.
Peter Amstutz [Thu, 30 Apr 2015 17:59:22 +0000 (13:59 -0400)]
Return error if Content-Length header is missing instead of panicing.
Peter Amstutz [Thu, 30 Apr 2015 15:18:24 +0000 (11:18 -0400)]
ArvadosFileReader object always tries to return the exact amount of data asked for.
This is to avoid breaking stuff like gzip that assumes it always gets the exact
amount of data unless EOF. (From the Python file docs for read(): Note that
this method may call the underlying C function fread() more than once in an
effort to acquire as close to size bytes as possible.) closes #5856
Tom Clegg [Thu, 30 Apr 2015 15:30:20 +0000 (11:30 -0400)]
Merge branch '5562-pycurl' refs #5562
Tom Clegg [Thu, 30 Apr 2015 15:27:46 +0000 (11:27 -0400)]
5562: Use static method. Fix "TypeError: _socket_open() takes exactly 5 arguments (4 given)".
Radhika Chippada [Thu, 30 Apr 2015 14:59:29 +0000 (10:59 -0400)]
5843: rename objects that contain xx_owner_uuid_name_unique constraint when they are removed from a subproject and the home project already has another object of the same type and name.
Tom Clegg [Thu, 30 Apr 2015 14:25:13 +0000 (10:25 -0400)]
Merge branch '3145-close-early' closes #3145
Tom Clegg [Thu, 30 Apr 2015 14:24:16 +0000 (10:24 -0400)]
Merge branch '5836-remote-api-server-errors-made-obvious' closes #5836
Tom Clegg [Thu, 30 Apr 2015 13:53:15 +0000 (09:53 -0400)]
5562: Use WRITEFUNCTION instead of WRITEDATA for compatibility with older pycurl. refs #5562
Tom Clegg [Wed, 29 Apr 2015 18:56:22 +0000 (14:56 -0400)]
3145: Respond to PUT without reading request body if no volumes are writable.
Tom Clegg [Wed, 29 Apr 2015 17:45:46 +0000 (13:45 -0400)]
Merge branch '5562-pycurl' closes #5562
Tom Clegg [Wed, 29 Apr 2015 15:10:40 +0000 (11:10 -0400)]
5562: Return UA to pool if it worked well enough to get an HTTP status.
Tom Clegg [Wed, 29 Apr 2015 14:57:47 +0000 (10:57 -0400)]
5562: Enable TCP Keepalive for Keep requests. refs #5822
mishaz [Wed, 29 Apr 2015 16:31:00 +0000 (16:31 +0000)]
Renamed RemoteApiServerError to APIServerError and NewRemoteApiServerError to newAPIServerError.
Reworked error messages to feature error details more prominently.
These changes were requested by code review at
https://github.com/curoverse/arvados/pull/17/files
Radhika Chippada [Wed, 29 Apr 2015 13:07:10 +0000 (09:07 -0400)]
closes #5826
Merge branch '5826-unreadable-inputs-error'
Radhika Chippada [Wed, 29 Apr 2015 12:44:49 +0000 (08:44 -0400)]
5826: use present? instead of !empty?
Tom Clegg [Tue, 28 Apr 2015 23:08:45 +0000 (19:08 -0400)]
5562: Add fake keepstore server with configurable problems.
Tom Clegg [Wed, 22 Apr 2015 18:26:43 +0000 (14:26 -0400)]
5562: Use pycurl library (instead of requests) for Keep transactions.
mishaz [Tue, 28 Apr 2015 22:29:27 +0000 (22:29 +0000)]
Added tests to confirm that error messages indicate that error is remote.
Fixed punctuation.
mishaz [Tue, 28 Apr 2015 22:16:46 +0000 (22:16 +0000)]
Rewrote ArvadosApiError as RemoteApiServerError:
* Name change to indicate that it's a remote error, not a local one.
* Rewrote Error() method to explicitly state that the error is remote and list all fields.
* Added server address field and use it in error response.
* Error details are now kept as a string slice rather than as a delimited string.
Some cleanup and gofmt import shuffling.
Radhika Chippada [Tue, 28 Apr 2015 22:03:58 +0000 (18:03 -0400)]
5826: revert the previous update that checked if readable only for pdh or uuid;
instead check as long as a collection datatype is presented with a non-empty string.
Radhika Chippada [Tue, 28 Apr 2015 18:43:34 +0000 (14:43 -0400)]
closes #5622
Merge branch '5622-fix-timeout-pdh-page'
Radhika Chippada [Tue, 28 Apr 2015 18:06:28 +0000 (14:06 -0400)]
5622: when there are too many collections matching a pdh, show only 20 of them.
Peter Amstutz [Tue, 28 Apr 2015 13:46:58 +0000 (09:46 -0400)]
Check if cache slot is not None before trying to test the read flag. refs #5831
Tom Clegg [Tue, 28 Apr 2015 06:10:14 +0000 (02:10 -0400)]
Merge branch '5739-no-sqlite3' closes #5739
Radhika Chippada [Mon, 27 Apr 2015 22:48:09 +0000 (18:48 -0400)]
closes #5826
closes #5827
Merge branch '5826-unreadable-inputs-error'
Radhika Chippada [Mon, 27 Apr 2015 22:30:22 +0000 (18:30 -0400)]
5827: check readable only attrvalue is a string
Brett Smith [Mon, 27 Apr 2015 21:52:35 +0000 (17:52 -0400)]
Merge branch '5490-crunch-tighten-job-reuse-wip'
Closes #3341, #5388, #5490, #5688, #5784.
Brett Smith [Tue, 21 Apr 2015 20:48:42 +0000 (16:48 -0400)]
5490: Require exact matches in API server's default job reuse filters.
The previous default filters would reuse jobs that used any Docker
image with the matching name, and/or Arvados SDK version since the
named commit. User feedback indicates this is surprising, and they
would prefer to have behavior more like the handling around
script_version: only reuse jobs that have the latest version of a
symbolic name, or the exact specified hash.
Brett Smith [Tue, 21 Apr 2015 15:35:01 +0000 (11:35 -0400)]
5490: Test API server finds Docker images with hash names.
This is in the same spirit as the previous, analogous commit for git
branches.
Brett Smith [Tue, 21 Apr 2015 15:23:19 +0000 (11:23 -0400)]
5490: Test API server handling of git hash-like branch names.
If you have a branch that looks like a commit hash, different git subcommands do different things. After extended discussion on IRC, we've decided we'd like the rules to be:
* If a 40-character hex string references a commit, resolve it to that
commit.
* In other cases of ambiguity, prefer branch names over short commit
hashes.
Fortunately, this corresponds to the behavior of `git rev-list` and
our existing implementation. This commit codifies our desired
behavior with tests.
Brett Smith [Thu, 16 Apr 2015 21:33:22 +0000 (17:33 -0400)]
5490: Clean up API server previous job fixtures.
* Every fixture that specified an arvados_sdk_version constraint
should also specify a docker_image constraint, to better match
reality.
* Use the same Docker image name in link and previous job fixture
constraints.
Brett Smith [Thu, 16 Apr 2015 21:32:54 +0000 (17:32 -0400)]
5490: Refactor API server job_reuse_controller_test.
Teach the convenience methods to start from any fixture job as a basis
for submitting new ones and comparing.
Radhika Chippada [Mon, 27 Apr 2015 20:58:10 +0000 (16:58 -0400)]
5826: check readable only when it is a data collection pdf or uuid.
Brett Smith [Mon, 27 Apr 2015 15:23:50 +0000 (11:23 -0400)]
Merge branch '5554-delete-job-log-rows-wip'
Closes #5554, #5798.
Brett Smith [Fri, 24 Apr 2015 21:13:31 +0000 (17:13 -0400)]
5554: Workbench links finished job logs from pipeline instance log tab.
This is an affordance to help users find logs after they're removed
from the API server's logs table. The display is not very great.
We're punting improvements until Workbench generally has better
capabilities to display large logs.
The layout change necessitated updates to the anonymous access tests.
While I was in there, I strengthened the assertions by putting
assertions that check a particular element has loaded before asserting
the nonexistence of other elements. This revealed the JavaScript
issue mentioned in the new comment: the old version of the test was
doing a single `assert_no_text` after clicking a job's log tab, which
only confirmed that we navigated away. We already test that the log
tab exists and is not disabled in this case, so I consider that
sufficient for now.
Brett Smith [Thu, 23 Apr 2015 20:52:07 +0000 (16:52 -0400)]
5554: Clean up erroneous fixture pipeline state.
Brett Smith [Thu, 23 Apr 2015 16:40:14 +0000 (12:40 -0400)]
5554: Add Rake task to delete old job log records.
Radhika Chippada [Mon, 27 Apr 2015 14:23:03 +0000 (10:23 -0400)]
closes #5780
Merge branch '5780-sharing-popup-message'
Radhika Chippada [Mon, 27 Apr 2015 14:22:37 +0000 (10:22 -0400)]
Merge branch 'master' into 5780-sharing-popup-message
Tom Clegg [Wed, 15 Apr 2015 18:26:33 +0000 (14:26 -0400)]
5739: Remove unnecessary sqlite3 dependency.
Brett Smith [Thu, 23 Apr 2015 21:52:27 +0000 (17:52 -0400)]
run_test_server doesn't assume ARVADOS_API_TOKEN is set.
This makes it slightly more feasible to run this script (and by
extension tests for individual components like Workbench) outside
run-tests.sh. No issue #.
Tom Clegg [Thu, 23 Apr 2015 21:28:56 +0000 (17:28 -0400)]
Fix typo. No issue #
Radhika Chippada [Thu, 23 Apr 2015 17:06:03 +0000 (13:06 -0400)]
closes #5796
Merge branch '5796-collection-search-index'
Radhika Chippada [Thu, 23 Apr 2015 17:01:15 +0000 (13:01 -0400)]
5796: add down migration
Radhika Chippada [Thu, 23 Apr 2015 16:10:05 +0000 (12:10 -0400)]
5796: omit file_names column from collections search index.
Tom Clegg [Thu, 23 Apr 2015 14:00:54 +0000 (10:00 -0400)]
5416: Test with HEAD in current tree, not master: jenkins index has no
Improve logging in test suite.
refs #5416
Radhika Chippada [Thu, 23 Apr 2015 01:21:29 +0000 (21:21 -0400)]
5780: Display message in chooser popup if one is provided. Use this to show a message in sharing popup
explaining to user that only those users or groups that the user is allowed to access are displayed.
Tom Clegg [Wed, 22 Apr 2015 18:28:10 +0000 (14:28 -0400)]
Merge branch '5416-browse-repo-tree' refs #5416
Radhika Chippada [Wed, 22 Apr 2015 17:31:06 +0000 (13:31 -0400)]
closes #5663
Merge branch '5663-doc-rake-secret'
Radhika Chippada [Wed, 22 Apr 2015 17:30:42 +0000 (13:30 -0400)]
Merge branch 'master' into 5663-doc-rake-secret
Radhika Chippada [Wed, 22 Apr 2015 17:27:16 +0000 (13:27 -0400)]
closes #5783
5783: add type="button" for Cancel button in add ssh key popup.
Radhika Chippada [Wed, 22 Apr 2015 14:36:00 +0000 (10:36 -0400)]
Merge branch 'master' into 5663-doc-rake-secret
Radhika Chippada [Wed, 22 Apr 2015 12:16:43 +0000 (08:16 -0400)]
closes #5675
Merge branch '5675-project-subprojects-in-anonymous-view'
Radhika Chippada [Tue, 21 Apr 2015 17:48:40 +0000 (13:48 -0400)]
Merge branch 'master' into 5663-doc-rake-secret
Radhika Chippada [Tue, 21 Apr 2015 17:47:19 +0000 (13:47 -0400)]
Merge branch 'master' into 5675-project-subprojects-in-anonymous-view
Radhika Chippada [Tue, 21 Apr 2015 17:23:45 +0000 (13:23 -0400)]
refs #5179 : gem version in workbench
Radhika Chippada [Tue, 21 Apr 2015 17:18:38 +0000 (13:18 -0400)]
closes #5179
Merge branch '5179-dirs-in-filenames'
Radhika Chippada [Tue, 21 Apr 2015 17:16:52 +0000 (13:16 -0400)]
5179: one more test with multilevel manifest text
Radhika Chippada [Tue, 21 Apr 2015 16:56:15 +0000 (12:56 -0400)]
Merge branch 'master' into 5179-dirs-in-filenames
Tom Clegg [Mon, 20 Apr 2015 20:43:40 +0000 (16:43 -0400)]
5416: Fix protected method that should have been public.
Tom Clegg [Thu, 16 Apr 2015 19:52:20 +0000 (15:52 -0400)]
5416: Use foo:bar@host:port/ instead of credential helper.
Tom Clegg [Thu, 16 Apr 2015 20:44:38 +0000 (16:44 -0400)]
5416: Remove second trailing slash in breadcrumbs link.
Tom Clegg [Thu, 16 Apr 2015 20:31:22 +0000 (16:31 -0400)]
5416: Disable repository browsing (and skip tests) if git version is suspected unreliable.
Tom Clegg [Tue, 14 Apr 2015 20:56:04 +0000 (16:56 -0400)]
5416: Add read-only clone_urls attribute to Repository resources, deprecate push_url and fetch_url, tidy up config settings.
Tom Clegg [Wed, 8 Apr 2015 15:35:56 +0000 (11:35 -0400)]
5416: Do not override git urls for remote hosted repos.
Tom Clegg [Wed, 8 Apr 2015 14:22:05 +0000 (10:22 -0400)]
5416: Run arv-git-httpd and nginx ssl proxy in test suite.
Tom Clegg [Wed, 1 Apr 2015 22:34:38 +0000 (18:34 -0400)]
5416: Browse git repository contents in workbench.
Tom Clegg [Tue, 31 Mar 2015 14:05:47 +0000 (10:05 -0400)]
5416: Fix comment.
Tom Clegg [Mon, 20 Apr 2015 20:29:55 +0000 (16:29 -0400)]
Revert errant change in
f8e6cb3. refs #3126
Ward Vandewege [Mon, 20 Apr 2015 19:23:40 +0000 (15:23 -0400)]
Docker: fix the build of the sso docker container.
No issue #
Tom Clegg [Mon, 20 Apr 2015 18:40:57 +0000 (14:40 -0400)]
Merge branch '3126-remote-git-url' closes #3126
Tom Clegg [Mon, 20 Apr 2015 18:15:36 +0000 (14:15 -0400)]
3126: Skip some unnecessary db resets.
Tom Clegg [Mon, 20 Apr 2015 18:13:35 +0000 (14:13 -0400)]
3126: Use localhost to simulate API failures. reset_application_config in teardown
nstead of setup. Remove superfluous cleanup.
Tom Clegg [Mon, 20 Apr 2015 17:37:15 +0000 (13:37 -0400)]
3126: Handle "no local repository" case better.
Tom Clegg [Wed, 15 Apr 2015 20:50:14 +0000 (16:50 -0400)]
3126: Delete git cache dir in test teardown. Remove no-op test.
Tom Clegg [Wed, 15 Apr 2015 19:45:59 +0000 (15:45 -0400)]
3126: Fix test. Avoid excess "git init" by probing with "git branch" first.
Tom Clegg [Tue, 14 Apr 2015 02:54:11 +0000 (22:54 -0400)]
3126: Always act as current_user in Commit.find_commit_range.
Tom Clegg [Mon, 13 Apr 2015 16:43:34 +0000 (12:43 -0400)]
3126: Do not try to do anything with job.repository in crunch-dispatch if the commit is already in internal.git.
Tom Clegg [Fri, 10 Apr 2015 07:40:55 +0000 (03:40 -0400)]
3126: Update API docs.
Tom Clegg [Thu, 9 Apr 2015 22:09:40 +0000 (18:09 -0400)]
3126: Accept remote http/https/git url as repository attr in jobs.create/save.
Radhika Chippada [Mon, 20 Apr 2015 16:55:00 +0000 (12:55 -0400)]
closes #5573
Merge branch '5573-user-activity-page-performance'
Radhika Chippada [Mon, 20 Apr 2015 16:44:52 +0000 (12:44 -0400)]
Merge branch 'master' into 5573-user-activity-page-performance
Radhika Chippada [Mon, 20 Apr 2015 16:36:10 +0000 (12:36 -0400)]
closes #5753
Merge branch '5753-job-name-column-in-project-page'
Radhika Chippada [Mon, 20 Apr 2015 16:30:56 +0000 (12:30 -0400)]
Merge branch 'master' into 5753-job-name-column-in-project-page
Radhika Chippada [Mon, 20 Apr 2015 16:29:34 +0000 (12:29 -0400)]
closes #5620
Merge branch '5620-collection-selections'
Radhika Chippada [Mon, 20 Apr 2015 15:42:04 +0000 (11:42 -0400)]
5620: added comment to input trigger event
Radhika Chippada [Sun, 19 Apr 2015 03:12:51 +0000 (23:12 -0400)]
5663: update documentation to use "puts rand" in place of "rake secret"
Radhika Chippada [Sun, 19 Apr 2015 02:25:55 +0000 (22:25 -0400)]
5179: update arvados ruby sdk gem version in workbench.
Radhika Chippada [Sun, 19 Apr 2015 02:22:14 +0000 (22:22 -0400)]
5179: update files method to move dir parts to streamname.
Radhika Chippada [Sat, 18 Apr 2015 02:41:25 +0000 (22:41 -0400)]
5675: include Subprojects tab in project#show for anonymous users.
projects / arvados.git / log