5554: Workbench links finished job logs from pipeline instance log tab.
authorBrett Smith <brett@curoverse.com>
Fri, 24 Apr 2015 21:13:31 +0000 (17:13 -0400)
committerBrett Smith <brett@curoverse.com>
Mon, 27 Apr 2015 15:23:21 +0000 (11:23 -0400)
commit45b556d1a204f694b69ca26d115cd6786ca585f3
tree421dde417260f26cfe87c19fc9ec83507f91bc34
parent123ef960b82540b98c8b68c47ff89bf85da3899c
5554: Workbench links finished job logs from pipeline instance log tab.

This is an affordance to help users find logs after they're removed
from the API server's logs table.  The display is not very great.
We're punting improvements until Workbench generally has better
capabilities to display large logs.

The layout change necessitated updates to the anonymous access tests.
While I was in there, I strengthened the assertions by putting
assertions that check a particular element has loaded before asserting
the nonexistence of other elements.  This revealed the JavaScript
issue mentioned in the new comment: the old version of the test was
doing a single `assert_no_text` after clicking a job's log tab, which
only confirmed that we navigated away.  We already test that the log
tab exists and is not disabled in this case, so I consider that
sufficient for now.
apps/workbench/app/controllers/jobs_controller.rb
apps/workbench/app/helpers/jobs_helper.rb [deleted file]
apps/workbench/app/models/pipeline_instance.rb
apps/workbench/app/views/application/_content.html.erb
apps/workbench/app/views/pipeline_instances/_show_log.html.erb
apps/workbench/test/integration/anonymous_access_test.rb
apps/workbench/test/integration/pipeline_instances_test.rb
apps/workbench/test/unit/pipeline_instance_test.rb
services/api/config/application.default.yml
services/api/test/fixtures/pipeline_instances.yml