Peter Amstutz [Fri, 22 Aug 2014 17:56:59 +0000 (13:56 -0400)]
Display first file in collection if name field is nil or empty. refs #3504
Peter Amstutz [Fri, 22 Aug 2014 13:58:19 +0000 (09:58 -0400)]
Merge branch '3504-clients-compatible-with-3036' refs #3504
Peter Amstutz [Fri, 22 Aug 2014 12:42:45 +0000 (08:42 -0400)]
3504: Don't create stand-in "name" links for post #3036 apiserver
Peter Amstutz [Thu, 21 Aug 2014 21:10:45 +0000 (17:10 -0400)]
3504: Support copy and moving collections on new apiserver
Peter Amstutz [Fri, 22 Aug 2014 12:35:01 +0000 (08:35 -0400)]
3504: Back out tags on project rows. Revisit in a later story.
Peter Amstutz [Thu, 21 Aug 2014 19:08:38 +0000 (15:08 -0400)]
3504: Remove link to links index page on tags. Add comment to
CollectionsController#choose. Adjust column width in collections file table.
Peter Amstutz [Thu, 21 Aug 2014 18:49:28 +0000 (14:49 -0400)]
3504: Don't set owner_uuid redundantly.
Peter Amstutz [Thu, 21 Aug 2014 18:44:30 +0000 (14:44 -0400)]
3036: Use preload_objects to fetch owner_uuids in the controller instead of in the view.
Ward Vandewege [Thu, 21 Aug 2014 17:23:08 +0000 (13:23 -0400)]
Be smarter about cleanup in crunch-job after a job finishes. This should
resolve the problem of the many leftover stale mount points.
no issue #
Peter Amstutz [Thu, 21 Aug 2014 16:13:11 +0000 (12:13 -0400)]
3504: Set owner_uuid when creating collection (will set owner_uuid of name link
on old apiserver, and set owner of collection object directly on new
apiserver.)
Peter Amstutz [Thu, 21 Aug 2014 15:39:09 +0000 (11:39 -0400)]
3504: Set the capybara driver explicitly so tests pass again.
Peter Amstutz [Thu, 21 Aug 2014 15:04:17 +0000 (11:04 -0400)]
Merge remote-tracking branch 'origin/master' into 3504-clients-compatible-with-3036
Peter Amstutz [Thu, 21 Aug 2014 15:03:58 +0000 (11:03 -0400)]
3504: Fixed preload_links_for_objects to use @objects.to_a. Fix collections
page to restore link names. Remove obsolete tests for "persist" button. Tweak
pipeline instance tests.
Peter Amstutz [Wed, 20 Aug 2014 21:10:37 +0000 (17:10 -0400)]
3504: Use preload_links_for_objects in projects_controller. Use
self[:portable_data_hash] in collection.rb to avoid recursive definition of
.uuid and .portable_data_hash. Revert change to show_attributes. Removed
column from collections show_recent. Reverted python tests to correspond to
behavior of pre-3036 API server so test pass.
Brett Smith [Wed, 20 Aug 2014 20:42:11 +0000 (16:42 -0400)]
Fix run_test_server Keep blob filename handling.
No issue #.
Peter Amstutz [Wed, 20 Aug 2014 20:33:27 +0000 (16:33 -0400)]
3504: CollectionReader accepts arvados object collection uuids. 'arv-put' sets
owner_uuid when collection is created. Fixed indentation.
Peter Amstutz [Wed, 20 Aug 2014 02:10:10 +0000 (22:10 -0400)]
3036: Fix arv-put to write name/owner of collections object directly when
'name' field is present on the returned object. Python SDK tests pass.
Brett Smith [Wed, 20 Aug 2014 20:08:38 +0000 (16:08 -0400)]
2800: run_test_server only uses tests/tmp for real Python tests.
tests/tmp is not available for Go tests.
This fixes a bug introduced in
da01d7e1.
No issue #.
Tom Clegg [Wed, 20 Aug 2014 20:05:11 +0000 (16:05 -0400)]
Update "standard objects" page to reflect change from keep_disks to
keep_services, and add some sanity checks. No issue #
Tom Clegg [Wed, 20 Aug 2014 19:51:41 +0000 (15:51 -0400)]
Add libpcre3-dev dependency. Sort package names in apt-get install command.
No issue #
Brett Smith [Wed, 20 Aug 2014 19:12:20 +0000 (15:12 -0400)]
2800: Delay API client creation in Python CollectionReader.
This more closely matches prior behavior, and is necessary to make the
Keep tests pass. See included comments for detailed rationale.
Refs #2800.
Tom Clegg [Wed, 20 Aug 2014 19:04:33 +0000 (15:04 -0400)]
Treat success=true exitcode!=0 as success when collating output,
just like we did when we decided the task completed. No issue #
Brett Smith [Wed, 20 Aug 2014 18:18:24 +0000 (14:18 -0400)]
Merge branch '2800-pysdk-no-global-keep-client-wip'
Closes #2800, #3639.
Brett Smith [Wed, 20 Aug 2014 13:24:22 +0000 (09:24 -0400)]
2800: Use local KeepClients in Python SDK tests.
This improves test isolation, and demonstrates the preferred way to
use the API.
Brett Smith [Wed, 20 Aug 2014 13:46:49 +0000 (09:46 -0400)]
2800: Introduce TestCaseWithServers to Python SDK.
This is a subclass of unittest.TestCase. It looks for specific class
variables to launch supporting Arvados servers for subclass test
cases, taking care to adjust the environment and local Arvados
configuration to match. Put another away, this refactors a number of
similar setUpClass/tearDownClass methods throughout the SDK tests.
Brett Smith [Tue, 19 Aug 2014 20:41:33 +0000 (16:41 -0400)]
2800: Make run_test_server put Keep tempfiles in tests/tmp/.
Brett Smith [Tue, 19 Aug 2014 20:37:42 +0000 (16:37 -0400)]
2800: Use dedicated logger in Python SDK api module.
Brett Smith [Wed, 20 Aug 2014 13:46:33 +0000 (09:46 -0400)]
2800: Migrate from Keep to KeepClient in the Python SDK.
Brett Smith [Tue, 19 Aug 2014 14:17:57 +0000 (10:17 -0400)]
2800: Remove global state from KeepClient.
This commit makes it possible to build and use a KeepClient that isn't
influenced by changes in outside state. Changing the KeepClient based
on global state has been pushed up to the simple Keep class.
This commit changes the tests as little as possible to demonstrate
backward compatibility. Refactoring the tests to build KeepClients
directly will come in the future.
Brett Smith [Tue, 19 Aug 2014 14:01:36 +0000 (10:01 -0400)]
2800: Improve spec conformance of Python SDK KeepLocator.
* Require size to immediately follow digest.
* Accept all valid hints.
Brett Smith [Tue, 19 Aug 2014 13:59:53 +0000 (09:59 -0400)]
2800: Introduce config.flag_is_true() to Python SDK.
Brett Smith [Wed, 20 Aug 2014 15:18:54 +0000 (11:18 -0400)]
Merge branch '3499-home-project-docs-wip'
Closes #3516. Refs #3499.
Brett Smith [Fri, 15 Aug 2014 20:08:52 +0000 (16:08 -0400)]
3499: Update Keep tutorial for recent UI changes.
Brett Smith [Fri, 15 Aug 2014 19:38:04 +0000 (15:38 -0400)]
3499: Update pipeline tutorial for recent UI changes.
Brett Smith [Fri, 15 Aug 2014 15:44:46 +0000 (11:44 -0400)]
3499: Improve style consistency throughout docs.
* Capitalize Dashboard.
* Article use: "access Workbench," "access the Dashboard."
* Bold references to Workbench UI elements.
* Make example Arvados environment variables more realistic.
Tom Clegg [Wed, 20 Aug 2014 14:10:33 +0000 (10:10 -0400)]
Merge branch '3610-pipeline-log-refresh' closes #3610
Tom Clegg [Wed, 20 Aug 2014 00:57:46 +0000 (20:57 -0400)]
3610: Move live log display into its own tab, avoid clobbering with tab reload.
* PipelineInstances#show gets a Log tab dedicated to the live log
window, rather than hiding it below the components table.
* Jobs#show uses its Log tab to show a live log window (instead of a
teaser) when the log is not yet finished/written to disk.
* In both cases, the live log window's tab pane intercepts and ignores
the arv:tab:reload event. (Previously, in addition to appending log
entries to the live window, websocket events would trigger a
"refresh all tabs" event, which would blow away the whole log viewer
anyway.)
* Behave sensibly when multiple lines of stderr arrive in a single
websocket update event.
* Stop displaying "update {pipeline-uuid}" messages that have no
additional content.
* Stop scrolling to bottom every time an ajax:complete fires
somewhere. (Previously, seeing anything above the last page of logs
was somewhere between annoying and impossible.)
* Make the log window taller.
Peter Amstutz [Tue, 19 Aug 2014 15:05:33 +0000 (11:05 -0400)]
Merge branch 'master' into 3504-clients-compatible-with-3036
Peter Amstutz [Tue, 19 Aug 2014 13:40:07 +0000 (09:40 -0400)]
3504: Fix collection chooser. Fix generic link render to use uuid if nothing
else is available. Fix tags for objects other than collections.
Peter Amstutz [Tue, 19 Aug 2014 03:13:19 +0000 (23:13 -0400)]
3504: Fix collection page rendering to work with collections as regular uuids.
Render tags onn project page. Improve helper function for rendering links to
Arvados objects.
Tom Clegg [Mon, 18 Aug 2014 22:58:06 +0000 (18:58 -0400)]
Merge branch '3114-copy-to-project' closes #3114
Tom Clegg [Mon, 18 Aug 2014 22:19:29 +0000 (18:19 -0400)]
3114: Follow return_to param, if given, when redirecting users#show to projects#show.
Don't redirect non-html requests.
Tom Clegg [Mon, 18 Aug 2014 22:18:55 +0000 (18:18 -0400)]
3114: Update test case: searching for own uuid now shows home project.
Tom Clegg [Mon, 18 Aug 2014 22:02:47 +0000 (18:02 -0400)]
3114: Merge branch 'master' into 3114-copy-to-project
Brett Smith [Mon, 18 Aug 2014 18:38:57 +0000 (14:38 -0400)]
3593: Add explanatory comment about Workbench's user cache.
Refs #3593.
Tom Clegg [Mon, 18 Aug 2014 20:51:13 +0000 (16:51 -0400)]
3114: Fix href in json response for generic #create action too. See
7485476.
Tom Clegg [Mon, 18 Aug 2014 18:26:59 +0000 (14:26 -0400)]
Merge branch '2800-pgs' refs #2800
Tom Clegg [Mon, 18 Aug 2014 18:25:47 +0000 (14:25 -0400)]
2800: Sort import statements.
Tom Clegg [Mon, 18 Aug 2014 18:17:49 +0000 (14:17 -0400)]
Merge branch '3604-theme-and-new-user-process' closes #3604
Tom Clegg [Mon, 18 Aug 2014 18:02:42 +0000 (14:02 -0400)]
2800: Restore deleted comment which is still relevant.
Tom Clegg [Mon, 18 Aug 2014 18:01:54 +0000 (14:01 -0400)]
2800: Remove unnecessary sha1. Just use the tuple as an array key.
Tom Clegg [Mon, 18 Aug 2014 17:37:21 +0000 (13:37 -0400)]
3604: Remove useless slice.
Tom Clegg [Mon, 18 Aug 2014 17:35:59 +0000 (13:35 -0400)]
3604: Remove useless loop.
Tom Clegg [Mon, 18 Aug 2014 17:23:03 +0000 (13:23 -0400)]
Do not try to predict uuid of new collection. refs #3261 refs #3504
Tom Clegg [Mon, 18 Aug 2014 17:15:13 +0000 (13:15 -0400)]
Do not throw away permission hints when writing data. refs #3261
Tom Clegg [Mon, 18 Aug 2014 16:52:53 +0000 (12:52 -0400)]
3604: Update comment to reflect lack of built-in default.
Tom Clegg [Mon, 18 Aug 2014 16:51:27 +0000 (12:51 -0400)]
3604: Remove unused style.
Tom Clegg [Mon, 18 Aug 2014 15:39:49 +0000 (11:39 -0400)]
Display progress by default when writing to regular files and stderr isatty. No issue #
Peter Amstutz [Mon, 18 Aug 2014 13:39:22 +0000 (09:39 -0400)]
Merge branch '3441-python-keep-log-level' refs #3441
Tom Clegg [Sun, 17 Aug 2014 21:14:35 +0000 (17:14 -0400)]
3604: Fix user deactivation test.
Tom Clegg [Sun, 17 Aug 2014 20:40:46 +0000 (16:40 -0400)]
3604: Fix tests, and restore ability to view user agreement before completing profile.
Tom Clegg [Sun, 17 Aug 2014 19:26:53 +0000 (15:26 -0400)]
3604: Fix up profile and redirect handling.
Tom Clegg [Sun, 17 Aug 2014 18:34:26 +0000 (14:34 -0400)]
3604: Fix user_agreements behavior, update tests to expect redirects.
Tom Clegg [Sun, 17 Aug 2014 18:10:20 +0000 (14:10 -0400)]
3604: Add test for redirect to welcome page
Tom Clegg [Sun, 17 Aug 2014 18:10:08 +0000 (14:10 -0400)]
3604: Verify permission cache behavior in unsetup test
Tom Clegg [Sun, 17 Aug 2014 18:05:11 +0000 (14:05 -0400)]
3604: Remove test for persistent/cache switch on wrong page.
Tom Clegg [Sun, 17 Aug 2014 18:02:19 +0000 (14:02 -0400)]
3604: Do not check for notifications if user is not even activated.
Tom Clegg [Sun, 17 Aug 2014 17:59:13 +0000 (13:59 -0400)]
3604: Fix stale permission cache by using destroy instead of delete.
Tom Clegg [Sun, 17 Aug 2014 17:50:05 +0000 (13:50 -0400)]
3604: Fix theme support for welcome page
Peter Amstutz [Sun, 17 Aug 2014 01:22:56 +0000 (21:22 -0400)]
3441: Change logging level of nonfatal Keep errors to "debug".
Tom Clegg [Sat, 16 Aug 2014 22:55:20 +0000 (18:55 -0400)]
2800: Clean up exceptions, variable names, handling of discoveryServiceUrl vs host args.
Tom Clegg [Sat, 16 Aug 2014 22:23:25 +0000 (18:23 -0400)]
2800: Merge branch 'master' into 2800-pgs
Tom Clegg [Sat, 16 Aug 2014 06:06:20 +0000 (02:06 -0400)]
Merge branch '2800-python-global-state' into 2800-pgs
Conflicts:
sdk/python/arvados/api.py
Ward Vandewege [Fri, 15 Aug 2014 20:56:34 +0000 (16:56 -0400)]
docker: be a bit smarter in the make clean target, so that we also
accomodate diretories underneath the generated directory.
refs #3551
Brett Smith [Fri, 15 Aug 2014 20:45:21 +0000 (16:45 -0400)]
Merge branch '3593-workbench-exception-rendering'
Closes #3593, #3595.
Brett Smith [Thu, 14 Aug 2014 17:59:18 +0000 (13:59 -0400)]
3593: Another round of hardening Workbench's render_exception.
render_exception was counting on session[:user] to help render the
error page. We recently excised that, which is turning exceptions
into 500s. This commit restores the session user object, but uses it
only for error rendering, in keeping with the spirit of the previous
revert. This commit also defends against more possible failure cases
in render_exception, and adds a basic test for it.
Tom Clegg [Fri, 15 Aug 2014 14:06:32 +0000 (10:06 -0400)]
gitignore sdk/cli/vendor. refs #3551
Tom Clegg [Fri, 15 Aug 2014 14:05:01 +0000 (10:05 -0400)]
Restore trailing newline in manifest format sanity check.
Amends
3cc80b447efcaf416ea4d6857d6d40583e462ff8
No issue #
Tom Clegg [Thu, 14 Aug 2014 19:30:28 +0000 (15:30 -0400)]
Merge branch '3551-go-layout' closes #3551
Tom Clegg [Thu, 14 Aug 2014 19:23:43 +0000 (15:23 -0400)]
3551: Merge branch 'master' into 3551-go-layout
Peter Amstutz [Thu, 14 Aug 2014 18:20:07 +0000 (14:20 -0400)]
Merge branch '3505-virtual-work-dir' refs #3505
Peter Amstutz [Thu, 14 Aug 2014 17:23:49 +0000 (13:23 -0400)]
Merge branch 'master' into 3505-virtual-work-dir
Peter Amstutz [Thu, 14 Aug 2014 17:17:06 +0000 (13:17 -0400)]
3505: tinker with logging
Peter Amstutz [Thu, 14 Aug 2014 15:41:45 +0000 (11:41 -0400)]
3505: Fix typo in run-command
Peter Amstutz [Thu, 14 Aug 2014 15:35:06 +0000 (11:35 -0400)]
3505: Move helper scripts into crunchutil module. In run-command, added
task.stdin redirection, and renamed save.stdout to task.stdout for consistency.
Stylistic change "x == None" and "x != None" to "x is None" and "x is not
None".
Tom Clegg [Thu, 14 Aug 2014 14:05:41 +0000 (10:05 -0400)]
3551: Revert "3551: When testing keep clients, write keepstore/keepproxy logs to"
This reverts commit
63871346153fea194b169eec38f6efae3061ebf6.
The default Popen behavior is to use stderr, and that's fine. This was
a mistaken attempt to reveal missing logs, the real solution for which
is
5fcff4c13ae17527ee1efd6fa01d08133212085b.
Tom Clegg [Thu, 14 Aug 2014 13:49:34 +0000 (09:49 -0400)]
3551: Remove superfluous chmod(). Umask is 022 here.
Phil Hodgson [Thu, 14 Aug 2014 11:51:35 +0000 (07:51 -0400)]
3114: bug fix: when rendering JSON response to a generic #show action, correctly set an 'href' attribute in the response to be the #show url for the object
Tom Clegg [Wed, 13 Aug 2014 22:15:46 +0000 (18:15 -0400)]
Increase Capybara timeout to accommodate slow test server. No issue #
Tom Clegg [Wed, 13 Aug 2014 21:09:08 +0000 (17:09 -0400)]
Report unexpected slurm states as "down". No issue #
Tom Clegg [Wed, 13 Aug 2014 20:47:50 +0000 (16:47 -0400)]
3551: Use FileUtils.rm_r so deleting stale generated/{dir} works.
Brett Smith [Wed, 13 Aug 2014 20:39:40 +0000 (16:39 -0400)]
Merge branch '3421-wide-project-tables-wip'
Closes #3421, #3584.
Brett Smith [Wed, 13 Aug 2014 16:07:06 +0000 (12:07 -0400)]
3421: Make Workbench project contents tables variable width.
This change will ensure that users can see the "edit name" buttons, by
letting a table row grow as needed to accommodate long names. It puts
each row's buttons in dedicated cells to try to stay true to the
original layout as much as possible.
Brett Smith [Wed, 13 Aug 2014 20:36:42 +0000 (16:36 -0400)]
Merge branch '3405-pipeline-error-logging-wip'
Closes #3405, #3582.
Brett Smith [Tue, 12 Aug 2014 18:48:32 +0000 (14:48 -0400)]
3405: Mark pipeline instances failed when they're aborted.
Brett Smith [Tue, 12 Aug 2014 18:41:55 +0000 (14:41 -0400)]
3405: Log errors about launching pipeline instances.
There's a couple of components to this:
* Do some basic checks on the organization of the pipeline instance
before we start running it, and abort if any of them fail.
* If the pipeline runner aborts for any reason, send that as pipeline
instance stderr to the API server, so other tools like Workbench can
render it for users' benefit.
Tom Clegg [Wed, 13 Aug 2014 20:23:43 +0000 (16:23 -0400)]
3551: Remove chmod 755, no longer necessary now that config.rb does that.
Tom Clegg [Wed, 13 Aug 2014 19:36:30 +0000 (15:36 -0400)]
3551: Set mode of generated files more aggressively (overrule umask).
Tom Clegg [Wed, 13 Aug 2014 19:22:00 +0000 (15:22 -0400)]
3551: Handle missing GOPATH and multiple-entry GOPATH sensibly.
Tom Clegg [Wed, 13 Aug 2014 19:13:43 +0000 (15:13 -0400)]
3551: Merge branch 'master' into 3551-go-layout