arvados.git
6 months ago21207: Set up MockedPut._state with a deepcopy
Brett Smith [Fri, 3 May 2024 13:55:15 +0000 (09:55 -0400)]
21207: Set up MockedPut._state with a deepcopy

Otherwise its internal state could get into EMPTY_STATE and contaminate
other tests.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

6 months agoMerge branch '15397-remove-obsolete-apis'
Tom Clegg [Fri, 3 May 2024 17:33:28 +0000 (13:33 -0400)]
Merge branch '15397-remove-obsolete-apis'

refs #15397

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago15397: Merge branch 'main'
Tom Clegg [Fri, 3 May 2024 14:53:32 +0000 (10:53 -0400)]
15397: Merge branch 'main'

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months agoMerge branch '12430-output-glob'
Tom Clegg [Thu, 2 May 2024 20:47:51 +0000 (16:47 -0400)]
Merge branch '12430-output-glob'

closes #12430

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months agoMerge branch '21356-clean-imports'
Brett Smith [Thu, 2 May 2024 15:47:42 +0000 (11:47 -0400)]
Merge branch '21356-clean-imports'

Closes #21356.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

6 months agoMerge branch '21717-keepstore-cors'
Tom Clegg [Thu, 2 May 2024 15:27:33 +0000 (11:27 -0400)]
Merge branch '21717-keepstore-cors'

fixes #21717

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months agoMerge branch '21642-io-panel-collection-tab-bug' into main. Closes #21642
Stephen Smith [Wed, 1 May 2024 15:37:07 +0000 (11:37 -0400)]
Merge branch '21642-io-panel-collection-tab-bug' into main. Closes #21642

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

6 months ago21700: Remove package-test-dockerfiles/Makefile instructions
Brett Smith [Wed, 1 May 2024 14:38:17 +0000 (10:38 -0400)]
21700: Remove package-test-dockerfiles/Makefile instructions

This Makefile was removed in 792a7d47b560d4aa80e2cb8a933a11e02e3109b3
because it only supported RVM, so there's no more need to update it.
Refs #21700.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

6 months ago15397: Remove checks for nodes and repositories endpoints.
Tom Clegg [Tue, 30 Apr 2024 18:43:13 +0000 (14:43 -0400)]
15397: Remove checks for nodes and repositories endpoints.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago15397: Fix python tests relying on removed APIs/fixtures.
Tom Clegg [Thu, 25 Apr 2024 19:24:02 +0000 (15:24 -0400)]
15397: Fix python tests relying on removed APIs/fixtures.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago15397: Move deprecated API links to old version of doc site.
Tom Clegg [Thu, 25 Apr 2024 18:39:55 +0000 (14:39 -0400)]
15397: Move deprecated API links to old version of doc site.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago15397: Remove code, configs, and docs for hosted git repo feature.
Tom Clegg [Mon, 22 Apr 2024 14:38:33 +0000 (10:38 -0400)]
15397: Remove code, configs, and docs for hosted git repo feature.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago15397: Remove obsolete APIs.
Tom Clegg [Wed, 17 Apr 2024 13:58:09 +0000 (09:58 -0400)]
15397: Remove obsolete APIs.

jobs, job_tasks, pipeline_instances, pipeline_templates, nodes,
repositories, humans, specimens, traits.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago15397: Silence nginx log noise like "closed keepalive connection".
Tom Clegg [Mon, 22 Apr 2024 18:20:14 +0000 (14:20 -0400)]
15397: Silence nginx log noise like "closed keepalive connection".

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago21717: Fix incorrect header. 21717-keepstore-cors
Tom Clegg [Tue, 30 Apr 2024 18:02:23 +0000 (14:02 -0400)]
21717: Fix incorrect header.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago12430: Add more glob unit test cases. 12430-output-glob
Tom Clegg [Tue, 30 Apr 2024 17:32:02 +0000 (13:32 -0400)]
12430: Add more glob unit test cases.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago12430: Add comments about the two stages of glob-filtering.
Tom Clegg [Tue, 30 Apr 2024 15:37:59 +0000 (11:37 -0400)]
12430: Add comments about the two stages of glob-filtering.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago12430: Avoid loading collections excluded by globs.
Tom Clegg [Tue, 30 Apr 2024 15:18:31 +0000 (11:18 -0400)]
12430: Avoid loading collections excluded by globs.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

6 months ago21356: Remove all Python 2/3 compatibility imports 21356-clean-imports
Brett Smith [Mon, 29 Apr 2024 16:11:05 +0000 (12:11 -0400)]
21356: Remove all Python 2/3 compatibility imports

This includes noop imports from __future__ and builtins, as well as
imports from the future and six compatibility libraries.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

6 months ago21642: Fix unit tests to account for hidden instead of absent tab content 21642-io-panel-collection-tab-bug
Stephen Smith [Mon, 29 Apr 2024 16:37:47 +0000 (12:37 -0400)]
21642: Fix unit tests to account for hidden instead of absent tab content

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

6 months ago21642: Change conditionaltabs to render tabs as hidden to avoid re-renders
Stephen Smith [Mon, 29 Apr 2024 13:35:02 +0000 (09:35 -0400)]
21642: Change conditionaltabs to render tabs as hidden to avoid re-renders

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

6 months ago21642: Update caniuse
Stephen Smith [Mon, 29 Apr 2024 13:32:27 +0000 (09:32 -0400)]
21642: Update caniuse

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

7 months ago12430: Add test for avoiding loading collections excluded by globs.
Tom Clegg [Fri, 26 Apr 2024 20:48:57 +0000 (16:48 -0400)]
12430: Add test for avoiding loading collections excluded by globs.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago12430: Expand output_glob documentation.
Tom Clegg [Fri, 26 Apr 2024 14:39:36 +0000 (10:39 -0400)]
12430: Expand output_glob documentation.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21700: Install Bundler system-wide in Rails postinst
Brett Smith [Fri, 26 Apr 2024 14:03:37 +0000 (10:03 -0400)]
21700: Install Bundler system-wide in Rails postinst

This effectively reverts 7e2165a5b7561f0c84ede6ab4ae58003a1551a48 and
follow-ups. Other parts of our install process like test-provision
assume that the correct version of Bundler is installed system-wide
after installing arvados-api-server. So just do that and find the
`bundle` command after the fact. Refs #21700.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago14230: Comment about test coverage, add trailing-** case.
Tom Clegg [Fri, 26 Apr 2024 13:36:18 +0000 (09:36 -0400)]
14230: Comment about test coverage, add trailing-** case.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months agoMerge branch '21721-refresh-python-deps'
Brett Smith [Fri, 26 Apr 2024 10:55:12 +0000 (06:55 -0400)]
Merge branch '21721-refresh-python-deps'

Refs #21721.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months agoMerge branch '21700-remove-rvm'
Brett Smith [Fri, 26 Apr 2024 10:54:59 +0000 (06:54 -0400)]
Merge branch '21700-remove-rvm'

Closes #21700.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Tighten Gemfile.lock parsing
Brett Smith [Fri, 26 Apr 2024 10:53:29 +0000 (06:53 -0400)]
21700: Tighten Gemfile.lock parsing

Avoid a bug if some subsection comes after `specs` under `GEM`.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Remove arvbox special case from run-tests.sh
Brett Smith [Fri, 26 Apr 2024 09:39:36 +0000 (05:39 -0400)]
21700: Remove arvbox special case from run-tests.sh

This was already a noop after ed268e53d2014ce5c49301559a46e67660f1404c,
and I suspect it's no longer necessary now that we do a better job of
standardizing the Bundler version anywhere, thanks in part to the
version locking added in Bundler 2.3.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Modernize arvbox bundler install recipe
Brett Smith [Fri, 26 Apr 2024 09:39:21 +0000 (05:39 -0400)]
21700: Modernize arvbox bundler install recipe

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months agoMerge branch '21722-remove-chokidar' into main. Closes #21722
Stephen Smith [Thu, 25 Apr 2024 14:36:07 +0000 (10:36 -0400)]
Merge branch '21722-remove-chokidar' into main. Closes #21722

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

7 months ago21717: Allow cross-origin keepstore requests.
Tom Clegg [Thu, 25 Apr 2024 13:59:54 +0000 (09:59 -0400)]
21717: Allow cross-origin keepstore requests.

Also add some missing Allow-Header and Expose-Header entries to
keepproxy CORS headers.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21721: Remove sdk/cwl version pins 21721-refresh-python-deps
Brett Smith [Wed, 24 Apr 2024 20:15:12 +0000 (16:15 -0400)]
21721: Remove sdk/cwl version pins

Both of these were set to work around limitations in the old pip
resolver. We have since standardized on the new one in our build
process, so they are no longer needed.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21721: Remove msgpack version pin
Brett Smith [Wed, 24 Apr 2024 20:13:47 +0000 (16:13 -0400)]
21721: Remove msgpack version pin

This was pinned to avoid an install bug in version 1.0.4. Newer releases
seem fine. See e2267bd9920.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21721: Remove pycurl version pin
Brett Smith [Wed, 24 Apr 2024 20:03:47 +0000 (16:03 -0400)]
21721: Remove pycurl version pin

This was originally pinned because of library conflicts on Debian 10,
which we no longer support. See commit
d655e2addaba4168f76fb7c4e2e9f6d649917bcc.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21721: Remove ruamel.yaml dependency
Brett Smith [Wed, 24 Apr 2024 19:55:06 +0000 (15:55 -0400)]
21721: Remove ruamel.yaml dependency

We import it a few times but never actually use it.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21721: Remove httplib2 and associated version pins
Brett Smith [Wed, 24 Apr 2024 19:29:54 +0000 (15:29 -0400)]
21721: Remove httplib2 and associated version pins

This whole stack was pinned to stay on an older version of
google-python-api-client, which has since been relaxed, and then keep
things working under the old pip resolver, which we've standardized off
of. Refs #18336.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21721: Remove google-auth version pin
Brett Smith [Wed, 24 Apr 2024 19:08:22 +0000 (15:08 -0400)]
21721: Remove google-auth version pin

Refs #18001. The original motivation for this pin is not
well-documented. My best guess is it was to retain Python 2.7 support,
which is no longer a concern.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21721: Remove tests_require=mock
Brett Smith [Wed, 24 Apr 2024 18:46:44 +0000 (14:46 -0400)]
21721: Remove tests_require=mock

unittest.mock in the stdlib is good enough for us.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months agoMerge branch '21719-deps-security-updates'. Closes #21719
Lucas Di Pentima [Wed, 24 Apr 2024 18:46:43 +0000 (15:46 -0300)]
Merge branch '21719-deps-security-updates'. Closes #21719

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

7 months ago21721: Clean various test imports for Python 3
Brett Smith [Wed, 24 Apr 2024 18:15:55 +0000 (14:15 -0400)]
21721: Clean various test imports for Python 3

This is not everything but cleans up files where I happened to notice
explicit version checks.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21721: Remove tests_require=pbr
Brett Smith [Wed, 24 Apr 2024 18:07:09 +0000 (14:07 -0400)]
21721: Remove tests_require=pbr

This module is a setuptools plugin that requires activation to
use. We're currently not doing that, so it's completely unused and safe
to remove.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21719: Upgrades golang.org/x/net to 0.24.0 21719-deps-security-updates
Lucas Di Pentima [Wed, 24 Apr 2024 17:38:06 +0000 (14:38 -0300)]
21719: Upgrades golang.org/x/net to 0.24.0

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

7 months ago21722: Remove node-sass-chokidar to fix security issues 21722-remove-chokidar
Stephen Smith [Wed, 24 Apr 2024 15:22:55 +0000 (11:22 -0400)]
21722: Remove node-sass-chokidar to fix security issues

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

7 months agoMerge branch '21697-slow-client-blocking'
Tom Clegg [Tue, 23 Apr 2024 19:53:32 +0000 (15:53 -0400)]
Merge branch '21697-slow-client-blocking'

fixes #21697

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21697: Fix typo. 21697-slow-client-blocking
Tom Clegg [Tue, 23 Apr 2024 18:10:30 +0000 (14:10 -0400)]
21697: Fix typo.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21697: Comment why releaseSession func exists.
Tom Clegg [Tue, 23 Apr 2024 18:09:34 +0000 (14:09 -0400)]
21697: Comment why releaseSession func exists.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months agoMerge branch '21696-slow-propfind'
Tom Clegg [Tue, 23 Apr 2024 15:36:26 +0000 (11:36 -0400)]
Merge branch '21696-slow-propfind'

fixes #21696

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21642: Add unit tests for conditional tabs, add test case for main process output...
Stephen Smith [Tue, 23 Apr 2024 14:35:49 +0000 (10:35 -0400)]
21642: Add unit tests for conditional tabs, add test case for main process output collection

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

7 months ago21700: Fix option typo 21700-remove-rvm
Brett Smith [Tue, 23 Apr 2024 14:22:42 +0000 (10:22 -0400)]
21700: Fix option typo

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21697: Don't hold session lock while processing read requests.
Tom Clegg [Tue, 23 Apr 2024 13:51:38 +0000 (09:51 -0400)]
21697: Don't hold session lock while processing read requests.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21700: Set GEM_PATH in Rails postinst
Brett Smith [Tue, 23 Apr 2024 13:25:59 +0000 (09:25 -0400)]
21700: Set GEM_PATH in Rails postinst

This is necessary to get the desired behavior in Ruby 2.7. Otherwise
Bundler gets installed somewhere else.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Adjust `gem fetch` syntax to work on Ruby 2.7
Brett Smith [Mon, 22 Apr 2024 20:07:18 +0000 (16:07 -0400)]
21700: Adjust `gem fetch` syntax to work on Ruby 2.7

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months agoMerge branch '21037-upgrade-react-scripts'
Lisa Knox [Mon, 22 Apr 2024 18:36:10 +0000 (14:36 -0400)]
Merge branch '21037-upgrade-react-scripts'

closes #21307

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months ago21700: Narrow `bundle install` workaround options
Brett Smith [Mon, 22 Apr 2024 18:32:40 +0000 (14:32 -0400)]
21700: Narrow `bundle install` workaround options

This prevents `gem install` from resolving dependencies differently from
Bundler and creating its own set of problems.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21037: added eslintrc to gitignore Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa... 21037-upgrade-react-scripts
Lisa Knox [Mon, 22 Apr 2024 18:09:27 +0000 (14:09 -0400)]
21037: added eslintrc to gitignore Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months ago21700: Install Bundler alongside bundled gems in Rails postinst
Brett Smith [Mon, 22 Apr 2024 17:51:36 +0000 (13:51 -0400)]
21700: Install Bundler alongside bundled gems in Rails postinst

See comments for rationale.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Work around incomplete `bundle cache` bug
Brett Smith [Sat, 20 Apr 2024 13:43:01 +0000 (09:43 -0400)]
21700: Work around incomplete `bundle cache` bug

It seems like the problem I was working around for zlib 3.1.0 on Ubuntu
20.04 earlier can affect basically any gem at any step, if you happen to
already have the exact same version installed on the system. This commit
adds workarounds for all gems at all steps of the bundle setup.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21696: Comment optimized PortableDataHash func. 21696-slow-propfind
Tom Clegg [Sun, 21 Apr 2024 22:35:27 +0000 (18:35 -0400)]
21696: Comment optimized PortableDataHash func.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21696: Update test case & timing results for ill-packed manifests.
Tom Clegg [Sun, 21 Apr 2024 22:16:45 +0000 (18:16 -0400)]
21696: Update test case & timing results for ill-packed manifests.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21696: Cache subpath->fnode lookups.
Tom Clegg [Sun, 21 Apr 2024 22:09:22 +0000 (18:09 -0400)]
21696: Cache subpath->fnode lookups.

Avoids extra locks/lookups when loading non-contiguous chunks.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21696: Speed up PortableDataHash by not using regexp.
Tom Clegg [Sun, 21 Apr 2024 22:08:48 +0000 (18:08 -0400)]
21696: Speed up PortableDataHash by not using regexp.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21696: Add test for non-contiguous file data segments.
Tom Clegg [Sat, 20 Apr 2024 17:50:45 +0000 (13:50 -0400)]
21696: Add test for non-contiguous file data segments.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21696: Fix slow loading of non-contiguous file data segments.
Tom Clegg [Sat, 20 Apr 2024 17:03:17 +0000 (13:03 -0400)]
21696: Fix slow loading of non-contiguous file data segments.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21700: Make workbench2 package respect --only-build
Brett Smith [Sat, 20 Apr 2024 13:36:55 +0000 (09:36 -0400)]
21700: Make workbench2 package respect --only-build

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Remove package-test-dockerfiles/Makefile
Brett Smith [Fri, 19 Apr 2024 22:41:19 +0000 (18:41 -0400)]
21700: Remove package-test-dockerfiles/Makefile

There's zero need for it after removing RVM.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Select more desired modules in rocky8 test Dockerfile
Brett Smith [Fri, 19 Apr 2024 19:13:22 +0000 (15:13 -0400)]
21700: Select more desired modules in rocky8 test Dockerfile

This prevents needless thrashing when the Dockerfile installs one set of
packages and then packages we test enable and reinstall a different
module stream.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Test the RailsAPI Bundler version
Brett Smith [Fri, 19 Apr 2024 16:46:10 +0000 (12:46 -0400)]
21700: Test the RailsAPI Bundler version

See comments for rationale.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Update the RailsAPI Bundler version
Brett Smith [Fri, 19 Apr 2024 16:45:12 +0000 (12:45 -0400)]
21700: Update the RailsAPI Bundler version

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Remove `bundle install` from package build Dockerfiles
Brett Smith [Fri, 19 Apr 2024 16:11:36 +0000 (12:11 -0400)]
21700: Remove `bundle install` from package build Dockerfiles

This work is better done in the package build script. I suspect the
problem that it's trying to solve is better solved by isolating the
RailsAPI `vendor` directory as done in
0333f33a7413aadb7159563e0a7aa2a0a50acaec.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Standardize on Bundler~>2.4.0
Brett Smith [Fri, 19 Apr 2024 16:05:18 +0000 (12:05 -0400)]
21700: Standardize on Bundler~>2.4.0

These are the last versions to support Ruby 2.7, which we're still
supporting as I write this.

Our usual install recipe is:

  gem install --conservative --version '~> 2.4.0' bundler

In environments where we *know* we have Ruby 3, that becomes:

  gem install --conservative --version '>= 2.4.0' bundler

As long as we have something at least as recent as 2.4.0, that should be
enough for function. This recipe meets our functional needs while
striking a balance between being easy to implement and avoiding
redundant installs.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Remove RVM support
Brett Smith [Fri, 19 Apr 2024 15:24:36 +0000 (11:24 -0400)]
21700: Remove RVM support

We haven't reliably tested this in a long time, and it's a lot of code
for no benefit.  In general we want to support the versions of Ruby that
come with the distributions we support. Anybody in a very weird case can
install a supported version of Ruby from source.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21700: Better isolate Bundler from the build source
Brett Smith [Fri, 19 Apr 2024 14:05:45 +0000 (10:05 -0400)]
21700: Better isolate Bundler from the build source

This helps ensure that when we build the RailsAPI package with Bundler,
we don't accidentally pick up settings or files from the developer's
machine. This shouldn't matter when we build packages on Jenkins but
this makes it easier for developers to test package builds on their own
systems.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months agoMerge branch '21606-keep-web-output-buffer'
Tom Clegg [Fri, 19 Apr 2024 18:11:30 +0000 (14:11 -0400)]
Merge branch '21606-keep-web-output-buffer'

closes #21606

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months agoMerge branch '21383-salt-debian12'
Brett Smith [Fri, 19 Apr 2024 18:08:11 +0000 (14:08 -0400)]
Merge branch '21383-salt-debian12'

Closes #21524, #21583, #21661.
Refs #21383.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21606: Document units for WebDAVOutputBuffer config. 21606-keep-web-output-buffer
Tom Clegg [Fri, 19 Apr 2024 18:07:16 +0000 (14:07 -0400)]
21606: Document units for WebDAVOutputBuffer config.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21037: moved entire beforeall into beforeeach in auto-logaout spec Arvados-DCO-1...
Lisa Knox [Fri, 19 Apr 2024 14:55:27 +0000 (10:55 -0400)]
21037: moved entire beforeall into beforeeach in auto-logaout spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months ago21037: fixed timers in auto-logout spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox...
Lisa Knox [Fri, 19 Apr 2024 14:48:28 +0000 (10:48 -0400)]
21037: fixed timers in auto-logout spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months ago21037: fixed search-input spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox...
Lisa Knox [Fri, 19 Apr 2024 14:46:47 +0000 (10:46 -0400)]
21037: fixed search-input spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months ago21037: removed stray whitespace in xml example Arvados-DCO-1.1-Signed-off-by: Lisa...
Lisa Knox [Fri, 19 Apr 2024 13:45:03 +0000 (09:45 -0400)]
21037: removed stray whitespace in xml example Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months ago21037: fixed auth-middleware test Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa...
Lisa Knox [Fri, 19 Apr 2024 13:28:07 +0000 (09:28 -0400)]
21037: fixed auth-middleware test Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months ago21642: Remove connect from main component and instead connect component that uses...
Stephen Smith [Thu, 18 Apr 2024 20:43:53 +0000 (16:43 -0400)]
21642: Remove connect from main component and instead connect component that uses navigateTo

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

7 months ago21642: Deduplicate wrapper elements into helper components
Stephen Smith [Thu, 18 Apr 2024 20:39:06 +0000 (16:39 -0400)]
21642: Deduplicate wrapper elements into helper components

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

7 months ago21642: Fix tab state misalignment by oursourcing tab state management
Stephen Smith [Thu, 18 Apr 2024 20:27:01 +0000 (16:27 -0400)]
21642: Fix tab state misalignment by oursourcing tab state management

ConditionalTabs component ensures no state misalignments by displaying tab
content by indexing into the same array of tabs that are given to the tab bar

By grouping tab and contents, we can simply remove inactive tabs before trying
to figure out which contents to show, making the logic much easier.

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

7 months ago21642: Remove unused import
Stephen Smith [Thu, 18 Apr 2024 20:24:24 +0000 (16:24 -0400)]
21642: Remove unused import

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

7 months agoRevert "21037: changed jest timer mocks to settimeouts Arvados-DCO-1.1-Signed-off...
Lisa Knox [Thu, 18 Apr 2024 18:29:24 +0000 (14:29 -0400)]
Revert "21037: changed jest timer mocks to settimeouts Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>"

Reverting due to false positives in search-input spec

This reverts commit 515f96c411358b45a978b6b7c93da860b09ee7d0.

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months ago21254: Add workaround for Bundler zlib bug 21383-salt-debian12
Brett Smith [Thu, 18 Apr 2024 15:11:31 +0000 (11:11 -0400)]
21254: Add workaround for Bundler zlib bug

See comments for discussion.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21383: Salt provisioner installs systemd-cron
Brett Smith [Thu, 7 Mar 2024 19:36:01 +0000 (14:36 -0500)]
21383: Salt provisioner installs systemd-cron

See comments for rationale.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21383: Reconfigure Salt logrotate service
Brett Smith [Wed, 6 Mar 2024 14:31:25 +0000 (09:31 -0500)]
21383: Reconfigure Salt logrotate service

See comments for rationale.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21383: Remove docker-ce version pin
Brett Smith [Tue, 5 Mar 2024 19:17:15 +0000 (14:17 -0500)]
21383: Remove docker-ce version pin

Now that we've removed support for older distros, all the distros we
currently support have the minimum version of docker-ce
available. Meanwhile, that older version is not available for some newer
distros we want to support. Remove the pin accordingly.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21383: Standardize on os-release variables
Brett Smith [Tue, 5 Mar 2024 19:16:06 +0000 (14:16 -0500)]
21383: Standardize on os-release variables

This script was getting this information three different ways: by
reading /etc/os-release, calling lsb_release, and using its own internal
lookup tables. This is silly. Just read /etc/os-release and use those
variables throughout.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21383: Update Salt installer formulas
Brett Smith [Tue, 16 Jan 2024 14:17:04 +0000 (09:17 -0500)]
21383: Update Salt installer formulas

I'm not aware of any specific reason we need this, but it's good
maintenance since I'm in here anyway.

letsencrypt 3.0.0 does introduce a backwards incompatible change because
it no longer installs the Apache plugin by default. Since we never
wanted that plugin and always specify the pkgs we want anyway, this
shouldn't affect us.
https://github.com/saltstack-formulas/letsencrypt-formula/blob/master/CHANGELOG.md#300-2021-07-02

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21383: Use postgres formula with support for Debian 12
Brett Smith [Mon, 15 Jan 2024 20:29:34 +0000 (15:29 -0500)]
21383: Use postgres formula with support for Debian 12

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21383: Upgrade Salt installer to Salt 3006
Brett Smith [Mon, 15 Jan 2024 18:39:34 +0000 (13:39 -0500)]
21383: Upgrade Salt installer to Salt 3006

Salt 3006 is the first version to support Python 3.11, included with
Debian 12.

Because 3006 is the current stable, we have to update the bootstrap
invocation to match. I guess we'll have to make another change after it
becomes old-stable.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21583: Configure Passenger with passenger_preload_bundler
Brett Smith [Fri, 5 Apr 2024 19:06:12 +0000 (15:06 -0400)]
21583: Configure Passenger with passenger_preload_bundler

This helps avoid situations where Passenger loads gems that create
a conflict with our bundle. We're currently seeing this with the base64
gem, where Passenger on Ruby 3.[0-3] can load the version shipped with
that Ruby before our RailsAPI bundle gets loaded. This causes an error:

  [ E 2024-03-12 15:12:44.8347 907382/Tf age/Cor/App/Implementation.cpp:221 ]:
  Could not spawn process for application /var/www/arvados-api/current:
  The application encountered the following error: You have already
  activated base64 0.1.1, but your Gemfile requires base64 0.2.0. Since
  base64 is a default gem, you can either remove your dependency on it or
  try updating to a newer version of bundler that supports base64 as a
  default gem. (Gem::LoadError)

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21583: Update link for Phusion Passenger install guide
Brett Smith [Fri, 5 Apr 2024 19:00:54 +0000 (15:00 -0400)]
21583: Update link for Phusion Passenger install guide

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

7 months ago21037: changed jest timer mocks to settimeouts Arvados-DCO-1.1-Signed-off-by: Lisa...
Lisa Knox [Wed, 17 Apr 2024 18:24:31 +0000 (14:24 -0400)]
21037: changed jest timer mocks to settimeouts Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

7 months agoMerge branch '21644-flaky-test'
Tom Clegg [Wed, 17 Apr 2024 15:37:11 +0000 (11:37 -0400)]
Merge branch '21644-flaky-test'

fixes #21644

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

7 months ago21696: Fix unnecessary copy-by-value.
Tom Clegg [Tue, 16 Apr 2024 18:18:03 +0000 (14:18 -0400)]
21696: Fix unnecessary copy-by-value.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>