Revert "21037: changed jest timer mocks to settimeouts Arvados-DCO-1.1-Signed-off...

Reverting due to false positives in search-input spec

This reverts commit 515f96c411358b45a978b6b7c93da860b09ee7d0.

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

diff --git a/services/workbench2/src/components/search-input/search-input.test.tsx b/services/workbench2/src/components/search-input/search-input.test.tsx
index de36ae3858e63739d33531d48c76a5f087dd0743..ba70f752b9d22fe131dd1b40fdbefe6b7dfa5731 100644 (file)
--- a/services/workbench2/src/components/search-input/search-input.test.tsx
+++ b/services/workbench2/src/components/search-input/search-input.test.tsx
@@ -11,7 +11,6 @@ configure({ adapter: new Adapter() });
 
 describe("<SearchInput />", () => {
 
-    // jest.useFakeTimers() applies to all setTimeout functions
     jest.useFakeTimers();
 
     let onSearch: () => void;
@@ -58,45 +57,39 @@ describe("<SearchInput />", () => {
             const searchInput = mount(<SearchInput selfClearProp="" value="" onSearch={onSearch} />);
             searchInput.find("input").simulate("change", { target: { value: "current value" } });
             expect(onSearch).not.toBeCalled();
-            setTimeout(() => {
-                expect(onSearch).toBeCalledWith("current value");
-            }, DEFAULT_SEARCH_DEBOUNCE);
+            jest.runTimersToTime(DEFAULT_SEARCH_DEBOUNCE);
+            expect(onSearch).toBeCalledWith("current value");
         });
 
         it("calls onSearch after the time specified in props has passed", () => {
             const searchInput = mount(<SearchInput selfClearProp="" value="" onSearch={onSearch} debounce={2000}/>);
             searchInput.find("input").simulate("change", { target: { value: "current value" } });
+            jest.runTimersToTime(1000);
             expect(onSearch).not.toBeCalled();
-            setTimeout(() => {
-                expect(onSearch).toBeCalledWith("current value");
-            }, 1000);
+            jest.runTimersToTime(1000);
+            expect(onSearch).toBeCalledWith("current value");
         });
 
         it("calls onSearch only once after no change happened during the specified time", () => {
             const searchInput = mount(<SearchInput selfClearProp="" value="" onSearch={onSearch} debounce={1000}/>);
             searchInput.find("input").simulate("change", { target: { value: "current value" } });
-            setTimeout(() => {
-                searchInput.find("input").simulate("change", { target: { value: "changed value" } });
-            }, 500);
-            setTimeout(() => {
-                expect(onSearch).toHaveBeenCalledTimes(1);
-            }, 1000);
+            jest.runTimersToTime(500);
+            searchInput.find("input").simulate("change", { target: { value: "changed value" } });
+            jest.runTimersToTime(1000);
+            expect(onSearch).toHaveBeenCalledTimes(1);
         });
 
         it("calls onSearch again after the specified time has passed since previous call", () => {
             const searchInput = mount(<SearchInput selfClearProp="" value="" onSearch={onSearch} debounce={1000}/>);
             searchInput.find("input").simulate("change", { target: { value: "current value" } });
-            setTimeout(() => {
-                searchInput.find("input").simulate("change", { target: { value: "intermediate value" } });
-            }, 500);
-            setTimeout(() => {
-                expect(onSearch).toBeCalledWith("intermediate value");
-            }, 1000);
+            jest.runTimersToTime(500);
+            searchInput.find("input").simulate("change", { target: { value: "intermediate value" } });
+            jest.runTimersToTime(1000);
+            expect(onSearch).toBeCalledWith("intermediate value");
             searchInput.find("input").simulate("change", { target: { value: "latest value" } });
-            setTimeout(() => {
-                expect(onSearch).toBeCalledWith("latest value");
-                expect(onSearch).toHaveBeenCalledTimes(2);
-            }, 1000);
+            jest.runTimersToTime(1000);
+            expect(onSearch).toBeCalledWith("latest value");
+            expect(onSearch).toHaveBeenCalledTimes(2);
 
         });
 
@@ -107,23 +100,20 @@ describe("<SearchInput />", () => {
             const searchInput = mount(<SearchInput selfClearProp="abc" value="123" onSearch={onSearch} debounce={1000}/>);
 
             // component should clear value upon creation
-            setTimeout(() => {
-                expect(onSearch).toBeCalledWith("");
-                expect(onSearch).toHaveBeenCalledTimes(1);
-            }, 1000);
+            jest.runTimersToTime(1000);
+            expect(onSearch).toBeCalledWith("");
+            expect(onSearch).toHaveBeenCalledTimes(1);
 
             // component should not clear on same selfClearProp
             searchInput.setProps({ selfClearProp: 'abc' });
-            setTimeout(() => {
-                expect(onSearch).toHaveBeenCalledTimes(1);
-            }, 1000);
+            jest.runTimersToTime(1000);
+            expect(onSearch).toHaveBeenCalledTimes(1);
 
             // component should clear on selfClearProp change
             searchInput.setProps({ selfClearProp: '111' });
-            setTimeout(() => {
-                expect(onSearch).toBeCalledWith("");
-                expect(onSearch).toHaveBeenCalledTimes(2);
-            }, 1000);
+            jest.runTimersToTime(1000);
+            expect(onSearch).toBeCalledWith("");
+            expect(onSearch).toHaveBeenCalledTimes(2);
         });
     });
 });