Peter Amstutz [Tue, 19 Aug 2014 15:37:24 +0000 (11:37 -0400)]
3036: Fixed migration to migrate modified_by_client_uuid and
modified_by_user_uuid (because modified_by isn't a column, whoops). Also fills
in in useless updated_at column because it has a NOT NULL constraint.
Peter Amstutz [Sat, 16 Aug 2014 02:37:59 +0000 (22:37 -0400)]
3036: Remove include_linked from project contents method because 'name' links
are obsolete. Remove tests related to include_linked. Fix docker image lookups.
Brett Smith [Thu, 14 Aug 2014 17:59:18 +0000 (13:59 -0400)]
3593: Another round of hardening Workbench's render_exception.
render_exception was counting on session[:user] to help render the
error page. We recently excised that, which is turning exceptions
into 500s. This commit restores the session user object, but uses it
only for error rendering, in keeping with the spirit of the previous
revert. This commit also defends against more possible failure cases
in render_exception, and adds a basic test for it.
Peter Amstutz [Fri, 15 Aug 2014 02:55:11 +0000 (22:55 -0400)]
3036: Adding pre-validation callback to set the portable_data_hash if necessay.
Added validation callback to check that portable_data_hash matches manifest_text.
Peter Amstutz [Thu, 14 Aug 2014 21:07:12 +0000 (17:07 -0400)]
3036: Split out logic to determine if a user is actually allowed to set the
uuid into validate_uuid. Fix docker/collection/job tests to use
portable_data_hash instead of uuid where appropriate.
Peter Amstutz [Thu, 14 Aug 2014 18:48:32 +0000 (14:48 -0400)]
3036: Removed special case normalize_collection_uuids. Removed special case
'name' links granting read permission. Renamed helper function
"collection_uuid" to "stripped_portable_data_hash" and moved to helpers
directory.
Peter Amstutz [Thu, 14 Aug 2014 15:35:06 +0000 (11:35 -0400)]
3505: Move helper scripts into crunchutil module. In run-command, added
task.stdin redirection, and renamed save.stdout to task.stdout for consistency.
Stylistic change "x == None" and "x != None" to "x is None" and "x is not
None".
The default Popen behavior is to use stderr, and that's fine. This was
a mistaken attempt to reveal missing logs, the real solution for which
is 5fcff4c13ae17527ee1efd6fa01d08133212085b.
Phil Hodgson [Thu, 14 Aug 2014 11:51:35 +0000 (07:51 -0400)]
3114: bug fix: when rendering JSON response to a generic #show action, correctly set an 'href' attribute in the response to be the #show url for the object
Brett Smith [Wed, 13 Aug 2014 16:07:06 +0000 (12:07 -0400)]
3421: Make Workbench project contents tables variable width.
This change will ensure that users can see the "edit name" buttons, by
letting a table row grow as needed to accommodate long names. It puts
each row's buttons in dedicated cells to try to stay true to the
original layout as much as possible.
Brett Smith [Tue, 12 Aug 2014 18:41:55 +0000 (14:41 -0400)]
3405: Log errors about launching pipeline instances.
There's a couple of components to this:
* Do some basic checks on the organization of the pipeline instance
before we start running it, and abort if any of them fail.
* If the pipeline runner aborts for any reason, send that as pipeline
instance stderr to the API server, so other tools like Workbench can
render it for users' benefit.
Brett Smith [Tue, 12 Aug 2014 21:43:28 +0000 (17:43 -0400)]
3457: Revamp Python SDK and tool logging.
The primary goal of this commit is to introduce a dedicated logging
object to the arvados module, which we configure to our
specifications, and use it consistently throughout the SDK and tools.
This lets us handle our logging configuration consistently in one
place, and avoid interfering with logging in SDK users. I made some
minor style changes to logging calls while I was at it.
Phil Hodgson [Wed, 13 Aug 2014 15:12:36 +0000 (11:12 -0400)]
3114: When current user, show root/home project rather than user attributes when landing on show user page.
(This is meant to be a compromise due to the fact that a home project's uuid has "user" as its arvados type, rather than "group".)
Peter Amstutz [Wed, 13 Aug 2014 15:04:52 +0000 (11:04 -0400)]
Added virtual working directory "task.vwd" option to run-command. Added
"task.cwd" to set the starting directory. Refactored upload retry logic from
run-command into robust_put.py and modified decompress-all to use it. no issue #