18123: Clarify variable names
authorStephen Smith <stephen@curii.com>
Wed, 15 Dec 2021 14:19:39 +0000 (09:19 -0500)
committerStephen Smith <stephen@curii.com>
Wed, 15 Dec 2021 14:19:39 +0000 (09:19 -0500)
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

src/store/groups-panel/groups-panel-actions.ts
src/views-components/dialog-update/dialog-project-update.tsx

index be4e5d72315cbf2464021fff4f246a985a2605f7..c72b00177c35f2ba42e377ca12d647a581b8cd7a 100644 (file)
@@ -6,7 +6,6 @@ import { Dispatch } from 'redux';
 import { reset, startSubmit, stopSubmit, FormErrors, initialize } from 'redux-form';
 import { bindDataExplorerActions } from "store/data-explorer/data-explorer-action";
 import { dialogActions } from 'store/dialog/dialog-actions';
-import { Participant } from 'views-components/sharing-dialog/participant-select';
 import { RootState } from 'store/store';
 import { ServiceRepository } from 'services/services';
 import { getResource } from 'store/resources/resources';
@@ -30,7 +29,7 @@ export const loadGroupsPanel = () => GroupsPanelActions.REQUEST_ITEMS();
 export const openCreateGroupDialog = () =>
     (dispatch: Dispatch, getState: () => RootState) => {
         dispatch(initialize(PROJECT_UPDATE_FORM_NAME, {}));
-        dispatch(dialogActions.OPEN_DIALOG({ id: PROJECT_UPDATE_FORM_NAME, data: {sourcePanel: GroupClass.ROLE, showUsersField: true} }));
+        dispatch(dialogActions.OPEN_DIALOG({ id: PROJECT_UPDATE_FORM_NAME, data: {sourcePanel: GroupClass.ROLE, create: true} }));
     };
 
 export const openGroupAttributes = (uuid: string) =>
index 64f7543362ebf2940cb301471ffa037a125f81fa..fda7c47d7d33c72dd1766d1d5bc5aa2a050c167a 100644 (file)
@@ -10,17 +10,17 @@ import { FormDialog } from 'components/form-dialog/form-dialog';
 import { ProjectNameField, ProjectDescriptionField, UsersField } from 'views-components/form-fields/project-form-fields';
 import { GroupClass } from 'models/group';
 
-type DialogProjectProps = WithDialogProps<{sourcePanel: GroupClass, showUsersField?: boolean}> & InjectedFormProps<ProjectUpdateFormDialogData>;
+type DialogProjectProps = WithDialogProps<{sourcePanel: GroupClass, create?: boolean}> & InjectedFormProps<ProjectUpdateFormDialogData>;
 
 export const DialogProjectUpdate = (props: DialogProjectProps) => {
     let title = 'Edit Project';
     let fields = ProjectEditFields;
     const sourcePanel = props.data.sourcePanel || '';
-    const showUsersField = !!props.data.showUsersField;
+    const create = !!props.data.create;
 
     if (sourcePanel === GroupClass.ROLE) {
-        title = showUsersField ? 'Create Group' : 'Edit Group';
-        fields = showUsersField ? GroupAddFields : ProjectEditFields;
+        title = create ? 'Create Group' : 'Edit Group';
+        fields = create ? GroupAddFields : ProjectEditFields;
     }
 
     return <FormDialog