From 7bf8014027507777a91a0266cf37beaa9841a2d1 Mon Sep 17 00:00:00 2001 From: Stephen Smith Date: Wed, 15 Dec 2021 09:19:39 -0500 Subject: [PATCH] 18123: Clarify variable names Arvados-DCO-1.1-Signed-off-by: Stephen Smith --- src/store/groups-panel/groups-panel-actions.ts | 3 +-- .../dialog-update/dialog-project-update.tsx | 8 ++++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/store/groups-panel/groups-panel-actions.ts b/src/store/groups-panel/groups-panel-actions.ts index be4e5d72..c72b0017 100644 --- a/src/store/groups-panel/groups-panel-actions.ts +++ b/src/store/groups-panel/groups-panel-actions.ts @@ -6,7 +6,6 @@ import { Dispatch } from 'redux'; import { reset, startSubmit, stopSubmit, FormErrors, initialize } from 'redux-form'; import { bindDataExplorerActions } from "store/data-explorer/data-explorer-action"; import { dialogActions } from 'store/dialog/dialog-actions'; -import { Participant } from 'views-components/sharing-dialog/participant-select'; import { RootState } from 'store/store'; import { ServiceRepository } from 'services/services'; import { getResource } from 'store/resources/resources'; @@ -30,7 +29,7 @@ export const loadGroupsPanel = () => GroupsPanelActions.REQUEST_ITEMS(); export const openCreateGroupDialog = () => (dispatch: Dispatch, getState: () => RootState) => { dispatch(initialize(PROJECT_UPDATE_FORM_NAME, {})); - dispatch(dialogActions.OPEN_DIALOG({ id: PROJECT_UPDATE_FORM_NAME, data: {sourcePanel: GroupClass.ROLE, showUsersField: true} })); + dispatch(dialogActions.OPEN_DIALOG({ id: PROJECT_UPDATE_FORM_NAME, data: {sourcePanel: GroupClass.ROLE, create: true} })); }; export const openGroupAttributes = (uuid: string) => diff --git a/src/views-components/dialog-update/dialog-project-update.tsx b/src/views-components/dialog-update/dialog-project-update.tsx index 64f75433..fda7c47d 100644 --- a/src/views-components/dialog-update/dialog-project-update.tsx +++ b/src/views-components/dialog-update/dialog-project-update.tsx @@ -10,17 +10,17 @@ import { FormDialog } from 'components/form-dialog/form-dialog'; import { ProjectNameField, ProjectDescriptionField, UsersField } from 'views-components/form-fields/project-form-fields'; import { GroupClass } from 'models/group'; -type DialogProjectProps = WithDialogProps<{sourcePanel: GroupClass, showUsersField?: boolean}> & InjectedFormProps; +type DialogProjectProps = WithDialogProps<{sourcePanel: GroupClass, create?: boolean}> & InjectedFormProps; export const DialogProjectUpdate = (props: DialogProjectProps) => { let title = 'Edit Project'; let fields = ProjectEditFields; const sourcePanel = props.data.sourcePanel || ''; - const showUsersField = !!props.data.showUsersField; + const create = !!props.data.create; if (sourcePanel === GroupClass.ROLE) { - title = showUsersField ? 'Create Group' : 'Edit Group'; - fields = showUsersField ? GroupAddFields : ProjectEditFields; + title = create ? 'Create Group' : 'Edit Group'; + fields = create ? GroupAddFields : ProjectEditFields; } return