17152: Avoids doing one extra request to persist versions on update.
authorLucas Di Pentima <lucas@di-pentima.com.ar>
Fri, 11 Dec 2020 15:41:30 +0000 (12:41 -0300)
committerLucas Di Pentima <lucas@di-pentima.com.ar>
Fri, 11 Dec 2020 15:41:30 +0000 (12:41 -0300)
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

src/services/collection-service/collection-service.ts

index 3280d05e82f65207c1dd1f9f2dbdcd66ec6ea361..9227393326576ab524030ac20da1d5858336c657 100644 (file)
@@ -31,12 +31,8 @@ export class CollectionService extends TrashableResourceService<CollectionResour
         return super.create({ ...data, preserveVersion: true });
     }
 
-    async update(uuid: string, data: Partial<CollectionResource>) {
-        // First make the changes
-        const collection = await super.update(uuid, data);
-        if (data === { preserveVersion: true }) { return collection; }
-        // Then set the head version to be preserved
-        return await super.update(uuid, { preserveVersion: true });
+    update(uuid: string, data: Partial<CollectionResource>) {
+        return super.update(uuid, { ...data, preserveVersion: true });
     }
 
     async files(uuid: string) {