From: Lucas Di Pentima <lucas@di-pentima.com.ar>
Date: Fri, 11 Dec 2020 15:41:30 +0000 (-0300)
Subject: 17152: Avoids doing one extra request to persist versions on update.
X-Git-Tag: 2.1.2~22^2~1
X-Git-Url: https://git.arvados.org/arvados-workbench2.git/commitdiff_plain/2cabc3d906f0e1b926072187834fff181656d6e5

17152: Avoids doing one extra request to persist versions on update.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
---

diff --git a/src/services/collection-service/collection-service.ts b/src/services/collection-service/collection-service.ts
index 3280d05e..92273933 100644
--- a/src/services/collection-service/collection-service.ts
+++ b/src/services/collection-service/collection-service.ts
@@ -31,12 +31,8 @@ export class CollectionService extends TrashableResourceService<CollectionResour
         return super.create({ ...data, preserveVersion: true });
     }
 
-    async update(uuid: string, data: Partial<CollectionResource>) {
-        // First make the changes
-        const collection = await super.update(uuid, data);
-        if (data === { preserveVersion: true }) { return collection; }
-        // Then set the head version to be preserved
-        return await super.update(uuid, { preserveVersion: true });
+    update(uuid: string, data: Partial<CollectionResource>) {
+        return super.update(uuid, { ...data, preserveVersion: true });
     }
 
     async files(uuid: string) {