4 Check lesson files and their contents.
11 from argparse import ArgumentParser
13 from util import (Reporter, read_markdown, load_yaml, check_unwanted_files,
18 # Where to look for source Markdown files.
19 SOURCE_DIRS = ['', '_episodes', '_extras']
21 # Where to look for source Rmd files.
22 SOURCE_RMD_DIRS = ['_episodes_rmd']
24 # Required files: each entry is ('path': YAML_required).
25 # FIXME: We do not yet validate whether any files have the required
26 # YAML headers, but should in the future.
27 # The '%' is replaced with the source directory path for checking.
28 # Episodes are handled specially, and extra files in '_extras' are also handled
29 # specially. This list must include all the Markdown files listed in the
30 # 'bin/initialize' script.
32 '%/CODE_OF_CONDUCT.md': True,
33 '%/CONTRIBUTING.md': False,
36 '%/_extras/discuss.md': True,
37 '%/_extras/guide.md': True,
39 '%/reference.md': True,
43 # Episode filename pattern.
44 P_EPISODE_FILENAME = re.compile(r'/_episodes/(\d\d)-[-\w]+.md$')
46 # Pattern to match lines ending with whitespace.
47 P_TRAILING_WHITESPACE = re.compile(r'\s+$')
49 # Pattern to match figure references in HTML.
50 P_FIGURE_REFS = re.compile(r'<img[^>]+src="([^"]+)"[^>]*>')
52 # Pattern to match internally-defined Markdown links.
53 P_INTERNAL_LINK_REF = re.compile(r'\[([^\]]+)\]\[([^\]]+)\]')
55 # Pattern to match reference links (to resolve internally-defined references).
56 P_INTERNAL_LINK_DEF = re.compile(r'^\[([^\]]+)\]:\s*(.+)')
58 # What kinds of blockquotes are allowed?
72 # What kinds of code fragments are allowed?
87 # What fields are required in teaching episode metadata?
88 TEACHING_METADATA_FIELDS = {
97 # What fields are required in break episode metadata?
98 BREAK_METADATA_FIELDS = {
104 # How long are lines allowed to be?
112 args.reporter = Reporter()
113 check_config(args.reporter, args.source_dir)
114 check_source_rmd(args.reporter, args.source_dir, args.parser)
115 args.references = read_references(args.reporter, args.reference_path)
117 docs = read_all_markdown(args.source_dir, args.parser)
118 check_fileset(args.source_dir, args.reporter, list(docs.keys()))
119 check_unwanted_files(args.source_dir, args.reporter)
120 for filename in list(docs.keys()):
121 checker = create_checker(args, filename, docs[filename])
124 args.reporter.report()
125 if args.reporter.messages and not args.permissive:
130 """Parse command-line arguments."""
132 parser = ArgumentParser(description="""Check episode files in a lesson.""")
133 parser.add_argument('-l', '--linelen',
137 help='Check line lengths')
138 parser.add_argument('-p', '--parser',
141 help='path to Markdown parser')
142 parser.add_argument('-r', '--references',
144 dest='reference_path',
145 help='path to Markdown file of external references')
146 parser.add_argument('-s', '--source',
149 help='source directory')
150 parser.add_argument('-w', '--whitespace',
153 dest='trailing_whitespace',
154 help='Check for trailing whitespace')
155 parser.add_argument('--permissive',
159 help='Do not raise an error even if issues are detected')
161 args, extras = parser.parse_known_args()
162 require(args.parser is not None,
163 'Path to Markdown parser not provided')
165 'Unexpected trailing command-line arguments "{0}"'.format(extras))
170 def check_config(reporter, source_dir):
171 """Check configuration file."""
173 config_file = os.path.join(source_dir, '_config.yml')
174 config = load_yaml(config_file)
175 reporter.check_field(config_file, 'configuration',
176 config, 'kind', 'lesson')
177 reporter.check_field(config_file, 'configuration',
178 config, 'carpentry', ('swc', 'dc', 'lc', 'cp'))
179 reporter.check_field(config_file, 'configuration', config, 'title')
180 reporter.check_field(config_file, 'configuration', config, 'email')
183 {'values': {'root': '.', 'layout': 'page'}},
184 {'values': {'root': '..', 'layout': 'episode'}, 'scope': {'type': 'episodes', 'path': ''}},
185 {'values': {'root': '..', 'layout': 'page'}, 'scope': {'type': 'extras', 'path': ''}}
187 reporter.check(defaults in config.get('defaults', []),
189 '"root" not set to "." in configuration')
191 def check_source_rmd(reporter, source_dir, parser):
192 """Check that Rmd episode files include `source: Rmd`"""
194 episode_rmd_dir = [os.path.join(source_dir, d) for d in SOURCE_RMD_DIRS]
195 episode_rmd_files = [os.path.join(d, '*.Rmd') for d in episode_rmd_dir]
197 for pat in episode_rmd_files:
198 for f in glob.glob(pat):
199 data = read_markdown(parser, f)
200 dy = data['metadata']
202 reporter.check_field(f, 'episode_rmd',
205 def read_references(reporter, ref_path):
206 """Read shared file of reference links, returning dictionary of valid references
207 {symbolic_name : URL}
213 with open(ref_path, 'r') as reader:
214 for (num, line) in enumerate(reader):
216 m = P_INTERNAL_LINK_DEF.search(line)
218 '{0}:{1} not valid reference:\n{2}'.format(ref_path, line_num, line.rstrip()))
222 'Empty reference at {0}:{1}'.format(ref_path, line_num))
223 reporter.check(name not in result,
225 'Duplicate reference {0} at line {1}',
227 reporter.check(url not in urls_seen,
229 'Duplicate definition of URL {0} at line {1}',
236 def read_all_markdown(source_dir, parser):
237 """Read source files, returning
238 {path : {'metadata':yaml, 'metadata_len':N, 'text':text, 'lines':[(i, line, len)], 'doc':doc}}
241 all_dirs = [os.path.join(source_dir, d) for d in SOURCE_DIRS]
242 all_patterns = [os.path.join(d, '*.md') for d in all_dirs]
244 for pat in all_patterns:
245 for filename in glob.glob(pat):
246 data = read_markdown(parser, filename)
248 result[filename] = data
252 def check_fileset(source_dir, reporter, filenames_present):
253 """Are all required files present? Are extraneous files present?"""
255 # Check files with predictable names.
256 required = [p.replace('%', source_dir) for p in REQUIRED_FILES]
257 missing = set(required) - set(filenames_present)
259 reporter.add(None, 'Missing required file {0}', m)
261 # Check episode files' names.
263 for filename in filenames_present:
264 if '_episodes' not in filename:
266 m = P_EPISODE_FILENAME.search(filename)
268 seen.append(m.group(1))
271 None, 'Episode {0} has badly-formatted filename', filename)
273 # Check for duplicate episode numbers.
274 reporter.check(len(seen) == len(set(seen)),
276 'Duplicate episode numbers {0} vs {1}',
277 sorted(seen), sorted(set(seen)))
279 # Check that numbers are consecutive.
280 seen = sorted([int(s) for s in seen])
282 for i in range(len(seen) - 1):
283 clean = clean and ((seen[i+1] - seen[i]) == 1)
284 reporter.check(clean,
286 'Missing or non-consecutive episode numbers {0}',
290 def create_checker(args, filename, info):
291 """Create appropriate checker for file."""
293 for (pat, cls) in CHECKERS:
294 if pat.search(filename):
295 return cls(args, filename, **info)
296 return NotImplemented
299 """Base class for checking Markdown files."""
301 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
302 """Cache arguments for checking."""
305 self.reporter = self.args.reporter # for convenience
306 self.filename = filename
307 self.metadata = metadata
308 self.metadata_len = metadata_len
318 self.check_metadata()
319 self.check_line_lengths()
320 self.check_trailing_whitespace()
321 self.check_blockquote_classes()
322 self.check_codeblock_classes()
323 self.check_defined_link_references()
325 def check_metadata(self):
326 """Check the YAML metadata."""
328 self.reporter.check(self.metadata is not None,
330 'Missing metadata entirely')
332 if self.metadata and (self.layout is not None):
333 self.reporter.check_field(
334 self.filename, 'metadata', self.metadata, 'layout', self.layout)
336 def check_line_lengths(self):
337 """Check the raw text of the lesson body."""
339 if self.args.line_lengths:
340 over = [i for (i, l, n) in self.lines if (
341 n > MAX_LINE_LEN) and (not l.startswith('!'))]
342 self.reporter.check(not over,
344 'Line(s) are too long: {0}',
345 ', '.join([str(i) for i in over]))
347 def check_trailing_whitespace(self):
348 """Check for whitespace at the ends of lines."""
350 if self.args.trailing_whitespace:
352 i for (i, l, n) in self.lines if P_TRAILING_WHITESPACE.match(l)]
353 self.reporter.check(not trailing,
355 'Line(s) end with whitespace: {0}',
356 ', '.join([str(i) for i in trailing]))
358 def check_blockquote_classes(self):
359 """Check that all blockquotes have known classes."""
361 for node in self.find_all(self.doc, {'type': 'blockquote'}):
362 cls = self.get_val(node, 'attr', 'class')
363 self.reporter.check(cls in KNOWN_BLOCKQUOTES,
364 (self.filename, self.get_loc(node)),
365 'Unknown or missing blockquote type {0}',
368 def check_codeblock_classes(self):
369 """Check that all code blocks have known classes."""
371 for node in self.find_all(self.doc, {'type': 'codeblock'}):
372 cls = self.get_val(node, 'attr', 'class')
373 self.reporter.check(cls in KNOWN_CODEBLOCKS,
374 (self.filename, self.get_loc(node)),
375 'Unknown or missing code block type {0}',
378 def check_defined_link_references(self):
379 """Check that defined links resolve in the file.
381 Internally-defined links match the pattern [text][label].
385 for node in self.find_all(self.doc, {'type': 'text'}):
386 for match in P_INTERNAL_LINK_REF.findall(node['value']):
389 if link not in self.args.references:
390 result.add('"{0}"=>"{1}"'.format(text, link))
391 self.reporter.check(not result,
393 'Internally-defined links may be missing definitions: {0}',
394 ', '.join(sorted(result)))
396 def find_all(self, node, pattern, accum=None):
397 """Find all matches for a pattern."""
399 assert isinstance(pattern, dict), 'Patterns must be dictionaries'
402 if self.match(node, pattern):
404 for child in node.get('children', []):
405 self.find_all(child, pattern, accum)
408 def match(self, node, pattern):
409 """Does this node match the given pattern?"""
415 if isinstance(val, str):
418 elif isinstance(val, dict):
419 if not self.match(node[key], val):
424 def get_val(node, *chain):
425 """Get value one or more levels down."""
428 for selector in chain:
429 curr = curr.get(selector, None)
434 def get_loc(self, node):
435 """Convenience method to get node's line number."""
437 result = self.get_val(node, 'options', 'location')
438 if self.metadata_len is not None:
439 result += self.metadata_len
443 class CheckNonJekyll(CheckBase):
444 """Check a file that isn't translated by Jekyll."""
446 def check_metadata(self):
447 self.reporter.check(self.metadata is None,
449 'Unexpected metadata')
452 class CheckIndex(CheckBase):
453 """Check the main index page."""
455 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
456 super().__init__(args, filename, metadata, metadata_len, text, lines, doc)
457 self.layout = 'lesson'
459 def check_metadata(self):
460 super().check_metadata()
461 self.reporter.check(self.metadata.get('root', '') == '.',
463 'Root not set to "."')
466 class CheckEpisode(CheckBase):
467 """Check an episode page."""
470 """Run extra tests."""
473 self.check_reference_inclusion()
475 def check_metadata(self):
476 super().check_metadata()
478 if 'layout' in self.metadata:
479 if self.metadata['layout'] == 'break':
480 self.check_metadata_fields(BREAK_METADATA_FIELDS)
482 self.reporter.add(self.filename,
483 'Unknown episode layout "{0}"',
484 self.metadata['layout'])
486 self.check_metadata_fields(TEACHING_METADATA_FIELDS)
488 def check_metadata_fields(self, expected):
489 """Check metadata fields."""
490 for (name, type_) in expected:
491 if name not in self.metadata:
492 self.reporter.add(self.filename,
493 'Missing metadata field {0}',
495 elif not isinstance(self.metadata[name], type_):
496 self.reporter.add(self.filename,
497 '"{0}" has wrong type in metadata ({1} instead of {2})',
498 name, type(self.metadata[name]), type_)
500 def check_reference_inclusion(self):
501 """Check that links file has been included."""
503 if not self.args.reference_path:
506 for (i, last_line, line_len) in reversed(self.lines):
511 'No non-empty lines in {0}'.format(self.filename))
513 include_filename = os.path.split(self.args.reference_path)[-1]
514 if include_filename not in last_line:
515 self.reporter.add(self.filename,
516 'episode does not include "{0}"',
520 class CheckReference(CheckBase):
521 """Check the reference page."""
523 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
524 super().__init__(args, filename, metadata, metadata_len, text, lines, doc)
525 self.layout = 'reference'
528 class CheckGeneric(CheckBase):
529 """Check a generic page."""
531 def __init__(self, args, filename, metadata, metadata_len, text, lines, doc):
532 super().__init__(args, filename, metadata, metadata_len, text, lines, doc)
536 (re.compile(r'CONTRIBUTING\.md'), CheckNonJekyll),
537 (re.compile(r'README\.md'), CheckNonJekyll),
538 (re.compile(r'index\.md'), CheckIndex),
539 (re.compile(r'reference\.md'), CheckReference),
540 (re.compile(r'_episodes/.*\.md'), CheckEpisode),
541 (re.compile(r'aio\.md'), CheckNonJekyll),
542 (re.compile(r'.*\.md'), CheckGeneric)
546 if __name__ == '__main__':