arvados.git
9 years ago5319: Improve collection PDH fix performance with LIKE searches. 5319-collection-pdh-fix-performance-2-wip
Brett Smith [Wed, 18 Mar 2015 14:44:18 +0000 (10:44 -0400)]
5319: Improve collection PDH fix performance with LIKE searches.

PostgreSQL regexp searches use a lot of RAM, and these queries run out
of RAM on qr1hi.  Prefer LIKE queries, which use less RAM and are more
portable.  We have to do multiple searches, but that's life.

9 years agorefs #5383
Radhika Chippada [Wed, 18 Mar 2015 13:44:32 +0000 (09:44 -0400)]
refs #5383
Merge branch '5383-api-db-current-time'

9 years agoMerge branch 'master' into 5383-api-db-current-time
Radhika Chippada [Wed, 18 Mar 2015 13:41:23 +0000 (09:41 -0400)]
Merge branch 'master' into 5383-api-db-current-time

9 years ago5383: Add back Time.parse(). Without it the value returned would be of the format...
Radhika Chippada [Wed, 18 Mar 2015 13:38:26 +0000 (09:38 -0400)]
5383: Add back Time.parse(). Without it the value returned would be of the format 2015-03-18 13:37:11 UTC,
and with Time.parse it would be 2015-03-18 09:37:11 -0400, which is the same as Time.now.

9 years agoMerge branch '5313-node-manager-node-naming-tag-wip'
Brett Smith [Wed, 18 Mar 2015 12:56:54 +0000 (08:56 -0400)]
Merge branch '5313-node-manager-node-naming-tag-wip'

Refs #5313.  Closes #5434, #5467.

9 years ago5313: Node Manager has cloud-specific logic to get node FQDNs.
Brett Smith [Fri, 13 Mar 2015 15:11:35 +0000 (11:11 -0400)]
5313: Node Manager has cloud-specific logic to get node FQDNs.

On AWS, we put compute nodes' FQDN in the name field.  On GCE, we
can't do that: it can't contain dots.  Add a node_fqdn classmethod to
cloud drivers to get a node's FQDN from the right place, and use that
method when deciding whether or not to sync a node.

Syncing a node will occasionally raise an "Invalid fingerprint"
exception on GCE.  This is nonfatal.  Add a comment explaining why.

9 years agocloses #5383
Radhika Chippada [Wed, 18 Mar 2015 01:08:31 +0000 (21:08 -0400)]
closes #5383
Merge branch '5383-api-db-current-time'

9 years ago5383: better test assertion
Radhika Chippada [Wed, 18 Mar 2015 00:50:15 +0000 (20:50 -0400)]
5383: better test assertion

9 years agoMerge branch 'master' into 5383-api-db-current-time
Radhika Chippada [Wed, 18 Mar 2015 00:44:20 +0000 (20:44 -0400)]
Merge branch 'master' into 5383-api-db-current-time

9 years agoWhen copying a collection that already exists on the destination, fetch
Peter Amstutz [Tue, 17 Mar 2015 17:35:42 +0000 (13:35 -0400)]
When copying a collection that already exists on the destination, fetch
manifest text from the destination in order to create a new collection with the
correct signing tokens.  closes #5475

9 years ago5383: minor test assertion updates
Radhika Chippada [Tue, 17 Mar 2015 14:57:28 +0000 (10:57 -0400)]
5383: minor test assertion updates

9 years agoMerge branch 'master' into 5383-api-db-current-time
Radhika Chippada [Tue, 17 Mar 2015 14:53:47 +0000 (10:53 -0400)]
Merge branch 'master' into 5383-api-db-current-time

9 years ago5383: add one more test that updates an object twice and verifies the updated_at...
Radhika Chippada [Tue, 17 Mar 2015 14:51:16 +0000 (10:51 -0400)]
5383: add one more test that updates an object twice and verifies the updated_at times are different.

9 years ago5383: remove unused include statement from log_test (it is now the same as in master...
Radhika Chippada [Tue, 17 Mar 2015 14:33:30 +0000 (10:33 -0400)]
5383: remove unused include statement from log_test (it is now the same as in master with no updates in this branch).

9 years agoMerge branch '5476-connect-timeout-scale' closes #5476
Peter Amstutz [Tue, 17 Mar 2015 14:28:24 +0000 (10:28 -0400)]
Merge branch '5476-connect-timeout-scale' closes #5476

9 years ago5383: postgres current_timestamp is the start of transaction and clock_timestamp...
Radhika Chippada [Tue, 17 Mar 2015 14:27:35 +0000 (10:27 -0400)]
5383: postgres current_timestamp is the start of transaction and clock_timestamp is the current time at the statement execution. updated db_current_time to use  clock_timestamp and reverted back all updates to log_test.rb

9 years ago5476: Describe timeout behavior if KeepClient.__init__ docstring.
Peter Amstutz [Tue, 17 Mar 2015 14:27:03 +0000 (10:27 -0400)]
5476: Describe timeout behavior if KeepClient.__init__ docstring.

9 years ago5476: Better implementation of connection timeout scaling. Updated docstring
Peter Amstutz [Tue, 17 Mar 2015 14:09:46 +0000 (10:09 -0400)]
5476: Better implementation of connection timeout scaling.  Updated docstring
for current_timeout.

9 years ago5476: Increase connection timeout when retrying keep get and put.
Peter Amstutz [Tue, 17 Mar 2015 13:37:20 +0000 (09:37 -0400)]
5476: Increase connection timeout when retrying keep get and put.

9 years ago5383: revert db_current_time back to Time.now in application_controller as the usages...
Radhika Chippada [Mon, 16 Mar 2015 23:16:46 +0000 (19:16 -0400)]
5383: revert db_current_time back to Time.now in application_controller as the usages were for error tokens and request profiling only.

9 years ago5383: revert back db_current_time update to Time.now in api scripts and middleware...
Radhika Chippada [Mon, 16 Mar 2015 23:07:01 +0000 (19:07 -0400)]
5383: revert back db_current_time update to Time.now in api scripts and middleware rb files.

9 years ago5383: update db_current_time to return date with more precision. Update log_test...
Radhika Chippada [Mon, 16 Mar 2015 22:35:58 +0000 (18:35 -0400)]
5383: update db_current_time to return date with more precision. Update log_test to use db_current_time instead of Time.now to ensure if there is a slight difference in time between db time and server time, the test does not fail.

9 years agoMerge branch 'master' into 5383-api-db-current-time
Radhika Chippada [Mon, 16 Mar 2015 21:41:28 +0000 (17:41 -0400)]
Merge branch 'master' into 5383-api-db-current-time

9 years agoMerge branch '5207-expires-at-time' closes #5207
Tom Clegg [Mon, 16 Mar 2015 21:19:16 +0000 (17:19 -0400)]
Merge branch '5207-expires-at-time' closes #5207

9 years agoMerge branch 'master' into 5383-api-db-current-time
Radhika Chippada [Mon, 16 Mar 2015 19:30:29 +0000 (15:30 -0400)]
Merge branch 'master' into 5383-api-db-current-time

9 years agoMerge branch '5448-crunch-job-task-fixes' refs #5448
Peter Amstutz [Mon, 16 Mar 2015 19:00:23 +0000 (15:00 -0400)]
Merge branch '5448-crunch-job-task-fixes' refs #5448

9 years ago5448: Clean up old cid files during job start.
Peter Amstutz [Mon, 16 Mar 2015 17:50:56 +0000 (13:50 -0400)]
5448: Clean up old cid files during job start.

9 years agoMerge branch '5319-collection-pdh-fix-performance-wip'
Brett Smith [Mon, 16 Mar 2015 16:41:36 +0000 (12:41 -0400)]
Merge branch '5319-collection-pdh-fix-performance-wip'

Refs #5319.

9 years ago5319: Improve performance of Collection PDH fix migration.
Brett Smith [Mon, 16 Mar 2015 14:09:57 +0000 (10:09 -0400)]
5319: Improve performance of Collection PDH fix migration.

* Use PostgreSQL's native regular expression search to limit the
  number of records we pull through ActiveRecord.
* Use a smaller batch size to avoid pulling pathological batches of
  records that cause swapping.

9 years agoMerge branch 'master' into 5383-api-db-current-time
Radhika Chippada [Mon, 16 Mar 2015 16:24:16 +0000 (12:24 -0400)]
Merge branch 'master' into 5383-api-db-current-time

9 years ago5383: blob.rb uses db_current_time as well. since it is using static methods, the...
Radhika Chippada [Mon, 16 Mar 2015 16:21:34 +0000 (12:21 -0400)]
5383: blob.rb uses db_current_time as well. since it is using static methods, the module needs to be "extended"

9 years ago5448: Fix cid file cleanup.
Peter Amstutz [Mon, 16 Mar 2015 15:26:49 +0000 (11:26 -0400)]
5448: Fix cid file cleanup.

9 years ago5383: add test that creates an object and does a lookup using that object's created_a...
Radhika Chippada [Mon, 16 Mar 2015 15:20:42 +0000 (11:20 -0400)]
5383: add test that creates an object and does a lookup using that object's created_at timestamp.

9 years ago5448: Add --all to "docker images" because it turns out it doesn't list all the insta...
Peter Amstutz [Mon, 16 Mar 2015 14:47:49 +0000 (10:47 -0400)]
5448: Add --all to "docker images" because it turns out it doesn't list all the installed images by default!

9 years agoMerge branch 'master' from github.com/daftano. No issue #
Tom Clegg [Mon, 16 Mar 2015 14:18:19 +0000 (10:18 -0400)]
Merge branch 'master' from github.com/daftano. No issue #

9 years agoMerge branch 'master' into 5383-api-db-current-time
Radhika Chippada [Mon, 16 Mar 2015 13:52:48 +0000 (09:52 -0400)]
Merge branch 'master' into 5383-api-db-current-time

9 years ago5383: use db current time in place of Time.now
Radhika Chippada [Mon, 16 Mar 2015 13:51:54 +0000 (09:51 -0400)]
5383: use db current time in place of Time.now

9 years ago5448: Don't create new tasks if $main::success is defined. Add failure count
Peter Amstutz [Mon, 16 Mar 2015 13:40:32 +0000 (09:40 -0400)]
5448: Don't create new tasks if $main::success is defined.  Add failure count
to cidfile and delete cidfile in reapchildren() to fix Docker cidfile collision.

9 years agoMerge branch 'install-doc-uuid-prefix' no issue #
Peter Amstutz [Mon, 16 Mar 2015 13:09:48 +0000 (09:09 -0400)]
Merge branch 'install-doc-uuid-prefix' no issue #

9 years agoMerge branch '4158-fix-compute-node-detail' closes #4158
Peter Amstutz [Mon, 16 Mar 2015 13:08:38 +0000 (09:08 -0400)]
Merge branch '4158-fix-compute-node-detail' closes #4158

9 years agoUpdate install-workbench-app.html.textile.liquid
David [Mon, 16 Mar 2015 11:38:22 +0000 (12:38 +0100)]
Update install-workbench-app.html.textile.liquid

Add libsqlite3-dev dependency

9 years agoUpdate install-workbench-app.html.textile.liquid
David [Mon, 16 Mar 2015 11:22:31 +0000 (12:22 +0100)]
Update install-workbench-app.html.textile.liquid

Remove sudo because to run sudo you need to have it already installed
Add git to download sources from github

9 years ago5034: Update Workbench integration tests.
Brett Smith [Fri, 13 Mar 2015 21:31:10 +0000 (17:31 -0400)]
5034: Update Workbench integration tests.

A lot of tests started failing because

* they were looking for the string "content hash" to assert they were
  on a collection page, or
* they expect the portable data hash to be real text on the page (as
  opposed to the value of an <input>).

Fixes:

* Have the upload test check that the collection is empty by looking
  for the relevant size information, which was specified by the story.
* Make sure we're on a specific collection page by looking for the
  collection's name or UUID (depending on what's available).
* Refute we're on a specific collection page by matching against the
  URL.  This seems much safer in the long run.
* Remove the "Content hash" assertion from projects test altogether.
  The prior text assertion should be sufficient to ensure we're on the
  right page.

Refs #5034.

9 years ago5034: Update Workbench Gemfile post-merge.
Brett Smith [Fri, 13 Mar 2015 19:16:44 +0000 (15:16 -0400)]
5034: Update Workbench Gemfile post-merge.

Refs #5034.

9 years agoMerge branch '5034-workbench-collection-summary-wip'
Brett Smith [Fri, 13 Mar 2015 19:14:11 +0000 (15:14 -0400)]
Merge branch '5034-workbench-collection-summary-wip'

Closes #5027, #5034, #5452.

9 years ago5034: Improve Workbench collection display.
Brett Smith [Thu, 12 Mar 2015 14:15:39 +0000 (10:15 -0400)]
5034: Improve Workbench collection display.

* Display the UUID, and make it auto-select for easy copying.
* Do the same for the portable data hash, and call it the content
  address to emphasize that.
* Display information about the collection's size on the show page and
  preview pane.  This relies on an updated Ruby SDK.
* Clean up code that checks for a portable data hash in the UUID.
  That can't happen anymore thanks to the redirect/list display logic
  in the controller.

9 years ago5034: Add Keep::Manifest#files_size to Ruby SDK.
Brett Smith [Tue, 10 Mar 2015 18:43:29 +0000 (14:43 -0400)]
5034: Add Keep::Manifest#files_size to Ruby SDK.

9 years agoMerge branch '5211-improved-top-navbar'
Ward Vandewege [Fri, 13 Mar 2015 15:24:46 +0000 (11:24 -0400)]
Merge branch '5211-improved-top-navbar'

closes #5211

9 years agoMerge branch 'master' into 5211-improved-top-navbar
Ward Vandewege [Fri, 13 Mar 2015 15:24:08 +0000 (11:24 -0400)]
Merge branch 'master' into 5211-improved-top-navbar

9 years agoRemove reference to as yet non-existant compute node setup page.
Ward Vandewege [Fri, 13 Mar 2015 15:23:22 +0000 (11:23 -0400)]
Remove reference to as yet non-existant compute node setup page.

Refs #5211

9 years agorefs #3761
Radhika Chippada [Fri, 13 Mar 2015 15:06:17 +0000 (11:06 -0400)]
refs #3761
Merge branch '3761-pull-list-worker'

9 years agoTypo fix and gofmt fix.
Peter Amstutz [Fri, 13 Mar 2015 15:23:32 +0000 (11:23 -0400)]
Typo fix and gofmt fix.

9 years ago3761: We do not need to MakeArvadosClient to create the pullq worker. Otherwise,...
Radhika Chippada [Fri, 13 Mar 2015 14:54:23 +0000 (10:54 -0400)]
3761: We do not need to MakeArvadosClient to create the pullq worker. Otherwise, we need the ARVADOS_API_HOST env variable in keep.

9 years agoAdd note to application.default.yml and installation documentation that
Peter Amstutz [Fri, 13 Mar 2015 14:43:13 +0000 (10:43 -0400)]
Add note to application.default.yml and installation documentation that
uuid_prefix must be exactly 5 characters.

9 years ago4158: Compute node details are in properties, not info
Peter Amstutz [Fri, 13 Mar 2015 14:15:40 +0000 (10:15 -0400)]
4158: Compute node details are in properties, not info

9 years agoMerge branch 'patch-1' from github.com/daftano. No issue #
Tom Clegg [Thu, 12 Mar 2015 20:17:25 +0000 (16:17 -0400)]
Merge branch 'patch-1' from github.com/daftano. No issue #

9 years agoUse postgresql options to reduce questions
David [Thu, 12 Mar 2015 16:07:42 +0000 (17:07 +0100)]
Use postgresql options to reduce questions

-S set new role to not be a superuser
-R disable the creation of more new roles for the new role

9 years agocloses #5418
Radhika Chippada [Thu, 12 Mar 2015 16:07:35 +0000 (12:07 -0400)]
closes #5418
Merge branch '5418-brand-unclickable-anonymous'

9 years agoMerge branch 'master' into 5418-brand-unclickable-anonymous
Radhika Chippada [Thu, 12 Mar 2015 16:07:02 +0000 (12:07 -0400)]
Merge branch 'master' into 5418-brand-unclickable-anonymous

9 years ago5418: fix assert formatting
Radhika Chippada [Thu, 12 Mar 2015 16:05:33 +0000 (12:05 -0400)]
5418: fix assert formatting

9 years ago5207: Change expires_at column type from date to datetime.
Tom Clegg [Thu, 12 Mar 2015 15:42:26 +0000 (11:42 -0400)]
5207: Change expires_at column type from date to datetime.

9 years agoMerge branch '5104-ruby-sdk-collections-wip'
Brett Smith [Thu, 12 Mar 2015 15:35:35 +0000 (11:35 -0400)]
Merge branch '5104-ruby-sdk-collections-wip'

Closes #5104, #5423.

9 years ago5104: Add Collection class to the Ruby SDK.
Brett Smith [Sun, 8 Mar 2015 21:12:40 +0000 (17:12 -0400)]
5104: Add Collection class to the Ruby SDK.

This provides an interface to do filesystem-like operations on a tree
expressed in a manifest.  It currently supports copy, rename, and
remove operations, and will give us common ground for further work in
Ruby components.

9 years ago5104: Refactor Ruby SDK test infrastructure into sharable module.
Brett Smith [Thu, 5 Mar 2015 17:44:02 +0000 (12:44 -0500)]
5104: Refactor Ruby SDK test infrastructure into sharable module.

9 years ago5418: topnav brand name is clickable only when user is logged in.
Radhika Chippada [Thu, 12 Mar 2015 15:06:51 +0000 (11:06 -0400)]
5418: topnav brand name is clickable only when user is logged in.

9 years agoFix arv-normalize regression. refs #5145 refs #4823
Peter Amstutz [Thu, 12 Mar 2015 13:36:37 +0000 (09:36 -0400)]
Fix arv-normalize regression.  refs #5145 refs #4823

9 years agoUpdate prerequisites
David [Thu, 12 Mar 2015 09:36:37 +0000 (10:36 +0100)]
Update prerequisites

Remove sudo because to run sudo you should already have to have it installed
Add git to download sources from github

9 years agorefs #5145
Radhika Chippada [Wed, 11 Mar 2015 21:20:11 +0000 (17:20 -0400)]
refs #5145
Merge branch '5145-combine-collections-repeated-filenames'

9 years ago5145: include manifest text in assert error message to identify the cause of test...
Radhika Chippada [Wed, 11 Mar 2015 20:36:51 +0000 (16:36 -0400)]
5145: include manifest text in assert error message to identify the cause of test failure in jenkins.

9 years agocloses #5145
Radhika Chippada [Wed, 11 Mar 2015 18:41:09 +0000 (14:41 -0400)]
closes #5145
Merge branch '5145-combine-collections-repeated-filenames'

9 years agoA series of changes to the top nav bar to make it more compact.
Ward Vandewege [Wed, 11 Mar 2015 18:39:10 +0000 (14:39 -0400)]
A series of changes to the top nav bar to make it more compact.

Refs #5211

9 years agoMerge branch 'master' into 5145-combine-collections-repeated-filenames
Radhika Chippada [Wed, 11 Mar 2015 18:38:30 +0000 (14:38 -0400)]
Merge branch 'master' into 5145-combine-collections-repeated-filenames

9 years agocloses #4426
Radhika Chippada [Wed, 11 Mar 2015 18:29:36 +0000 (14:29 -0400)]
closes #4426
Merge branch '4426-search-documentation'

9 years agoMerge branch 'master' into 4426-search-documentation
Radhika Chippada [Wed, 11 Mar 2015 18:29:18 +0000 (14:29 -0400)]
Merge branch 'master' into 4426-search-documentation

9 years ago4426: Adjust styling for search button on search box
Peter Amstutz [Wed, 11 Mar 2015 18:43:49 +0000 (14:43 -0400)]
4426: Adjust styling for search button on search box

9 years ago4426: convert the search icon to a button
Radhika Chippada [Wed, 11 Mar 2015 18:04:08 +0000 (14:04 -0400)]
4426: convert the search icon to a button

9 years agoAdd missing re import to PySDK arvfile module.
Brett Smith [Wed, 11 Mar 2015 18:00:31 +0000 (14:00 -0400)]
Add missing re import to PySDK arvfile module.

No issue #.

9 years agoMerge branch 'master' into 4426-search-documentation
Radhika Chippada [Wed, 11 Mar 2015 17:39:08 +0000 (13:39 -0400)]
Merge branch 'master' into 4426-search-documentation

9 years ago4426: name attribute is needed for google search
Radhika Chippada [Wed, 11 Mar 2015 17:38:35 +0000 (13:38 -0400)]
4426: name attribute is needed for google search

9 years agoMerge branch 'master' into 5145-combine-collections-repeated-filenames
Radhika Chippada [Wed, 11 Mar 2015 16:07:41 +0000 (12:07 -0400)]
Merge branch 'master' into 5145-combine-collections-repeated-filenames

9 years ago5145: small updates
Radhika Chippada [Wed, 11 Mar 2015 16:07:28 +0000 (12:07 -0400)]
5145: small updates

9 years agocloses #5304
Radhika Chippada [Wed, 11 Mar 2015 15:53:07 +0000 (11:53 -0400)]
closes #5304
Merge branch '5304-include-nulls-when-notequal-filter'

9 years agoMerge branch 'master' into 5304-include-nulls-when-notequal-filter
Radhika Chippada [Wed, 11 Mar 2015 15:52:41 +0000 (11:52 -0400)]
Merge branch 'master' into 5304-include-nulls-when-notequal-filter

9 years agocloses #3761
Radhika Chippada [Wed, 11 Mar 2015 15:21:20 +0000 (11:21 -0400)]
closes #3761
Merge branch '3761-pull-list-worker'

9 years agoMerge branch 'master' into 5145-combine-collections-repeated-filenames
Radhika Chippada [Wed, 11 Mar 2015 15:14:00 +0000 (11:14 -0400)]
Merge branch 'master' into 5145-combine-collections-repeated-filenames

9 years ago3761: Expand DiscoverKeepServers method to return service_roots and use it in test
Radhika Chippada [Wed, 11 Mar 2015 14:13:57 +0000 (10:13 -0400)]
3761: Expand DiscoverKeepServers method to return service_roots and use it in test

9 years agoMerge branch 'master' into 3761-pull-list-worker
Radhika Chippada [Wed, 11 Mar 2015 13:32:21 +0000 (09:32 -0400)]
Merge branch 'master' into 3761-pull-list-worker

9 years ago3761: add a test with invalid data manager token and expect the item to be rejected.
Radhika Chippada [Wed, 11 Mar 2015 13:31:44 +0000 (09:31 -0400)]
3761: add a test with invalid data manager token and expect the item to be rejected.

9 years agoMerge branch 'master' into 4426-search-documentation
Radhika Chippada [Tue, 10 Mar 2015 22:08:49 +0000 (18:08 -0400)]
Merge branch 'master' into 4426-search-documentation

9 years ago4426: add google search in doc topnav
Radhika Chippada [Tue, 10 Mar 2015 22:08:16 +0000 (18:08 -0400)]
4426: add google search in doc topnav

9 years agoMerge branch '5182-cors-error-reporting' closes #5182
Tom Clegg [Tue, 10 Mar 2015 20:06:37 +0000 (16:06 -0400)]
Merge branch '5182-cors-error-reporting' closes #5182

9 years agoMerge branch '5073-docker-limitations' closes #5073
Tom Clegg [Tue, 10 Mar 2015 19:52:18 +0000 (15:52 -0400)]
Merge branch '5073-docker-limitations' closes #5073

9 years agoMerge branch '5105-ajax-redirect' closes #5105
Tom Clegg [Tue, 10 Mar 2015 19:46:26 +0000 (15:46 -0400)]
Merge branch '5105-ajax-redirect' closes #5105

9 years ago5182: Tweak error messages.
Tom Clegg [Tue, 10 Mar 2015 19:44:45 +0000 (15:44 -0400)]
5182: Tweak error messages.

9 years ago5105: Clarify "no double-layout" asserts. Remove redundant "not on welcome page"...
Tom Clegg [Tue, 10 Mar 2015 18:50:14 +0000 (14:50 -0400)]
5105: Clarify "no double-layout" asserts. Remove redundant "not on welcome page" asserts.

9 years ago5304: include nulls in resutls when filter operator is "!="
Radhika Chippada [Tue, 10 Mar 2015 18:44:50 +0000 (14:44 -0400)]
5304: include nulls in resutls when filter operator is "!="

9 years ago5073: Update ruby version to 2.1.5
Tom Clegg [Tue, 10 Mar 2015 18:24:04 +0000 (14:24 -0400)]
5073: Update ruby version to 2.1.5

9 years ago5073: Document docker limitations. Bring "overview" up to the top of the install...
Tom Clegg [Tue, 10 Mar 2015 18:23:44 +0000 (14:23 -0400)]
5073: Document docker limitations. Bring "overview" up to the top of the install section.

9 years ago5105: Better assertion for tab-loading error display.
Tom Clegg [Tue, 10 Mar 2015 15:40:22 +0000 (11:40 -0400)]
5105: Better assertion for tab-loading error display.

9 years ago5105: Restore previous token in an ensure block.
Tom Clegg [Tue, 10 Mar 2015 15:17:25 +0000 (11:17 -0400)]
5105: Restore previous token in an ensure block.