Brett Smith [Wed, 21 May 2014 18:32:03 +0000 (14:32 -0400)]
2764: Shrink footer text on Workbench collection download page.
Brett Smith [Wed, 21 May 2014 18:31:24 +0000 (14:31 -0400)]
2764: Workbench collection download page uses wget long options.
Brett Smith [Wed, 21 May 2014 17:30:15 +0000 (13:30 -0400)]
2764: Display Collection download files as a tree.
Brett Smith [Wed, 21 May 2014 17:30:05 +0000 (13:30 -0400)]
2753: Properly close entire Collection file tree in Workbench.
Brett Smith [Wed, 21 May 2014 17:15:12 +0000 (13:15 -0400)]
Merge branch 'master' into 2764-wget-collections-wip
Brett Smith [Wed, 21 May 2014 16:04:00 +0000 (12:04 -0400)]
Merge branch '2753-collection-tree-view'
Closes #2777, #2828, #2753.
Brett Smith [Wed, 21 May 2014 14:27:10 +0000 (10:27 -0400)]
2753: Add space between Workspace file tree buttons and scrollbar.
Brett Smith [Wed, 21 May 2014 14:19:55 +0000 (10:19 -0400)]
2753: Move file tree CSS to collections.css.
Brett Smith [Wed, 21 May 2014 14:17:29 +0000 (10:17 -0400)]
2753: Refactor Collection view to use library CSS.
Brett Smith [Wed, 21 May 2014 14:07:28 +0000 (10:07 -0400)]
2753: Replace Workbench file tree backgrounds with hover effect.
Based on feedback from Tom in refs #2753. I'm still concerned about
users being able to line up buttons with filenames, so the highlight
on :hover is intended to help with that.
Brett Smith [Thu, 15 May 2014 14:55:47 +0000 (10:55 -0400)]
2753: Workbench shows Collection files in a tree.
Brett Smith [Tue, 13 May 2014 21:31:29 +0000 (17:31 -0400)]
2753: Workbench renders "0 bytes" for empty file sizes.
Brett Smith [Mon, 12 May 2014 21:29:55 +0000 (17:29 -0400)]
2753: Add Workbench Collection#files_tree.
Brett Smith [Mon, 12 May 2014 15:21:12 +0000 (11:21 -0400)]
2753: Add tests for CollectionsHelper.file_path.
Brett Smith [Mon, 12 May 2014 14:37:55 +0000 (10:37 -0400)]
2753: Make Collection filenames with existing helper.
This is pure refactoring to make the code more consistent.
Ward Vandewege [Wed, 21 May 2014 15:42:05 +0000 (11:42 -0400)]
Add some basic request logging to Keep.
Brett Smith [Wed, 21 May 2014 15:35:00 +0000 (11:35 -0400)]
Merge branch 'master' into 2764-wget-collections-wip
Conflicts:
apps/workbench/test/functional/collections_controller_test.rb
Brett Smith [Wed, 21 May 2014 15:30:44 +0000 (11:30 -0400)]
2764: Add information to the Collection download page.
Brett Smith [Tue, 20 May 2014 19:50:48 +0000 (15:50 -0400)]
Merge branch '2753-collection-metadata'
Closes #2780, #2837.
Brett Smith [Mon, 19 May 2014 16:07:18 +0000 (12:07 -0400)]
2753: Show immediate relations on Workbench Collection page.
This concept and implementation borrows a lot from the new folder UI.
Brett Smith [Mon, 19 May 2014 15:22:48 +0000 (11:22 -0400)]
2753: Move Workbench object list rendering to application_helper.
I would like to be able to reuse this functionality in the upcoming
Collections view.
Brett Smith [Mon, 19 May 2014 14:14:24 +0000 (10:14 -0400)]
2753: Add event_at data to Log fixtures.
Brett Smith [Fri, 16 May 2014 17:33:57 +0000 (13:33 -0400)]
2753: Remove older, unused Workbench provenance code.
I do not see any code that would directly render these partials;
they're not indirectly referenced in the pane list; and I can remove
the controller code and run all our tests without tripping on a
NoMethodError exception from a nil.
Peter Amstutz [Tue, 20 May 2014 19:44:59 +0000 (15:44 -0400)]
2764: Fixed active_all_collections scoped token to be able to access
keep_disks. Also some minor code cleanup in FileStreamer.
Brett Smith [Tue, 20 May 2014 19:15:11 +0000 (15:15 -0400)]
2764: Reset browser session between Workbench integration tests.
Peter and I just debugged an issue where a test was falsely passing
because the session had authorization state in it. This prevents it
from passing.
Brett Smith [Tue, 20 May 2014 19:03:27 +0000 (15:03 -0400)]
Merge branch 'master' into 2764-wget-collections-wip
Peter Amstutz [Tue, 20 May 2014 19:00:42 +0000 (15:00 -0400)]
2764: Fixed scopes_allow_request to use request.request_method (the effective
HTTP method) instead of request.method (the actual HTTP method) because
workbench uses POST even for GET.
Tom Clegg [Mon, 19 May 2014 20:50:19 +0000 (16:50 -0400)]
Fix crash when saving api_client_authorization during migration.
Tom Clegg [Mon, 19 May 2014 18:57:37 +0000 (14:57 -0400)]
2352: Reset column information between adding a new serialized
attribute and using the model. Otherwise, Rails (4) fails to validate
the serialized attribute.
Tom Clegg [Mon, 19 May 2014 16:21:56 +0000 (12:21 -0400)]
Prevent admin from creating an object with empty string as UUID.
Tom Clegg [Fri, 16 May 2014 19:28:20 +0000 (15:28 -0400)]
2809: Fix arvados_api_client usage in FileStreamer. refs #2809
Tom Clegg [Fri, 16 May 2014 14:57:32 +0000 (10:57 -0400)]
Remove debug log message. refs #1969
Tom Clegg [Fri, 16 May 2014 00:44:28 +0000 (20:44 -0400)]
2809: Fix disappearing ArvadosApiClient in development mode. refs #2809
Tom Clegg [Thu, 15 May 2014 21:14:15 +0000 (17:14 -0400)]
2755: Defer to CollectionReader to get manifests instead of going
directly to Keep (which only works when Keep has no permission
checks).
refs #2755
Ward Vandewege [Thu, 15 May 2014 21:11:08 +0000 (17:11 -0400)]
Merge branch '0000-arv-mount-bugfixes'
This closes #2831
Ward Vandewege [Thu, 15 May 2014 20:47:42 +0000 (16:47 -0400)]
CollectionReader can throw exceptions (for example, when passing an
argument that is not a manifest or collection UUID). Trap those and
print an error message, instead blowing up the fuse driver.
Brett Smith [Thu, 15 May 2014 20:38:12 +0000 (16:38 -0400)]
2764: Add wget-friendly Collections file page.
This new route will become the way you share authless Collection links
with others. They can pass it to `wget -r` to download the whole
collection, nicely organized, with nothing extraneous. Since it
doesn't try to load user information or look up related Arvados items,
it can be rendered using an API token with a very narrow scope.
Because wget respects robots.txt, this branch stops using that in
favor of the corresponding <meta> tag. The new view only limits
indexing, so wget can follow the links on the page.
Refs #2764.
Brett Smith [Thu, 15 May 2014 19:54:32 +0000 (15:54 -0400)]
2764: Introduce show_file_links route.
Right now this just takes advantage of the provided reader token, but
we're going to extend it to provide a wget-friendly view.
Brett Smith [Thu, 15 May 2014 19:39:16 +0000 (15:39 -0400)]
2765: Tear out general Workbench reader_tokens support.
Refs #2765. This approach is not tenable in its current form, and the
callbacks are making further development confusing, so I'm getting rid
of them.
Brett Smith [Tue, 6 May 2014 15:30:58 +0000 (11:30 -0400)]
1904: Make Keep file EPERM test stricter.
Refs #1904. Tom said that we want the security benefits of a 404
result, so make sure that's exactly what we get.
Ward Vandewege [Thu, 15 May 2014 20:18:38 +0000 (16:18 -0400)]
In daemon mode, arv-mount should set up the fuse connection before
forking to the background, so that any failures to set up are reported
to the user.
Tom Clegg [Thu, 15 May 2014 18:19:32 +0000 (14:19 -0400)]
2809: Merge branch '2809-workbench-rails4' refs #2809
Tom Clegg [Thu, 15 May 2014 18:19:06 +0000 (14:19 -0400)]
2809: Merge branch 'master' into 2809-workbench-rails4 refs #2809
Conflicts:
apps/workbench/app/models/arvados_api_client.rb
Tom Clegg [Thu, 15 May 2014 16:30:25 +0000 (12:30 -0400)]
2809: Move coffee-rails out of :assets section to make tests thread-safe.
Otherwise, when Rails decides to build assets while running the test
suite, we get:
WARN: tilt autoloading 'coffee_script' in a non thread-safe way; explicit require 'coffee_script' suggested.
Tom Clegg [Thu, 15 May 2014 16:26:10 +0000 (12:26 -0400)]
2809: Remove javascript and coffeescript boilerplate.
Tom Clegg [Wed, 14 May 2014 22:00:09 +0000 (18:00 -0400)]
2809: Remove some unnecessary sleep(0.1).
Tom Clegg [Wed, 14 May 2014 21:56:59 +0000 (17:56 -0400)]
2809: Rearrange "run API server during tests" to suit Minitest 5.
Also, use passenger instead of webrick.
Tom Clegg [Wed, 14 May 2014 20:35:39 +0000 (16:35 -0400)]
2809: Upgrade to Rails 4.1
Tom Clegg [Wed, 14 May 2014 18:21:05 +0000 (14:21 -0400)]
2809: Add wait_for_ajax after submitting forms, to avoid race condition.
Tom Clegg [Wed, 14 May 2014 17:26:42 +0000 (13:26 -0400)]
2809: Remove debug printfs, add comment explaining why so much "permit!"
Tom Clegg [Wed, 14 May 2014 17:25:24 +0000 (13:25 -0400)]
2809: Add note about harmless warning when installing the themes_for_rails gem.
Tom Clegg [Wed, 14 May 2014 17:08:04 +0000 (13:08 -0400)]
2809: Fix whitespace.
Tom Clegg [Sat, 10 May 2014 00:29:09 +0000 (20:29 -0400)]
2809: Turn off secret_key_base by default, instead of requiring it in config.
Tom Clegg [Sat, 10 May 2014 00:28:40 +0000 (20:28 -0400)]
2809: Fix load_config so it loads in time to set passenger configs.
Tom Clegg [Fri, 9 May 2014 18:38:39 +0000 (14:38 -0400)]
2809: Merge branch 'master' refs #2809
Conflicts:
apps/workbench/Gemfile.lock
apps/workbench/app/controllers/application_controller.rb
apps/workbench/app/models/arvados_api_client.rb
apps/workbench/app/models/group.rb
apps/workbench/app/models/user.rb
apps/workbench/app/views/layouts/application.html.erb
Tom Clegg [Thu, 15 May 2014 15:33:20 +0000 (11:33 -0400)]
2756: Fix "duplicate tab" behavior in Chrome.
Tom Clegg [Thu, 15 May 2014 15:09:43 +0000 (11:09 -0400)]
2756: Fix ajax refresh on pipeline instance page.
Tom Clegg [Wed, 14 May 2014 22:07:40 +0000 (18:07 -0400)]
Merge branch '2762-owner-uuid-integrity'
closes #2762
Tom Clegg [Wed, 14 May 2014 22:02:51 +0000 (18:02 -0400)]
2762: Merge branch 'master' into 2762-owner-uuid-integrity
Misha Zatsman [Wed, 14 May 2014 19:19:35 +0000 (19:19 +0000)]
Merge branch 'master' of git.curoverse.com:arvados
Tom Clegg [Wed, 14 May 2014 18:05:15 +0000 (14:05 -0400)]
2762: Fix wrong class used in test case.
Tom Clegg [Wed, 14 May 2014 18:04:44 +0000 (14:04 -0400)]
2762: Finish enigmatic comment.
Tom Clegg [Wed, 14 May 2014 18:04:20 +0000 (14:04 -0400)]
2762: Move destroy_permission_links method to HasUuid.
Tim Pierce [Wed, 14 May 2014 17:02:30 +0000 (13:02 -0400)]
2328: fix log.Warning bug
oops.
Tim Pierce [Wed, 14 May 2014 16:24:46 +0000 (12:24 -0400)]
Merge branch '2328-keep-permission-flags' (closes #2328)
Misha Zatsman [Wed, 14 May 2014 00:58:43 +0000 (00:58 +0000)]
Merge branch '1968-monitor-disk-usage'
Lots of changes to datamanager. refs #2719
Tim Pierce [Wed, 14 May 2014 05:15:38 +0000 (01:15 -0400)]
2328: code review comments.
Misha Zatsman [Wed, 14 May 2014 00:54:18 +0000 (00:54 +0000)]
Reversed histogram format, so timestamps come first.
Tom Clegg [Tue, 13 May 2014 19:21:10 +0000 (15:21 -0400)]
Really write log messages to logfile. refs #2221 commit:
ced5e21
Tom Clegg [Tue, 13 May 2014 18:45:42 +0000 (14:45 -0400)]
Fix job state cleanup in crunch-job failure case.
Tom Clegg [Tue, 13 May 2014 18:36:50 +0000 (14:36 -0400)]
2673: Use _method=GET hack to avoid combining request body with GET
method (but still support parameters too long to fit in a query
string).
Tim Pierce [Tue, 13 May 2014 18:25:37 +0000 (14:25 -0400)]
2328: more 80-column fixes
Tim Pierce [Tue, 13 May 2014 18:05:45 +0000 (14:05 -0400)]
2328: incorporate code review comments.
Wrap very long lines to 80 columns.
Describe each test failure more explicitly.
TestIndexHandler: Add /index/prefix tests for unauthenticated and
authenticated non-superusers.
TestGetHandler: initialize all variables in one var block.
main: failure to read permission key or data manager token is now a
fatal error.
Tom Clegg [Tue, 13 May 2014 17:37:17 +0000 (13:37 -0400)]
Specify required ruby version (>= 2.1.0) in gems.
Tom Clegg [Tue, 13 May 2014 17:30:31 +0000 (13:30 -0400)]
2673: Update bundle to ensure we get commit:
67f1781 at runtime.
Tom Clegg [Tue, 13 May 2014 17:13:58 +0000 (13:13 -0400)]
2673: Move auth to headers, avoid combining request body with GET method.
Tom Clegg [Tue, 13 May 2014 16:49:20 +0000 (12:49 -0400)]
2821: Add "delete" button to pipeline instances page. closes #2821
Tom Clegg [Tue, 13 May 2014 16:44:04 +0000 (12:44 -0400)]
2673: Update bundle to ensure we get commit:
7ff8586 at runtime.
Tom Clegg [Tue, 13 May 2014 14:13:45 +0000 (10:13 -0400)]
2638: Fix css syntax.
Tom Clegg [Mon, 12 May 2014 19:37:24 +0000 (15:37 -0400)]
Add self-signed.{key,pem} to .gitignore files.
Tom Clegg [Mon, 12 May 2014 19:28:58 +0000 (15:28 -0400)]
Merge branch '2673-no-request-body-in-get'
closes #2673
Tom Clegg [Mon, 12 May 2014 19:01:37 +0000 (15:01 -0400)]
2673: Move auth to headers, avoid combining request body with GET method.
Tom Clegg [Mon, 12 May 2014 17:43:09 +0000 (13:43 -0400)]
2754: Hide unhelpful "Add a new job" button.
Tom Clegg [Mon, 12 May 2014 17:36:43 +0000 (13:36 -0400)]
2812: Fix "not in" filter so it can retrieve rows with null values.
closes #2812
radhika [Mon, 12 May 2014 17:11:15 +0000 (13:11 -0400)]
Merge branch 'master' into 2352-remove-attrs
Tom Clegg [Mon, 12 May 2014 14:41:17 +0000 (10:41 -0400)]
2808: Fix paging on jobs, pipeline_instances, api_client_authorizations.
Restore Jobs link to left nav.
closes #2808
radhika [Mon, 12 May 2014 00:29:29 +0000 (20:29 -0400)]
Merge branch 'master' into 2352-remove-attrs
Tom Clegg [Sun, 11 May 2014 20:30:53 +0000 (16:30 -0400)]
Merge branch 'master' into 2762-owner-uuid-integrity
Tom Clegg [Sun, 11 May 2014 20:24:25 +0000 (16:24 -0400)]
2756: Use site-default x-editable mode for pipeline instance name.
Inline mode avoided an "editable popup hides behind left nav" bug
which was fixed in
c66afecd36cf7d91223b5db79f3e120954f8217d.
Tom Clegg [Sun, 11 May 2014 07:02:57 +0000 (03:02 -0400)]
2762: Rename assign_uuid to has_uuid to reflect expanded scope.
Tom Clegg [Sun, 11 May 2014 06:55:45 +0000 (02:55 -0400)]
2762: When deleting an object, delete permissions and fail if other
links would be left dangling.
Tom Clegg [Sat, 10 May 2014 18:55:57 +0000 (14:55 -0400)]
2762: Test assigning random non-existent owner_uuids to new objects.
Tom Clegg [Sat, 10 May 2014 18:34:32 +0000 (14:34 -0400)]
2762: Protect owner_uuid referential integrity when changing uuids and
deleting users and groups.
radhika [Sat, 10 May 2014 18:26:31 +0000 (14:26 -0400)]
2352: log statement to include uuid if either active or success found in changed attributes.
Tim Pierce [Sat, 10 May 2014 03:12:18 +0000 (23:12 -0400)]
2328: restrict all /index requests to superuser
Per discussion with Tom on IRC: all /index requests, whether they
include a prefix argument or not, should be restricted to the superuser.
radhika [Sat, 10 May 2014 03:00:23 +0000 (23:00 -0400)]
2352: Address review feedback: (1) input can be edited even in Ready state, (2) pipeline cleanup to set state to Paused if RunningOnClient.
radhika [Sat, 10 May 2014 00:22:26 +0000 (20:22 -0400)]
Merge branch 'master' into 2352-remove-attrs
Brett Smith [Fri, 9 May 2014 21:35:32 +0000 (17:35 -0400)]
2803: Make all Python required versions match wheezy.
Brett Smith [Fri, 9 May 2014 21:06:16 +0000 (17:06 -0400)]
2803: Further relax Python SDK requirement for httplib2.
Our build server is using version 0.7.4, so it's apparently fine.
Brett Smith [Fri, 9 May 2014 20:51:17 +0000 (16:51 -0400)]
Merge branch '2803-python-package-split-wip'
Closes #2803, #2804.