arvados.git
9 years agoMerge branch 'master' into 2492-docker-crunch-jobs 2492-docker-crunch-jobs
Brett Smith [Wed, 7 May 2014 12:18:42 +0000 (08:18 -0400)]
Merge branch 'master' into 2492-docker-crunch-jobs

9 years agocrunch: `docker.io pull` can't take a hash.
Brett Smith [Wed, 7 May 2014 12:18:25 +0000 (08:18 -0400)]
crunch: `docker.io pull` can't take a hash.

Refs #2942.  Like I said in my recent comments there, this pull
functionality is a bit of a stopgap.  I could make this more robust
by, e.g., checking ahead of time that the hash image is already
installed on all nodes, but I expect that work will be completely
replaced when we integrate Docker and Keep.

9 years agoRefuse to run rake tasks without "bundle exec".
Tom Clegg [Wed, 7 May 2014 03:15:40 +0000 (23:15 -0400)]
Refuse to run rake tasks without "bundle exec".

Otherwise you can accidentally load (or dump) schemas without having
the pg_power gem loaded, which will leave you with incorrect indexes
in your database (or schema.rb).

9 years agoFix crash creating new user during initial login. Add test.
Tom Clegg [Wed, 7 May 2014 01:46:04 +0000 (21:46 -0400)]
Fix crash creating new user during initial login. Add test.

9 years agoAdd wait_for_ajax after using x-editable in tests.
Tom Clegg [Tue, 6 May 2014 22:27:01 +0000 (18:27 -0400)]
Add wait_for_ajax after using x-editable in tests.

9 years agoFix dead links
Tom Clegg [Tue, 6 May 2014 21:28:12 +0000 (17:28 -0400)]
Fix dead links

9 years agoMerge branch '2733-coverage-report'
Tom Clegg [Tue, 6 May 2014 20:54:12 +0000 (16:54 -0400)]
Merge branch '2733-coverage-report'

closes #2733

9 years agoFix copy/paste error in gem build instructions.
Tom Clegg [Tue, 6 May 2014 19:53:10 +0000 (15:53 -0400)]
Fix copy/paste error in gem build instructions.

9 years agoRemove Gemfile.lock from repo
Tom Clegg [Tue, 6 May 2014 19:52:10 +0000 (15:52 -0400)]
Remove Gemfile.lock from repo

see http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

9 years agoRemove stray debug puts.
Tom Clegg [Tue, 6 May 2014 17:10:05 +0000 (13:10 -0400)]
Remove stray debug puts.

9 years agoMerge branch '1970-folder-view'
Tom Clegg [Tue, 6 May 2014 17:01:44 +0000 (13:01 -0400)]
Merge branch '1970-folder-view'

closes #1970

9 years agoMerge branch 'master' into 1970-folder-view
Tom Clegg [Tue, 6 May 2014 17:01:34 +0000 (13:01 -0400)]
Merge branch 'master' into 1970-folder-view

9 years agoAdd find?() method so "assert find?(...), msg" can be used in test cases.
Tom Clegg [Tue, 6 May 2014 16:58:14 +0000 (12:58 -0400)]
Add find?() method so "assert find?(...), msg" can be used in test cases.

9 years agoReplace unfailable assert() with a comment explaining what it means
Tom Clegg [Tue, 6 May 2014 16:37:29 +0000 (12:37 -0400)]
Replace unfailable assert() with a comment explaining what it means
for find() to raise an exception.

9 years agocrunch-job: Ignore empty docker_image constraint.
Brett Smith [Tue, 6 May 2014 14:25:43 +0000 (10:25 -0400)]
crunch-job: Ignore empty docker_image constraint.

9 years agodocker: Don't set up FUSE inside arvados/jobs.
Brett Smith [Tue, 6 May 2014 14:17:42 +0000 (10:17 -0400)]
docker: Don't set up FUSE inside arvados/jobs.

Now that we expect crunch-job to expose the Keep mount to containers
as a volume, there's no general need to make FUSE mounts from inside
the container.  This commit removes that setup from the image, which
makse the build process a lot less hairy.

9 years agoMerge branch 'master' into 2492-docker-crunch-jobs
Brett Smith [Tue, 6 May 2014 13:38:00 +0000 (09:38 -0400)]
Merge branch 'master' into 2492-docker-crunch-jobs

10 years agoFix so that a present but empty select parameter in queries no longer yields
Peter Amstutz [Tue, 6 May 2014 01:24:45 +0000 (21:24 -0400)]
Fix so that a present but empty select parameter in queries no longer yields
an error.

10 years agoRemove duplicate ERROR_ACTIONS constant from merge.
Tom Clegg [Tue, 6 May 2014 00:31:45 +0000 (20:31 -0400)]
Remove duplicate ERROR_ACTIONS constant from merge.

10 years agoEnsure edited description really gets saved.
Tom Clegg [Tue, 6 May 2014 00:31:18 +0000 (20:31 -0400)]
Ensure edited description really gets saved.

10 years agoUse send(symbol) instead of send(string).
Tom Clegg [Tue, 6 May 2014 00:22:38 +0000 (20:22 -0400)]
Use send(symbol) instead of send(string).

10 years agoChange icon for virtual machines nav.
Tom Clegg [Tue, 6 May 2014 00:21:08 +0000 (20:21 -0400)]
Change icon for virtual machines nav.

10 years agoRemove confusing return value.
Tom Clegg [Tue, 6 May 2014 00:20:46 +0000 (20:20 -0400)]
Remove confusing return value.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Mon, 5 May 2014 22:33:04 +0000 (18:33 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

Conflicts:
apps/workbench/app/controllers/application_controller.rb
services/api/app/controllers/application_controller.rb

10 years agoMove contents action to GroupsController.
Tom Clegg [Mon, 5 May 2014 21:30:11 +0000 (17:30 -0400)]
Move contents action to GroupsController.

10 years agoFix broken test case.
Tom Clegg [Mon, 5 May 2014 21:24:10 +0000 (17:24 -0400)]
Fix broken test case.

10 years agoMerge branch 'master' of git.curoverse.com:arvados
Ward Vandewege [Mon, 5 May 2014 21:09:43 +0000 (17:09 -0400)]
Merge branch 'master' of git.curoverse.com:arvados

10 years agoDocumentation tweaks:
Ward Vandewege [Mon, 5 May 2014 21:06:01 +0000 (17:06 -0400)]
Documentation tweaks:
* Python SDK requires Python 2.7, make that clear up front
* Remove duplicated SDK installation instructions

10 years agoMerge branch '2640-folder-api'
Tom Clegg [Mon, 5 May 2014 21:02:37 +0000 (17:02 -0400)]
Merge branch '2640-folder-api'

10 years agoMerge branch 'master' into 2640-folder-api
Tom Clegg [Mon, 5 May 2014 21:01:50 +0000 (17:01 -0400)]
Merge branch 'master' into 2640-folder-api

Conflicts:
apps/workbench/app/models/arvados_api_client.rb

10 years agoRaise PermissionDeniedError even more consistently
Tom Clegg [Mon, 5 May 2014 20:55:19 +0000 (16:55 -0400)]
Raise PermissionDeniedError even more consistently

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Mon, 5 May 2014 20:14:34 +0000 (16:14 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoRaise PermissionDeniedError more consistently
Tom Clegg [Mon, 5 May 2014 20:05:22 +0000 (16:05 -0400)]
Raise PermissionDeniedError more consistently

10 years agoComment mysterious testing code.
Tom Clegg [Mon, 5 May 2014 20:02:29 +0000 (16:02 -0400)]
Comment mysterious testing code.

10 years agoAdd test for links_for + multiple link_classes.
Tom Clegg [Mon, 5 May 2014 19:59:44 +0000 (15:59 -0400)]
Add test for links_for + multiple link_classes.

10 years agoMerge branch '1904-workbench-reader-tokens'
Brett Smith [Mon, 5 May 2014 19:20:45 +0000 (15:20 -0400)]
Merge branch '1904-workbench-reader-tokens'

Refs #1904.  Closes #2663, #2736.

10 years agoworkbench: Reader tokens show collection files.
Brett Smith [Mon, 5 May 2014 16:55:29 +0000 (12:55 -0400)]
workbench: Reader tokens show collection files.

Fundamentally, this commit aims to support reader tokens when showing
a file from a Collection.  Because this requires changing the token
handling generally, I also took this opportunity to improve error
reporting by checking the request's validity against the API server
before we pipe out to arv-get to render the file.

As a consequence, Workbench now returns a 404 if you request a file
using a token that does not have permission to read the collection.
Maybe this is not the best result, but previously it returned a 422,
so I think this counts as an improvement.

10 years agoworkbench: Add initial reader tokens support.
Brett Smith [Mon, 5 May 2014 14:54:53 +0000 (10:54 -0400)]
workbench: Add initial reader tokens support.

The API server recently gained support for reader tokens, which
optionally supplement the user's permissions for read-only
operations.  This commit extends Workbench to pass on reader tokens
for general index and show operations.

10 years agoworkbench: Add Collections controller tests.
Brett Smith [Wed, 30 Apr 2014 14:38:08 +0000 (10:38 -0400)]
workbench: Add Collections controller tests.

Working to establish a baseline of behavior before I go mucking with
this.

10 years agoworkbench: Remove trailing whitespace.
Brett Smith [Thu, 1 May 2014 14:42:33 +0000 (10:42 -0400)]
workbench: Remove trailing whitespace.

10 years agoMerge branch '2328-keep-permission-hints'
Tim Pierce [Mon, 5 May 2014 18:03:10 +0000 (14:03 -0400)]
Merge branch '2328-keep-permission-hints'

10 years agoResolve code review (closes #2328)
Tim Pierce [Mon, 5 May 2014 17:52:06 +0000 (13:52 -0400)]
Resolve code review (closes #2328)

Fix doc comments and argument names for the expiry timestamp arguments
for SignLocator and makePermSignature.

10 years agoAdd simplecov-rcov.
Tom Clegg [Mon, 5 May 2014 17:30:37 +0000 (13:30 -0400)]
Add simplecov-rcov.

10 years agodoc: Document docker_image constraint for Jobs.
Brett Smith [Mon, 5 May 2014 13:41:45 +0000 (09:41 -0400)]
doc: Document docker_image constraint for Jobs.

10 years agoMerge branch 'master' into 2492-docker-crunch-jobs
Brett Smith [Mon, 5 May 2014 13:34:35 +0000 (09:34 -0400)]
Merge branch 'master' into 2492-docker-crunch-jobs

10 years agoFix ajax->refresh race condition in test case.
Tom Clegg [Mon, 5 May 2014 10:58:54 +0000 (06:58 -0400)]
Fix ajax->refresh race condition in test case.

10 years agoFix tests, make model.editable? work for new records.
Tom Clegg [Mon, 5 May 2014 10:32:27 +0000 (06:32 -0400)]
Fix tests, make model.editable? work for new records.

10 years agoBehave nicer if supplied owner_uuid is not a valid uuid at all.
Tom Clegg [Mon, 5 May 2014 10:08:30 +0000 (06:08 -0400)]
Behave nicer if supplied owner_uuid is not a valid uuid at all.

10 years agoEdit objects after creating them with x-editable.
Tom Clegg [Mon, 5 May 2014 10:06:16 +0000 (06:06 -0400)]
Edit objects after creating them with x-editable.

10 years agoImplement simple client-side folder contents search.
Tom Clegg [Mon, 5 May 2014 08:01:48 +0000 (04:01 -0400)]
Implement simple client-side folder contents search.

10 years agoImplement "remove from folder"
Tom Clegg [Mon, 5 May 2014 07:47:50 +0000 (03:47 -0400)]
Implement "remove from folder"

10 years agoName new folders "New folder", fix crash if folder name is nil
Tom Clegg [Mon, 5 May 2014 07:25:53 +0000 (03:25 -0400)]
Name new folders "New folder", fix crash if folder name is nil

10 years agoUpdate name in breadcrumb after editing elsewhere on page.
Tom Clegg [Mon, 5 May 2014 07:21:09 +0000 (03:21 -0400)]
Update name in breadcrumb after editing elsewhere on page.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Mon, 5 May 2014 06:51:30 +0000 (02:51 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoOmit locally configurable files and testing code from coverage report
Tom Clegg [Mon, 5 May 2014 02:23:51 +0000 (22:23 -0400)]
Omit locally configurable files and testing code from coverage report

10 years agoSkip simplecov if gem fails to load or NO_COVERAGE_TEST env is set.
Tom Clegg [Mon, 5 May 2014 02:02:08 +0000 (22:02 -0400)]
Skip simplecov if gem fails to load or NO_COVERAGE_TEST env is set.

10 years agoDo not try to record object_owner_uuid during earlier migrations.
Tom Clegg [Sun, 4 May 2014 18:49:11 +0000 (14:49 -0400)]
Do not try to record object_owner_uuid during earlier migrations.

10 years agoMerge branch 'master' into 2640-folder-api
Tom Clegg [Sun, 4 May 2014 01:25:19 +0000 (21:25 -0400)]
Merge branch 'master' into 2640-folder-api

10 years agoFix crashing "grant access to my own object" permission check.
Tom Clegg [Sun, 4 May 2014 01:22:17 +0000 (21:22 -0400)]
Fix crashing "grant access to my own object" permission check.

10 years agoPrevent ownership cycles.
Tom Clegg [Sun, 4 May 2014 01:08:18 +0000 (21:08 -0400)]
Prevent ownership cycles.

10 years agoGenerate test coverage reports with SimpleCov.
Tom Clegg [Sat, 3 May 2014 04:44:12 +0000 (00:44 -0400)]
Generate test coverage reports with SimpleCov.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Sat, 3 May 2014 03:20:56 +0000 (23:20 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoImprove code formatting
Tom Clegg [Sat, 3 May 2014 00:00:04 +0000 (20:00 -0400)]
Improve code formatting

10 years agoReturn all links if link_class is not provided. Add docs.
Tom Clegg [Fri, 2 May 2014 23:45:16 +0000 (19:45 -0400)]
Return all links if link_class is not provided. Add docs.

10 years agoReturn empty list if no "links" supplied in api response. Add tests.
Tom Clegg [Fri, 2 May 2014 23:41:23 +0000 (19:41 -0400)]
Return empty list if no "links" supplied in api response. Add tests.

10 years agoIncorporating code review. (refs #2328)
Tim Pierce [Fri, 2 May 2014 22:26:08 +0000 (18:26 -0400)]
Incorporating code review. (refs #2328)

10 years agoarv-mount: Add --allow-other option.
Brett Smith [Fri, 2 May 2014 21:46:19 +0000 (17:46 -0400)]
arv-mount: Add --allow-other option.

We need this to support running job tasks in Docker containers.  We
rely on the allow_other mount option to make the Keep mount available
to the container.

10 years agocrunch-job: Manually configure containers' DNS.
Brett Smith [Fri, 2 May 2014 21:27:51 +0000 (17:27 -0400)]
crunch-job: Manually configure containers' DNS.

All the compute nodes run dnsmasq to enable friendly names for
different hosts on the private Arvados network.  Crunch jobs will need
to talk to that DNS server to reach, e.g., the local Keep servers.
This makes that happen.

10 years agoMerge branch '2223-repo-owner-admin-perms'
Tom Clegg [Fri, 2 May 2014 20:27:18 +0000 (16:27 -0400)]
Merge branch '2223-repo-owner-admin-perms'

closes #2223

10 years agoAdd "remove item from folder" buttons
Tom Clegg [Fri, 2 May 2014 20:26:47 +0000 (16:26 -0400)]
Add "remove item from folder" buttons

10 years agoAdd writable_by to Group API response.
Tom Clegg [Fri, 2 May 2014 20:26:37 +0000 (16:26 -0400)]
Add writable_by to Group API response.

10 years agoMerge branch 'query-select-distinct'
Peter Amstutz [Fri, 2 May 2014 20:16:16 +0000 (16:16 -0400)]
Merge branch 'query-select-distinct'

10 years agoRestored support for old-style 'order' strings and added test. Clarified
Peter Amstutz [Fri, 2 May 2014 20:10:10 +0000 (16:10 -0400)]
Restored support for old-style 'order' strings and added test.  Clarified
documentation for 'distinct' as to the default behavior.

10 years agoFixed botched 'distinct' parameter, now is a boolean instead of taking a
Peter Amstutz [Fri, 2 May 2014 19:54:45 +0000 (15:54 -0400)]
Fixed botched 'distinct' parameter, now is a boolean instead of taking a
column.  New tests.  Also changed syntax of 'order' to take a JSON array for
consistency with 'filters' and 'select'.

10 years agoUpdate docs. (refs #2328)
Tim Pierce [Fri, 2 May 2014 19:09:46 +0000 (15:09 -0400)]
Update docs. (refs #2328)

10 years agoAdded permission helper functions.
Tim Pierce [Fri, 2 May 2014 19:05:07 +0000 (15:05 -0400)]
Added permission helper functions.

GeneratePerms returns a string representing the signed permission hint
for the blob identified by blob_hash, api_token and timestamp.

SignLocator takes a blob_locator, an api_token and a timestamp, and
returns a signed locator string.

VerifySignature returns true if the signature on the signed_locator can
be verified using the given api_token.

Refs #2328.

10 years agoUnify button styles.
Tom Clegg [Fri, 2 May 2014 18:22:21 +0000 (14:22 -0400)]
Unify button styles.

10 years agoAdd shadow to left nav.
Tom Clegg [Fri, 2 May 2014 17:34:30 +0000 (13:34 -0400)]
Add shadow to left nav.

10 years agoTake into account owner_uuid and is_admin when exporting repository permissions.
Tom Clegg [Fri, 2 May 2014 16:19:42 +0000 (12:19 -0400)]
Take into account owner_uuid and is_admin when exporting repository permissions.

10 years agoMerge branch 'master' into 2492-docker-crunch-jobs
Brett Smith [Fri, 2 May 2014 15:18:19 +0000 (11:18 -0400)]
Merge branch 'master' into 2492-docker-crunch-jobs

10 years agocrunch-job: Install Docker images on demand.
Brett Smith [Fri, 2 May 2014 15:18:02 +0000 (11:18 -0400)]
crunch-job: Install Docker images on demand.

10 years agoFix name_for method name.
Tom Clegg [Fri, 2 May 2014 14:34:10 +0000 (10:34 -0400)]
Fix name_for method name.

10 years agoFix crash if item has no name (backported from 1970-folder-view)
Tom Clegg [Fri, 2 May 2014 14:32:52 +0000 (10:32 -0400)]
Fix crash if item has no name (backported from 1970-folder-view)

10 years agoFix for interaction between 'select' and 'order' (SQL requires that order
Peter Amstutz [Fri, 2 May 2014 14:12:25 +0000 (10:12 -0400)]
Fix for interaction between 'select' and 'order' (SQL requires that order
fields show up in select when doing select distinct; readable_by does 'select distinct' by default to avoid duplicate rows).

10 years agoUse class_for_display more.
Tom Clegg [Fri, 2 May 2014 02:58:20 +0000 (22:58 -0400)]
Use class_for_display more.

10 years agoAdd folder list to left nav.
Tom Clegg [Fri, 2 May 2014 02:54:40 +0000 (22:54 -0400)]
Add folder list to left nav.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Fri, 2 May 2014 02:24:06 +0000 (22:24 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoAdd "Copy selections to current folder" button to selection drop-down.
Tom Clegg [Fri, 2 May 2014 02:23:57 +0000 (22:23 -0400)]
Add "Copy selections to current folder" button to selection drop-down.

10 years agoName links do not need to be owned by tail_uuid.
Tom Clegg [Fri, 2 May 2014 02:20:28 +0000 (22:20 -0400)]
Name links do not need to be owned by tail_uuid.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Thu, 1 May 2014 23:57:07 +0000 (19:57 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoAdd unique and valid name constraints.
Tom Clegg [Thu, 1 May 2014 22:01:37 +0000 (18:01 -0400)]
Add unique and valid name constraints.

10 years agoFix wrong infixes in fixture uuids.
Tom Clegg [Thu, 1 May 2014 21:43:50 +0000 (17:43 -0400)]
Fix wrong infixes in fixture uuids.

10 years agoMerge branch 'master' into 2640-folder-api
Tom Clegg [Thu, 1 May 2014 21:41:29 +0000 (17:41 -0400)]
Merge branch 'master' into 2640-folder-api

10 years agoMerge remote-tracking branch 'origin/master' into 2035-arv-mount-tags-folders
Peter Amstutz [Thu, 1 May 2014 20:26:09 +0000 (16:26 -0400)]
Merge remote-tracking branch 'origin/master' into 2035-arv-mount-tags-folders

Conflicts:
services/api/app/controllers/application_controller.rb

10 years agoAdded 'select' and 'distinct' parameters to discovery document. Improved
Peter Amstutz [Thu, 1 May 2014 18:54:51 +0000 (14:54 -0400)]
Added 'select' and 'distinct' parameters to discovery document.  Improved
select parameter to parse strings as json.

10 years agoUse partial unique index for name links.
Tom Clegg [Thu, 1 May 2014 18:38:46 +0000 (14:38 -0400)]
Use partial unique index for name links.

10 years agoFix log permission case broken in merge.
Tom Clegg [Thu, 1 May 2014 18:38:15 +0000 (14:38 -0400)]
Fix log permission case broken in merge.

10 years agoMerge branch 'master' into 2640-folder-api
Tom Clegg [Thu, 1 May 2014 18:26:40 +0000 (14:26 -0400)]
Merge branch 'master' into 2640-folder-api

Conflicts:
services/api/app/controllers/application_controller.rb
services/api/app/models/arvados_model.rb

10 years agoMerge branch 'master' of git.clinicalfuture.com:arvados
Peter Amstutz [Thu, 1 May 2014 17:16:10 +0000 (13:16 -0400)]
Merge branch 'master' of git.clinicalfuture.com:arvados

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

10 years agoAnother go at migration, uses batched loading and transactions, should have
Peter Amstutz [Thu, 1 May 2014 17:15:54 +0000 (13:15 -0400)]
Another go at migration, uses batched loading and transactions, should have
improved performance.