arvados.git
3 years agoreverting tokenV2 -> tokenV1 in tests 17014-controller-cr
Nico Cesar [Tue, 10 Nov 2020 12:39:42 +0000 (07:39 -0500)]
reverting tokenV2 -> tokenV1 in tests

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years agoreverting tokenV2 -> tokenV1 in tests
Nico Cesar [Tue, 10 Nov 2020 12:28:00 +0000 (07:28 -0500)]
reverting tokenV2 -> tokenV1 in tests

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years ago17014: Restores container uuid check.
Lucas Di Pentima [Mon, 9 Nov 2020 19:51:58 +0000 (16:51 -0300)]
17014: Restores container uuid check.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17014: Restores exception raising.
Lucas Di Pentima [Mon, 9 Nov 2020 19:28:01 +0000 (16:28 -0300)]
17014: Restores exception raising.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge commit 'bb131f1aa' into 17014-controller-cr
Nico Cesar [Tue, 3 Nov 2020 21:07:17 +0000 (16:07 -0500)]
Merge commit 'bb131f1aa' into 17014-controller-cr

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years ago17014: Fixes test. 17014-controller-cr-ldp
Lucas Di Pentima [Tue, 3 Nov 2020 17:09:44 +0000 (14:09 -0300)]
17014: Fixes test.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17014: Reverts fixture removal.
Lucas Di Pentima [Tue, 3 Nov 2020 16:23:43 +0000 (13:23 -0300)]
17014: Reverts fixture removal.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoreverted changes in tests
Nico Cesar [Tue, 3 Nov 2020 16:09:16 +0000 (11:09 -0500)]
reverted changes in tests

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years agoHard to know why time was missing
Nico Cesar [Tue, 3 Nov 2020 15:34:17 +0000 (10:34 -0500)]
Hard to know why time was missing

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years agoMerge branch '17014-controller-cr-ldp' of git.arvados.org:arvados into 17014-controll...
Nico Cesar [Tue, 3 Nov 2020 14:52:31 +0000 (09:52 -0500)]
Merge branch '17014-controller-cr-ldp' of git.arvados.org:arvados into 17014-controller-cr

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years ago17014: Allows ContainerRequest's container_uuid member to be NULL.
Lucas Di Pentima [Mon, 2 Nov 2020 20:07:42 +0000 (17:07 -0300)]
17014: Allows ContainerRequest's container_uuid member to be NULL.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17014: Fixture fix (WIP)
Lucas Di Pentima [Mon, 2 Nov 2020 18:31:12 +0000 (15:31 -0300)]
17014: Fixture fix (WIP)

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agofixed fixtures and tests that send garbage to find()
Nico Cesar [Sat, 31 Oct 2020 19:25:31 +0000 (15:25 -0400)]
fixed fixtures and tests that send garbage to find()

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years agoadded empty mounts in fixtures
Nico Cesar [Thu, 29 Oct 2020 19:39:02 +0000 (15:39 -0400)]
added empty mounts in fixtures

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years agoMoved some tests to integration_test.go
Nico Cesar [Fri, 23 Oct 2020 19:37:53 +0000 (15:37 -0400)]
Moved some tests to integration_test.go

This is an effort to have container_requests in the new codepath
and the tests to be all integration tests.

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years ago17014: Test database connection to test cluster.
Tom Clegg [Thu, 22 Oct 2020 16:04:21 +0000 (12:04 -0400)]
17014: Test database connection to test cluster.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years ago17014: missing fields and rails compat added to CR
Nico Cesar [Tue, 20 Oct 2020 20:06:00 +0000 (16:06 -0400)]
17014: missing fields and rails compat added to CR

Arvados-DCO-1.1-Signed-off-by: <nico@curii.com>

3 years ago17014: Return nil instead of "" for nil output_uuid.
Tom Clegg [Tue, 20 Oct 2020 17:55:26 +0000 (13:55 -0400)]
17014: Return nil instead of "" for nil output_uuid.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years ago17014: Fixup federation/localdb wiring.
Tom Clegg [Tue, 20 Oct 2020 15:56:15 +0000 (11:56 -0400)]
17014: Fixup federation/localdb wiring.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years ago17014: Port container request federation code to new style (WIP).
Tom Clegg [Mon, 19 Oct 2020 19:04:22 +0000 (15:04 -0400)]
17014: Port container request federation code to new style (WIP).

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years agoInitial commit with tests that are failing
Nico Cesar [Fri, 16 Oct 2020 17:37:46 +0000 (13:37 -0400)]
Initial commit with tests that are failing

this is the verbose log of failing test:

What next? test lib/controller/federation
======= test lib/controller/federation
ok   git.arvados.org/arvados.git/lib/controller/federation 1.178s coverage: 48.1% of statements
======= test lib/controller/federation -- 3s
Pass: lib/controller/federation tests (3s)
All test suites passed.
What next? test lib/controller
======= test lib/controller

----------------------------------------------------------------------
FAIL: federation_test.go:590: FederationSuite.TestCreateContainerRequestBadToken

time="2020-10-16T17:27:40.958155049Z" level=info msg=request RequestID=req-33wrdjmne2bs1nwkc9z8 remoteAddr="192.0.2.1:1234" reqBytes=24 reqForwardedFor= reqHost=example.com reqMethod=POST reqPath=arvados/v1/container_requests reqQuery="cluster_id=zzzzz"
time="2020-10-16T17:27:40.958812397Z" level=info msg=response RequestID=req-33wrdjmne2bs1nwkc9z8 remoteAddr="192.0.2.1:1234" reqBytes=24 reqForwardedFor= reqHost=example.com reqMethod=POST reqPath=arvados/v1/container_requests reqQuery="cluster_id=zzzzz" respBody="{\"errors\":[\"badly formatted token\"]}\n" respBytes=37 respStatus="Internal Server Error" respStatusCode=500 timeToStatus=0.000649 timeTotal=0.000655 timeWriteBody=0.000006
federation_test.go:599:
    c.Check(resp.StatusCode, check.Equals, http.StatusForbidden)
... obtained int = 500
... expected int = 403

federation_test.go:602:
    c.Check(e["errors"], check.DeepEquals, []string{"invalid API token"})
... obtained []string = []string{"badly formatted token"}
... expected []string = []string{"invalid API token"}

----------------------------------------------------------------------
FAIL: federation_test.go:630: FederationSuite.TestCreateRemoteContainerRequestCheckRuntimeToken

time="2020-10-16T17:27:41.013982673Z" level=info msg=request RequestID=req-1cdwy5iwe0qw3jgxdjf0 remoteAddr="192.0.2.1:1234" reqBytes=165 reqForwardedFor= reqHost=example.com reqMethod=POST reqPath=arvados/v1/container_requests reqQuery="cluster_id=zmock"
time="2020-10-16T17:27:41.015464942Z" level=info msg=response RequestID=req-1cdwy5iwe0qw3jgxdjf0 remoteAddr="192.0.2.1:1234" reqBytes=165 reqForwardedFor= reqHost=example.com reqMethod=POST reqPath=arvados/v1/container_requests reqQuery="cluster_id=zmock" respBytes=726 respStatus=OK respStatusCode=200 timeToStatus=0.001473 timeTotal=0.001477 timeWriteBody=0.000004
federation_test.go:659:
    c.Check(json.NewDecoder(s.remoteMockRequests[0].Body).Decode(&cr), check.IsNil)
... value *json.SyntaxError = &json.SyntaxError{msg:"invalid character 'c' looking for beginning of value", Offset:1} ("invalid character 'c' looking for beginning of value")

federation_test.go:660:
    c.Check(strings.HasPrefix(cr.ContainerRequest.RuntimeToken, "v2/zzzzz-gj3su-"), check.Equals, true)
... obtained bool = false
... expected bool = true

----------------------------------------------------------------------
FAIL: federation_test.go:664: FederationSuite.TestCreateRemoteContainerRequestCheckSetRuntimeToken

time="2020-10-16T17:27:41.020613425Z" level=info msg=request RequestID=req-12j635qfrmsbx1jludwq remoteAddr="192.0.2.1:1234" reqBytes=193 reqForwardedFor= reqHost=example.com reqMethod=POST reqPath=arvados/v1/container_requests reqQuery="cluster_id=zmock"
time="2020-10-16T17:27:41.022068784Z" level=info msg=response RequestID=req-12j635qfrmsbx1jludwq remoteAddr="192.0.2.1:1234" reqBytes=193 reqForwardedFor= reqHost=example.com reqMethod=POST reqPath=arvados/v1/container_requests reqQuery="cluster_id=zmock" respBytes=726 respStatus=OK respStatusCode=200 timeToStatus=0.001450 timeTotal=0.001453 timeWriteBody=0.000003
federation_test.go:690:
    c.Check(json.NewDecoder(s.remoteMockRequests[0].Body).Decode(&cr), check.IsNil)
... value *json.SyntaxError = &json.SyntaxError{msg:"invalid character 'c' looking for beginning of value", Offset:1} ("invalid character 'c' looking for beginning of value")

federation_test.go:691:
    c.Check(cr.ContainerRequest.RuntimeToken, check.Equals, "xyz")
... obtained string = ""
... expected string = "xyz"

----------------------------------------------------------------------
FAIL: federation_test.go:694: FederationSuite.TestCreateRemoteContainerRequestRuntimeTokenFromAuth

time="2020-10-16T17:27:41.030750822Z" level=info msg=request RequestID=req-m6xowfzgvbv2zi2sg8jo remoteAddr="192.0.2.1:1234" reqBytes=165 reqForwardedFor= reqHost=example.com reqMethod=POST reqPath=arvados/v1/container_requests reqQuery="cluster_id=zmock"
time="2020-10-16T17:27:41.031717846Z" level=info msg=response RequestID=req-m6xowfzgvbv2zi2sg8jo remoteAddr="192.0.2.1:1234" reqBytes=165 reqForwardedFor= reqHost=example.com reqMethod=POST reqPath=arvados/v1/container_requests reqQuery="cluster_id=zmock" respBytes=726 respStatus=OK respStatusCode=200 timeToStatus=0.000961 timeTotal=0.000963 timeWriteBody=0.000002
federation_test.go:719:
    c.Check(json.NewDecoder(s.remoteMockRequests[0].Body).Decode(&cr), check.IsNil)
... value *json.SyntaxError = &json.SyntaxError{msg:"invalid character 'c' looking for beginning of value", Offset:1} ("invalid character 'c' looking for beginning of value")

federation_test.go:720:
    c.Check(cr.ContainerRequest.RuntimeToken, check.Equals, arvadostest.ActiveTokenV2)
... obtained string = ""
... expected string = "v2/zzzzz-gj3su-077z32aux8dg2s1/3kg6k6lzmp9kj5cpkcoxie963cmvjahbt2fod9zru30k1jqdmi"

----------------------------------------------------------------------
FAIL: handler_test.go:321: HandlerSuite.TestGetObjects

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:316:
    c.Errorf("%s's key %q missing on controller's response.", direct["kind"], k)
... Error: arvados#containerRequest's key "expires_at" missing on controller's response.

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:312:
    c.Check(val, check.DeepEquals, direct[k],
        check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val))
... obtained string = ""
... expected = nil
... RailsAPI arvados#containerRequest key "log_uuid"'s value %!q(<nil>) differs from controller's "".

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:312:
    c.Check(val, check.DeepEquals, direct[k],
        check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val))
... obtained string = ""
... expected = nil
... RailsAPI arvados#containerRequest key "output_uuid"'s value %!q(<nil>) differs from controller's "".

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:316:
    c.Errorf("%s's key %q missing on controller's response.", direct["kind"], k)
... Error: arvados#containerRequest's key "container_count" missing on controller's response.

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:312:
    c.Check(val, check.DeepEquals, direct[k],
        check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val))
... obtained float64 = 0
... expected = nil
... RailsAPI arvados#containerRequest key "container_count_max"'s value %!q(<nil>) differs from controller's %!q(float64=0).

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:316:
    c.Errorf("%s's key %q missing on controller's response.", direct["kind"], k)
... Error: arvados#containerRequest's key "filters" missing on controller's response.

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:312:
    c.Check(val, check.DeepEquals, direct[k],
        check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val))
... obtained string = ""
... expected = nil
... RailsAPI arvados#containerRequest key "output_name"'s value %!q(<nil>) differs from controller's "".

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:312:
    c.Check(val, check.DeepEquals, direct[k],
        check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val))
... obtained map[string]interface {} = map[string]interface {}{"API":interface {}(nil), "keep_cache_ram":0, "ram":123, "vcpus":1}
... expected map[string]interface {} = map[string]interface {}{"ram":123, "vcpus":1}
... RailsAPI arvados#containerRequest key "runtime_constraints"'s value map["ram":%!q(float64=123) "vcpus":%!q(float64=1)] differs from controller's map["API":<nil> "keep_cache_ram":%!q(float64=0) "ram":%!q(float64=123) "vcpus":%!q(float64=1)].

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:312:
    c.Check(val, check.DeepEquals, direct[k],
        check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val))
... obtained map[string]interface {} = map[string]interface {}{"max_run_time":0, "partitions":interface {}(nil), "preemptible":false}
... expected map[string]interface {} = map[string]interface {}{}
... RailsAPI arvados#containerRequest key "scheduling_parameters"'s value map[] differs from controller's map["max_run_time":%!q(float64=0) "partitions":<nil> "preemptible":%!q(bool=false)].

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:312:
    c.Check(val, check.DeepEquals, direct[k],
        check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val))
... obtained string = ""
... expected = nil
... RailsAPI arvados#containerRequest key "description"'s value %!q(<nil>) differs from controller's "".

handler_test.go:351:
    s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields)
handler_test.go:312:
    c.Check(val, check.DeepEquals, direct[k],
        check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val))
... obtained string = ""
... expected = nil
... RailsAPI arvados#containerRequest key "requesting_container_uuid"'s value %!q(<nil>) differs from controller's "".

----------------------------------------------------------------------
FAIL: integration_test.go:43: IntegrationSuite.SetUpSuite

refs #17014

Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>

3 years agoFix arvados-cwl-conformance-tests.
Ward Vandewege [Fri, 16 Oct 2020 15:12:27 +0000 (11:12 -0400)]
Fix arvados-cwl-conformance-tests.

refs #16982

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoLink to the coding standards
Michael R. Crusoe [Fri, 16 Oct 2020 07:24:14 +0000 (09:24 +0200)]
Link to the coding standards

I expect coding standards to be in (or directly linked from) a
project's `CONTRIBUTING.md`

no issue #

Arvados-DCO-1.1-Signed-off-by: Michael R. Crusoe <mcrusoe@curii.com>

3 years agoSSLHandshakeError is Python 2 only refs #17008
Michael R. Crusoe [Thu, 15 Oct 2020 15:16:37 +0000 (17:16 +0200)]
SSLHandshakeError is Python 2 only refs #17008

Arvados-DCO-1.1-Signed-off-by: Michael R. Crusoe <mcrusoe@curii.com>

3 years agoWhen calculating the version of our Go and Rails deb/rpm packages, take
Ward Vandewege [Fri, 16 Oct 2020 01:23:38 +0000 (21:23 -0400)]
When calculating the version of our Go and Rails deb/rpm packages, take
the 'build' directory into account.

refs #17011

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoBugfix: fix detection of already generated Python deb/rpm packages.
Ward Vandewege [Fri, 16 Oct 2020 01:04:55 +0000 (21:04 -0400)]
Bugfix: fix detection of already generated Python deb/rpm packages.

refs #16982

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoFix whitespace in build/run-library.sh
Ward Vandewege [Fri, 16 Oct 2020 00:29:25 +0000 (20:29 -0400)]
Fix whitespace in build/run-library.sh

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoSeparate inline/download keep-web ports refs #16812
Peter Amstutz [Thu, 15 Oct 2020 21:06:45 +0000 (17:06 -0400)]
Separate inline/download keep-web ports refs #16812

This makes inline viewing of private files work as expected with
arvbox, which is helpful for development and testing.

It relies on "TrustAllContent: true", so it is also XSS insecure.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoMerge branch '16982-tilde-devN' refs #16982
Peter Amstutz [Thu, 15 Oct 2020 14:59:56 +0000 (10:59 -0400)]
Merge branch '16982-tilde-devN' refs #16982

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoFix heading for "upgrading" no issue #
Peter Amstutz [Wed, 14 Oct 2020 14:29:52 +0000 (10:29 -0400)]
Fix heading for "upgrading" no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoMerge branch '16992-disable-pg-pager' into master
Ward Vandewege [Wed, 14 Oct 2020 13:31:11 +0000 (09:31 -0400)]
Merge branch '16992-disable-pg-pager' into master

closes #16992

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16992: Merge branch 'master' into 16992-disable-pg-pager
Ward Vandewege [Wed, 14 Oct 2020 13:30:29 +0000 (09:30 -0400)]
16992: Merge branch 'master' into 16992-disable-pg-pager

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16981-sync-group-report-fix'. Refs #16981
Lucas Di Pentima [Tue, 13 Oct 2020 14:16:32 +0000 (11:16 -0300)]
Merge branch '16981-sync-group-report-fix'. Refs #16981

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '16989-fix-fed-migrate' refs #16989 2.1.0
Peter Amstutz [Mon, 12 Oct 2020 19:52:35 +0000 (15:52 -0400)]
Merge branch '16989-fix-fed-migrate' refs #16989

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16989: setup_on_activate needs to happen after update, not before
Peter Amstutz [Mon, 12 Oct 2020 19:42:20 +0000 (15:42 -0400)]
16989: setup_on_activate needs to happen after update, not before

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16989: Don't auto-admin first user in federation migrate test
Peter Amstutz [Mon, 12 Oct 2020 19:23:14 +0000 (15:23 -0400)]
16989: Don't auto-admin first user in federation migrate test

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16989: Make sure username is valid before trying to create repo
Peter Amstutz [Mon, 12 Oct 2020 19:18:32 +0000 (15:18 -0400)]
16989: Make sure username is valid before trying to create repo

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16981: Fixes error reporting when failing to create a remote group.
Lucas Di Pentima [Mon, 12 Oct 2020 14:23:18 +0000 (11:23 -0300)]
16981: Fixes error reporting when failing to create a remote group.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoFix a few more golint warnings.
Ward Vandewege [Mon, 12 Oct 2020 02:12:12 +0000 (22:12 -0400)]
Fix a few more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16922: disable the postgres pager in the rails postinst script.
Ward Vandewege [Sat, 10 Oct 2020 12:56:02 +0000 (08:56 -0400)]
16922: disable the postgres pager in the rails postinst script.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoSetup default VM/repo in setup method refs #16989
Peter Amstutz [Sat, 10 Oct 2020 00:12:53 +0000 (20:12 -0400)]
Setup default VM/repo in setup method refs #16989

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoSetup default VM from AutoSetupNewUsersWithVmUUID refs #16989
Peter Amstutz [Fri, 9 Oct 2020 22:52:14 +0000 (18:52 -0400)]
Setup default VM from AutoSetupNewUsersWithVmUUID refs #16989

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoMerge branch '16989-user-setup' refs #16989
Peter Amstutz [Fri, 9 Oct 2020 18:30:58 +0000 (14:30 -0400)]
Merge branch '16989-user-setup' refs #16989

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16989: Test all combinations of remote user status
Peter Amstutz [Fri, 9 Oct 2020 17:00:05 +0000 (13:00 -0400)]
16989: Test all combinations of remote user status

Rework remote user setup/activate/unsetup.  Sending welcome email
moved to model setup method.  Add tests.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16989: Add test to sync is_invited
Peter Amstutz [Fri, 9 Oct 2020 16:26:04 +0000 (12:26 -0400)]
16989: Add test to sync is_invited

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoMerge branch '16981-logincluster-sync-groups-fix'
Lucas Di Pentima [Fri, 9 Oct 2020 13:41:09 +0000 (10:41 -0300)]
Merge branch '16981-logincluster-sync-groups-fix'
Refs #16981

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16981: Retrieves the local clusterID from exported config.
Lucas Di Pentima [Thu, 8 Oct 2020 21:01:09 +0000 (18:01 -0300)]
16981: Retrieves the local clusterID from exported config.

Also, fixed tests by not starting a new api server and using what run-tests
provides.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16982: OS packages build as ~devN, Python and Ruby use .devN
Peter Amstutz [Thu, 8 Oct 2020 20:07:06 +0000 (16:07 -0400)]
16982: OS packages build as ~devN, Python and Ruby use .devN

Also ~rcN becomes .rcN in Ruby.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoMerge branch '16976-python-rc-packages' refs #16976
Peter Amstutz [Thu, 8 Oct 2020 18:28:49 +0000 (14:28 -0400)]
Merge branch '16976-python-rc-packages' refs #16976

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16976: use unfiltered version number when checking for deb/rpm of our
Ward Vandewege [Thu, 8 Oct 2020 18:23:19 +0000 (14:23 -0400)]
16976: use unfiltered version number when checking for deb/rpm of our
       Python packages.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16976: Use adjusted version tag to accomodate release candidate packages
Peter Amstutz [Thu, 8 Oct 2020 17:40:18 +0000 (13:40 -0400)]
16976: Use adjusted version tag to accomodate release candidate packages

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16976: Support release candidates for our Python packages
Peter Amstutz [Thu, 8 Oct 2020 16:55:31 +0000 (12:55 -0400)]
16976: Support release candidates for our Python packages

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoWhen doing arvbox hotreset, make sure to use flock around the rake task.
Ward Vandewege [Thu, 8 Oct 2020 03:40:42 +0000 (23:40 -0400)]
When doing arvbox hotreset, make sure to use flock around the rake task.

refs #16955

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16955-more-fixes' into master
Ward Vandewege [Thu, 8 Oct 2020 01:24:28 +0000 (21:24 -0400)]
Merge branch '16955-more-fixes' into master

refs #16955

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoSerialize the service startup in arvbox by adding a dependency on the
Ward Vandewege [Thu, 8 Oct 2020 00:53:22 +0000 (20:53 -0400)]
Serialize the service startup in arvbox by adding a dependency on the
availability of the API server for those services that need it. This
greatly speeds up boot. Also remove superfluous service configuration
for keepproxy.

refs #16955

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16928-non-boolean-param-warning'
Tom Clegg [Wed, 7 Oct 2020 20:37:06 +0000 (16:37 -0400)]
Merge branch '16928-non-boolean-param-warning'

refs #16928

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years agoActually load our custom sysctl.conf entries.
Ward Vandewege [Wed, 7 Oct 2020 18:33:25 +0000 (14:33 -0400)]
Actually load our custom sysctl.conf entries.

refs #16955

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16928: Avoid misleading warning when using implicit bool defaults.
Tom Clegg [Wed, 7 Oct 2020 17:32:10 +0000 (13:32 -0400)]
16928: Avoid misleading warning when using implicit bool defaults.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years ago16928: Fill in missing bool defaults in *_requires_parameters.
Tom Clegg [Wed, 7 Oct 2020 17:31:03 +0000 (13:31 -0400)]
16928: Fill in missing bool defaults in *_requires_parameters.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years ago16928: Fix advertised default value of include_old_versions.
Tom Clegg [Wed, 7 Oct 2020 17:30:47 +0000 (13:30 -0400)]
16928: Fix advertised default value of include_old_versions.

Also remove special defaults-override logic, now that the existing
load_params code knows the right defaults.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years ago16928: Improve warning message.
Tom Clegg [Wed, 7 Oct 2020 17:25:12 +0000 (13:25 -0400)]
16928: Improve warning message.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years agoMerge branch '16955-fix-arvbox' into master
Ward Vandewege [Wed, 7 Oct 2020 15:45:50 +0000 (11:45 -0400)]
Merge branch '16955-fix-arvbox' into master

closes #16955

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16955: Merge branch 'master' into 16955-fix-arvbox
Ward Vandewege [Wed, 7 Oct 2020 15:45:09 +0000 (11:45 -0400)]
16955: Merge branch 'master' into 16955-fix-arvbox

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16955: a number of fixes to make the federation migration tests pass
Ward Vandewege [Wed, 7 Oct 2020 01:06:01 +0000 (21:06 -0400)]
16955: a number of fixes to make the federation migration tests pass
       with arvbox again. Followup to #16267.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16956-doc-fix-zenweb-liquid-4' into master
Ward Vandewege [Tue, 6 Oct 2020 21:23:23 +0000 (17:23 -0400)]
Merge branch '16956-doc-fix-zenweb-liquid-4' into master

closes #16956

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16956: address review comments.
Ward Vandewege [Tue, 6 Oct 2020 21:14:48 +0000 (17:14 -0400)]
16956: address review comments.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16956: update our zenweb/liquid package to support liquid 4+
Ward Vandewege [Tue, 6 Oct 2020 18:02:17 +0000 (14:02 -0400)]
16956: update our zenweb/liquid package to support liquid 4+

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16809-s3-v4-signature'
Tom Clegg [Tue, 6 Oct 2020 17:56:07 +0000 (13:56 -0400)]
Merge branch '16809-s3-v4-signature'

closes #16809

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years agoFix arv-federation-migrate-test jenkins job: update hardcoded arvbox
Ward Vandewege [Tue, 6 Oct 2020 15:55:41 +0000 (11:55 -0400)]
Fix arv-federation-migrate-test jenkins job: update hardcoded arvbox
container paths.

refs #16267

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoFix arvados-cwl-conformance-tests and arv-federation-migrate-test
Ward Vandewege [Tue, 6 Oct 2020 13:47:55 +0000 (09:47 -0400)]
Fix arvados-cwl-conformance-tests and arv-federation-migrate-test
jenkins jobs.

refs #16267

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoFix more golint warnings.
Ward Vandewege [Tue, 6 Oct 2020 00:26:10 +0000 (20:26 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoCan't use generic copy for container requests refs #16886
Peter Amstutz [Mon, 5 Oct 2020 18:18:27 +0000 (14:18 -0400)]
Can't use generic copy for container requests refs #16886

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16809: Test S3 API using Amazon client library.
Tom Clegg [Mon, 5 Oct 2020 18:13:00 +0000 (14:13 -0400)]
16809: Test S3 API using Amazon client library.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years agoFix 'test' login method to return v2 token, no issue #
Peter Amstutz [Mon, 5 Oct 2020 18:01:36 +0000 (14:01 -0400)]
Fix 'test' login method to return v2 token, no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoFix more golint warnings.
Ward Vandewege [Sun, 4 Oct 2020 21:25:37 +0000 (17:25 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoAdd a cli example: create an empty collection.
Ward Vandewege [Sun, 4 Oct 2020 21:10:27 +0000 (17:10 -0400)]
Add a cli example: create an empty collection.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16750-logincluster-wb1-trash-fix'
Lucas Di Pentima [Sat, 3 Oct 2020 14:29:57 +0000 (11:29 -0300)]
Merge branch '16750-logincluster-wb1-trash-fix'
Closes #16750

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoFix some more golint warnings.
Ward Vandewege [Sat, 3 Oct 2020 01:10:19 +0000 (21:10 -0400)]
Fix some more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16750: Avoids using params on requests to make it compatible with federation.
Lucas Di Pentima [Thu, 1 Oct 2020 13:52:23 +0000 (10:52 -0300)]
16750: Avoids using params on requests to make it compatible with federation.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoFixes collection_versioning mention on documentation. No issue #
Lucas Di Pentima [Fri, 2 Oct 2020 14:48:14 +0000 (11:48 -0300)]
Fixes collection_versioning mention on documentation. No issue #

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoFix more golint warnings.
Ward Vandewege [Thu, 1 Oct 2020 23:44:14 +0000 (19:44 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16923-auth-api-client' refs #16923
Peter Amstutz [Thu, 1 Oct 2020 22:12:03 +0000 (18:12 -0400)]
Merge branch '16923-auth-api-client' refs #16923

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16923: Improve architecture diagram a bit.
Peter Amstutz [Thu, 1 Oct 2020 22:09:50 +0000 (18:09 -0400)]
16923: Improve architecture diagram a bit.

Fix comment about TrustedClients config item.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoarvados-cwl-runner, don't pull arvados/jobs:latest, pull arvados/jobs:version
Peter Amstutz [Thu, 1 Oct 2020 20:46:08 +0000 (16:46 -0400)]
arvados-cwl-runner, don't pull arvados/jobs:latest, pull arvados/jobs:version

refs #16886

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16923: Add Login.TrustedClients to export
Peter Amstutz [Thu, 1 Oct 2020 19:11:44 +0000 (15:11 -0400)]
16923: Add Login.TrustedClients to export

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16923: Add peer federation / logincluster federation to architecture
Peter Amstutz [Thu, 1 Oct 2020 17:58:43 +0000 (13:58 -0400)]
16923: Add peer federation / logincluster federation to architecture

Also rearrange the high-level architecture diagram a little bit.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16923: Add note about federation types and trusted clients.
Peter Amstutz [Wed, 30 Sep 2020 18:08:12 +0000 (14:08 -0400)]
16923: Add note about federation types and trusted clients.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16923: Add "TrustedClients" configuration option.
Peter Amstutz [Tue, 29 Sep 2020 23:12:50 +0000 (19:12 -0400)]
16923: Add "TrustedClients" configuration option.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16923: user/pass api_client is trusted by default
Peter Amstutz [Tue, 29 Sep 2020 21:26:46 +0000 (17:26 -0400)]
16923: user/pass api_client is trusted by default

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoUserGet() passes "select" option along to batch update refs #16914
Peter Amstutz [Wed, 30 Sep 2020 21:13:59 +0000 (17:13 -0400)]
UserGet() passes "select" option along to batch update refs #16914

Fixes issue of user being deactivated because something called "get
user" and selected fields didn't include is_active.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agolibpam-arvados-go: do not put a file with comments in
Ward Vandewege [Tue, 29 Sep 2020 21:53:53 +0000 (17:53 -0400)]
libpam-arvados-go: do not put a file with comments in
/usr/share/pam-configs, the `pam-auth-update` command does not take
kindly to that. Put that file in the package documentation directory
instead.

refs #15348

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoAdjust arvbox shell to have /var/lib/arvados/bin in PATH
Peter Amstutz [Tue, 29 Sep 2020 19:42:54 +0000 (15:42 -0400)]
Adjust arvbox shell to have /var/lib/arvados/bin in PATH

no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoBetter help text for arvbox adduser/removeuser no issue #
Peter Amstutz [Tue, 29 Sep 2020 18:59:57 +0000 (14:59 -0400)]
Better help text for arvbox adduser/removeuser no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoMerge branch '16914-inactive-user' closes #16914
Peter Amstutz [Tue, 29 Sep 2020 18:54:44 +0000 (14:54 -0400)]
Merge branch '16914-inactive-user' closes #16914

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16914: Make sure remote uninvited user is not invited here
Peter Amstutz [Tue, 29 Sep 2020 14:55:16 +0000 (10:55 -0400)]
16914: Make sure remote uninvited user is not invited here

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16914: "Get current user" is forwarded to LoginCluster
Peter Amstutz [Mon, 28 Sep 2020 21:00:33 +0000 (17:00 -0400)]
16914: "Get current user" is forwarded to LoginCluster

Results from "get user" and "current user" are now cached, same as
"user list".

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoMerge branch '16913-logout' closes #16913
Peter Amstutz [Mon, 28 Sep 2020 19:36:54 +0000 (15:36 -0400)]
Merge branch '16913-logout' closes #16913

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16913: Add upgrade note about LoginCluster
Peter Amstutz [Mon, 28 Sep 2020 18:43:05 +0000 (14:43 -0400)]
16913: Add upgrade note about LoginCluster

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16913: Treat LoginCluster as a distinct login method.
Peter Amstutz [Mon, 28 Sep 2020 18:28:18 +0000 (14:28 -0400)]
16913: Treat LoginCluster as a distinct login method.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoMerge branch '16267-change-arvbox-deps' into master
Ward Vandewege [Mon, 28 Sep 2020 15:59:28 +0000 (11:59 -0400)]
Merge branch '16267-change-arvbox-deps' into master

closes #16267

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>