Radhika Chippada [Wed, 11 Feb 2015 20:01:28 +0000 (15:01 -0500)]
5110: update a comment in test; this comment was reflecting ui from before project tabs.
Radhika Chippada [Wed, 11 Feb 2015 19:58:28 +0000 (14:58 -0500)]
5110: update couple more tests to do a single visit to page than visit home and then visit page.
Radhika Chippada [Wed, 11 Feb 2015 19:49:26 +0000 (14:49 -0500)]
Merge branch 'master' into 5110-workbench-full-text-search
Tom Clegg [Tue, 10 Feb 2015 22:50:38 +0000 (17:50 -0500)]
Merge branch '4958-old-browser-alert' closes #4958
Tom Clegg [Tue, 10 Feb 2015 22:12:16 +0000 (17:12 -0500)]
4958: Merge branch 'master' into 4958-old-browser-alert
Tom Clegg [Tue, 10 Feb 2015 22:08:57 +0000 (17:08 -0500)]
4958: Tweak wording. Fix margins.
Tom Clegg [Tue, 10 Feb 2015 22:02:10 +0000 (17:02 -0500)]
4958: Test WebSocket support.
Tom Clegg [Tue, 10 Feb 2015 22:02:00 +0000 (17:02 -0500)]
4958: Rename test file.
Tom Clegg [Tue, 10 Feb 2015 21:42:04 +0000 (16:42 -0500)]
Fix javascript errors when closing modal. refs #5183
Tom Clegg [Tue, 10 Feb 2015 21:22:37 +0000 (16:22 -0500)]
5183: Disable animation on modal. (It seems to cause intermittent test failures.) refs #5183
Brett Smith [Tue, 10 Feb 2015 19:14:51 +0000 (14:14 -0500)]
Merge branch '5160-share-with-anonymous-group-wip'
Closes #5160, #5163.
Brett Smith [Tue, 10 Feb 2015 16:33:59 +0000 (11:33 -0500)]
5160: Workbench hides anonymous sharing when browsing disabled.
This commit updates Workbench to filter out the anonymous group from
the group sharing modal when anonymous browsing is disabled. That
helps avoid situations where users think their work is publicly
sharable, but that's been disabled by the administrator.
Brett Smith [Tue, 10 Feb 2015 16:25:16 +0000 (11:25 -0500)]
5160: Make anonymous group fixture match database seed.
Refer to /services/api/app/models/database_seeds.rb.
Brett Smith [Tue, 10 Feb 2015 14:00:01 +0000 (09:00 -0500)]
5160: Fix typo in Workbench default config comments.
Brett Smith [Tue, 10 Feb 2015 19:11:55 +0000 (14:11 -0500)]
5160: All users have API read permission to anonymous group.
Workbench makes public data available to everyone by including the
anonymous user API token as a reader token for every request.
However, model-level validations do not respect reader tokens. As a
consequence, users cannot make their project public by sharing it with
the anonymous group. They can't create the necessary link, because
the validation can't confirm that the creator can see the anonymous
group.
There are a few ways we could've tackled this, but granting all users
permission to see the anonymous group seems like the most reliable,
since it works within our existing permissions infrastructure as much
as possible.
Radhika Chippada [Tue, 10 Feb 2015 16:01:10 +0000 (11:01 -0500)]
Merge branch 'master' into 5110-workbench-full-text-search
Radhika Chippada [Tue, 10 Feb 2015 15:58:44 +0000 (10:58 -0500)]
refs #4523 : Add postgres full text search support
Merge branch '4523-full-text-search'
Radhika Chippada [Tue, 10 Feb 2015 15:47:34 +0000 (10:47 -0500)]
5110: update comment
Radhika Chippada [Tue, 10 Feb 2015 15:42:15 +0000 (10:42 -0500)]
Merge branch '4523-full-text-search' into 5110-workbench-full-text-search
Radhika Chippada [Tue, 10 Feb 2015 15:42:02 +0000 (10:42 -0500)]
Merge branch 'master' into 5110-workbench-full-text-search
Radhika Chippada [Tue, 10 Feb 2015 15:41:44 +0000 (10:41 -0500)]
Merge branch 'master' into 4523-full-text-search
Ward Vandewege [Tue, 10 Feb 2015 04:39:46 +0000 (23:39 -0500)]
Fix typo.
refs #4754
Ward Vandewege [Tue, 10 Feb 2015 04:35:54 +0000 (23:35 -0500)]
Also add minitest and friends to the performance group.
Refs #4754
Ward Vandewege [Tue, 10 Feb 2015 04:32:23 +0000 (23:32 -0500)]
Revert "We need tmp/cache to exist before we can run performance tests"
refs #4754
This reverts commit
c882575c856e01313cf2caf2e4ead1f27bfb33ae.
Radhika Chippada [Tue, 10 Feb 2015 04:03:01 +0000 (23:03 -0500)]
Merge branch '4523-full-text-search' into 5110-workbench-full-text-search
Radhika Chippada [Tue, 10 Feb 2015 04:02:39 +0000 (23:02 -0500)]
Merge branch 'master' into 4523-full-text-search
Ward Vandewege [Tue, 10 Feb 2015 03:45:04 +0000 (22:45 -0500)]
We need tmp/cache to exist before we can run performance tests
refs #4754
Ward Vandewege [Tue, 10 Feb 2015 03:25:50 +0000 (22:25 -0500)]
Make sure the performance testing gems are available when workbench is
run in the performance rails environment.
refs #4754
Radhika Chippada [Tue, 10 Feb 2015 02:50:41 +0000 (21:50 -0500)]
5110: full text search seems to treat '_' characters as spaces. Thus, when searched for 'pipeline_1', objects matching 'pipeline'
are also fetched since '1' is a common word and ignored. Hence, update the test to use more specific search filters.
Radhika Chippada [Tue, 10 Feb 2015 02:36:07 +0000 (21:36 -0500)]
Merge branch '4523-full-text-search' into 5110-workbench-full-text-search
Radhika Chippada [Tue, 10 Feb 2015 02:34:45 +0000 (21:34 -0500)]
4523: add search test looking for '_' which is ignored by full text search.
Radhika Chippada [Tue, 10 Feb 2015 02:27:25 +0000 (21:27 -0500)]
Merge branch 'master' into 4523-full-text-search
Brett Smith [Tue, 10 Feb 2015 01:15:30 +0000 (20:15 -0500)]
5176: Update Gemfiles with current arvados gem.
Refs #5176. Closes #5181.
Brett Smith [Tue, 10 Feb 2015 01:12:17 +0000 (20:12 -0500)]
Merge branch '5176-escape-filenames'
Closes #5176, #5180.
Brett Smith [Tue, 10 Feb 2015 01:12:00 +0000 (20:12 -0500)]
5176: Update API Collections test to accommodate new fixtures.
Radhika Chippada [Mon, 9 Feb 2015 23:33:25 +0000 (18:33 -0500)]
5110: append :* to search filter to enable prefix matching; server no longer does this and expects clients to append it as needed.
Tom Clegg [Mon, 9 Feb 2015 22:56:10 +0000 (17:56 -0500)]
5176: Update Gemfile.lock.
Radhika Chippada [Mon, 9 Feb 2015 22:48:55 +0000 (17:48 -0500)]
Merge branch '4523-full-text-search' into 5110-workbench-full-text-search
Radhika Chippada [Mon, 9 Feb 2015 22:47:19 +0000 (17:47 -0500)]
Merge branch 'master' into 4523-full-text-search
Radhika Chippada [Mon, 9 Feb 2015 22:45:47 +0000 (17:45 -0500)]
4523: update tests to include :* in the filters sent rather than expect server to append it.
Tom Clegg [Mon, 9 Feb 2015 22:45:25 +0000 (17:45 -0500)]
5176: Update bundles.
Tom Clegg [Mon, 9 Feb 2015 22:34:41 +0000 (17:34 -0500)]
5176: Fix broken fixtures, add tests.
Nancy Ouyang [Mon, 9 Feb 2015 22:29:47 +0000 (17:29 -0500)]
refs #4926 #5072 Merge branch '4926-fix-imagesizes'
Brett Smith [Mon, 9 Feb 2015 22:10:03 +0000 (17:10 -0500)]
Merge branch '4464-api-project-contents-wip'
Refs #4464. Closes #5140.
Brett Smith [Mon, 9 Feb 2015 21:40:08 +0000 (16:40 -0500)]
4464: Simplify API collection list method docs.
Brett Smith [Thu, 5 Feb 2015 16:58:43 +0000 (11:58 -0500)]
4464: API group contents no longer include manifests.
This change achieves symmetry with the collections list method, which
doesn't return manifests unless you expressly request them. We don't
have a good way to support the select parameter in group contents at
all right now, so this commit also makes that clear through the
discovery document, and documents the limitation. This change should
help avoid performance problems like witnessed in #4464.
Some refactoring/clean-up to help support this change:
* Extract out a method that generates the full hash response to list
@objects. Reuse that code in the groups contents method.
* The collections controller had code to generate a list of a model's
selectable attributes. Move that to ArvadosModel and reuse it in
the groups contents method.
* Make signatures consistent across all definitions of apply_filters
and apply_where_limit_order_params. The latter simply passes
arguments to the former, so it can have the same signature, and it
should respect the provided model_class argument the same way. Same
for the override in the users controller.
Brett Smith [Wed, 4 Feb 2015 20:46:25 +0000 (15:46 -0500)]
4464: Document API group contents parameters.
Brett Smith [Wed, 4 Feb 2015 20:46:04 +0000 (15:46 -0500)]
4464: Remove API group contents include_linked parameter.
With Tom's permission.
Brett Smith [Mon, 9 Feb 2015 22:02:01 +0000 (17:02 -0500)]
5176: Add more Ruby SDK tests for empty manifests.
I wrote these while trying to diagnose other issues in the branch.
They didn't reveal anything directly, but it seems like a waste to
write tests and not commit them, so here they are.
Brett Smith [Mon, 9 Feb 2015 21:01:35 +0000 (16:01 -0500)]
5175: Avoid egg_info name conflicts with pip.
pip does its own subclassing of egg_info. Installing with pip fails
if setup.py includes an egg_info class that is passed in as the
cmdclass for the egg_info command. Avoid using that name to avoid
conflicts with pip. Refs #5175.
Radhika Chippada [Mon, 9 Feb 2015 20:23:00 +0000 (15:23 -0500)]
4523: update full text search record_filter to not append :* for prefix matching; instead expect client to append it as needed.
Tom Clegg [Mon, 9 Feb 2015 18:28:55 +0000 (13:28 -0500)]
Merge branch '5175-pep-440' refs #5175
Tom Clegg [Mon, 9 Feb 2015 18:28:38 +0000 (13:28 -0500)]
5715: Sort imports.
Tom Clegg [Mon, 9 Feb 2015 18:28:18 +0000 (13:28 -0500)]
5175: Revert change to find_packages(), it gets confused by run_test_server.py.
Brett Smith [Mon, 9 Feb 2015 17:31:29 +0000 (12:31 -0500)]
5175: Include README for Node Manager packages.
Brett Smith [Mon, 9 Feb 2015 17:31:11 +0000 (12:31 -0500)]
5175: Do not add +sha1 tag to Python packages ever.
PEP 440 is clear that the local version tag is for distributors who
are patching an upstream release. That's not us; we are the upstream
release. "Local version identifiers SHOULD NOT be used for upstream
projects," so just don't do it.
This also lets us sidestep the issue of trying to parse sys.argv
behind setuptools' back.
Developers who want to keep their development builds distinct should
tag packages themselves with -b .devN.
Tom Clegg [Mon, 9 Feb 2015 17:10:29 +0000 (12:10 -0500)]
4523: Add tests for some edge cases.
Tom Clegg [Mon, 9 Feb 2015 17:05:16 +0000 (12:05 -0500)]
4523: Fix up whitespace.
Tom Clegg [Mon, 9 Feb 2015 15:42:22 +0000 (10:42 -0500)]
4523: Remove unneeded else.
Tom Clegg [Mon, 9 Feb 2015 16:20:28 +0000 (11:20 -0500)]
5176: Add spaces-in-filenames tests.
Tom Clegg [Mon, 9 Feb 2015 15:49:13 +0000 (10:49 -0500)]
5176: Fix handling of escape sequences in manifest filenames.
Radhika Chippada [Mon, 9 Feb 2015 02:28:57 +0000 (21:28 -0500)]
5110: clean up pipeline instances integration tests a bit. and remove a few of the tests in
"scroll pipeline instances page for with search filter" that are neither searching nor scrolling.
Tom Clegg [Sun, 8 Feb 2015 23:53:49 +0000 (18:53 -0500)]
5175: Do not add +sha1 tag unless --sha1-tag flag given.
Radhika Chippada [Sun, 8 Feb 2015 21:56:51 +0000 (16:56 -0500)]
Merge branch '4523-full-text-search' into 5110-workbench-full-text-search
Radhika Chippada [Sun, 8 Feb 2015 21:22:07 +0000 (16:22 -0500)]
4523: update full text search to append ':*' for each word to support a collection file search such as dir_name_part space file_name_part.
Radhika Chippada [Sun, 8 Feb 2015 20:54:14 +0000 (15:54 -0500)]
Merge branch 'master' into 4523-full-text-search
Conflicts:
services/api/test/unit/collection_test.rb
Tom Clegg [Sun, 8 Feb 2015 08:46:34 +0000 (03:46 -0500)]
4958: Add tests.
Tom Clegg [Sat, 7 Feb 2015 22:21:14 +0000 (17:21 -0500)]
4958: Avoid squishing dax's aspect ratio when window is narrow.
Tom Clegg [Sat, 7 Feb 2015 22:19:50 +0000 (17:19 -0500)]
4958: Detect old browsers and recommend upgrading.
We use a plain .js file in /public instead of the asset pipeline, and
don't rely on any JS libraries. This gives the error alert a much
better chance of working in a browser that can't even parse our
compiled/minified application.js.
Tom Clegg [Fri, 6 Feb 2015 22:53:33 +0000 (17:53 -0500)]
Merge branch '5011-arv-put-replication' closes #5011
Tom Clegg [Fri, 6 Feb 2015 22:53:02 +0000 (17:53 -0500)]
5011: Fix comment about when local_store_* methods get used.
Nancy Ouyang [Fri, 6 Feb 2015 22:43:22 +0000 (17:43 -0500)]
4926: Fixed images to be consistently 900x500
Tom Clegg [Fri, 6 Feb 2015 22:30:31 +0000 (17:30 -0500)]
Merge branch '3021-leave-api-running' refs #3021
Radhika Chippada [Fri, 6 Feb 2015 21:22:51 +0000 (16:22 -0500)]
5110: use full text search operator '@@' instead of 'ilike'
Radhika Chippada [Fri, 6 Feb 2015 21:15:23 +0000 (16:15 -0500)]
4523: slightly modified full text search condition.
Radhika Chippada [Fri, 6 Feb 2015 18:47:32 +0000 (13:47 -0500)]
Merge branch 'master' into 4523-full-text-search
Tom Clegg [Fri, 6 Feb 2015 18:47:22 +0000 (13:47 -0500)]
5011: Merge branch 'master' into 5011-arv-put-replication
Tom Clegg [Fri, 6 Feb 2015 18:42:00 +0000 (13:42 -0500)]
5011: Make docstring less scary.
Peter Amstutz [Fri, 6 Feb 2015 18:34:43 +0000 (13:34 -0500)]
3021: Bugfix for arvados_fuse.TagsDirectory to correctly merge tag list updates
with existing TagsDirectory entries.
Tom Clegg [Fri, 6 Feb 2015 17:46:57 +0000 (12:46 -0500)]
3021: Use bind(0.0.0.0, 0) instead of grep /proc/net/tcp to find a port number.
Brett Smith [Fri, 6 Feb 2015 17:00:41 +0000 (12:00 -0500)]
Relax version limit of python-daemon dependencies.
We imposed this limit in
9c2e673ba96ba5d11e56a4aba67157e64dfe01e2.
The issues seem to be ironed out as of version 2.0.4. See:
* <http://lists.alioth.debian.org/pipermail/python-daemon-devel/2015-January/000114.html>
* <https://bitbucket.org/pypa/setuptools/issue/338/__future__-imports-are-not-effective-in>
No issue #.
Radhika Chippada [Fri, 6 Feb 2015 13:56:09 +0000 (08:56 -0500)]
Merge branch 'master' into 4523-full-text-search
Tom Clegg [Fri, 6 Feb 2015 05:04:29 +0000 (00:04 -0500)]
3021: Merge branch 'master' into 3021-leave-api-running
Conflicts:
sdk/python/tests/test_websockets.py
Tom Clegg [Fri, 6 Feb 2015 04:59:35 +0000 (23:59 -0500)]
3021: We use passenger in dev and test environments, too.
Tom Clegg [Fri, 6 Feb 2015 01:37:48 +0000 (20:37 -0500)]
3021: Make sure any unexpected openssl output ends up on stderr.
Tom Clegg [Thu, 5 Feb 2015 23:31:12 +0000 (18:31 -0500)]
3021: Reduce race potential by resetting database after fuse unmounts.
Tom Clegg [Thu, 5 Feb 2015 23:12:22 +0000 (18:12 -0500)]
3021: Remove unused variable.
Tom Clegg [Thu, 5 Feb 2015 22:37:32 +0000 (17:37 -0500)]
3021: Use kwargs to pass options through make_mount(). Dry up FuseTagsUpdateTest.
Brett Smith [Thu, 5 Feb 2015 22:14:03 +0000 (17:14 -0500)]
Merge branch '5141-workbench-numeric-inputs-wip'
Closes #5141, #5143.
Brett Smith [Thu, 5 Feb 2015 21:18:00 +0000 (16:18 -0500)]
5141: Workbench permits float values for number pipeline inputs.
Previously, when a pipeline input had the number dataclass, we
rendered the input form with type=number. However, the Arvados number
dataclass is meant to allow all numeric types. The HTML 5 number
input type only permits integers.
Unfortunately, X-Editable does not have any built-in validation for a
broader range of numeric types. This commit simply removes any
validation.
Tom Clegg [Thu, 5 Feb 2015 22:02:45 +0000 (17:02 -0500)]
3021: Give up earlier if ARVADOS_TEST_API_HOST is set but reset() fails.
Tom Clegg [Thu, 5 Feb 2015 22:02:16 +0000 (17:02 -0500)]
3021: Reset env vars in any reset(), not just in start().
Tom Clegg [Thu, 5 Feb 2015 21:22:34 +0000 (16:22 -0500)]
Avoid optional disk cache usage if it is owned by a different user. refs #2659.
Brett Smith [Thu, 5 Feb 2015 21:43:29 +0000 (16:43 -0500)]
5135: Workbench consistently orders modal buttons.
Primary buttons should be first from the right, following Bootstrap
conventions and Tom's edict. Closes #5135.
Radhika Chippada [Thu, 5 Feb 2015 21:33:39 +0000 (16:33 -0500)]
Merge branch 'master' into 4523-full-text-search
Conflicts:
services/api/db/structure.sql
Radhika Chippada [Thu, 5 Feb 2015 21:29:56 +0000 (16:29 -0500)]
4523: preparing to merge master
Tom Clegg [Thu, 5 Feb 2015 21:29:27 +0000 (16:29 -0500)]
3021: Set env var to empty string instead of removing it. Unsetenv isn't worth introducing a dependency on Go 1.4.
Tom Clegg [Thu, 5 Feb 2015 21:22:20 +0000 (16:22 -0500)]
5011: Add forward compatibility, so we don't need backward compatibility later.
Tom Clegg [Thu, 5 Feb 2015 20:15:22 +0000 (15:15 -0500)]
5011: Add tests and comments for redundancy vs. replication_desired attrs.
Tom Clegg [Thu, 5 Feb 2015 20:14:49 +0000 (15:14 -0500)]
5011: Fix up docstring.