arvados.git
9 years ago5753: show name column in project#show page when the object supports name.
Radhika Chippada [Fri, 17 Apr 2015 14:59:27 +0000 (10:59 -0400)]
5753: show name column in project#show page when the object supports name.

9 years agocloses #5417
Radhika Chippada [Thu, 16 Apr 2015 22:06:52 +0000 (18:06 -0400)]
closes #5417
Merge branch '5417-not-start-pipeline-with-unreadable-inputs'

9 years agoMerge branch 'master' into 5417-not-start-pipeline-with-unreadable-inputs
Radhika Chippada [Thu, 16 Apr 2015 22:06:31 +0000 (18:06 -0400)]
Merge branch 'master' into 5417-not-start-pipeline-with-unreadable-inputs

9 years ago5417: one more test condition for dataclass=File
Radhika Chippada [Thu, 16 Apr 2015 22:05:53 +0000 (18:05 -0400)]
5417: one more test condition for dataclass=File

9 years agoMerge branch '3145-readonly-volumes' refs #3145
Tom Clegg [Thu, 16 Apr 2015 21:28:42 +0000 (17:28 -0400)]
Merge branch '3145-readonly-volumes' refs #3145

9 years ago5417: in case of a File dataclass with unreadable input and uneditable pipeline,...
Radhika Chippada [Thu, 16 Apr 2015 21:18:59 +0000 (17:18 -0400)]
5417: in case of a File dataclass with unreadable input and uneditable pipeline, the Run button should be disabled.

9 years ago5417: revert unreadable-input check for links since no such case exists.
Radhika Chippada [Thu, 16 Apr 2015 18:28:14 +0000 (14:28 -0400)]
5417: revert unreadable-input check for links since no such case exists.

9 years ago5417: update created_at time on pipeline_in_publicly_accessible_project, so that...
Radhika Chippada [Thu, 16 Apr 2015 18:02:18 +0000 (14:02 -0400)]
5417: update created_at time on pipeline_in_publicly_accessible_project, so that it is newest and always first in the list.

9 years agoMerge branch 'master' into 5417-not-start-pipeline-with-unreadable-inputs
Radhika Chippada [Thu, 16 Apr 2015 17:47:18 +0000 (13:47 -0400)]
Merge branch 'master' into 5417-not-start-pipeline-with-unreadable-inputs

9 years ago5417: a few changes from based on review feedback. also, account for dataclass=File...
Radhika Chippada [Thu, 16 Apr 2015 17:35:58 +0000 (13:35 -0400)]
5417: a few changes from based on review feedback. also, account for dataclass=File type when checking if input is readable by current user.

9 years ago3145: Add -readonly flag. Accept multiple -volume arguments.
Tom Clegg [Thu, 16 Apr 2015 16:16:53 +0000 (12:16 -0400)]
3145: Add -readonly flag. Accept multiple -volume arguments.

* Leave -volumes (and accept comma-separated dir lists) for backward
  compatibility.

* Detect read-only filesystems when using /proc/mounts to discover
  Keep volumes.

* VolumeManagers know whether volumes are writable, so it's not
  necessary to wait in a serialize queue just to find out a volume
  isn't writable.

* Simplify RRVolumeManager: use atomic.AddUint32() instead of channels
  and goroutines.

* -serialize (like -readonly) now affects only the volumes that come
  after it in the argument list (and automatically discovered
  volumes). This makes it possible to have a mix of serialized and
  non-serialized volumes.

* Fix some test cases that just skipped the test (instead of failing)
  when encountering an error during test setup.

* Move MockVolume code from volume.go to volume_test.go.

* Clean up some over-indented code blocks, see
  https://github.com/golang/go/wiki/CodeReviewComments#indent-error-flow

* Remove some stating-the-obvious/redundant comments and duplicate log
  messages.

9 years ago5742: User setup process uses username for VM login, not repo name.
Brett Smith [Thu, 16 Apr 2015 14:18:26 +0000 (10:18 -0400)]
5742: User setup process uses username for VM login, not repo name.

Closes #5742.

9 years agoMerge branch '5717-crunch-dynamic-max-tasks-per-node-wip'
Brett Smith [Wed, 15 Apr 2015 20:06:08 +0000 (16:06 -0400)]
Merge branch '5717-crunch-dynamic-max-tasks-per-node-wip'

Closes #5717, #5721.

9 years ago5717: crunch-job uses fewer slots when few tasks at this level.
Brett Smith [Tue, 14 Apr 2015 17:13:29 +0000 (13:13 -0400)]
5717: crunch-job uses fewer slots when few tasks at this level.

When crunch-job begins tasks at a new level, it looks at the number of
tasks scheduled for that level.  If that's smaller than the maximum
number of slots available, then it only considers slots "free" up to
the number of tasks scheduled, or the number of nodes available,
whichever is greater.

This change lets Crunch scale whole-node resources like RAM more
effectively.  This may not be desired if a level starts with a small
number of tasks queued, but later schedules more and wants maximum
parallelization, but that's uncommon enough that this seems like net
win.  Previously, Crunch could overallocate RAM in this scenario,
which seems worse.

9 years agoMerge branch '5714-gce-setup-bugfixes-wip'
Brett Smith [Wed, 15 Apr 2015 19:14:29 +0000 (15:14 -0400)]
Merge branch '5714-gce-setup-bugfixes-wip'

Closes #5714, #5715.

9 years ago5714: Avoid Node Manager race conditions around stop_if_no_cloud_node.
Brett Smith [Mon, 13 Apr 2015 20:48:16 +0000 (16:48 -0400)]
5714: Avoid Node Manager race conditions around stop_if_no_cloud_node.

Checking .is_alive() seems to always lead to race conditions.
Instead, have CloudNodeSetupActor.stop_if_no_cloud_node() return True
if it's going to stop, else False.  Have NodeManagerDaemonActor
respect this return value consistently.

9 years ago5714: Node Manager setup process retries Arvados errors.
Brett Smith [Mon, 13 Apr 2015 19:37:48 +0000 (15:37 -0400)]
5714: Node Manager setup process retries Arvados errors.

This fixes a regression from 6ab7cf882cd9a268374b880b5e55b4c8946406b4.

9 years ago5417: fix typo
Radhika Chippada [Wed, 15 Apr 2015 18:49:11 +0000 (14:49 -0400)]
5417: fix typo

9 years ago5417: add additional test updates to verify Run button status when input is not readable.
Radhika Chippada [Wed, 15 Apr 2015 17:44:17 +0000 (13:44 -0400)]
5417: add additional test updates to verify Run button status when input is not readable.

9 years ago5417: when input is unreadable, present visual cue even when it is not editable by...
Radhika Chippada [Wed, 15 Apr 2015 14:14:50 +0000 (10:14 -0400)]
5417: when input is unreadable, present visual cue even when it is not editable by the user.

9 years ago5417: add "unreadable inputs provided" visual cue for an editable pipeline instance.
Radhika Chippada [Tue, 14 Apr 2015 19:33:32 +0000 (15:33 -0400)]
5417: add "unreadable inputs provided" visual cue for an editable pipeline instance.

9 years agocloses #5647
Radhika Chippada [Tue, 14 Apr 2015 13:53:59 +0000 (09:53 -0400)]
closes #5647
Merge branch '5647-login-dropdown'

9 years ago5647: minor text update
Radhika Chippada [Tue, 14 Apr 2015 13:53:12 +0000 (09:53 -0400)]
5647: minor text update

9 years ago5647: as a team we need to learn to weigh options with their worth; aka, this login...
Radhika Chippada [Tue, 14 Apr 2015 05:03:01 +0000 (01:03 -0400)]
5647: as a team we need to learn to weigh options with their worth; aka, this login hover drop-down should have been implemented as a simple tooltip.

9 years ago5647: add icon to the new login dropdown link
Radhika Chippada [Tue, 14 Apr 2015 04:23:08 +0000 (00:23 -0400)]
5647: add icon to the new login dropdown link

9 years ago5647: minor tweak to dropdown text
Radhika Chippada [Tue, 14 Apr 2015 03:53:32 +0000 (23:53 -0400)]
5647: minor tweak to dropdown text

9 years agoMerge branch 'master' into 5647-login-dropdown
Radhika Chippada [Tue, 14 Apr 2015 03:42:50 +0000 (23:42 -0400)]
Merge branch 'master' into 5647-login-dropdown

9 years agocloses #5440
Radhika Chippada [Tue, 14 Apr 2015 03:41:29 +0000 (23:41 -0400)]
closes #5440
Merge branch '5440-remove-doc-getting-started'

9 years ago5440: remove usused getting_started images
Radhika Chippada [Tue, 14 Apr 2015 03:40:43 +0000 (23:40 -0400)]
5440: remove usused getting_started images

9 years ago5647: add a hover dropdown login item.
Radhika Chippada [Tue, 14 Apr 2015 03:34:00 +0000 (23:34 -0400)]
5647: add a hover dropdown login item.

9 years ago5440: reword quickstart
Nancy Ouyang [Tue, 14 Apr 2015 03:10:20 +0000 (23:10 -0400)]
5440: reword quickstart

9 years agolinkfix, reword quickstart section on homepage
Nancy Ouyang [Tue, 14 Apr 2015 02:35:49 +0000 (22:35 -0400)]
linkfix, reword quickstart section on homepage

9 years agoFix indentation. Remove errant unclosed <p> tag. refs #5493
Tom Clegg [Tue, 14 Apr 2015 02:21:23 +0000 (22:21 -0400)]
Fix indentation. Remove errant unclosed <p> tag. refs #5493

9 years ago5440: remove all links to /start temporarily to avoid confusing user
Nancy Ouyang [Tue, 14 Apr 2015 02:04:53 +0000 (22:04 -0400)]
5440: remove all links to /start temporarily to avoid confusing user
Put in quickstart sections on docs homepage for both 1) public pipeline 2) pipeline developers
Revert changes made in #5090 (home title back to "Arvados Docs", topnav link to "arvados.org")
Refactor /user/index.html, removing references to /start and directing new users to homepage quickstart section

9 years agoIf provided, use TMPDIR instead of /tmp. No issue #
Tom Clegg [Tue, 14 Apr 2015 02:00:43 +0000 (22:00 -0400)]
If provided, use TMPDIR instead of /tmp. No issue #

9 years agoFix loop label that became disconnected in bae652c, causing crash on "next THISROUND...
Tom Clegg [Tue, 14 Apr 2015 01:47:06 +0000 (21:47 -0400)]
Fix loop label that became disconnected in bae652c, causing crash on "next THISROUND". refs #5642

9 years agoMerge branch 'master' of git.curoverse.com:arvados into 5440-remove-doc-getting-started
Nancy Ouyang [Tue, 14 Apr 2015 00:26:18 +0000 (20:26 -0400)]
Merge branch 'master' of git.curoverse.com:arvados into 5440-remove-doc-getting-started

9 years agoMerge branch '5414-keep-service-hints' refs #5414
Tom Clegg [Mon, 13 Apr 2015 21:05:44 +0000 (17:05 -0400)]
Merge branch '5414-keep-service-hints' refs #5414

9 years agorefs #5493
Radhika Chippada [Mon, 13 Apr 2015 20:53:35 +0000 (16:53 -0400)]
refs #5493
Merge branch '5493-getting-started-modal'

9 years ago5493: popup size
Radhika Chippada [Mon, 13 Apr 2015 20:51:32 +0000 (16:51 -0400)]
5493: popup size

9 years ago5493: popup size and a typo
Radhika Chippada [Mon, 13 Apr 2015 20:47:35 +0000 (16:47 -0400)]
5493: popup size and a typo

9 years ago5493: make popup size fixed
Radhika Chippada [Mon, 13 Apr 2015 20:34:20 +0000 (16:34 -0400)]
5493: make popup size fixed

9 years ago5493: public pipeline wiki page link added in page 3
Radhika Chippada [Mon, 13 Apr 2015 20:25:21 +0000 (16:25 -0400)]
5493: public pipeline wiki page link added in page 3

9 years ago5414: Merge branch 'master' into 5414-keep-service-hints
Tom Clegg [Mon, 13 Apr 2015 20:24:02 +0000 (16:24 -0400)]
5414: Merge branch 'master' into 5414-keep-service-hints

9 years ago1 2 3 ul>ol 3rd page
Nancy Ouyang [Mon, 13 Apr 2015 20:11:31 +0000 (16:11 -0400)]
1 2 3 ul>ol 3rd page

9 years ago5493: that did not sit well
Radhika Chippada [Mon, 13 Apr 2015 20:09:54 +0000 (16:09 -0400)]
5493: that did not sit well

9 years ago5493: remove confusing btn class on explanation button spans to not show hand mouse...
Radhika Chippada [Mon, 13 Apr 2015 19:53:56 +0000 (15:53 -0400)]
5493: remove confusing btn class on explanation button spans to not show hand mouse cursor

9 years agoMerge branch 'master' of git.curoverse.com:arvados into 5440-remove-doc-getting-started
Nancy Ouyang [Mon, 13 Apr 2015 19:50:18 +0000 (15:50 -0400)]
Merge branch 'master' of git.curoverse.com:arvados into 5440-remove-doc-getting-started

9 years agoMerge branch 'master' into 5493-getting-started-modal
Radhika Chippada [Mon, 13 Apr 2015 19:47:29 +0000 (15:47 -0400)]
Merge branch 'master' into 5493-getting-started-modal

9 years agotypo
Nancy Ouyang [Mon, 13 Apr 2015 19:39:29 +0000 (15:39 -0400)]
typo

9 years agodashed line
Nancy Ouyang [Mon, 13 Apr 2015 19:31:06 +0000 (15:31 -0400)]
dashed line

9 years agoformat pg 3, 4
Nancy Ouyang [Mon, 13 Apr 2015 19:16:45 +0000 (15:16 -0400)]
format pg 3, 4

9 years agominor format changes
Nancy Ouyang [Mon, 13 Apr 2015 18:20:33 +0000 (14:20 -0400)]
minor format changes

9 years agoformatted first 2 pages
Nancy Ouyang [Mon, 13 Apr 2015 18:16:41 +0000 (14:16 -0400)]
formatted first 2 pages

9 years ago5414: Rename zz_preload* to preload*; alphabetical names are not needed any more.
Tom Clegg [Mon, 13 Apr 2015 17:49:04 +0000 (13:49 -0400)]
5414: Rename zz_preload* to preload*; alphabetical names are not needed any more.

9 years ago5414: Rename zz_load* to load*; alphabetical names are not needed any more.
Tom Clegg [Mon, 13 Apr 2015 17:48:40 +0000 (13:48 -0400)]
5414: Rename zz_load* to load*; alphabetical names are not needed any more.

9 years ago5414: Control initializer load order using require_relative instead of alphabetical...
Tom Clegg [Mon, 13 Apr 2015 17:47:03 +0000 (13:47 -0400)]
5414: Control initializer load order using require_relative instead of alphabetical filenames.

9 years ago5414: Add test case for unrecognized/future hints.
Tom Clegg [Mon, 13 Apr 2015 17:28:05 +0000 (13:28 -0400)]
5414: Add test case for unrecognized/future hints.

9 years ago5614: Update Workbench Gemfile for new Ruby SDK.
Brett Smith [Mon, 13 Apr 2015 17:22:37 +0000 (13:22 -0400)]
5614: Update Workbench Gemfile for new Ruby SDK.

Refs #5614.

9 years ago5414: Fix up formatting.
Tom Clegg [Mon, 13 Apr 2015 17:22:34 +0000 (13:22 -0400)]
5414: Fix up formatting.

9 years agoMerge branch '5614-workbench-optimize-combine-collections-wip'
Brett Smith [Mon, 13 Apr 2015 17:21:15 +0000 (13:21 -0400)]
Merge branch '5614-workbench-optimize-combine-collections-wip'

Refs #5614, #4943.  Closes #5686.

9 years ago5614: Improve Workbench combine collections performance.
Brett Smith [Wed, 8 Apr 2015 20:37:58 +0000 (16:37 -0400)]
5614: Improve Workbench combine collections performance.

* Get links with API list calls, instead of fetching each one
  individually.

* Get a list mapping portable data hashes to UUIDs, and add a single
  UUID per portable data hash to the fetch list.  This helps us avoid
  downloading multiple copies the same manifest text, and is probably
  the single-biggest win in this entire commit for most use cases.

* Use the Ruby SDK to build the new collection.  This lets us avoid
  spawning new arv-normalize processes, and piping large manifests to
  them.  It also lets us build the entire collection and normalize
  only when we're done.

* Use Oj instead of JSON.

9 years ago5614: Workbench renders error flash separately from others.
Brett Smith [Mon, 13 Apr 2015 15:59:51 +0000 (11:59 -0400)]
5614: Workbench renders error flash separately from others.

9 years ago5614: Use assert_includes more in Workbench tests for better diagnostics.
Brett Smith [Wed, 8 Apr 2015 20:00:57 +0000 (16:00 -0400)]
5614: Use assert_includes more in Workbench tests for better diagnostics.

9 years ago5614: Ruby SDK cp_r method creates streams as needed.
Brett Smith [Wed, 8 Apr 2015 19:42:53 +0000 (15:42 -0400)]
5614: Ruby SDK cp_r method creates streams as needed.

9 years ago5614: Add Collection#each_file to Ruby SDK.
Brett Smith [Tue, 7 Apr 2015 19:50:31 +0000 (15:50 -0400)]
5614: Add Collection#each_file to Ruby SDK.

9 years ago5614: Add Collection#exist? to Ruby SDK.
Brett Smith [Tue, 7 Apr 2015 19:29:40 +0000 (15:29 -0400)]
5614: Add Collection#exist? to Ruby SDK.

9 years agoMerge branch '5692-pysdk-manifest-text-flush' closes #5692
Peter Amstutz [Mon, 13 Apr 2015 17:10:09 +0000 (13:10 -0400)]
Merge branch '5692-pysdk-manifest-text-flush' closes #5692

9 years ago5692: Don't call _get_manifest_text from test if we don't need to.
Peter Amstutz [Mon, 13 Apr 2015 16:51:53 +0000 (12:51 -0400)]
5692: Don't call _get_manifest_text from test if we don't need to.

9 years agodropped a header
Nancy Ouyang [Mon, 13 Apr 2015 16:39:19 +0000 (12:39 -0400)]
dropped a header

9 years agotext content done; formatting needed
Nancy Ouyang [Mon, 13 Apr 2015 16:37:50 +0000 (12:37 -0400)]
text content done; formatting needed

9 years agorefs #5365
Radhika Chippada [Mon, 13 Apr 2015 16:02:12 +0000 (12:02 -0400)]
refs #5365
Merge branch '5365-not-link-unreadables'

9 years ago5365: when the attrvalue is not a uuid, link_to_if_arvados_object
Radhika Chippada [Mon, 13 Apr 2015 16:01:33 +0000 (12:01 -0400)]
5365: when the attrvalue is not a uuid, link_to_if_arvados_object

9 years ago5692: Move implementation to internal _get_manifest_text(). Fix typos.
Peter Amstutz [Mon, 13 Apr 2015 15:23:09 +0000 (11:23 -0400)]
5692: Move implementation to internal _get_manifest_text().  Fix typos.

9 years ago5692: Add flush flag to manifest_text() which calls commit_all(). Added
Peter Amstutz [Mon, 13 Apr 2015 14:18:16 +0000 (10:18 -0400)]
5692: Add flush flag to manifest_text() which calls commit_all().  Added
portable_manifest_text() which returns the stripped, normalized manifest text
free of side effects.  Fixed tests.

9 years agocloses #5365
Radhika Chippada [Sun, 12 Apr 2015 21:32:00 +0000 (17:32 -0400)]
closes #5365
Merge branch '5365-not-link-unreadables'

9 years ago5365: add back data-toggle along with link disabled for Log tab.
Radhika Chippada [Sun, 12 Apr 2015 21:29:28 +0000 (17:29 -0400)]
5365: add back data-toggle along with link disabled for Log tab.

9 years ago5365: missed one updated signature update
Radhika Chippada [Sun, 12 Apr 2015 13:06:38 +0000 (09:06 -0400)]
5365: missed one updated signature update

9 years ago5365: updated signature for link_to_arvados_object_if_readable
Radhika Chippada [Sun, 12 Apr 2015 03:06:31 +0000 (23:06 -0400)]
5365: updated signature for link_to_arvados_object_if_readable

9 years ago5692: Backed out commit_all() from Collection.manifest_text().
Peter Amstutz [Fri, 10 Apr 2015 20:24:22 +0000 (16:24 -0400)]
5692: Backed out commit_all() from Collection.manifest_text().
Collection.save() and Collection.save_new() now return unstripped manifest
text.

9 years ago5692: Collection.manifest_text(strip=False) will flush open files and wait for
Peter Amstutz [Fri, 10 Apr 2015 19:27:05 +0000 (15:27 -0400)]
5692: Collection.manifest_text(strip=False) will flush open files and wait for
all blocks to be committed in order to return a manifest text with valid
authorization tokens.  Fix tests affected by the change.

9 years agoMerge branch '5493-getting-started-modal' of git.curoverse.com:arvados into 5493...
Nancy Ouyang [Fri, 10 Apr 2015 17:33:47 +0000 (13:33 -0400)]
Merge branch '5493-getting-started-modal' of git.curoverse.com:arvados into 5493-getting-started-modal

Conflicts:
apps/workbench/app/views/getting_started/_getting_started_popup.html.erb

9 years agofix merge conflicts
Nancy Ouyang [Fri, 10 Apr 2015 17:32:42 +0000 (13:32 -0400)]
fix merge conflicts

9 years agofirst page prototype
Nancy Ouyang [Fri, 10 Apr 2015 16:57:39 +0000 (12:57 -0400)]
first page prototype

9 years ago5365: do not link to docker_image_locator if not readable; also preload these.
Radhika Chippada [Thu, 9 Apr 2015 15:54:59 +0000 (11:54 -0400)]
5365: do not link to docker_image_locator if not readable; also preload these.

9 years agoMerge branch 'master' into 5365-not-link-unreadables
Radhika Chippada [Thu, 9 Apr 2015 14:13:11 +0000 (10:13 -0400)]
Merge branch 'master' into 5365-not-link-unreadables

9 years ago5365: add controller tests for preload_for_pdhs and collection_for_pdh methods
Radhika Chippada [Thu, 9 Apr 2015 14:08:36 +0000 (10:08 -0400)]
5365: add controller tests for preload_for_pdhs and collection_for_pdh methods

9 years ago5365: preload editable component inputs
Radhika Chippada [Thu, 9 Apr 2015 13:37:46 +0000 (09:37 -0400)]
5365: preload editable component inputs

9 years ago5365: add @distinct handling to workbench select queries and use this to preload...
Radhika Chippada [Wed, 8 Apr 2015 23:48:13 +0000 (19:48 -0400)]
5365: add @distinct handling to workbench select queries and use this to preload portable_data_hashes as well.

9 years agoMerge branch '5416-git-config' refs #5416
Tom Clegg [Wed, 8 Apr 2015 18:40:42 +0000 (14:40 -0400)]
Merge branch '5416-git-config' refs #5416

9 years ago5416: Improve logging.
Tom Clegg [Wed, 8 Apr 2015 16:41:31 +0000 (12:41 -0400)]
5416: Improve logging.

9 years ago5416: Do not blow up tests when git global config is uninitialized.
Tom Clegg [Wed, 8 Apr 2015 16:03:44 +0000 (12:03 -0400)]
5416: Do not blow up tests when git global config is uninitialized.

9 years ago5414: Do not blow up if local config file is empty.
Tom Clegg [Wed, 8 Apr 2015 15:40:21 +0000 (11:40 -0400)]
5414: Do not blow up if local config file is empty.

9 years ago5414: Use reflect.DeepEqual instead of comparing serialized maps.
Tom Clegg [Wed, 8 Apr 2015 15:39:48 +0000 (11:39 -0400)]
5414: Use reflect.DeepEqual instead of comparing serialized maps.

9 years ago5414: Add TestGetWithLocalServiceHint.
Tom Clegg [Wed, 1 Apr 2015 15:48:39 +0000 (11:48 -0400)]
5414: Add TestGetWithLocalServiceHint.

9 years ago5414: Clean up Locator / MakeLocator() API.
Tom Clegg [Wed, 1 Apr 2015 15:48:12 +0000 (11:48 -0400)]
5414: Clean up Locator / MakeLocator() API.

9 years ago5414: Add client support for Keep service hints.
Tom Clegg [Sun, 29 Mar 2015 00:26:00 +0000 (20:26 -0400)]
5414: Add client support for Keep service hints.

Also, some incidental improvements in nearby code:

* Consistent logging in keepproxy, with one reusable logging statement
  instead of a different statement/format for each outcome.

* In sdk/go/keepclient, remove public AuthorizedGet and AuthorizedAsk
  methods. Instead, Get() and Ask() accept a locator (with or without
  a permission token) and do the right thing. Callers don't have to
  parse locators to decide which method to call.

* In sdk/go/keepclient, use an RWMutex instead of atomic.LoadPointer()
  and unsafe.Pointer() to update KeepClient root maps safely.

* In sdk/go/keepclient, DiscoverKeepServers() doesn't return the new
  root maps, just an error. In normal usage, the caller only cares
  whether discovery was successful.

Also, some Go style fixes in nearby code:

* Use pointer receivers for all KeepClient methods.
  https://golang.org/doc/faq#methods_on_values_or_pointers

* Use receiver name "kc", not "this".
  https://github.com/golang/go/wiki/CodeReviewComments#receiver-names

* Handle errors first, use minimal indentation for normal code path.
  https://github.com/golang/go/wiki/CodeReviewComments#indent-error-flow

9 years agoMerge branch 'master' into 5493-getting-started-modal
Radhika Chippada [Wed, 8 Apr 2015 14:37:01 +0000 (10:37 -0400)]
Merge branch 'master' into 5493-getting-started-modal

9 years ago5365: Additional test verifications for Log tab display.
Radhika Chippada [Wed, 8 Apr 2015 14:24:30 +0000 (10:24 -0400)]
5365: Additional test verifications for Log tab display.

9 years agoMerge branch '5642-crunch-job-swap-limits-wip'
Brett Smith [Wed, 8 Apr 2015 13:47:09 +0000 (09:47 -0400)]
Merge branch '5642-crunch-job-swap-limits-wip'

Closes #5642, #5664.