Brett Smith [Thu, 5 Feb 2015 21:18:00 +0000 (16:18 -0500)]
5141: Workbench permits float values for number pipeline inputs.
Previously, when a pipeline input had the number dataclass, we
rendered the input form with type=number. However, the Arvados number
dataclass is meant to allow all numeric types. The HTML 5 number
input type only permits integers.
Unfortunately, X-Editable does not have any built-in validation for a
broader range of numeric types. This commit simply removes any
validation.
Tom Clegg [Wed, 4 Feb 2015 22:28:29 +0000 (17:28 -0500)]
3021: Remove ARVADOS_KEEP_PROXY support. (If you need to interfere
with the discovery mechanism from out-of-process, use some combination
of HTTP_PROXY, NO_PROXY, and a generic proxy server.)
Radhika Chippada [Wed, 4 Feb 2015 14:22:05 +0000 (09:22 -0500)]
2659: Do not turn on anonymous config by default in test mode; instead make the tests set it as needed.
Also convert some of the simple integration tests into controller tests.
Tom Clegg [Tue, 3 Feb 2015 21:33:18 +0000 (16:33 -0500)]
2659: Check anon config at runtime instead of boot time in skip_before_filter. This makes it possible for test cases to toggle behavior by changing configuration on the fly.
Brett Smith [Tue, 3 Feb 2015 20:40:10 +0000 (15:40 -0500)]
5131: run-command consumes escape backslashes.
run-command has long recognized backslashes to inhibit
substitution, but it was leaving those backslashes in the string,
which could lead to incorrect commands. This commit makes sure
they're removed after they're parsed.
Radhika Chippada [Tue, 3 Feb 2015 15:20:45 +0000 (10:20 -0500)]
2659: Finally understood the mystery behind the "anonymous tests are failing when run with all other tests".
There is a permission link fixture for anonymous group. I needed to create read permission link for anonymous user.
(Tom thinks) the groups permission cache may be getting out of sync somehow.
Radhika Chippada [Tue, 3 Feb 2015 13:33:29 +0000 (08:33 -0500)]
2659: Expect redirect to login page when show method is executed in jobs controller etc when no anonymous configuration is set.
Something is overriding the configured value from application.default.yml when the test is executed along with all other tests!
Radhika Chippada [Mon, 2 Feb 2015 23:23:16 +0000 (18:23 -0500)]
2659: Do not require login for project tab_counts method as well.
Remove anonymous login tests for /users and /groups pages since we are no longer doing session establishment for anonymous user login.
These are like any other un-shared pages and show login page to user.
Radhika Chippada [Mon, 2 Feb 2015 22:15:55 +0000 (17:15 -0500)]
2659: load @prov_svg outside of the 'if current_user' block so that an anonymous user can see the provenance graph when accessing publicly accessible collection.
Tom Clegg [Mon, 2 Feb 2015 01:13:48 +0000 (20:13 -0500)]
3021: Round up various implementations of "run test servers" into an arvadostest module. Update to work with new run_test_server.py.
* Get the API host, port, and admin token from the run_test_server.py
--auth output, instead of guessing localhost:3000 etc.
* Fix race condition in proxy TestPutAskGetForbidden: set up the
client first, then switch back to a real token for the server to
use, instead of hoping the server grabs its token before sleep(0.1)
returns and we sabotage the environment with a bogus one.
Tom Clegg [Mon, 2 Feb 2015 00:48:09 +0000 (19:48 -0500)]
3021: Refactor run_test_server.
* Always start API server with both https:// and wss:// enabled. Use
mocks to test the websocket-not-available case.
* Leave the API server running between tests; just hit reset() when
needed. Wait until exiting the process to stop the server.
* Do not use rake (tmp:cache:clear, db:test:load, db:fixtures:load) to
reset the API server's database before starting up a new
server. Instead, call /database/reset after starting it. (If that
doesn't work, crash instead of proceeding with undefined results.)
* If a parent process has already started an API server and put its
endpoint in ARVADOS_TEST_API_HOST, use that instead of starting a
new one, and leave it running at exit.
* Start servers on random port numbers, so [some] test suites can run
concurrently with others on a single host (assuming they're
configured to use different databases).
Radhika Chippada [Mon, 2 Feb 2015 01:22:42 +0000 (20:22 -0500)]
2659: (1) Update link_to_if_arvados_object method to display an object name as link for User type only when the user is active.
Otherwise, an anonymous user will always see 404 when such a link is clicked.
(2) In the unlikely event of an anonymous user traversing to /users or /groups pages, there will be an 'Add a new xxx' link,
which is undesirable (even though they do eventually fail when accessed). Hence, hide them for inactive users.
(3) Add test assertions for both the updates.
Radhika Chippada [Sun, 1 Feb 2015 20:09:23 +0000 (15:09 -0500)]
2659: It appears that a job's log file is stored in a user's Home project, instead of the project in which the job originated from.
Due to this, when an anonymous user accesses the job from the publicly accessible project, the Log tab is failing.
Hence, display job -> Log tab for active users only.
Radhika Chippada [Sun, 1 Feb 2015 16:30:40 +0000 (11:30 -0500)]
2659: Collection show_files shows selection dropdown (which has only create new collection from selected files option) when user is active.
Also, dashboard displays the 'Run a pipeline' selector for active users. Upated anonymous user test to verify dashboard access.
Brett Smith [Sun, 1 Feb 2015 16:22:42 +0000 (11:22 -0500)]
5037: Fix tearDown error handling in PySDK Websockets test.
I accidentally broke this in 51f9e6cb. That version would crash if
the test failed to assign self.ws. Refactor to be more robust in that
case. No issue #.
projects / arvados.git / log