2659: add a "you are not logged in" warning in 404 page.

diff --git a/apps/workbench/app/views/application/404.html.erb b/apps/workbench/app/views/application/404.html.erb
index 8a0482274ad0cd18fcbde0d1cb770991ac4f995f..4c8fa7635ebd85912f8dd280c861207ac104822e 100644 (file)
--- a/apps/workbench/app/views/application/404.html.erb
+++ b/apps/workbench/app/views/application/404.html.erb
@@ -13,6 +13,10 @@
 
 <h2>Not Found</h2>
 
+<% if !current_user %>
+<p>You are not logged into Arvados. Please retry after log in.</p><br/>
+<% end %>
+
 <p>The <%= req_item %> was not found.
 
 <% if class_name %>

diff --git a/apps/workbench/test/integration/errors_test.rb b/apps/workbench/test/integration/errors_test.rb
index 03c359e089590f20f8ea12334b7d518923923479..23e8c012af7e78abd091ad3e79473645ad500b5a 100644 (file)
--- a/apps/workbench/test/integration/errors_test.rb
+++ b/apps/workbench/test/integration/errors_test.rb
@@ -126,4 +126,10 @@ class ErrorsTest < ActionDispatch::IntegrationTest
     end
   end
 
+  test "404 page checks if user not logged in and makes suggestion" do
+    visit "/collections/#{BAD_UUID}"
+    assert_text 'You are not logged into Arvados',
+                'Not found: You are not logged into Arvados'
+  end
+
 end