arvados.git
9 months ago21361: Remove StartLimitInterval from service units
Brett Smith [Mon, 29 Jan 2024 03:57:33 +0000 (22:57 -0500)]
21361: Remove StartLimitInterval from service units

CentOS 7 was the last distribution we supported with systemd this old,
and that ends with Arvados 3.0.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

9 months ago21361: Update workbench2 package TARGETS
Brett Smith [Mon, 29 Jan 2024 03:49:27 +0000 (22:49 -0500)]
21361: Update workbench2 package TARGETS

We no longer support centos7, debian10, or ubuntu1804.
We now support debian12 and ubuntu2204.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

9 months ago21361: Remove ubuntu1804 dependencies from services/api package
Brett Smith [Mon, 29 Jan 2024 03:46:52 +0000 (22:46 -0500)]
21361: Remove ubuntu1804 dependencies from services/api package

We no longer support this distribution.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

9 months ago21361: Expand distro detection in Salt installer
Brett Smith [Mon, 29 Jan 2024 03:10:11 +0000 (22:10 -0500)]
21361: Expand distro detection in Salt installer

The immediate motivation for this is to detect Alma/Rocky/RHEL 8.
The way we do it is by reading both the ID and ID_LIKE values from
/etc/os-release. All these have "rhel" in either ID or
ID_LIKE. Similiarly, Ubuntu has ID_LIKE=debian. We're already reading
this file anyway; now we just use more of it.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

9 months ago21361: Remove unsupported distros from build scripts
Brett Smith [Mon, 29 Jan 2024 02:47:31 +0000 (21:47 -0500)]
21361: Remove unsupported distros from build scripts

After this, `git grep -e debian10 -e ubuntu1804 -e centos7 build`
returns nothing.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

9 months ago21392: Package build scripts require --target
Brett Smith [Mon, 29 Jan 2024 02:40:36 +0000 (21:40 -0500)]
21392: Package build scripts require --target

Now that we no longer support debian10, it doesn't make sense as a
default. Rather than continue updating the default at arbitrary points
in time, remove it and require the user to specify their target.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

9 months agoAdd comment to workaround while waiting for upstream to merge PR.
Tom Clegg [Wed, 31 Jan 2024 16:37:23 +0000 (11:37 -0500)]
Add comment to workaround while waiting for upstream to merge PR.

refs #21252

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months agoMerge branch '21317-toolbar-overflow'
Lisa Knox [Thu, 25 Jan 2024 14:16:21 +0000 (09:16 -0500)]
Merge branch '21317-toolbar-overflow'

closes #21317

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months agoMerge branch '21366-subprocess-output-loading-bug' into main. Closes #21366
Stephen Smith [Wed, 24 Jan 2024 21:30:24 +0000 (16:30 -0500)]
Merge branch '21366-subprocess-output-loading-bug' into main. Closes #21366

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months ago21317: overflow now toggles on and off at the same pixel Arvados-DCO-1.1-Signed-off... 21317-toolbar-overflow
Lisa Knox [Wed, 24 Jan 2024 16:19:08 +0000 (11:19 -0500)]
21317: overflow now toggles on and off at the same pixel Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21336: Add type checking to output data reducer instead of accepting any, fix 21366-subprocess-output-loading-bug
Stephen Smith [Tue, 23 Jan 2024 20:00:51 +0000 (15:00 -0500)]
21336: Add type checking to output data reducer instead of accepting any, fix
misalignments in payload type. Rename some properties for clarity to align with
passing in uuid in addition to output details to reducer.

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months ago21317: fixed collapse occlusion Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox...
Lisa Knox [Tue, 23 Jan 2024 16:49:19 +0000 (11:49 -0500)]
21317: fixed collapse occlusion Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21366: Display raw/JSON tab on subprocess even if empty while still guarding against...
Stephen Smith [Tue, 23 Jan 2024 15:40:24 +0000 (10:40 -0500)]
21366: Display raw/JSON tab on subprocess even if empty while still guarding against undefined

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months agoMerge branch '21394-docker-tag-push'
Peter Amstutz [Fri, 19 Jan 2024 14:34:21 +0000 (09:34 -0500)]
Merge branch '21394-docker-tag-push'

Also includes 21230-no-global-pip

This updates how certain dev/test environments install our Python
packages as well as some infrastructure around running the CWL
conformance tests.

refs #21230
refs #21394

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

10 months ago21394: Emit conformance badges json from test_with_arvbox 21394-docker-tag-push
Peter Amstutz [Thu, 18 Jan 2024 15:32:12 +0000 (10:32 -0500)]
21394: Emit conformance badges json from test_with_arvbox

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

10 months agoMerge branch '21353-loginas-flaky-bug' into main. Closes #21353.
Stephen Smith [Thu, 18 Jan 2024 15:04:11 +0000 (10:04 -0500)]
Merge branch '21353-loginas-flaky-bug' into main. Closes #21353.

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months agoMerge branch '20318-disk-cache' 20318-disk-cache
Tom Clegg [Wed, 17 Jan 2024 22:51:34 +0000 (17:51 -0500)]
Merge branch '20318-disk-cache'

closes #20318

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Fix arvados-login-sync and arvados-cli dependencies.
Tom Clegg [Wed, 17 Jan 2024 21:41:24 +0000 (16:41 -0500)]
20318: Fix arvados-login-sync and arvados-cli dependencies.

Previous requirement '~> 2.7.0.rc1' excluded the current prerelease
version '2.8.0.dev20231214204948' that the test suite deliberately
installs ahead of time, so bundler overrode that and selected the last
released published version 2.7.1 from rubygems, which is not
compatible with Ruby 3.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21394: use /opt/arvados-py if present
Peter Amstutz [Wed, 17 Jan 2024 20:28:20 +0000 (15:28 -0500)]
21394: use /opt/arvados-py if present

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

10 months ago21394: Use v1.2.1 tag for CWL conformance tests
Peter Amstutz [Wed, 17 Jan 2024 01:18:53 +0000 (20:18 -0500)]
21394: Use v1.2.1 tag for CWL conformance tests

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

10 months ago20318: Update stale comments to match current error handling.
Tom Clegg [Tue, 16 Jan 2024 22:32:01 +0000 (17:32 -0500)]
20318: Update stale comments to match current error handling.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21394: Adjust how tags are pushed in build/run-build-docker-images.sh
Peter Amstutz [Tue, 16 Jan 2024 21:49:10 +0000 (16:49 -0500)]
21394: Adjust how tags are pushed in build/run-build-docker-images.sh

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

10 months agoMerge branch '21379-user-activity-remote-collection'
Tom Clegg [Tue, 16 Jan 2024 19:05:50 +0000 (14:05 -0500)]
Merge branch '21379-user-activity-remote-collection'

fixes #21379

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21315: css tweaks Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>
Lisa Knox [Tue, 16 Jan 2024 18:23:32 +0000 (13:23 -0500)]
21315: css tweaks Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21315: functionality to skip first hidden button in place Arvados-DCO-1.1-Signed...
Lisa Knox [Tue, 16 Jan 2024 16:59:09 +0000 (11:59 -0500)]
21315: functionality to skip first hidden button in place Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21230: Update virtualenv in fed-migrate test 21230-no-global-pip
Brett Smith [Tue, 16 Jan 2024 16:14:02 +0000 (11:14 -0500)]
21230: Update virtualenv in fed-migrate test

I don't believe this is strictly necessary, but `python3 -m venv` is
more likely to work than `virtualenv` and better matches all our other
code. Everything else is just style updates.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Add license header
Brett Smith [Tue, 16 Jan 2024 16:39:26 +0000 (11:39 -0500)]
21230: Add license header

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Update test_with_arvbox.sh to use arvbox virtualenv
Brett Smith [Tue, 16 Jan 2024 15:55:59 +0000 (10:55 -0500)]
21230: Update test_with_arvbox.sh to use arvbox virtualenv

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Refactor out pip_install_sdist function
Brett Smith [Tue, 16 Jan 2024 15:38:42 +0000 (10:38 -0500)]
21230: Refactor out pip_install_sdist function

This can be useful to supporting tooling like test_with_arvbox.sh.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21353: Add waitForDom in process spec 21353-loginas-flaky-bug 21353-test3
Stephen Smith [Tue, 16 Jan 2024 01:35:38 +0000 (20:35 -0500)]
21353: Add waitForDom in process spec

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months ago21353: Add waitForDom to loginAs to wait before getting elements
Stephen Smith [Tue, 16 Jan 2024 00:59:32 +0000 (19:59 -0500)]
21353: Add waitForDom to loginAs to wait before getting elements

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months ago21353: Move url location check into waitUntil
Stephen Smith [Mon, 15 Jan 2024 21:44:12 +0000 (16:44 -0500)]
21353: Move url location check into waitUntil

It seems possible for window.location to be defined, then later undefined.
Moving the url location check should solve the problem by waiting for redirects
to be done.

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months ago21353: Add cypress-wait-until to prevent cy.url before window.location is
Stephen Smith [Mon, 15 Jan 2024 21:02:16 +0000 (16:02 -0500)]
21353: Add cypress-wait-until to prevent cy.url before window.location is
defined in loginAs, fixes flaky test

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months ago21230: Fix typo
Brett Smith [Mon, 15 Jan 2024 15:48:23 +0000 (10:48 -0500)]
21230: Fix typo

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Update yml_override.py for PyYAML 6.0+
Brett Smith [Mon, 15 Jan 2024 15:23:54 +0000 (10:23 -0500)]
21230: Update yml_override.py for PyYAML 6.0+

This tool gets called to update configuration files for other Arvados
services, so we're not expecting it to deal with any Python objects.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Activate virtualenv in arvbox doc service
Brett Smith [Mon, 15 Jan 2024 14:52:29 +0000 (09:52 -0500)]
21230: Activate virtualenv in arvbox doc service

Generating the PySDK docs needs to actually import pdoc, not just run
it. Given this, linking pdoc in /usr/local/bin/ is probably more
confusing than helpful, so don't.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Clean up directory state in arvbox doc service
Brett Smith [Mon, 15 Jan 2024 14:47:30 +0000 (09:47 -0500)]
21230: Clean up directory state in arvbox doc service

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months agoMerge branch '21285-installer-updates'. Closes #21285
Lucas Di Pentima [Fri, 12 Jan 2024 21:27:39 +0000 (18:27 -0300)]
Merge branch '21285-installer-updates'. Closes #21285

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

10 months ago21285: Fixes worker & nofile calculations on nginx config. 21285-installer-updates
Lucas Di Pentima [Fri, 12 Jan 2024 20:45:59 +0000 (17:45 -0300)]
21285: Fixes worker & nofile calculations on nginx config.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

10 months ago21230: Fix binstubs generation in arvbox
Brett Smith [Fri, 12 Jan 2024 19:30:45 +0000 (14:30 -0500)]
21230: Fix binstubs generation in arvbox

At some point, bundle started installing binstubs in `bin/` by
default. Various pieces of arvbox assume they go in `binstubs/` and
break when they don't. Explicitly pass options to get the old behavior
where needed.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Use virtualenv in arvbox
Brett Smith [Fri, 12 Jan 2024 15:52:00 +0000 (10:52 -0500)]
21230: Use virtualenv in arvbox

This is preparation to let us build arvbox on Debian 12, which has
adopted PEP 668 and doesn't permit installing packages outside a
virtualenv anymore.

This does move pdoc installation out of the doc service and into the
Dockerfile. The doc code currently doesn't have any way to version this
dependency, and it rarely changes in development, so this seems fine as
a code simplification.

All the code that tries to "pip install from cache only, then use the
network" is gone because as best I can tell it's already non-functional:
the pip cache isn't structured in the way that it assumes
anymore. Generally pip looks at what's installed in the virtualenv and
only installs what it *must* to satisfy dependencies, so this seems
fine.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months agoMerge branch '21315-row-select'
Lisa Knox [Fri, 12 Jan 2024 20:24:42 +0000 (15:24 -0500)]
Merge branch '21315-row-select'

closes #21315

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: increased checkbox hitbox size Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa... 21315-row-select
Lisa Knox [Fri, 12 Jan 2024 20:21:23 +0000 (15:21 -0500)]
21317: increased checkbox hitbox size Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21366: Add unit tests to verify io panel doesn't get stuck showing spinner
Stephen Smith [Fri, 12 Jan 2024 20:20:58 +0000 (15:20 -0500)]
21366: Add unit tests to verify io panel doesn't get stuck showing spinner

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months ago21366: Tweaks the condition for displaying io panel subprocess spinner
Stephen Smith [Fri, 12 Jan 2024 20:18:04 +0000 (15:18 -0500)]
21366: Tweaks the condition for displaying io panel subprocess spinner

It no longer shows when there are input mounts or output collection to show.
Also fixes possibility of spinner and no results showing simultaneously.

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

10 months agoMerge branch '21316-left-panel-collapse'
Lisa Knox [Fri, 12 Jan 2024 19:50:49 +0000 (14:50 -0500)]
Merge branch '21316-left-panel-collapse'

closes #21316

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21379: Follow rules for federated list queries. 21379-user-activity-remote-collection
Tom Clegg [Fri, 12 Jan 2024 19:43:43 +0000 (14:43 -0500)]
21379: Follow rules for federated list queries.

* cannot execute federated list query unless count=="none"

* cannot execute federated list query with limit (1) < nUUIDs (1),
  offset (0) > 0, or order ([created_at]) parameter

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21317: increased default toolbar width Arvados-DCO-1.1-Signed-off-by: Lisa Knox ...
Lisa Knox [Fri, 12 Jan 2024 19:04:48 +0000 (14:04 -0500)]
21317: increased default toolbar width Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: set viewport width to 1920 in spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox...
Lisa Knox [Fri, 12 Jan 2024 18:21:58 +0000 (13:21 -0500)]
21317: set viewport width to 1920 in spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: reset all specs Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii...
Lisa Knox [Fri, 12 Jan 2024 17:03:49 +0000 (12:03 -0500)]
21317: reset all specs Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago20318: Avoid error when cache file is deleted while being written.
Tom Clegg [Fri, 12 Jan 2024 16:06:19 +0000 (11:06 -0500)]
20318: Avoid error when cache file is deleted while being written.

The previous code had one goroutine writing the cache file, and
another goroutine(s) waiting for it to finish, then opening the file
for reading. If the cache file was deleted before being opened for
reading, ReadAt would return an error.

The new code shares the writer's filehandle with all of the goroutines
that are waiting for it to finish writing. This ensures ReadAt can
always read from the newly written file even if it is deleted
mid-write.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21317: set viewport width in collection spec Arvados-DCO-1.1-Signed-off-by: Lisa...
Lisa Knox [Fri, 12 Jan 2024 16:05:54 +0000 (11:05 -0500)]
21317: set viewport width in collection spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: tweak collection spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox...
Lisa Knox [Fri, 12 Jan 2024 15:49:59 +0000 (10:49 -0500)]
21317: tweak collection spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: tweak process workflow and collection specs Arvados-DCO-1.1-Signed-off-by...
Lisa Knox [Fri, 12 Jan 2024 15:36:37 +0000 (10:36 -0500)]
21317: tweak process workflow and collection specs Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: tweak project spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii...
Lisa Knox [Fri, 12 Jan 2024 15:22:16 +0000 (10:22 -0500)]
21317: tweak project spec Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21230: Remove pip install from get-package-version
Brett Smith [Fri, 12 Jan 2024 14:39:41 +0000 (09:39 -0500)]
21230: Remove pip install from get-package-version

Reasons to remove this: it can't work on Debian 12+, and the code has
obviously gotten stale with its original rationale ('setuptools<45' is
definitely not "latest setuptools").

Nobody can tell me what context this runs in. I'm going to hope that it
runs in some context where setuptools is already available. If it turns
out I'm wrong, then hopefully that will break the build in a way that
lets me assess our options.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Clean up unnecessary Python packages from package build Dockerfiles
Brett Smith [Fri, 12 Jan 2024 14:31:27 +0000 (09:31 -0500)]
21230: Clean up unnecessary Python packages from package build Dockerfiles

* python3-pip: `ensurepip` is standard as of Python 3.4+.
* python3-setuptools: We want to install this in our build
  virtualenv anyway.
* python3-virtualenv: python3-venv is sufficient.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21230: Remove `pip install virtualenv` from package build Dockerfiles
Brett Smith [Fri, 12 Jan 2024 14:26:34 +0000 (09:26 -0500)]
21230: Remove `pip install virtualenv` from package build Dockerfiles

Installing the python3-venv package is sufficient.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months agoMerge branch 'main' into 21317-toolbar-overflow
Lisa Knox [Fri, 12 Jan 2024 14:20:32 +0000 (09:20 -0500)]
Merge branch 'main' into 21317-toolbar-overflow

refs# 21317

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago20318: Bypass disk cache in keep-rsync.
Tom Clegg [Thu, 11 Jan 2024 20:51:20 +0000 (15:51 -0500)]
20318: Bypass disk cache in keep-rsync.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Fix tests that expect Get to work on bare hashes.
Tom Clegg [Thu, 11 Jan 2024 20:12:57 +0000 (15:12 -0500)]
20318: Fix tests that expect Get to work on bare hashes.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Fix ornery tests that hang/panic instead of failing.
Tom Clegg [Thu, 11 Jan 2024 20:08:56 +0000 (15:08 -0500)]
20318: Fix ornery tests that hang/panic instead of failing.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Fix settled condition.
Tom Clegg [Thu, 11 Jan 2024 18:10:47 +0000 (13:10 -0500)]
20318: Fix settled condition.

Intention was to stop iterating when *all* of the keepstore servers
need 0 pulls, but the code as written stops on the N>1st iteration
when *any* of the keepstore servers need 0 pulls. This caused a false
negative when it took more than one iteration for keepstore to
complete the requested pulls.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Clean up some gocheck usage: Equals, Nil -> IsNil
Tom Clegg [Thu, 11 Jan 2024 18:10:22 +0000 (13:10 -0500)]
20318: Clean up some gocheck usage: Equals, Nil -> IsNil

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Route (*KeepClient)Get() through disk cache layer.
Tom Clegg [Thu, 11 Jan 2024 17:01:11 +0000 (12:01 -0500)]
20318: Route (*KeepClient)Get() through disk cache layer.

The updated implementation maintains the existing calling signature
but has some semantic differences:

The block size returned by Get is now -1 if the block size is not
indicated by the supplied locator. All locators generated by Arvados
include sizes, and Get() doesn't work on bare hashes because they have
no permission signature, so in practice this only comes up for test
cases and keepstore's pull worker.

The url returned by Get is now "" because
* in general it is not necessarily available in principle (data often
  comes from the cache instead of a backend server)
* in the cases where it is available in principle, it would be a lot
  of trouble to propagate it
* the only known reason to reveal the url is to provide detail about
  an error, in which case the error message should already include the
  relevant url.

In some cases where the upstream server responds 200 but an error is
detected early in the response content, Get() now returns the error
itself, where the old Get() implementation would have returned a
reader whose Read method returns an error.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21317: made search input width static Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa...
Lisa Knox [Thu, 11 Jan 2024 19:37:25 +0000 (14:37 -0500)]
21317: made search input width static Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: fixed search input resizing bug Arvados-DCO-1.1-Signed-off-by: Lisa Knox ...
Lisa Knox [Thu, 11 Jan 2024 19:27:08 +0000 (14:27 -0500)]
21317: fixed search input resizing bug Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: cleanup Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>
Lisa Knox [Thu, 11 Jan 2024 18:30:22 +0000 (13:30 -0500)]
21317: cleanup Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: overflow now accounts for dynamic menu length Arvados-DCO-1.1-Signed-off-by...
Lisa Knox [Thu, 11 Jan 2024 17:01:09 +0000 (12:01 -0500)]
21317: overflow now accounts for dynamic menu length Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago20318: Fix DiskCacheSize not propagated by (*KeepClient)Clone().
Tom Clegg [Thu, 11 Jan 2024 16:49:42 +0000 (11:49 -0500)]
20318: Fix DiskCacheSize not propagated by (*KeepClient)Clone().

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Bypass disk cache in certain tests, keepstore, and keepproxy.
Tom Clegg [Thu, 11 Jan 2024 16:48:28 +0000 (11:48 -0500)]
20318: Bypass disk cache in certain tests, keepstore, and keepproxy.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Propagate Close error from http backend.
Tom Clegg [Thu, 11 Jan 2024 16:45:10 +0000 (11:45 -0500)]
20318: Propagate Close error from http backend.

This isn't known to happen, but if it does, it should propagate.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Fix BadChecksum error not propagated through cache layer.
Tom Clegg [Thu, 11 Jan 2024 16:22:27 +0000 (11:22 -0500)]
20318: Fix BadChecksum error not propagated through cache layer.

Previously, ReadAt would not return an error as long as enough bytes
were read, because the error might mean the read was truncated after
the point needed for the current read. This had the unintended
consequence that even a BadChecksum error returned on the final read
would not be propagated.

The updated version propagates errors even if the requested bytes were
retrieved, so the only case where a bad checksum error can be
undetected is when the read does not reach the end of the block *and*
the block has not been fully retrieved yet.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago20318: Remove redundant WriteTo case already handled by io.Copy.
Tom Clegg [Thu, 11 Jan 2024 16:21:58 +0000 (11:21 -0500)]
20318: Remove redundant WriteTo case already handled by io.Copy.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21317: cleanup Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>
Lisa Knox [Thu, 11 Jan 2024 16:02:04 +0000 (11:02 -0500)]
21317: cleanup Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: overflow css Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>
Lisa Knox [Thu, 11 Jan 2024 15:55:17 +0000 (10:55 -0500)]
21317: overflow css Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: added menu types Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii...
Lisa Knox [Thu, 11 Jan 2024 14:51:23 +0000 (09:51 -0500)]
21317: added menu types Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21367: Use --dist-dir option of setup.py sdist
Brett Smith [Thu, 11 Jan 2024 14:41:51 +0000 (09:41 -0500)]
21367: Use --dist-dir option of setup.py sdist

Way cleaner and clearer. Refs #21367.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21317: added tooltip to overflow icon Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa...
Lisa Knox [Thu, 11 Jan 2024 14:37:06 +0000 (09:37 -0500)]
21317: added tooltip to overflow icon Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months ago21317: toolbar css good Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii...
Lisa Knox [Thu, 11 Jan 2024 14:29:28 +0000 (09:29 -0500)]
21317: toolbar css good Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months agoMerge branch '21367-arvados-jobs-update'
Brett Smith [Wed, 10 Jan 2024 22:03:12 +0000 (17:03 -0500)]
Merge branch '21367-arvados-jobs-update'

Closes #21367.
Refs #21230.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21367: Prefer COPY to ADD
Brett Smith [Wed, 10 Jan 2024 22:02:05 +0000 (17:02 -0500)]
21367: Prefer COPY to ADD

This avoids ADD's auto-extract behavior and helps keep the image a
little cleaner.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21367: Explicitly install setuptools
Brett Smith [Wed, 10 Jan 2024 22:01:41 +0000 (17:01 -0500)]
21367: Explicitly install setuptools

Prepare for a PEP 517 world.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21367/21230: Set up dev-jobs with virtualenv 21367-arvados-jobs-update
Brett Smith [Wed, 10 Jan 2024 18:43:20 +0000 (13:43 -0500)]
21367/21230: Set up dev-jobs with virtualenv

The functional goal here is to do all pip installs inside the Dockerfile
inside a virtualenv to avoid the global pip install issues.

Changes that fall out of that:

* Installing python3-venv is all we need to go back to the -slim Debian
  image.
* Stop installing other Python packages we'll just install inside the
  virtualenv anyway.
* Rather than having separate arguments and code blocks for every
  package we might want to install, just set up a dedicated build
  context for the Docker image with all the packages we want to install,
  and install them all unconditionally during the image build. This is
  much less code and hopefully easier to follow.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21367: Remove environment check
Brett Smith [Wed, 10 Jan 2024 18:33:36 +0000 (13:33 -0500)]
21367: Remove environment check

You only need for this for `arv-keepdocker` at the end of the process,
which can read from settings.conf just fine too. Even if it fails, the
developer will have the command handy to fix their environment and try
that again easily.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21367: Remove debug print
Brett Smith [Wed, 10 Jan 2024 18:33:13 +0000 (13:33 -0500)]
21367: Remove debug print

Doubly redundant since we're using `set -x` here anyway.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21285: Updates overview dashboard to include concurrent reqs queue names.
Lucas Di Pentima [Tue, 9 Jan 2024 22:03:05 +0000 (19:03 -0300)]
21285: Updates overview dashboard to include concurrent reqs queue names.

At the moment we have 2 queues: "api" & "tunnel", I think this change will
allow the dashboard to adapt to potential new queues (instead of hardcoding
queue names in the query)

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

10 months ago20318: Fix bad compare / short read behavior in DiskCache BlockRead.
Tom Clegg [Tue, 9 Jan 2024 21:59:21 +0000 (16:59 -0500)]
20318: Fix bad compare / short read behavior in DiskCache BlockRead.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21367: Use regular bullseye instead of bullseye-slim
Peter Amstutz [Tue, 9 Jan 2024 21:51:53 +0000 (16:51 -0500)]
21367: Use regular bullseye instead of bullseye-slim

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

10 months agoAdd arvbox check for fs.inotify.max_user_watches, refs #21349
Peter Amstutz [Tue, 9 Jan 2024 21:14:14 +0000 (16:14 -0500)]
Add arvbox check for fs.inotify.max_user_watches, refs #21349

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

10 months ago21367: Add arvados virtualenv to $PATH
Brett Smith [Tue, 9 Jan 2024 20:38:33 +0000 (15:38 -0500)]
21367: Add arvados virtualenv to $PATH

This is both more user-friendly (now a-c-r itself is in $PATH) and a
cleaner implementation than the previous version.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21367: Modernize apt key handling in arvados/jobs Dockerfile
Brett Smith [Tue, 9 Jan 2024 20:34:29 +0000 (15:34 -0500)]
21367: Modernize apt key handling in arvados/jobs Dockerfile

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21367: Remove debug prints
Brett Smith [Tue, 9 Jan 2024 20:26:06 +0000 (15:26 -0500)]
21367: Remove debug prints

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21367: Update arvados/jobs image to bullseye
Brett Smith [Tue, 9 Jan 2024 20:24:24 +0000 (15:24 -0500)]
21367: Update arvados/jobs image to bullseye

Required for Python 3.7 deprecation.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

10 months ago21285: Adds MaxGatewayTunnels' value to nginx's request queue size.
Lucas Di Pentima [Tue, 9 Jan 2024 17:35:53 +0000 (14:35 -0300)]
21285: Adds MaxGatewayTunnels' value to nginx's request queue size.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

10 months ago21317: initial overflow components up Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa...
Lisa Knox [Tue, 9 Jan 2024 16:10:05 +0000 (11:10 -0500)]
21317: initial overflow components up Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

10 months agoMerge branch '21258-flaky-adc-test'
Tom Clegg [Tue, 9 Jan 2024 16:05:29 +0000 (11:05 -0500)]
Merge branch '21258-flaky-adc-test'

fixes #21258

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months agoMerge branch '21036-keep-balance-metrics'
Tom Clegg [Tue, 9 Jan 2024 16:04:09 +0000 (11:04 -0500)]
Merge branch '21036-keep-balance-metrics'

fixes #21036

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

10 months ago21285: Adds max gw tunnels config to multi host installer.
Lucas Di Pentima [Tue, 9 Jan 2024 15:28:56 +0000 (12:28 -0300)]
21285: Adds max gw tunnels config to multi host installer.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

10 months agoMerge branch '20846-package-build-fixes'
Brett Smith [Mon, 8 Jan 2024 21:48:00 +0000 (16:48 -0500)]
Merge branch '20846-package-build-fixes'

Closes #21273.
Refs #20846, #21230.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>