Tom Clegg [Fri, 7 Nov 2014 03:28:00 +0000 (22:28 -0500)]
3400: Remove ArvadosResourceList#all
Peter Amstutz [Wed, 5 Nov 2014 21:26:37 +0000 (16:26 -0500)]
3400: Too much code that assumes it can call .first over and over without
incurring an API call each time (silly).
Peter Amstutz [Wed, 5 Nov 2014 20:57:01 +0000 (15:57 -0500)]
3400: ArvadosResourceList returns all items (paging as necessary) unless limit() is specified.
* ArvadosResourceList#each returns results incrementally. ArvadosResourceList#all (or ArvadosResourceList#results) prefetches the entire list.
* Added tests. Fixed tests.
* Removed hardcoded limit() in cases where it was apparent that it was being used as a workaround for the paging problem.
* Removed obsolete name_link code (including CollectionsController#choose override) that was causing tests to fail.
Brett Smith [Tue, 4 Nov 2014 17:38:55 +0000 (12:38 -0500)]
4412: Remaining Ruby clients use :body_object for API requests.
A follow-up from the last commit. Refs #4412.
Brett Smith [Tue, 4 Nov 2014 17:31:00 +0000 (12:31 -0500)]
4412: arv edit consistently uses :body_object in API requests.
Fixes #4412.
Peter Amstutz [Tue, 4 Nov 2014 15:57:37 +0000 (10:57 -0500)]
Merge branch '4031-fix-graph-connections' closes #4031
Phil Hodgson [Tue, 4 Nov 2014 15:16:21 +0000 (16:16 +0100)]
Merge branch '3618-column-ordering' closes #3618
Peter Amstutz [Tue, 4 Nov 2014 15:15:16 +0000 (10:15 -0500)]
4031: Fix tests. Move RequestDuck to test_helper.rb so as not to duplicate code.
Tom Clegg [Tue, 4 Nov 2014 14:48:44 +0000 (09:48 -0500)]
Update version dependency to ensure CollectionReader has a normalize() method. refs #3706
Phil Hodgson [Tue, 4 Nov 2014 14:47:11 +0000 (15:47 +0100)]
Merge branch 'master' into 3618-column-ordering
Phil Hodgson [Tue, 4 Nov 2014 13:58:44 +0000 (14:58 +0100)]
3618: accommodate new fixture indexing in pipeline_instance tests (including run-time=0 test)
Phil Hodgson [Tue, 4 Nov 2014 11:32:55 +0000 (12:32 +0100)]
3618: accommodate new fixture indexing in pipeline_instance tests
Tom Clegg [Mon, 3 Nov 2014 22:30:15 +0000 (17:30 -0500)]
Merge branch '3706-keep-warning' closes #3706
Tom Clegg [Mon, 3 Nov 2014 22:27:54 +0000 (17:27 -0500)]
3706: Oops, the test was broken, the feature works fine.
Tom Clegg [Mon, 3 Nov 2014 22:13:38 +0000 (17:13 -0500)]
3706: Add (skipped) test for broken max_manifest_depth=0 feature.
Peter Amstutz [Mon, 3 Nov 2014 21:00:00 +0000 (16:00 -0500)]
4031: Add owner_uuid to graph_test_collection fixtures.
Tom Clegg [Mon, 3 Nov 2014 20:27:13 +0000 (15:27 -0500)]
3706: Merge branch 'master' into 3706-keep-warning
Peter Amstutz [Mon, 3 Nov 2014 20:07:10 +0000 (15:07 -0500)]
Merge remote-tracking branch 'origin/master' into 4031-fix-graph-connections
Conflicts:
services/api/test/fixtures/collections.yml
Peter Amstutz [Mon, 3 Nov 2014 20:06:09 +0000 (15:06 -0500)]
4031: Improve provenance graph tests for readability, use fixtures instead of
hardcoded hashes. Improve efficiency of matching collections in search_edges.
Remove spurious debug code.
Tom Clegg [Mon, 3 Nov 2014 19:33:15 +0000 (14:33 -0500)]
3706: Remove superfluous conditional.
Tom Clegg [Mon, 3 Nov 2014 18:33:06 +0000 (13:33 -0500)]
3706: Add back "collections.get => 404" to "fallback to Keep" test.
Ward Vandewege [Mon, 3 Nov 2014 18:31:26 +0000 (13:31 -0500)]
The sso server docker image is not used by default at the moment, so
arvdock shouldn't try to start it unless explicitly requested (part 2).
refs #4383
Tom Clegg [Mon, 3 Nov 2014 14:35:59 +0000 (09:35 -0500)]
3706: Prefer "is None" and "is not None" to "== None" and "!= None".
Tom Clegg [Mon, 3 Nov 2014 14:33:16 +0000 (09:33 -0500)]
3706: Mutating normalize() does not return self.
Tom Clegg [Mon, 3 Nov 2014 14:32:16 +0000 (09:32 -0500)]
3706: Process directory trees in sorted() order, instead of the order
returned by os.listdir().
This causes write_directory_tree() to produce a manifest that is
normalized to the greatest extent possible for the given
max_manifest_depth.
Brett Smith [Mon, 3 Nov 2014 16:10:51 +0000 (11:10 -0500)]
4388: Ruby Keep::Manifest skips blank lines in manifests.
Closes #4388.
Ward Vandewege [Mon, 3 Nov 2014 15:33:54 +0000 (10:33 -0500)]
The sso server docker image is not used by default at the moment, so
arvdock shouldn't try to start it unless explicitly requested.
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 04:39:40 +0000 (23:39 -0500)]
system_user and anonymous_user should be excluded from
auto_setup_new_user, always.
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 02:03:34 +0000 (21:03 -0500)]
Enable auto_setup_new_users in the docker API server image.
refs #4383
Phil Hodgson [Sat, 1 Nov 2014 14:22:48 +0000 (15:22 +0100)]
3618: refactor scroll tests to share code
Tom Clegg [Fri, 31 Oct 2014 23:46:26 +0000 (19:46 -0400)]
3706: Clarify test case.
Tom Clegg [Fri, 31 Oct 2014 23:36:49 +0000 (19:36 -0400)]
3706: Prefer join() to many string concatenations.
Tom Clegg [Fri, 31 Oct 2014 22:58:37 +0000 (18:58 -0400)]
3706: Prefer "if x" to "if len(x) > 0".
Tom Clegg [Fri, 31 Oct 2014 22:56:16 +0000 (18:56 -0400)]
3706: Two blank lines after class definition.
Tom Clegg [Fri, 31 Oct 2014 21:21:31 +0000 (17:21 -0400)]
3706: Really make the API server return the wrong data, instead of just saying so.
Tom Clegg [Fri, 31 Oct 2014 20:48:34 +0000 (16:48 -0400)]
3706: Put --normalize and --max-manifest-depth arguments in a mutually_exclusive_group.
Tim Pierce [Fri, 31 Oct 2014 20:45:56 +0000 (16:45 -0400)]
Merge branch '4040-fuse-tests'
Fixes #4040.
Tom Clegg [Fri, 31 Oct 2014 20:44:19 +0000 (16:44 -0400)]
3706: normalize() returns None instead of self. Add equally convenient, and more Pythonic, manifest_text(normalize=True) feature.
Tom Clegg [Fri, 31 Oct 2014 20:30:07 +0000 (16:30 -0400)]
3706: Catch and return exceptions in _populate_* methods to dry up _populate()
Tim Pierce [Fri, 31 Oct 2014 20:21:11 +0000 (16:21 -0400)]
4040: code review feedback
* Renamed
** collection_owned_by_fuse_1 -> collection_1_owned_by_fuse
** collection_owned_by_fuse_2 -> collection_2_owned_by_fuse
* Added fixtures pipeline_instance_owned_by_fuse and
pipeline_instance_in_fuse_project.
* Added name link for the empty collection, to exercise that links are
exposed in the filesystem in the expected way.
Ward Vandewege [Fri, 31 Oct 2014 20:13:52 +0000 (16:13 -0400)]
Fix broken link in docs. Duh.
refs #4186
Ward Vandewege [Fri, 31 Oct 2014 15:04:03 +0000 (11:04 -0400)]
Merge branch '4186-install-doc-improvements-2'
refs #4186
Ward Vandewege [Fri, 31 Oct 2014 15:03:30 +0000 (11:03 -0400)]
Clean up the installation overview pages a bit more.
refs #4186
Ward Vandewege [Fri, 31 Oct 2014 14:52:24 +0000 (10:52 -0400)]
Merge branch 'master' into 4186-install-doc-improvements-2
Ward Vandewege [Fri, 31 Oct 2014 14:47:45 +0000 (10:47 -0400)]
Add keepstore installation page.
refs #4186
Ward Vandewege [Fri, 31 Oct 2014 14:43:28 +0000 (10:43 -0400)]
Workbench: Change from yui to uglifier to compress javascript in
config/environments/production.rb.example
No issue #
Ward Vandewege [Fri, 31 Oct 2014 02:07:11 +0000 (22:07 -0400)]
Fix typo.
refs #4186
Ward Vandewege [Wed, 29 Oct 2014 16:27:45 +0000 (12:27 -0400)]
Keepproxy just needs an anonymous token.
refs #4186
Ward Vandewege [Wed, 29 Oct 2014 15:40:12 +0000 (11:40 -0400)]
Batch of improvements for the manual installation documentation:
* add prerequisites section
* add shell server section
* add keepproxy section
* many other updates throughout
refs #4186
Phil Hodgson [Fri, 31 Oct 2014 13:04:51 +0000 (14:04 +0100)]
3618: improve api security for sorting to make sure each column we sort by is for a real table and a real column in the db
Phil Hodgson [Fri, 31 Oct 2014 13:04:07 +0000 (14:04 +0100)]
3618: make sure something happens if the order param is actually detected as an array
Phil Hodgson [Fri, 31 Oct 2014 13:03:25 +0000 (14:03 +0100)]
3618: bug fix: was confusing the "desc" meaning a "descending sort" with the "desc" that is the beginning of the column name "description"
Phil Hodgson [Fri, 31 Oct 2014 12:56:01 +0000 (13:56 +0100)]
Merge branch 'master' into 3618-column-ordering
Conflicts (all resolved including fixes):
apps/workbench/app/controllers/projects_controller.rb
apps/workbench/app/views/projects/_show_jobs_and_pipelines.html.erb
apps/workbench/app/views/projects/_show_tab_contents.html.erb
services/api/app/controllers/arvados/v1/groups_controller.rb
Tom Clegg [Thu, 30 Oct 2014 21:13:31 +0000 (17:13 -0400)]
Merge branch '3824-crunch-container-setup' closes #3824
Tom Clegg [Thu, 30 Oct 2014 21:13:23 +0000 (17:13 -0400)]
3824: Merge branch 'master' into 3824-crunch-container-setup
Tom Clegg [Thu, 30 Oct 2014 21:05:25 +0000 (17:05 -0400)]
3824: Fix comment to state that tasks must not assume $TASK_KEEPMOUNT is /keep.
Tom Clegg [Thu, 30 Oct 2014 20:33:23 +0000 (16:33 -0400)]
Fix google-api-client version deps. No issue #
Tom Clegg [Thu, 30 Oct 2014 20:30:56 +0000 (16:30 -0400)]
Merge branch '4359-project-paging' closes #4359
Tom Clegg [Thu, 30 Oct 2014 20:13:35 +0000 (16:13 -0400)]
Merge branch '4088-filterable-docs' refs #4088
Tom Clegg [Thu, 30 Oct 2014 19:59:41 +0000 (15:59 -0400)]
3706: Use normalize() in arv-mount.
Tom Clegg [Thu, 30 Oct 2014 18:48:05 +0000 (14:48 -0400)]
3824: Import GPG key needed for RVM installation.
Tom Clegg [Thu, 30 Oct 2014 18:27:58 +0000 (14:27 -0400)]
3824: Remove redundant "apt-get update", standardize on "apt-get update -qq" and "apt-get install -qqy".
Tom Clegg [Thu, 30 Oct 2014 18:04:14 +0000 (14:04 -0400)]
3824: Set mode on /etc/fuse.conf in compute image.
Brett Smith [Thu, 30 Oct 2014 17:45:10 +0000 (13:45 -0400)]
4307: Workbench: only pipeline components are not editable after start.
This fixes a regression from
d7fdbbab. Closes #4307.
Tom Clegg [Thu, 30 Oct 2014 17:43:34 +0000 (13:43 -0400)]
4088: Add usage docs to filterable.js
Tom Clegg [Thu, 30 Oct 2014 17:05:17 +0000 (13:05 -0400)]
3824: Bring back $! in error message, in case it's helpful.
Tom Clegg [Thu, 30 Oct 2014 17:02:56 +0000 (13:02 -0400)]
3824: Merge branch 'master' into 3824-crunch-container-setup
Tom Clegg [Thu, 30 Oct 2014 17:00:05 +0000 (13:00 -0400)]
3824: Use Data::Dumper instead of custom quoting to show srun/task exec args.
Tom Clegg [Wed, 29 Oct 2014 21:06:17 +0000 (17:06 -0400)]
4091: Use <=N instead of <N+1. Pass "uuid not in" filter to API instead of adding custom filter params.
Tim Pierce [Wed, 29 Oct 2014 20:23:08 +0000 (16:23 -0400)]
4040: clarify variable names
Per code review: give d1, d2, d3 more descriptive variable names.
radhika [Wed, 29 Oct 2014 19:23:45 +0000 (15:23 -0400)]
closes #4091
Merge branch '4091-test-infinite-scrolling'
radhika [Wed, 29 Oct 2014 19:23:07 +0000 (15:23 -0400)]
Merge branch 'master' into 4091-test-infinite-scrolling
radhika [Wed, 29 Oct 2014 19:21:45 +0000 (15:21 -0400)]
4091: set the limit size to 50 for "Jobs and pipelines" tab.
Tim Pierce [Wed, 29 Oct 2014 19:12:47 +0000 (15:12 -0400)]
4040: update FUSE driver tests with stable fixtures
Added test fixtures specifically for FUSE driver tests.
Brett Smith [Wed, 29 Oct 2014 18:58:59 +0000 (14:58 -0400)]
Fix Node Manager test bug introduced by last commit.
Bad Brett, only running specific tests. No issue #.
Brett Smith [Wed, 29 Oct 2014 18:22:16 +0000 (14:22 -0400)]
Fix race condition in Node Manager shutdown tests.
ComputeNodeMonitorActor considers a shutdown when it's initialized.
Blocking on the subscription we send ensures that message is fully
processed before the tests continue. This is important because
several of them change the shutdown state immediately after, and that
might be seen by the internal shutdown consideration without this.
No issue #, but see
<https://ci.curoverse.com/job/arvados-api-server/1027/console>.
Tim Pierce [Wed, 29 Oct 2014 16:53:19 +0000 (12:53 -0400)]
Fix the goldang consarned FUSE tests again.
No issue #, dammit
Tim Pierce [Wed, 29 Oct 2014 16:07:07 +0000 (12:07 -0400)]
Merge branch '4088-collection-show-files-filter'
Refs #4088.
Tim Pierce [Wed, 29 Oct 2014 15:40:52 +0000 (11:40 -0400)]
4088: filter only on files
Only apply the regex filter to files; continue to process subdirectories
as normal in order to keep the appropriate filename hierarchy.
Phil Hodgson [Wed, 29 Oct 2014 15:39:56 +0000 (16:39 +0100)]
3618: Make tests pass: bugs were revealed in "Other objects" tab related to there not being any sorting going on there, etc.; add checks for HTML5 history and for nulls and undefineds
Tim Pierce [Wed, 29 Oct 2014 15:19:32 +0000 (11:19 -0400)]
4088: fix alignment for right-floating input field
Phil Hodgson [Wed, 29 Oct 2014 11:21:14 +0000 (12:21 +0100)]
Merge branch 'master' into 3618-column-ordering
Phil Hodgson [Wed, 29 Oct 2014 11:20:08 +0000 (12:20 +0100)]
3618: store in the browser history state the current sort settings for each tab
Ward Vandewege [Wed, 29 Oct 2014 02:18:37 +0000 (22:18 -0400)]
Improve config/application.yml.example for the API server and workbench:
* API server: define prefix_uuid in development mode
* workbench: add a production section
No issue #
Tim Pierce [Tue, 28 Oct 2014 21:26:58 +0000 (17:26 -0400)]
4088: code review feedback
* Filter files by regex before .take(10000)
* Added "regular expression" placeholder in the filter input box
* Issue a Rails "alert" div if the regex could not be parsed
* Test that we're actually viewing a collection when no matches are
found (and not a fiddlesticks page or something)
Peter Amstutz [Tue, 28 Oct 2014 20:05:42 +0000 (16:05 -0400)]
4031: Test for collection provenance/used_by
Peter Amstutz [Tue, 28 Oct 2014 18:18:10 +0000 (14:18 -0400)]
4031: Find for collection dependencies even in the middle of script parameter
fields. Server side collections with same PDH into a single entry with a
special name. Fix node descriptions, hyperlinks. More options to eliminate
certain node types for certain graphs to make them easier to read. Handle both
PDH and UUID when identifying collections.
Brett Smith [Tue, 28 Oct 2014 17:32:05 +0000 (13:32 -0400)]
Fix off-by-one error in Node Manager server calculations.
This bug prevented Node Manager from starting nodes for a job that
requested a number of nodes equal to the daemon's max_nodes setting.
No issue #.
radhika [Tue, 28 Oct 2014 17:16:43 +0000 (13:16 -0400)]
4091: update jobs fixture to set same created_at timestamp for some of the jobs.
radhika [Tue, 28 Oct 2014 16:18:17 +0000 (12:18 -0400)]
4091: enhance code to handle the case where there are more than one item in the next page matching the previous page's last object's created_at time.
Also, handle the case where the entire next page has the same created_at time as the previous page's last item; to keep things simple, stop scrolling in this case.
Tim Pierce [Tue, 28 Oct 2014 15:14:47 +0000 (11:14 -0400)]
4088: filter collection file view by regex
Added a "Filter" field for supplying a regular expression to filter
filenames. Updated integration tests.
Tom Clegg [Tue, 28 Oct 2014 14:59:40 +0000 (10:59 -0400)]
3824: Remove redundant addition of arvados package repo and key.
Tom Clegg [Tue, 28 Oct 2014 14:35:13 +0000 (10:35 -0400)]
3824: Add sources.list file missing from commit:
0f9aaf1
Phil Hodgson [Tue, 28 Oct 2014 10:48:46 +0000 (11:48 +0100)]
3618: remove unnecessary "raw" directive for the sort columns table header attribute
Tom Clegg [Tue, 28 Oct 2014 05:06:02 +0000 (01:06 -0400)]
3824: Fix up logging messages.
Tom Clegg [Tue, 28 Oct 2014 02:24:35 +0000 (22:24 -0400)]
3706: Merge branch 'master' into 3706-keep-warning
Tom Clegg [Tue, 28 Oct 2014 02:20:22 +0000 (22:20 -0400)]
3706: Remove automatic normalization. Add --normalize option to
arv-put. Add normalize() and stripped_manifest() methods to
CollectionReader. Clean up normalize code.
Tom Clegg [Tue, 28 Oct 2014 02:12:53 +0000 (22:12 -0400)]
3706: Consolidate more regular expressions into util package.
Tom Clegg [Tue, 28 Oct 2014 02:08:24 +0000 (22:08 -0400)]
3706: Do not leave zero-length file segment at end of stream after finish_current_file().
Tom Clegg [Tue, 28 Oct 2014 02:04:54 +0000 (22:04 -0400)]
3706: In CollectionReader, try fetching manifests before/after API
server when the ID is a Keep locator with/without a permission hint
respectively. Do not display a warning if the manifest is found one
way or the other.