3400: ArvadosResourceList returns all items (paging as necessary) unless limit()...
authorPeter Amstutz <peter.amstutz@curoverse.com>
Wed, 5 Nov 2014 20:57:01 +0000 (15:57 -0500)
committerPeter Amstutz <peter.amstutz@curoverse.com>
Wed, 5 Nov 2014 20:57:01 +0000 (15:57 -0500)
commit47530892a8a6b174786316c3881e22dc0864c859
tree3c2b6dcbf67d6c7089c708225ce85b1ac58a7edb
parentd5cf000ee76060ce5e96bb4032f54e7f6b19116e
3400: ArvadosResourceList returns all items (paging as necessary) unless limit() is specified.
* ArvadosResourceList#each returns results incrementally.  ArvadosResourceList#all (or ArvadosResourceList#results) prefetches the entire list.
* Added tests.  Fixed tests.
* Removed hardcoded limit() in cases where it was apparent that it was being used as a workaround for the paging problem.
* Removed obsolete name_link code (including CollectionsController#choose override) that was causing tests to fail.
apps/workbench/app/controllers/collections_controller.rb
apps/workbench/app/controllers/users_controller.rb
apps/workbench/app/models/arvados_resource_list.rb
apps/workbench/app/views/collections/_choose_rows.html.erb
apps/workbench/app/views/collections/_index_tbody.html.erb
apps/workbench/app/views/collections/_show_recent.html.erb
apps/workbench/app/views/projects/_show_sharing.html.erb
apps/workbench/app/views/users/_show_admin.html.erb
apps/workbench/test/functional/users_controller_test.rb
apps/workbench/test/unit/arvados_resource_list_test.rb