Brett Smith [Tue, 10 Feb 2015 19:11:55 +0000 (14:11 -0500)]
5160: All users have API read permission to anonymous group.
Workbench makes public data available to everyone by including the
anonymous user API token as a reader token for every request.
However, model-level validations do not respect reader tokens. As a
consequence, users cannot make their project public by sharing it with
the anonymous group. They can't create the necessary link, because
the validation can't confirm that the creator can see the anonymous
group.
There are a few ways we could've tackled this, but granting all users
permission to see the anonymous group seems like the most reliable,
since it works within our existing permissions infrastructure as much
as possible.
Brett Smith [Thu, 5 Feb 2015 16:58:43 +0000 (11:58 -0500)]
4464: API group contents no longer include manifests.
This change achieves symmetry with the collections list method, which
doesn't return manifests unless you expressly request them. We don't
have a good way to support the select parameter in group contents at
all right now, so this commit also makes that clear through the
discovery document, and documents the limitation. This change should
help avoid performance problems like witnessed in #4464.
Some refactoring/clean-up to help support this change:
* Extract out a method that generates the full hash response to list
@objects. Reuse that code in the groups contents method.
* The collections controller had code to generate a list of a model's
selectable attributes. Move that to ArvadosModel and reuse it in
the groups contents method.
* Make signatures consistent across all definitions of apply_filters
and apply_where_limit_order_params. The latter simply passes
arguments to the former, so it can have the same signature, and it
should respect the provided model_class argument the same way. Same
for the override in the users controller.
Brett Smith [Mon, 9 Feb 2015 22:02:01 +0000 (17:02 -0500)]
5176: Add more Ruby SDK tests for empty manifests.
I wrote these while trying to diagnose other issues in the branch.
They didn't reveal anything directly, but it seems like a waste to
write tests and not commit them, so here they are.
Brett Smith [Mon, 9 Feb 2015 21:01:35 +0000 (16:01 -0500)]
5175: Avoid egg_info name conflicts with pip.
pip does its own subclassing of egg_info. Installing with pip fails
if setup.py includes an egg_info class that is passed in as the
cmdclass for the egg_info command. Avoid using that name to avoid
conflicts with pip. Refs #5175.
Brett Smith [Mon, 9 Feb 2015 17:31:11 +0000 (12:31 -0500)]
5175: Do not add +sha1 tag to Python packages ever.
PEP 440 is clear that the local version tag is for distributors who
are patching an upstream release. That's not us; we are the upstream
release. "Local version identifiers SHOULD NOT be used for upstream
projects," so just don't do it.
This also lets us sidestep the issue of trying to parse sys.argv
behind setuptools' back.
Developers who want to keep their development builds distinct should
tag packages themselves with -b .devN.
Brett Smith [Thu, 5 Feb 2015 21:18:00 +0000 (16:18 -0500)]
5141: Workbench permits float values for number pipeline inputs.
Previously, when a pipeline input had the number dataclass, we
rendered the input form with type=number. However, the Arvados number
dataclass is meant to allow all numeric types. The HTML 5 number
input type only permits integers.
Unfortunately, X-Editable does not have any built-in validation for a
broader range of numeric types. This commit simply removes any
validation.
Tom Clegg [Wed, 4 Feb 2015 22:28:29 +0000 (17:28 -0500)]
3021: Remove ARVADOS_KEEP_PROXY support. (If you need to interfere
with the discovery mechanism from out-of-process, use some combination
of HTTP_PROXY, NO_PROXY, and a generic proxy server.)
Radhika Chippada [Wed, 4 Feb 2015 14:22:05 +0000 (09:22 -0500)]
2659: Do not turn on anonymous config by default in test mode; instead make the tests set it as needed.
Also convert some of the simple integration tests into controller tests.
projects / arvados.git / log