arvados.git
9 years ago4523: Add tests for some edge cases.
Tom Clegg [Mon, 9 Feb 2015 17:10:29 +0000 (12:10 -0500)]
4523: Add tests for some edge cases.

9 years ago4523: Fix up whitespace.
Tom Clegg [Mon, 9 Feb 2015 17:05:16 +0000 (12:05 -0500)]
4523: Fix up whitespace.

9 years ago4523: Remove unneeded else.
Tom Clegg [Mon, 9 Feb 2015 15:42:22 +0000 (10:42 -0500)]
4523: Remove unneeded else.

9 years ago5176: Add spaces-in-filenames tests.
Tom Clegg [Mon, 9 Feb 2015 16:20:28 +0000 (11:20 -0500)]
5176: Add spaces-in-filenames tests.

9 years ago5176: Fix handling of escape sequences in manifest filenames.
Tom Clegg [Mon, 9 Feb 2015 15:49:13 +0000 (10:49 -0500)]
5176: Fix handling of escape sequences in manifest filenames.

9 years ago5110: clean up pipeline instances integration tests a bit. and remove a few of the...
Radhika Chippada [Mon, 9 Feb 2015 02:28:57 +0000 (21:28 -0500)]
5110: clean up pipeline instances integration tests a bit. and remove a few of the tests in
"scroll pipeline instances page for with search filter" that are neither searching nor scrolling.

9 years ago5175: Do not add +sha1 tag unless --sha1-tag flag given.
Tom Clegg [Sun, 8 Feb 2015 23:53:49 +0000 (18:53 -0500)]
5175: Do not add +sha1 tag unless --sha1-tag flag given.

9 years agoMerge branch '4523-full-text-search' into 5110-workbench-full-text-search
Radhika Chippada [Sun, 8 Feb 2015 21:56:51 +0000 (16:56 -0500)]
Merge branch '4523-full-text-search' into 5110-workbench-full-text-search

9 years ago4523: update full text search to append ':*' for each word to support a collection...
Radhika Chippada [Sun, 8 Feb 2015 21:22:07 +0000 (16:22 -0500)]
4523: update full text search to append ':*' for each word to support a collection file search such as dir_name_part space file_name_part.

9 years agoMerge branch 'master' into 4523-full-text-search
Radhika Chippada [Sun, 8 Feb 2015 20:54:14 +0000 (15:54 -0500)]
Merge branch 'master' into 4523-full-text-search

Conflicts:
services/api/test/unit/collection_test.rb

9 years ago4958: Add tests.
Tom Clegg [Sun, 8 Feb 2015 08:46:34 +0000 (03:46 -0500)]
4958: Add tests.

9 years ago4958: Avoid squishing dax's aspect ratio when window is narrow.
Tom Clegg [Sat, 7 Feb 2015 22:21:14 +0000 (17:21 -0500)]
4958: Avoid squishing dax's aspect ratio when window is narrow.

9 years ago4958: Detect old browsers and recommend upgrading.
Tom Clegg [Sat, 7 Feb 2015 22:19:50 +0000 (17:19 -0500)]
4958: Detect old browsers and recommend upgrading.

We use a plain .js file in /public instead of the asset pipeline, and
don't rely on any JS libraries. This gives the error alert a much
better chance of working in a browser that can't even parse our
compiled/minified application.js.

9 years ago5030: Hide cpu/mem/io graph until data points arrive.
Tom Clegg [Sat, 7 Feb 2015 10:36:50 +0000 (05:36 -0500)]
5030: Hide cpu/mem/io graph until data points arrive.

9 years ago5030: Move log graph javascript into its own file.
Tom Clegg [Sat, 7 Feb 2015 10:15:31 +0000 (05:15 -0500)]
5030: Move log graph javascript into its own file.

9 years ago5037: Use a newer Python SDK (with no connection cache) instead of cache=False.
Tom Clegg [Sat, 7 Feb 2015 08:59:12 +0000 (03:59 -0500)]
5037: Use a newer Python SDK (with no connection cache) instead of cache=False.

9 years agoMerge branch '5011-arv-put-replication' closes #5011
Tom Clegg [Fri, 6 Feb 2015 22:53:33 +0000 (17:53 -0500)]
Merge branch '5011-arv-put-replication' closes #5011

9 years ago5011: Fix comment about when local_store_* methods get used.
Tom Clegg [Fri, 6 Feb 2015 22:53:02 +0000 (17:53 -0500)]
5011: Fix comment about when local_store_* methods get used.

9 years ago4926: Fixed images to be consistently 900x500
Nancy Ouyang [Fri, 6 Feb 2015 22:43:22 +0000 (17:43 -0500)]
4926: Fixed images to be consistently 900x500

9 years agoMerge branch '3021-leave-api-running' refs #3021
Tom Clegg [Fri, 6 Feb 2015 22:30:31 +0000 (17:30 -0500)]
Merge branch '3021-leave-api-running' refs #3021

9 years ago5110: use full text search operator '@@' instead of 'ilike'
Radhika Chippada [Fri, 6 Feb 2015 21:22:51 +0000 (16:22 -0500)]
5110: use full text search operator '@@' instead of 'ilike'

9 years ago4523: slightly modified full text search condition.
Radhika Chippada [Fri, 6 Feb 2015 21:15:23 +0000 (16:15 -0500)]
4523: slightly modified full text search condition.

9 years agoMerge branch 'master' into 4523-full-text-search
Radhika Chippada [Fri, 6 Feb 2015 18:47:32 +0000 (13:47 -0500)]
Merge branch 'master' into 4523-full-text-search

9 years ago5011: Merge branch 'master' into 5011-arv-put-replication
Tom Clegg [Fri, 6 Feb 2015 18:47:22 +0000 (13:47 -0500)]
5011: Merge branch 'master' into 5011-arv-put-replication

9 years ago4951: remove unused id from link
Radhika Chippada [Fri, 6 Feb 2015 18:43:11 +0000 (13:43 -0500)]
4951: remove unused id from link

9 years ago5011: Make docstring less scary.
Tom Clegg [Fri, 6 Feb 2015 18:42:00 +0000 (13:42 -0500)]
5011: Make docstring less scary.

9 years agoMerge branch 'master' into 4951-request-vm
Radhika Chippada [Fri, 6 Feb 2015 18:39:22 +0000 (13:39 -0500)]
Merge branch 'master' into 4951-request-vm

9 years ago4951: localStorage lookup much simplified and handled during page loading.
Radhika Chippada [Fri, 6 Feb 2015 18:38:18 +0000 (13:38 -0500)]
4951: localStorage lookup much simplified and handled during page loading.

9 years ago3021: Bugfix for arvados_fuse.TagsDirectory to correctly merge tag list updates
Peter Amstutz [Fri, 6 Feb 2015 18:34:43 +0000 (13:34 -0500)]
3021: Bugfix for arvados_fuse.TagsDirectory to correctly merge tag list updates
with existing TagsDirectory entries.

9 years ago3021: Use bind(0.0.0.0, 0) instead of grep /proc/net/tcp to find a port number.
Tom Clegg [Fri, 6 Feb 2015 17:46:57 +0000 (12:46 -0500)]
3021: Use bind(0.0.0.0, 0) instead of grep /proc/net/tcp to find a port number.

9 years agoRelax version limit of python-daemon dependencies.
Brett Smith [Fri, 6 Feb 2015 17:00:41 +0000 (12:00 -0500)]
Relax version limit of python-daemon dependencies.

We imposed this limit in 9c2e673ba96ba5d11e56a4aba67157e64dfe01e2.
The issues seem to be ironed out as of version 2.0.4.  See:

* <http://lists.alioth.debian.org/pipermail/python-daemon-devel/2015-January/000114.html>
* <https://bitbucket.org/pypa/setuptools/issue/338/__future__-imports-are-not-effective-in>

No issue #.

9 years agoMerge branch 'master' into 4523-full-text-search
Radhika Chippada [Fri, 6 Feb 2015 13:56:09 +0000 (08:56 -0500)]
Merge branch 'master' into 4523-full-text-search

9 years ago4951: actually add test assertion to verify that request access button was no longer...
Radhika Chippada [Fri, 6 Feb 2015 13:02:52 +0000 (08:02 -0500)]
4951: actually add test assertion to verify that request access button was no longer displayed after a request was made.

9 years ago4951: add test assertion to verify that request access button was no longer displayed...
Radhika Chippada [Fri, 6 Feb 2015 12:49:27 +0000 (07:49 -0500)]
4951: add test assertion to verify that request access button was no longer displayed after a request was made.

9 years agoMerge branch 'master' into 4951-request-vm
Radhika Chippada [Fri, 6 Feb 2015 12:36:15 +0000 (07:36 -0500)]
Merge branch 'master' into 4951-request-vm

9 years ago3021: Merge branch 'master' into 3021-leave-api-running
Tom Clegg [Fri, 6 Feb 2015 05:04:29 +0000 (00:04 -0500)]
3021: Merge branch 'master' into 3021-leave-api-running

Conflicts:
sdk/python/tests/test_websockets.py

9 years ago3021: We use passenger in dev and test environments, too.
Tom Clegg [Fri, 6 Feb 2015 04:59:35 +0000 (23:59 -0500)]
3021: We use passenger in dev and test environments, too.

9 years ago3021: Make sure any unexpected openssl output ends up on stderr.
Tom Clegg [Fri, 6 Feb 2015 01:37:48 +0000 (20:37 -0500)]
3021: Make sure any unexpected openssl output ends up on stderr.

9 years ago3021: Reduce race potential by resetting database after fuse unmounts.
Tom Clegg [Thu, 5 Feb 2015 23:31:12 +0000 (18:31 -0500)]
3021: Reduce race potential by resetting database after fuse unmounts.

9 years ago3021: Remove unused variable.
Tom Clegg [Thu, 5 Feb 2015 23:12:22 +0000 (18:12 -0500)]
3021: Remove unused variable.

9 years ago3021: Use kwargs to pass options through make_mount(). Dry up FuseTagsUpdateTest.
Tom Clegg [Thu, 5 Feb 2015 22:37:32 +0000 (17:37 -0500)]
3021: Use kwargs to pass options through make_mount(). Dry up FuseTagsUpdateTest.

9 years agoMerge branch '5141-workbench-numeric-inputs-wip'
Brett Smith [Thu, 5 Feb 2015 22:14:03 +0000 (17:14 -0500)]
Merge branch '5141-workbench-numeric-inputs-wip'

Closes #5141, #5143.

9 years ago5141: Workbench permits float values for number pipeline inputs.
Brett Smith [Thu, 5 Feb 2015 21:18:00 +0000 (16:18 -0500)]
5141: Workbench permits float values for number pipeline inputs.

Previously, when a pipeline input had the number dataclass, we
rendered the input form with type=number.  However, the Arvados number
dataclass is meant to allow all numeric types.  The HTML 5 number
input type only permits integers.

Unfortunately, X-Editable does not have any built-in validation for a
broader range of numeric types.  This commit simply removes any
validation.

9 years ago3021: Give up earlier if ARVADOS_TEST_API_HOST is set but reset() fails.
Tom Clegg [Thu, 5 Feb 2015 22:02:45 +0000 (17:02 -0500)]
3021: Give up earlier if ARVADOS_TEST_API_HOST is set but reset() fails.

9 years ago3021: Reset env vars in any reset(), not just in start().
Tom Clegg [Thu, 5 Feb 2015 22:02:16 +0000 (17:02 -0500)]
3021: Reset env vars in any reset(), not just in start().

9 years agoAvoid optional disk cache usage if it is owned by a different user. refs #2659.
Tom Clegg [Thu, 5 Feb 2015 21:22:34 +0000 (16:22 -0500)]
Avoid optional disk cache usage if it is owned by a different user. refs #2659.

9 years ago5135: Workbench consistently orders modal buttons.
Brett Smith [Thu, 5 Feb 2015 21:43:29 +0000 (16:43 -0500)]
5135: Workbench consistently orders modal buttons.

Primary buttons should be first from the right, following Bootstrap
conventions and Tom's edict.  Closes #5135.

9 years agoMerge branch 'master' into 4523-full-text-search
Radhika Chippada [Thu, 5 Feb 2015 21:33:39 +0000 (16:33 -0500)]
Merge branch 'master' into 4523-full-text-search

Conflicts:
services/api/db/structure.sql

9 years ago4523: preparing to merge master
Radhika Chippada [Thu, 5 Feb 2015 21:29:56 +0000 (16:29 -0500)]
4523: preparing to merge master

9 years ago3021: Set env var to empty string instead of removing it. Unsetenv isn't worth introd...
Tom Clegg [Thu, 5 Feb 2015 21:29:27 +0000 (16:29 -0500)]
3021: Set env var to empty string instead of removing it. Unsetenv isn't worth introducing a dependency on Go 1.4.

9 years agoMerge branch 'master' into 4951-request-vm
Radhika Chippada [Thu, 5 Feb 2015 21:22:57 +0000 (16:22 -0500)]
Merge branch 'master' into 4951-request-vm

9 years ago5011: Add forward compatibility, so we don't need backward compatibility later.
Tom Clegg [Thu, 5 Feb 2015 21:22:20 +0000 (16:22 -0500)]
5011: Add forward compatibility, so we don't need backward compatibility later.

9 years ago4951: when a request for shell access is made, remember this in html5 localStorage...
Radhika Chippada [Thu, 5 Feb 2015 21:20:48 +0000 (16:20 -0500)]
4951: when a request for shell access is made, remember this in html5 localStorage so that on future revisits of the page (in the same browser) we can show an info message to that effect rather than showing the request button again.

9 years ago5011: Add tests and comments for redundancy vs. replication_desired attrs.
Tom Clegg [Thu, 5 Feb 2015 20:15:22 +0000 (15:15 -0500)]
5011: Add tests and comments for redundancy vs. replication_desired attrs.

9 years ago5011: Fix up docstring.
Tom Clegg [Thu, 5 Feb 2015 20:14:49 +0000 (15:14 -0500)]
5011: Fix up docstring.

9 years agoMerge branch '4472-save-partial-output' closes #4472
Tom Clegg [Thu, 5 Feb 2015 18:16:53 +0000 (13:16 -0500)]
Merge branch '4472-save-partial-output' closes #4472

9 years ago5011: Dry up three different solutions for mocking keep_services().accessible().
Tom Clegg [Thu, 5 Feb 2015 17:05:29 +0000 (12:05 -0500)]
5011: Dry up three different solutions for mocking keep_services().accessible().

9 years ago5011: Merge branch 'master' into 5011-arv-put-replication
Tom Clegg [Thu, 5 Feb 2015 14:40:25 +0000 (09:40 -0500)]
5011: Merge branch 'master' into 5011-arv-put-replication

9 years ago3021: In start(), if a stale server is already running (but we can't reset() it)...
Tom Clegg [Thu, 5 Feb 2015 02:28:52 +0000 (21:28 -0500)]
3021: In start(), if a stale server is already running (but we can't reset() it), kill it.

9 years ago3021: Check whether a randomly selected port is available before using it.
Tom Clegg [Thu, 5 Feb 2015 02:27:17 +0000 (21:27 -0500)]
3021: Check whether a randomly selected port is available before using it.

9 years ago3021: Don't worry about env vars, run_test_server.py does that.
Tom Clegg [Thu, 5 Feb 2015 02:25:53 +0000 (21:25 -0500)]
3021: Don't worry about env vars, run_test_server.py does that.

9 years ago4951: trailing white space
Radhika Chippada [Thu, 5 Feb 2015 02:25:23 +0000 (21:25 -0500)]
4951: trailing white space

9 years ago4951: add tests for request shell access feature.
Radhika Chippada [Thu, 5 Feb 2015 02:21:26 +0000 (21:21 -0500)]
4951: add tests for request shell access feature.

9 years ago4951: add ajax handling for request shell access button.
Radhika Chippada [Wed, 4 Feb 2015 23:54:18 +0000 (18:54 -0500)]
4951: add ajax handling for request shell access button.

9 years ago3021: Fix use of inaccessible global in atexit handler.
Tom Clegg [Wed, 4 Feb 2015 22:35:26 +0000 (17:35 -0500)]
3021: Fix use of inaccessible global in atexit handler.

9 years ago3021: Remove ARVADOS_KEEP_PROXY support. (If you need to interfere
Tom Clegg [Wed, 4 Feb 2015 22:28:29 +0000 (17:28 -0500)]
3021: Remove ARVADOS_KEEP_PROXY support. (If you need to interfere
with the discovery mechanism from out-of-process, use some combination
of HTTP_PROXY, NO_PROXY, and a generic proxy server.)

9 years ago3021: Set up a proxy-only keepclient manually, instead of communicating with global...
Tom Clegg [Wed, 4 Feb 2015 22:15:53 +0000 (17:15 -0500)]
3021: Set up a proxy-only keepclient manually, instead of communicating with global/env vars.

9 years ago3021: Tidy up (and document) the choice of exactly which server we expect to run...
Tom Clegg [Wed, 4 Feb 2015 22:13:25 +0000 (17:13 -0500)]
3021: Tidy up (and document) the choice of exactly which server we expect to run/reset/stop.

9 years ago3021: Fix misspelled variable.
Tom Clegg [Wed, 4 Feb 2015 22:11:57 +0000 (17:11 -0500)]
3021: Fix misspelled variable.

9 years agoDiagnostics testing: The test fails because there are 2 Run buttons in the Inputs...
Radhika Chippada [Wed, 4 Feb 2015 20:54:14 +0000 (15:54 -0500)]
Diagnostics testing: The test fails because there are 2 Run buttons in the Inputs tab right after choosing inputs. Click on Components tab before clicking on the Run button.

9 years agoMerge branch 'master' into 4951-request-vm
Radhika Chippada [Wed, 4 Feb 2015 19:04:49 +0000 (14:04 -0500)]
Merge branch 'master' into 4951-request-vm

9 years agoMerge branch '2659-anonymous-share-projects' refs #2659
Tom Clegg [Wed, 4 Feb 2015 19:00:43 +0000 (14:00 -0500)]
Merge branch '2659-anonymous-share-projects' refs #2659

9 years ago5011: Convert comment to docstring.
Tom Clegg [Wed, 4 Feb 2015 18:56:45 +0000 (13:56 -0500)]
5011: Convert comment to docstring.

9 years ago5011: Sync local_store_put/get() signatures to put/get(). Add docstrings.
Tom Clegg [Wed, 4 Feb 2015 18:56:33 +0000 (13:56 -0500)]
5011: Sync local_store_put/get() signatures to put/get(). Add docstrings.

9 years ago5011: Use None, not 0, to signify default replication.
Tom Clegg [Wed, 4 Feb 2015 18:54:37 +0000 (13:54 -0500)]
5011: Use None, not 0, to signify default replication.

9 years ago4951: send mail to request shell access to user
Radhika Chippada [Wed, 4 Feb 2015 18:29:17 +0000 (13:29 -0500)]
4951: send mail to request shell access to user

9 years ago2659: Use a partial instead of a switch block for the not-so-generic "create object...
Tom Clegg [Wed, 4 Feb 2015 17:36:32 +0000 (12:36 -0500)]
2659: Use a partial instead of a switch block for the not-so-generic "create object" button. Don't show one at /jobs or /collections.

9 years ago2659: Use assert_operator to help debug unreliable test.
Tom Clegg [Wed, 4 Feb 2015 17:01:35 +0000 (12:01 -0500)]
2659: Use assert_operator to help debug unreliable test.

9 years ago2659: Split skip_around_filter back into two separate cases. 063c546 was misguided...
Tom Clegg [Wed, 4 Feb 2015 16:24:05 +0000 (11:24 -0500)]
2659: Split skip_around_filter back into two separate cases. 063c546 was misguided here.

9 years ago5131: Document run-command's escape sequences.
Brett Smith [Wed, 4 Feb 2015 14:59:31 +0000 (09:59 -0500)]
5131: Document run-command's escape sequences.

Refs #5131.

9 years ago2659: Do not turn on anonymous config by default in test mode; instead make the tests...
Radhika Chippada [Wed, 4 Feb 2015 14:22:05 +0000 (09:22 -0500)]
2659: Do not turn on anonymous config by default in test mode; instead make the tests set it as needed.
Also convert some of the simple integration tests into controller tests.

9 years ago2659: add publicly accessible pipeline instance and template to the list of objects...
Radhika Chippada [Wed, 4 Feb 2015 05:00:16 +0000 (00:00 -0500)]
2659: add publicly accessible pipeline instance and template to the list of objects to be expected in the project.

9 years agoMerge branch '2659-anonymous-share-projects' of git.curoverse.com:arvados into 2659...
Radhika Chippada [Wed, 4 Feb 2015 03:23:52 +0000 (22:23 -0500)]
Merge branch '2659-anonymous-share-projects' of git.curoverse.com:arvados into 2659-anonymous-share-projects

9 years agoMerge branch 'master' of git.curoverse.com:arvados into 2659-anonymous-share-projects
Radhika Chippada [Wed, 4 Feb 2015 03:23:16 +0000 (22:23 -0500)]
Merge branch 'master' of git.curoverse.com:arvados into 2659-anonymous-share-projects

9 years ago2659: Fix up chicken-and-egg conditions in seed setup.
Tom Clegg [Wed, 4 Feb 2015 03:13:15 +0000 (22:13 -0500)]
2659: Fix up chicken-and-egg conditions in seed setup.

9 years ago2659: Fix infinite recursion while creating system_user.
Tom Clegg [Wed, 4 Feb 2015 03:12:06 +0000 (22:12 -0500)]
2659: Fix infinite recursion while creating system_user.

9 years agoMerge branch '2659-anonymous-share-projects' of git.curoverse.com:arvados into 2659...
Radhika Chippada [Wed, 4 Feb 2015 00:32:24 +0000 (19:32 -0500)]
Merge branch '2659-anonymous-share-projects' of git.curoverse.com:arvados into 2659-anonymous-share-projects

9 years ago2659: tests do not "assume" that anonymous configuration is enabled.
Radhika Chippada [Wed, 4 Feb 2015 00:31:01 +0000 (19:31 -0500)]
2659: tests do not "assume" that anonymous configuration is enabled.

9 years ago2659: Token fail during download is 404 when anon token is enabled, 302 otherwise.
Tom Clegg [Wed, 4 Feb 2015 00:24:33 +0000 (19:24 -0500)]
2659: Token fail during download is 404 when anon token is enabled, 302 otherwise.

9 years ago2659: Fix anonymous token test.
Tom Clegg [Tue, 3 Feb 2015 23:22:03 +0000 (18:22 -0500)]
2659: Fix anonymous token test.

9 years ago2659: add test cases where anonymous config is turned off for collections, jobs,...
Radhika Chippada [Tue, 3 Feb 2015 23:20:41 +0000 (18:20 -0500)]
2659: add test cases where anonymous config is turned off for collections, jobs, pipeline instances, templates, and projects controller show method.

9 years ago2659: Add separate test for "run pipeline" notification when anonymous token is confi...
Tom Clegg [Tue, 3 Feb 2015 23:19:31 +0000 (18:19 -0500)]
2659: Add separate test for "run pipeline" notification when anonymous token is configured, skip it for now.

9 years ago2659: Do not ask to skip_around_filter(only:...) and skip_around_filter(if:...) for...
Tom Clegg [Tue, 3 Feb 2015 22:22:53 +0000 (17:22 -0500)]
2659: Do not ask to skip_around_filter(only:...) and skip_around_filter(if:...) for the same filter, because that doesn't work.

9 years ago2659: Check anon config at runtime instead of boot time in skip_before_filter. This...
Tom Clegg [Tue, 3 Feb 2015 21:33:18 +0000 (16:33 -0500)]
2659: Check anon config at runtime instead of boot time in skip_before_filter. This makes it possible for test cases to toggle behavior by changing configuration on the fly.

9 years agoMerge branch '5131-run-command-consume-backslashes-wip'
Brett Smith [Tue, 3 Feb 2015 20:48:32 +0000 (15:48 -0500)]
Merge branch '5131-run-command-consume-backslashes-wip'

Closes #5131, #5132.

9 years ago5131: run-command consumes escape backslashes.
Brett Smith [Tue, 3 Feb 2015 20:40:10 +0000 (15:40 -0500)]
5131: run-command consumes escape backslashes.

run-command has long recognized backslashes to inhibit
substitution, but it was leaving those backslashes in the string,
which could lead to incorrect commands.  This commit makes sure
they're removed after they're parsed.

9 years ago2659: Remove obsolete "don't create jobs in workbench" rule.
Tom Clegg [Tue, 3 Feb 2015 20:24:24 +0000 (15:24 -0500)]
2659: Remove obsolete "don't create jobs in workbench" rule.

9 years ago2659: Update test to match changed error message.
Tom Clegg [Tue, 3 Feb 2015 19:57:28 +0000 (14:57 -0500)]
2659: Update test to match changed error message.

9 years ago2659: Remove obsolete "don't create collections in workbench" rule.
Tom Clegg [Tue, 3 Feb 2015 19:56:41 +0000 (14:56 -0500)]
2659: Remove obsolete "don't create collections in workbench" rule.

9 years ago2659: Back out unneeded condition. Fix up whitespace.
Tom Clegg [Tue, 3 Feb 2015 19:28:00 +0000 (14:28 -0500)]
2659: Back out unneeded condition. Fix up whitespace.