Peter Amstutz [Thu, 6 Nov 2014 16:37:49 +0000 (11:37 -0500)]
4310: Fix race condition between testing for tag and setting tag by reversing
order of operations: try to set the tag, and only test for it if there is an
error.
Tom Clegg [Thu, 6 Nov 2014 16:33:07 +0000 (11:33 -0500)]
Merge branch '4389-breadcrumbs-infinite-loop' closes #4389
Ward Vandewege [Thu, 6 Nov 2014 16:30:11 +0000 (11:30 -0500)]
Install instructions: be a bit more explicit that arvdock is downloaded
and saved in the current working directory.
refs #4383
Tom Clegg [Thu, 6 Nov 2014 16:12:58 +0000 (11:12 -0500)]
4084: Fix wrong state name: jobs are Running, pipelines are RunningOn[...].
Ward Vandewege [Thu, 6 Nov 2014 16:09:00 +0000 (11:09 -0500)]
Merge branch 'master' into 4383-easy-install
refs #4383
Ward Vandewege [Thu, 6 Nov 2014 16:04:36 +0000 (11:04 -0500)]
Only try to install .config/arvados/settings.conf if we have a token to
put in there.
refs #4383
Tim Pierce [Thu, 6 Nov 2014 16:02:50 +0000 (11:02 -0500)]
4088: code review feedback
* Modified styling for "Select all" and "Unselect all"
* "filename filter" -> "filename regex"
* Changed refutations to assertions to avoid running afoul of AJAX race
conditions
* Refactored checkbox assertions into a helper
Tom Clegg [Thu, 6 Nov 2014 15:55:07 +0000 (10:55 -0500)]
4389: Merge branch 'master' into 4389-breadcrumbs-infinite-loop
Tom Clegg [Thu, 6 Nov 2014 15:53:13 +0000 (10:53 -0500)]
4084: Update views that were still using pane-anchor.
radhika [Thu, 6 Nov 2014 15:42:07 +0000 (10:42 -0500)]
3177: try to partition input selection only if it is a string
Peter Amstutz [Thu, 6 Nov 2014 15:26:21 +0000 (10:26 -0500)]
add 'arv-run' to setup.py refs #3609
Ward Vandewege [Thu, 6 Nov 2014 15:25:01 +0000 (10:25 -0500)]
Add more tests so that we cover all possible combinations of the
auto_admin_first_user and auto_admin_user configuration settings.
refs #4383
Ward Vandewege [Thu, 6 Nov 2014 15:23:11 +0000 (10:23 -0500)]
Update the behavior of the auto_admin_user configuration field a bit to
make it more intuitive: the first user created with an e-mail address
that matches auto_admin_user will now become admin, regardless of the
presence of other admin users. Any subsequent accounts created with that
e-mail address will no longer become admin.
refs #4383
radhika [Thu, 6 Nov 2014 14:54:41 +0000 (09:54 -0500)]
3177: trailing white space
radhika [Thu, 6 Nov 2014 14:49:23 +0000 (09:49 -0500)]
3177: add tests for a template that uses dataclass = File
radhika [Thu, 6 Nov 2014 13:01:39 +0000 (08:01 -0500)]
3177: store input pdh value even when input dataclass is File. Update two tests to no longer look for clippy.
radhika [Thu, 6 Nov 2014 04:33:21 +0000 (23:33 -0500)]
3177: restrict only one file selection in collection chooser; remove clippy; clear selections on load.
radhika [Thu, 6 Nov 2014 03:57:30 +0000 (22:57 -0500)]
3177: propagate checkbox selection param when dataclass is File.
Tim Pierce [Wed, 5 Nov 2014 21:24:57 +0000 (16:24 -0500)]
3857: replaced httplib2 with 'requests'
Replaced httplib2 with the 'requests' library in modules that use it to
call Keep:
* arvados.collection
* arvados.keep
* arvados.retry
* arvados.stream
Updated unit tests and mocks appropriately.
Tom Clegg [Wed, 5 Nov 2014 22:48:30 +0000 (17:48 -0500)]
4389: Add test.
Peter Amstutz [Wed, 5 Nov 2014 21:26:37 +0000 (16:26 -0500)]
3400: Too much code that assumes it can call .first over and over without
incurring an API call each time (silly).
Peter Amstutz [Wed, 5 Nov 2014 20:57:01 +0000 (15:57 -0500)]
3400: ArvadosResourceList returns all items (paging as necessary) unless limit() is specified.
* ArvadosResourceList#each returns results incrementally. ArvadosResourceList#all (or ArvadosResourceList#results) prefetches the entire list.
* Added tests. Fixed tests.
* Removed hardcoded limit() in cases where it was apparent that it was being used as a workaround for the paging problem.
* Removed obsolete name_link code (including CollectionsController#choose override) that was causing tests to fail.
radhika [Wed, 5 Nov 2014 20:46:10 +0000 (15:46 -0500)]
Merge branch 'master' into 3177-collection-choose-files
Peter Amstutz [Wed, 5 Nov 2014 20:43:40 +0000 (15:43 -0500)]
Merge branch 'origin-3609-arv-run' into master closes #3609
Conflicts:
sdk/cli/bin/arv
Brett Smith [Wed, 5 Nov 2014 19:29:14 +0000 (14:29 -0500)]
Merge branch '4357-node-manager-busy-nodes-wip'
Closes #4357, #4370.
Brett Smith [Fri, 31 Oct 2014 17:59:59 +0000 (13:59 -0400)]
4357: Node Manager boots new nodes when up nodes are busy.
The key part of this commit is the change to _nodes_wanted.
Everything else provides the information to make that calculation.
This changes the daemon test to use real monitor actors, rather than a
mock. This hurts test isolation a bit, but it's really tricky to mock
individual monitors otherwise. Because monitors only communicate with
the daemon itself, this seems like a worthwhile trade-off; it doesn't
introduce external dependencies or noticeably increase test time.
radhika [Wed, 5 Nov 2014 18:57:55 +0000 (13:57 -0500)]
Merge branch 'master' into 3177-collection-choose-files
radhika [Wed, 5 Nov 2014 18:57:14 +0000 (13:57 -0500)]
3177: look for checked persistent selections on submit.
Tom Clegg [Wed, 5 Nov 2014 17:22:03 +0000 (12:22 -0500)]
4389: Merge branch 'master' into 4389-breadcrumbs-infinite-loop
Tom Clegg [Wed, 5 Nov 2014 17:15:42 +0000 (12:15 -0500)]
4434: Test whether sort order matches application locale, instead of testing a locale-dependent collation rule.
Brett Smith [Wed, 5 Nov 2014 16:31:42 +0000 (11:31 -0500)]
Merge branch '4303-crunch-retry-logging-wip'
Closes #4303, #4385.
Brett Smith [Fri, 31 Oct 2014 18:54:25 +0000 (14:54 -0400)]
4303: crunch-job logs when it retries API calls.
Brett Smith [Wed, 5 Nov 2014 16:27:50 +0000 (11:27 -0500)]
Fix `arv keep copy` → `arv copy` wrapper.
No issue #.
Ward Vandewege [Wed, 5 Nov 2014 15:21:24 +0000 (10:21 -0500)]
Merge branch 'master' into 4383-easy-install
Conflicts:
docker/api/application.yml.in
refs #4383
Ward Vandewege [Wed, 5 Nov 2014 15:18:31 +0000 (10:18 -0500)]
Add unit tests for new auto_admin_first_user configuration setting.
refs #4383
Tom Clegg [Wed, 5 Nov 2014 08:52:58 +0000 (03:52 -0500)]
4084: Add comment.
Tom Clegg [Wed, 5 Nov 2014 08:16:33 +0000 (03:16 -0500)]
4084: Fix dashboard refresh.
Tom Clegg [Wed, 5 Nov 2014 07:58:20 +0000 (02:58 -0500)]
4084: Remove excess loaded class.
Tom Clegg [Wed, 5 Nov 2014 07:17:56 +0000 (02:17 -0500)]
4084: Update comments.
Tom Clegg [Wed, 5 Nov 2014 07:02:37 +0000 (02:02 -0500)]
4084: Ignore bubbling arv-log-event events, just process each once at the original target.
Tom Clegg [Wed, 5 Nov 2014 04:28:22 +0000 (23:28 -0500)]
4084: Merge branch 'master' into 4084-log-pane-refresh-TC
Conflicts:
services/api/test/fixtures/jobs.yml
Tom Clegg [Wed, 5 Nov 2014 04:20:23 +0000 (23:20 -0500)]
4084: Use assert_text, not assert page_has_text?, to make tests reliable.
Tom Clegg [Wed, 5 Nov 2014 03:54:12 +0000 (22:54 -0500)]
4084: Skip the "inactive pane" optimization when the div is not a tab pane.
Content divs that are _not_ tabbed panes no longer need to remember to
add an "active" flag.
Tom Clegg [Wed, 5 Nov 2014 03:40:48 +0000 (22:40 -0500)]
4084: Fix up whitespace (4-space indent, like the other *.js)
Peter Amstutz [Wed, 5 Nov 2014 02:28:12 +0000 (21:28 -0500)]
3609: Simplify "group" example a bit more.
Peter Amstutz [Wed, 5 Nov 2014 02:05:00 +0000 (21:05 -0500)]
3609: Further improve documentation and code comments.
Tom Clegg [Wed, 5 Nov 2014 00:25:08 +0000 (19:25 -0500)]
4084: Move all pane state into $pane, flatten panes with multiple entry points.
Peter Amstutz [Tue, 4 Nov 2014 21:28:54 +0000 (16:28 -0500)]
3609: Documentation improvements. More error checking on run-command list function evaluation.
Tom Clegg [Sat, 1 Nov 2014 19:45:04 +0000 (15:45 -0400)]
4389: Add debugging tools to dev bundle.
Tom Clegg [Sat, 1 Nov 2014 19:44:23 +0000 (15:44 -0400)]
4389: Fix infinite loop when ownership trail terminates at a self-owning user.
Brett Smith [Tue, 4 Nov 2014 17:38:55 +0000 (12:38 -0500)]
4412: Remaining Ruby clients use :body_object for API requests.
A follow-up from the last commit. Refs #4412.
Brett Smith [Tue, 4 Nov 2014 17:31:00 +0000 (12:31 -0500)]
4412: arv edit consistently uses :body_object in API requests.
Fixes #4412.
Peter Amstutz [Tue, 4 Nov 2014 15:57:37 +0000 (10:57 -0500)]
Merge branch '4031-fix-graph-connections' closes #4031
Peter Amstutz [Tue, 4 Nov 2014 15:35:09 +0000 (10:35 -0500)]
4084: Remove "no-auto-reload" css class hint, tabs no longer reload on click by
default so it is not necessary to have a class to suppress that behavior.
Phil Hodgson [Tue, 4 Nov 2014 15:16:21 +0000 (16:16 +0100)]
Merge branch '3618-column-ordering' closes #3618
Peter Amstutz [Tue, 4 Nov 2014 15:15:16 +0000 (10:15 -0500)]
4031: Fix tests. Move RequestDuck to test_helper.rb so as not to duplicate code.
Tom Clegg [Tue, 4 Nov 2014 14:48:44 +0000 (09:48 -0500)]
Update version dependency to ensure CollectionReader has a normalize() method. refs #3706
Phil Hodgson [Tue, 4 Nov 2014 14:47:11 +0000 (15:47 +0100)]
Merge branch 'master' into 3618-column-ordering
Phil Hodgson [Tue, 4 Nov 2014 13:58:44 +0000 (14:58 +0100)]
3618: accommodate new fixture indexing in pipeline_instance tests (including run-time=0 test)
Phil Hodgson [Tue, 4 Nov 2014 11:32:55 +0000 (12:32 +0100)]
3618: accommodate new fixture indexing in pipeline_instance tests
Ward Vandewege [Mon, 3 Nov 2014 22:32:28 +0000 (17:32 -0500)]
When auto_admin_first_user is set to true (default false), the first
user to sign in on a new installation will be an admin.
refs #4383
Tom Clegg [Mon, 3 Nov 2014 22:30:15 +0000 (17:30 -0500)]
Merge branch '3706-keep-warning' closes #3706
Tom Clegg [Mon, 3 Nov 2014 22:27:54 +0000 (17:27 -0500)]
3706: Oops, the test was broken, the feature works fine.
Tom Clegg [Mon, 3 Nov 2014 22:13:38 +0000 (17:13 -0500)]
3706: Add (skipped) test for broken max_manifest_depth=0 feature.
Peter Amstutz [Mon, 3 Nov 2014 21:15:31 +0000 (16:15 -0500)]
4084: Only load tab on switch if it doesn't have "pane-loaded" class. Increase
default throttle to 15 sec instead of 3 (but refresh panels can set their own
throttle time.)
Peter Amstutz [Mon, 3 Nov 2014 21:00:00 +0000 (16:00 -0500)]
4031: Add owner_uuid to graph_test_collection fixtures.
Tom Clegg [Mon, 3 Nov 2014 20:27:13 +0000 (15:27 -0500)]
3706: Merge branch 'master' into 3706-keep-warning
Peter Amstutz [Mon, 3 Nov 2014 20:07:10 +0000 (15:07 -0500)]
Merge remote-tracking branch 'origin/master' into 4031-fix-graph-connections
Conflicts:
services/api/test/fixtures/collections.yml
Peter Amstutz [Mon, 3 Nov 2014 20:06:09 +0000 (15:06 -0500)]
4031: Improve provenance graph tests for readability, use fixtures instead of
hardcoded hashes. Improve efficiency of matching collections in search_edges.
Remove spurious debug code.
Tom Clegg [Mon, 3 Nov 2014 19:33:15 +0000 (14:33 -0500)]
3706: Remove superfluous conditional.
Tom Clegg [Mon, 3 Nov 2014 18:33:06 +0000 (13:33 -0500)]
3706: Add back "collections.get => 404" to "fallback to Keep" test.
Ward Vandewege [Mon, 3 Nov 2014 18:31:26 +0000 (13:31 -0500)]
The sso server docker image is not used by default at the moment, so
arvdock shouldn't try to start it unless explicitly requested (part 2).
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 18:31:26 +0000 (13:31 -0500)]
The sso server docker image is not used by default at the moment, so
arvdock shouldn't try to start it unless explicitly requested (part 2).
refs #4383
Tom Clegg [Mon, 3 Nov 2014 14:35:59 +0000 (09:35 -0500)]
3706: Prefer "is None" and "is not None" to "== None" and "!= None".
Tom Clegg [Mon, 3 Nov 2014 14:33:16 +0000 (09:33 -0500)]
3706: Mutating normalize() does not return self.
Tom Clegg [Mon, 3 Nov 2014 14:32:16 +0000 (09:32 -0500)]
3706: Process directory trees in sorted() order, instead of the order
returned by os.listdir().
This causes write_directory_tree() to produce a manifest that is
normalized to the greatest extent possible for the given
max_manifest_depth.
Brett Smith [Mon, 3 Nov 2014 16:10:51 +0000 (11:10 -0500)]
4388: Ruby Keep::Manifest skips blank lines in manifests.
Closes #4388.
Ward Vandewege [Mon, 3 Nov 2014 15:33:54 +0000 (10:33 -0500)]
The sso server docker image is not used by default at the moment, so
arvdock shouldn't try to start it unless explicitly requested.
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 15:33:54 +0000 (10:33 -0500)]
The sso server docker image is not used by default at the moment, so
arvdock shouldn't try to start it unless explicitly requested.
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 04:39:40 +0000 (23:39 -0500)]
system_user and anonymous_user should be excluded from
auto_setup_new_user, always.
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 04:39:40 +0000 (23:39 -0500)]
system_user and anonymous_user should be excluded from
auto_setup_new_user, always.
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 02:03:34 +0000 (21:03 -0500)]
Enable auto_setup_new_users in the docker API server image.
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 02:03:34 +0000 (21:03 -0500)]
Enable auto_setup_new_users in the docker API server image.
refs #4383
Ward Vandewege [Mon, 3 Nov 2014 01:08:13 +0000 (20:08 -0500)]
Add instructions for 'binary' docker installation.
refs #4383
Phil Hodgson [Sat, 1 Nov 2014 14:22:48 +0000 (15:22 +0100)]
3618: refactor scroll tests to share code
Tom Clegg [Fri, 31 Oct 2014 23:46:26 +0000 (19:46 -0400)]
3706: Clarify test case.
Tom Clegg [Fri, 31 Oct 2014 23:36:49 +0000 (19:36 -0400)]
3706: Prefer join() to many string concatenations.
Tom Clegg [Fri, 31 Oct 2014 22:58:37 +0000 (18:58 -0400)]
3706: Prefer "if x" to "if len(x) > 0".
Tom Clegg [Fri, 31 Oct 2014 22:56:16 +0000 (18:56 -0400)]
3706: Two blank lines after class definition.
Tom Clegg [Fri, 31 Oct 2014 21:21:31 +0000 (17:21 -0400)]
3706: Really make the API server return the wrong data, instead of just saying so.
Tom Clegg [Fri, 31 Oct 2014 20:48:34 +0000 (16:48 -0400)]
3706: Put --normalize and --max-manifest-depth arguments in a mutually_exclusive_group.
Tim Pierce [Fri, 31 Oct 2014 20:45:56 +0000 (16:45 -0400)]
Merge branch '4040-fuse-tests'
Fixes #4040.
Tom Clegg [Fri, 31 Oct 2014 20:44:19 +0000 (16:44 -0400)]
3706: normalize() returns None instead of self. Add equally convenient, and more Pythonic, manifest_text(normalize=True) feature.
Peter Amstutz [Fri, 31 Oct 2014 20:37:47 +0000 (16:37 -0400)]
3609: Correctly recognize and rewrite directory names in collections.
Tom Clegg [Fri, 31 Oct 2014 20:30:07 +0000 (16:30 -0400)]
3706: Catch and return exceptions in _populate_* methods to dry up _populate()
Tim Pierce [Fri, 31 Oct 2014 20:21:11 +0000 (16:21 -0400)]
4040: code review feedback
* Renamed
** collection_owned_by_fuse_1 -> collection_1_owned_by_fuse
** collection_owned_by_fuse_2 -> collection_2_owned_by_fuse
* Added fixtures pipeline_instance_owned_by_fuse and
pipeline_instance_in_fuse_project.
* Added name link for the empty collection, to exercise that links are
exposed in the filesystem in the expected way.
Ward Vandewege [Fri, 31 Oct 2014 20:13:52 +0000 (16:13 -0400)]
Fix broken link in docs. Duh.
refs #4186
Peter Amstutz [Fri, 31 Oct 2014 19:26:46 +0000 (15:26 -0400)]
3609: Inherit --retries from _util. Be more specific about error being caught. Add comments.
Tim Pierce [Thu, 30 Oct 2014 14:22:02 +0000 (10:22 -0400)]
4088: use filterable.js to filter on client side
Implemented client-side filtering via filterable.js:
* Designated filename rows as "filterable"
* Designated filename pattern input field as "filterable-control"
* Added "Select all" and "Unselect all" buttons with matching
select_all_files() and unselect_all_files() actions
* Limit selection actions (compare, move, copy etc) to visible page
elements only.
* Added integration tests "Filtering collection files by regexp" and
"Creating collection from list of filtered files".
Peter Amstutz [Fri, 31 Oct 2014 17:28:09 +0000 (13:28 -0400)]
4084: Change $(this) to this and add comments. Refactor @pidfile in test_helper slightly.