Tom Clegg [Tue, 30 Aug 2016 21:34:42 +0000 (17:34 -0400)]
9799: Fix bootstrap markup.
Tom Clegg [Tue, 30 Aug 2016 20:30:17 +0000 (16:30 -0400)]
9799: Fix up live_log_lines so it works for all work units.
Tom Clegg [Tue, 30 Aug 2016 20:35:32 +0000 (16:35 -0400)]
9799: Remove bogus bootstrap classes and fix html syntax.
Tom Clegg [Tue, 30 Aug 2016 20:23:59 +0000 (16:23 -0400)]
9799: Move work unit tests from application_layout_test to work_units_test.
Tom Clegg [Tue, 30 Aug 2016 15:36:28 +0000 (11:36 -0400)]
9799: Fix show/hide "cancel container req" button: check ArvadosBase#editable?, and use CR priority instead of container priority.
Tom Clegg [Tue, 30 Aug 2016 15:14:55 +0000 (11:14 -0400)]
9799: Add forgotten serialized column.
Tom Clegg [Tue, 30 Aug 2016 03:29:57 +0000 (23:29 -0400)]
9799: Use more realistic log entries in Workbench live-logging tests. Remove redundant test.
Tom Clegg [Sun, 28 Aug 2016 03:31:37 +0000 (23:31 -0400)]
9799: Add missing container request, so container fixture is visible to test user.
Tom Clegg [Sat, 27 Aug 2016 03:34:14 +0000 (23:34 -0400)]
9799: Clean up permission code and comments.
Tom Clegg [Sat, 27 Aug 2016 03:16:15 +0000 (23:16 -0400)]
9799: Fix test order dependency.
Tom Clegg [Sat, 27 Aug 2016 03:06:11 +0000 (23:06 -0400)]
9799: Remove redundant test.
Tom Clegg [Tue, 30 Aug 2016 03:11:34 +0000 (23:11 -0400)]
9799: Restore permission on Log entries via owner_uuid.
Tom Clegg [Sat, 27 Aug 2016 03:06:01 +0000 (23:06 -0400)]
9799: Dry up SQL statements using named bind parameters.
Tom Clegg [Sat, 27 Aug 2016 01:46:10 +0000 (21:46 -0400)]
9799: Update test: "spectator" user is now allowed to read log entries about itself.
Tom Clegg [Sat, 27 Aug 2016 01:45:17 +0000 (21:45 -0400)]
9799: Permit read access to containers via container requests. Move Log- and Container-specific permission queries to log.rb and container.rb.
Tom Clegg [Sat, 27 Aug 2016 01:03:57 +0000 (21:03 -0400)]
9799: Add tests for container permissions.
Tom Clegg [Fri, 26 Aug 2016 21:34:25 +0000 (17:34 -0400)]
9799: Add tests for container log permissions.
Tom Clegg [Fri, 26 Aug 2016 21:09:42 +0000 (17:09 -0400)]
9799: Fix container fixture owner_uuid attributes to look like real-life containers.
Tom Clegg [Fri, 19 Aug 2016 15:14:03 +0000 (11:14 -0400)]
9799: Use regular (non-admin) user in Workbench websocket tests.
Tom Clegg [Fri, 19 Aug 2016 13:29:58 +0000 (09:29 -0400)]
9799: Use regular (non-admin) user in websocket integration tests.
Lucas Di Pentima [Tue, 30 Aug 2016 20:38:33 +0000 (17:38 -0300)]
Merge branch '9687-container-request-display'
Closes #9687
Lucas Di Pentima [Tue, 30 Aug 2016 19:37:48 +0000 (16:37 -0300)]
Merge branch 'master' into 9687-container-request-display
Peter Amstutz [Tue, 30 Aug 2016 19:34:14 +0000 (15:34 -0400)]
Merge branch '8232-docker-remove-obsolete' closes #8232
Peter Amstutz [Tue, 30 Aug 2016 19:07:15 +0000 (15:07 -0400)]
Merge branch '9783-cwl-error-invalid-dir' closes #9783
Tom Clegg [Tue, 30 Aug 2016 16:00:48 +0000 (12:00 -0400)]
9700: Remove "trashLifetime != 0 is not supported in S3" check, now that it is supported.
refs #9700
Lucas Di Pentima [Tue, 30 Aug 2016 13:47:32 +0000 (10:47 -0300)]
9687: Added exit_code method to work_unit interface declarations. Simplified state_label method using the new exit_code accessor.
Lucas Di Pentima [Tue, 30 Aug 2016 12:27:17 +0000 (09:27 -0300)]
9687: Added method to access container's exit_code. Updated test to explicitly test for exit_code in addition to state_label.
Lucas Di Pentima [Mon, 29 Aug 2016 20:50:58 +0000 (17:50 -0300)]
9687: Updated state_label method changes to something more simple and compact. Added exit_code:0 to complete container fixtures. Added explicit test case to check for a not Failed container.
Peter Amstutz [Mon, 29 Aug 2016 19:15:36 +0000 (15:15 -0400)]
Merge branch 'origin-9043-test-edit-container-request' closes #9043
Peter Amstutz [Mon, 29 Aug 2016 19:15:11 +0000 (15:15 -0400)]
9043: Remove redundant ex_opt_string and unsupported ex_opt_file_array from test fixture.
Peter Amstutz [Mon, 29 Aug 2016 19:05:03 +0000 (15:05 -0400)]
9043: Add check that Run button is disabled before filling in final require
value and checking that run button is enabled.
Lucas Di Pentima [Mon, 29 Aug 2016 14:03:58 +0000 (11:03 -0300)]
Merge branch '9854-container-validations-produce-bad-errors'
Closes #9854
Lucas Di Pentima [Fri, 26 Aug 2016 21:04:45 +0000 (18:04 -0300)]
Merge branch '9463-pysdk-amended'
Refs #9463
Lucas Di Pentima [Fri, 26 Aug 2016 18:09:18 +0000 (15:09 -0300)]
9463: Updated CWL tests to match Collection new behaviour.
Lucas Di Pentima [Fri, 26 Aug 2016 17:07:08 +0000 (14:07 -0300)]
9854: Added ArvadosModel::UnresolvableContainerError exception to return a 422 http status. Modified container resolving methods to raise this new exception instead of RecordNotFound. Updated related tests.
radhika [Fri, 26 Aug 2016 11:52:18 +0000 (07:52 -0400)]
9043: minor test tweaks
radhika [Fri, 26 Aug 2016 02:35:49 +0000 (22:35 -0400)]
9043: added tests for various input types
Tom Clegg [Thu, 25 Aug 2016 19:19:00 +0000 (15:19 -0400)]
Merge branch '9709-restore-manifest-logging'
closes #9709
Tom Clegg [Thu, 25 Aug 2016 18:41:43 +0000 (14:41 -0400)]
9709: Tweak config comment.
Tom Clegg [Thu, 25 Aug 2016 18:41:01 +0000 (14:41 -0400)]
9709: Test empty unlogged_attributes config.
Tom Clegg [Thu, 25 Aug 2016 17:49:15 +0000 (13:49 -0400)]
Merge branch '9705-crunch2-install-guide-wip'
closes #9705
closes #9706
Tom Clegg [Thu, 25 Aug 2016 17:44:24 +0000 (13:44 -0400)]
9709: Restore logging of manifest_text by default, add config option to omit it.
Peter Amstutz [Thu, 25 Aug 2016 16:59:12 +0000 (12:59 -0400)]
9043: Handle errors on when trying to commit container.
Peter Amstutz [Thu, 25 Aug 2016 16:58:32 +0000 (12:58 -0400)]
9043: Use match_uuid_with_optional_filepath instead of hardcoded uuid regex.
Peter Amstutz [Thu, 25 Aug 2016 15:25:03 +0000 (11:25 -0400)]
9043: Remove non-existent "Graph" tab. Fix "false" selection dropdown. Use
helper function instead of duplicating regex.
Peter Amstutz [Tue, 23 Aug 2016 18:57:52 +0000 (14:57 -0400)]
9043: Initial commit testing for container request editing
Peter Amstutz [Mon, 22 Aug 2016 20:21:59 +0000 (16:21 -0400)]
9043: Complete support for editing basic parameter types.
Supported parameter types: boolean, string, int, long, float, double, enum,
File, Directory. May be specified required or optional.
Not supported: arrays, unions (other than with "null"), records.
Peter Amstutz [Fri, 19 Aug 2016 21:33:18 +0000 (17:33 -0400)]
9043: Fixup incoming values from x-editable to have correct types. Work in progress.
Peter Amstutz [Fri, 19 Aug 2016 20:36:46 +0000 (16:36 -0400)]
9043: Initial work on rendering input forms for CWL workflows. Works for
simple parameters. Successfully writes back to container request object.
Peter Amstutz [Mon, 22 Aug 2016 20:33:32 +0000 (16:33 -0400)]
9043: Expand "uncommitted" test fixture to include more optional parameter types. Add uncommitted_ready_to_run to test the "Run" button.
Peter Amstutz [Thu, 18 Aug 2016 19:16:07 +0000 (15:16 -0400)]
Test fixture for uncommitted container request.
radhika [Thu, 25 Aug 2016 15:46:04 +0000 (11:46 -0400)]
refs #9767
Merge branch '9767-workflows-in-chooser'
radhika [Fri, 19 Aug 2016 17:54:19 +0000 (13:54 -0400)]
9767: include workflows in the template chooser.
Lucas Di Pentima [Fri, 19 Aug 2016 20:50:42 +0000 (17:50 -0300)]
9463: Several changes to the PySDK, as described below:
* Added ability to define the number of copies on the BlockManager.
* Added optional parameter to RichCollectionBase's method _get_manifest_text so that it returns the manifest text including only those committed blocks (avoiding flushing the others).
* Added ability to set up the replication desired level on Collection class.
* Fixed Collection's _my_api method, avoiding to ovewrite self.keep_client if already assigned.
* On Collection class, instantiate a BlockManager with the "copies" parameter taken from the collection or from the discovery document.
* Modified tests to support the new replication desired param at Collection class.
* Added tests to check if the replication desired parameter is loaded only when necessary.
* Added test to check the new behaviour of getting the manifest text with only committed blocks.
Lucas Di Pentima [Wed, 24 Aug 2016 19:05:27 +0000 (16:05 -0300)]
9687: For a ContainerRequest being committed, if its container has the state "Complete" but exit_code not zero, return "Failed" as a state_label so that Workbench won't render its status as "Complete". Added fixture & test to check for this correction.
Lucas Di Pentima [Tue, 23 Aug 2016 22:41:05 +0000 (19:41 -0300)]
Merge branch '9804-drop-activity-pane'
9804: Deleted activity pane from Workbench's collection view, a couple of queries that became unused on collection controller and updated the related tests. Closes #9804.
Lucas Di Pentima [Tue, 23 Aug 2016 20:36:34 +0000 (17:36 -0300)]
9804: Tweaked the collection#show's pane widths. Fixed some integration_performance tests that were failing after the activity pane removal and removed an unused query at collection controller.
Tom Clegg [Tue, 23 Aug 2016 17:29:04 +0000 (13:29 -0400)]
Merge branch '9706-package-systemd-files'
refs #9706
refs #9745
Tom Clegg [Mon, 22 Aug 2016 19:18:30 +0000 (15:18 -0400)]
9706: Use ${} interpolation syntax consistently.
Tom Clegg [Tue, 16 Aug 2016 01:35:35 +0000 (21:35 -0400)]
9706: 9745: Fix config struct to match example.
Tom Clegg [Mon, 15 Aug 2016 20:58:02 +0000 (16:58 -0400)]
9706: Notify systemd when crunch-dispatch-slurm is ready.
Tom Clegg [Mon, 15 Aug 2016 20:10:58 +0000 (16:10 -0400)]
9706: Add systemd unit file for crunch-dispatch-slurm.
Tom Clegg [Mon, 15 Aug 2016 20:10:29 +0000 (16:10 -0400)]
9706: Stop systemd services when their packages are uninstalled.
Brett Smith [Wed, 10 Aug 2016 17:22:02 +0000 (13:22 -0400)]
9706: Go service postinst improvements.
* Use /bin/sh, per Debian policy.
* Prefer basename for readability.
* Check for systemd init with [ -e /run/systemd/system ].
* Make configuration changes based on checking the unit file state.
Tom Clegg [Thu, 4 Aug 2016 22:43:17 +0000 (18:43 -0400)]
9706: Add postinst script to Go packages that have systemd unit files, so (on Debian) the service starts up without manual intervention.
Tom Clegg [Wed, 3 Aug 2016 21:06:55 +0000 (17:06 -0400)]
9706: If "foo.service" exists in the source dir for a Go program, package it so it installs to /lib/systemd/system/.
Peter Amstutz [Tue, 23 Aug 2016 13:27:28 +0000 (09:27 -0400)]
Merge branch '9827-no-docker-caching' closes #9827
Tom Clegg [Mon, 22 Aug 2016 20:39:05 +0000 (16:39 -0400)]
Merge branch '9773-faster-find-or-create'
refs #9773
Tom Clegg [Mon, 22 Aug 2016 20:25:14 +0000 (16:25 -0400)]
9773: If previous jobs disagree about outputs, but a new job is
already queued/running, reuse the new job (as we did before 9773).
Tom Clegg [Sat, 20 Aug 2016 22:20:29 +0000 (18:20 -0400)]
9773: Exclude script_parameters_digest from searchable columns -- it is not even visible to clients.
Tom Clegg [Fri, 19 Aug 2016 21:03:24 +0000 (17:03 -0400)]
9773: Use script_parameters_digest in reusable job query.
Tom Clegg [Fri, 19 Aug 2016 21:02:03 +0000 (17:02 -0400)]
9773: Add script_parameters_digest column to support faster job reuse.
Tom Clegg [Fri, 19 Aug 2016 19:00:09 +0000 (15:00 -0400)]
9773: Fix up find-or-create-job code.
* Reduce pyramid of conditions
* Ask the database to filter script_parameters, instead of doing that in Ruby
* Ditto job state
* Check "output is readable?" only once, not once per candidate job
* If two matching jobs have different outputs, avoid reusing either of them,
even if one of the outputs is not readable by current_user.
Tom Clegg [Mon, 22 Aug 2016 17:06:58 +0000 (13:06 -0400)]
Merge branch '9818-logstash'
refs #9818
refs #9709
Tom Clegg [Thu, 18 Aug 2016 20:47:19 +0000 (16:47 -0400)]
9818: Log params when small, first 1K of json-encoded params when big.
Tom Clegg [Thu, 18 Aug 2016 19:18:45 +0000 (15:18 -0400)]
9818: Use lograge/logstash for Workbench request logs.
Tom Clegg [Thu, 18 Aug 2016 19:12:03 +0000 (15:12 -0400)]
9818: Use lograge to log API requests in logstash format.
Example log line:
{"method":"GET","path":"/arvados/v1/keep_services/accessible","format":"html","controller":"arvados/v1/keep_services","action":"accessible","status":200,"duration":11.07,"view":0.36,"db":2.63,"@timestamp":"2016-08-18T19:04:17Z","@version":"1","message":"[200] GET /arvados/v1/keep_services/accessible (arvados/v1/keep_services#accessible)"}
Lucas Di Pentima [Mon, 22 Aug 2016 14:05:00 +0000 (11:05 -0300)]
9804: Removed the "Activity" pane from Collection View @ Workbench. Also removed a related query on the controller's show method, and a test.
Tom Clegg [Mon, 22 Aug 2016 13:42:44 +0000 (09:42 -0400)]
Merge branch '9826-config-symbols'
closes #9826
Tom Clegg [Mon, 22 Aug 2016 13:13:15 +0000 (09:13 -0400)]
9826: Deserialize symbols when loading server config YAML.
Peter Amstutz [Mon, 22 Aug 2016 02:53:32 +0000 (22:53 -0400)]
Add --compute-checksum to sdk/cwl/test_with_arvbox.sh refs #9552
Peter Amstutz [Mon, 22 Aug 2016 02:13:55 +0000 (22:13 -0400)]
9827: Use "arvbox rebuild" to ensure up to date arvados/arvbox-demo image.
Peter Amstutz [Mon, 22 Aug 2016 02:09:38 +0000 (22:09 -0400)]
8232: Remove outdated/misleading Docker install
Peter Amstutz [Fri, 19 Aug 2016 15:13:51 +0000 (11:13 -0400)]
Merge branch '9820-cwl-poll-jobs' closes #9820
Peter Amstutz [Fri, 19 Aug 2016 14:50:25 +0000 (10:50 -0400)]
9820: Directly poll job or container records that we are interested in. Benefit: puts less load on database than log table polling, and doesn't miss events.
Tom Clegg [Fri, 19 Aug 2016 00:27:37 +0000 (20:27 -0400)]
Merge branch '9684-workflows'
refs #9684
Tom Clegg [Fri, 19 Aug 2016 00:12:25 +0000 (20:12 -0400)]
9684: Style nitpicks.
radhika [Thu, 18 Aug 2016 18:22:59 +0000 (14:22 -0400)]
9684: update arvados_model -> recursive_stringify to convert ":foo" to "foo"
Lucas Di Pentima [Thu, 18 Aug 2016 17:56:43 +0000 (14:56 -0300)]
Merge branch '9333-api-server-invalid-sql'
9333: Fixes to solve workbench integration tests failures. Refs #9333
Lucas Di Pentima [Thu, 18 Aug 2016 17:34:38 +0000 (14:34 -0300)]
Merge branch 'master' into 9333-api-server-invalid-sql
radhika [Thu, 18 Aug 2016 16:47:50 +0000 (12:47 -0400)]
9684: update arvados_model -> recursive_stringify to convert ":foo" to "foo"
Lucas Di Pentima [Thu, 18 Aug 2016 16:06:01 +0000 (13:06 -0300)]
9333: Adding collection model specific sttributes to be ignored on the validation mechanism to fix workbench integration test failures
radhika [Thu, 18 Aug 2016 13:43:23 +0000 (09:43 -0400)]
9684: Add safe_yaml initializer
radhika [Thu, 18 Aug 2016 11:51:21 +0000 (07:51 -0400)]
closes #9684
Merge branch '9684-workflows'
Lucas Di Pentima [Wed, 17 Aug 2016 16:44:41 +0000 (13:44 -0300)]
Merge branch '9333-api-server-invalid-sql'
9333: Selected attributes list validation on the API Server, avoiding invalid SQL queries to the database. Closes #9333
Lucas Di Pentima [Wed, 17 Aug 2016 16:39:24 +0000 (13:39 -0300)]
9333: Removed superfluous quote marks on exception message
Lucas Di Pentima [Tue, 16 Aug 2016 21:22:04 +0000 (18:22 -0300)]
9333: Treating the "attribute is not a string" error case the same as the other invalid attributes. Moved the checks to ArvadosModel. Updated tests.
radhika [Tue, 16 Aug 2016 21:09:33 +0000 (17:09 -0400)]
9684: workflow yaml error logging
Peter Amstutz [Tue, 16 Aug 2016 16:01:23 +0000 (12:01 -0400)]
9783: Report useful error if subdirectory of a collection doesn't exist or isn't a
directory.
radhika [Mon, 15 Aug 2016 22:19:00 +0000 (18:19 -0400)]
9678: use safe_yaml and other updates.