arvados.git
4 years agoMerge branch '16928-non-boolean-param-warning'
Tom Clegg [Wed, 7 Oct 2020 20:37:06 +0000 (16:37 -0400)]
Merge branch '16928-non-boolean-param-warning'

refs #16928

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoActually load our custom sysctl.conf entries.
Ward Vandewege [Wed, 7 Oct 2020 18:33:25 +0000 (14:33 -0400)]
Actually load our custom sysctl.conf entries.

refs #16955

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16928: Avoid misleading warning when using implicit bool defaults.
Tom Clegg [Wed, 7 Oct 2020 17:32:10 +0000 (13:32 -0400)]
16928: Avoid misleading warning when using implicit bool defaults.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16928: Fill in missing bool defaults in *_requires_parameters.
Tom Clegg [Wed, 7 Oct 2020 17:31:03 +0000 (13:31 -0400)]
16928: Fill in missing bool defaults in *_requires_parameters.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16928: Fix advertised default value of include_old_versions.
Tom Clegg [Wed, 7 Oct 2020 17:30:47 +0000 (13:30 -0400)]
16928: Fix advertised default value of include_old_versions.

Also remove special defaults-override logic, now that the existing
load_params code knows the right defaults.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16928: Improve warning message.
Tom Clegg [Wed, 7 Oct 2020 17:25:12 +0000 (13:25 -0400)]
16928: Improve warning message.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16955-fix-arvbox' into master
Ward Vandewege [Wed, 7 Oct 2020 15:45:50 +0000 (11:45 -0400)]
Merge branch '16955-fix-arvbox' into master

closes #16955

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16955: Merge branch 'master' into 16955-fix-arvbox
Ward Vandewege [Wed, 7 Oct 2020 15:45:09 +0000 (11:45 -0400)]
16955: Merge branch 'master' into 16955-fix-arvbox

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16955: a number of fixes to make the federation migration tests pass
Ward Vandewege [Wed, 7 Oct 2020 01:06:01 +0000 (21:06 -0400)]
16955: a number of fixes to make the federation migration tests pass
       with arvbox again. Followup to #16267.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16956-doc-fix-zenweb-liquid-4' into master
Ward Vandewege [Tue, 6 Oct 2020 21:23:23 +0000 (17:23 -0400)]
Merge branch '16956-doc-fix-zenweb-liquid-4' into master

closes #16956

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16956: address review comments.
Ward Vandewege [Tue, 6 Oct 2020 21:14:48 +0000 (17:14 -0400)]
16956: address review comments.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16956: update our zenweb/liquid package to support liquid 4+
Ward Vandewege [Tue, 6 Oct 2020 18:02:17 +0000 (14:02 -0400)]
16956: update our zenweb/liquid package to support liquid 4+

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16809-s3-v4-signature'
Tom Clegg [Tue, 6 Oct 2020 17:56:07 +0000 (13:56 -0400)]
Merge branch '16809-s3-v4-signature'

closes #16809

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoFix arv-federation-migrate-test jenkins job: update hardcoded arvbox
Ward Vandewege [Tue, 6 Oct 2020 15:55:41 +0000 (11:55 -0400)]
Fix arv-federation-migrate-test jenkins job: update hardcoded arvbox
container paths.

refs #16267

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoFix arvados-cwl-conformance-tests and arv-federation-migrate-test
Ward Vandewege [Tue, 6 Oct 2020 13:47:55 +0000 (09:47 -0400)]
Fix arvados-cwl-conformance-tests and arv-federation-migrate-test
jenkins jobs.

refs #16267

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoFix more golint warnings.
Ward Vandewege [Tue, 6 Oct 2020 00:26:10 +0000 (20:26 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoCan't use generic copy for container requests refs #16886
Peter Amstutz [Mon, 5 Oct 2020 18:18:27 +0000 (14:18 -0400)]
Can't use generic copy for container requests refs #16886

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16809: Test S3 API using Amazon client library.
Tom Clegg [Mon, 5 Oct 2020 18:13:00 +0000 (14:13 -0400)]
16809: Test S3 API using Amazon client library.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoFix 'test' login method to return v2 token, no issue #
Peter Amstutz [Mon, 5 Oct 2020 18:01:36 +0000 (14:01 -0400)]
Fix 'test' login method to return v2 token, no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoFix more golint warnings.
Ward Vandewege [Sun, 4 Oct 2020 21:25:37 +0000 (17:25 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoAdd a cli example: create an empty collection.
Ward Vandewege [Sun, 4 Oct 2020 21:10:27 +0000 (17:10 -0400)]
Add a cli example: create an empty collection.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16750-logincluster-wb1-trash-fix'
Lucas Di Pentima [Sat, 3 Oct 2020 14:29:57 +0000 (11:29 -0300)]
Merge branch '16750-logincluster-wb1-trash-fix'
Closes #16750

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoFix some more golint warnings.
Ward Vandewege [Sat, 3 Oct 2020 01:10:19 +0000 (21:10 -0400)]
Fix some more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16750: Avoids using params on requests to make it compatible with federation.
Lucas Di Pentima [Thu, 1 Oct 2020 13:52:23 +0000 (10:52 -0300)]
16750: Avoids using params on requests to make it compatible with federation.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoFixes collection_versioning mention on documentation. No issue #
Lucas Di Pentima [Fri, 2 Oct 2020 14:48:14 +0000 (11:48 -0300)]
Fixes collection_versioning mention on documentation. No issue #

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoFix more golint warnings.
Ward Vandewege [Thu, 1 Oct 2020 23:44:14 +0000 (19:44 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16923-auth-api-client' refs #16923
Peter Amstutz [Thu, 1 Oct 2020 22:12:03 +0000 (18:12 -0400)]
Merge branch '16923-auth-api-client' refs #16923

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16923: Improve architecture diagram a bit.
Peter Amstutz [Thu, 1 Oct 2020 22:09:50 +0000 (18:09 -0400)]
16923: Improve architecture diagram a bit.

Fix comment about TrustedClients config item.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoarvados-cwl-runner, don't pull arvados/jobs:latest, pull arvados/jobs:version
Peter Amstutz [Thu, 1 Oct 2020 20:46:08 +0000 (16:46 -0400)]
arvados-cwl-runner, don't pull arvados/jobs:latest, pull arvados/jobs:version

refs #16886

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16923: Add Login.TrustedClients to export
Peter Amstutz [Thu, 1 Oct 2020 19:11:44 +0000 (15:11 -0400)]
16923: Add Login.TrustedClients to export

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16923: Add peer federation / logincluster federation to architecture
Peter Amstutz [Thu, 1 Oct 2020 17:58:43 +0000 (13:58 -0400)]
16923: Add peer federation / logincluster federation to architecture

Also rearrange the high-level architecture diagram a little bit.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16923: Add note about federation types and trusted clients.
Peter Amstutz [Wed, 30 Sep 2020 18:08:12 +0000 (14:08 -0400)]
16923: Add note about federation types and trusted clients.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16923: Add "TrustedClients" configuration option.
Peter Amstutz [Tue, 29 Sep 2020 23:12:50 +0000 (19:12 -0400)]
16923: Add "TrustedClients" configuration option.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16923: user/pass api_client is trusted by default
Peter Amstutz [Tue, 29 Sep 2020 21:26:46 +0000 (17:26 -0400)]
16923: user/pass api_client is trusted by default

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoUserGet() passes "select" option along to batch update refs #16914
Peter Amstutz [Wed, 30 Sep 2020 21:13:59 +0000 (17:13 -0400)]
UserGet() passes "select" option along to batch update refs #16914

Fixes issue of user being deactivated because something called "get
user" and selected fields didn't include is_active.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agolibpam-arvados-go: do not put a file with comments in
Ward Vandewege [Tue, 29 Sep 2020 21:53:53 +0000 (17:53 -0400)]
libpam-arvados-go: do not put a file with comments in
/usr/share/pam-configs, the `pam-auth-update` command does not take
kindly to that. Put that file in the package documentation directory
instead.

refs #15348

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoAdjust arvbox shell to have /var/lib/arvados/bin in PATH
Peter Amstutz [Tue, 29 Sep 2020 19:42:54 +0000 (15:42 -0400)]
Adjust arvbox shell to have /var/lib/arvados/bin in PATH

no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoBetter help text for arvbox adduser/removeuser no issue #
Peter Amstutz [Tue, 29 Sep 2020 18:59:57 +0000 (14:59 -0400)]
Better help text for arvbox adduser/removeuser no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16914-inactive-user' closes #16914
Peter Amstutz [Tue, 29 Sep 2020 18:54:44 +0000 (14:54 -0400)]
Merge branch '16914-inactive-user' closes #16914

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16914: Make sure remote uninvited user is not invited here
Peter Amstutz [Tue, 29 Sep 2020 14:55:16 +0000 (10:55 -0400)]
16914: Make sure remote uninvited user is not invited here

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16914: "Get current user" is forwarded to LoginCluster
Peter Amstutz [Mon, 28 Sep 2020 21:00:33 +0000 (17:00 -0400)]
16914: "Get current user" is forwarded to LoginCluster

Results from "get user" and "current user" are now cached, same as
"user list".

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16913-logout' closes #16913
Peter Amstutz [Mon, 28 Sep 2020 19:36:54 +0000 (15:36 -0400)]
Merge branch '16913-logout' closes #16913

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16913: Add upgrade note about LoginCluster
Peter Amstutz [Mon, 28 Sep 2020 18:43:05 +0000 (14:43 -0400)]
16913: Add upgrade note about LoginCluster

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16913: Treat LoginCluster as a distinct login method.
Peter Amstutz [Mon, 28 Sep 2020 18:28:18 +0000 (14:28 -0400)]
16913: Treat LoginCluster as a distinct login method.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16267-change-arvbox-deps' into master
Ward Vandewege [Mon, 28 Sep 2020 15:59:28 +0000 (11:59 -0400)]
Merge branch '16267-change-arvbox-deps' into master

closes #16267

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16267: Merge branch 'master' into 16267-change-arvbox-deps
Ward Vandewege [Mon, 28 Sep 2020 15:58:54 +0000 (11:58 -0400)]
16267: Merge branch 'master' into 16267-change-arvbox-deps

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoFix more golint warnings.
Ward Vandewege [Mon, 28 Sep 2020 02:16:48 +0000 (22:16 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoFix more golint warnings.
Ward Vandewege [Sun, 27 Sep 2020 02:09:06 +0000 (22:09 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16874-configure-welcome-mail' refs #16874
Peter Amstutz [Fri, 25 Sep 2020 22:17:13 +0000 (18:17 -0400)]
Merge branch '16874-configure-welcome-mail' refs #16874

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16874: Fix test.
Peter Amstutz [Fri, 25 Sep 2020 22:04:29 +0000 (18:04 -0400)]
16874: Fix test.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16267: fix logic bug, use local checked out arvados directory in dev
Ward Vandewege [Fri, 25 Sep 2020 21:31:43 +0000 (17:31 -0400)]
16267: fix logic bug, use local checked out arvados directory in dev
       mode, not the copy under ~/.arvbox

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16874: Content of account_is_setup.text.erb uses Users.UserSetupMailText
Peter Amstutz [Fri, 25 Sep 2020 21:17:06 +0000 (17:17 -0400)]
16874: Content of account_is_setup.text.erb uses Users.UserSetupMailText

The most straightforward solution seems to be for UserSetupMailText to
still be an erb template and is evaluated in the same environment as
as before, but it gets the code from the config file.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16825-delete-token' closes #16825
Peter Amstutz [Fri, 25 Sep 2020 18:55:31 +0000 (14:55 -0400)]
Merge branch '16825-delete-token' closes #16825

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16825: Document deleting token at the CLI
Peter Amstutz [Fri, 25 Sep 2020 15:46:36 +0000 (11:46 -0400)]
16825: Document deleting token at the CLI

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoRecommend installing R package from https refs #16885
Peter Amstutz [Fri, 25 Sep 2020 15:07:02 +0000 (11:07 -0400)]
Recommend installing R package from https refs #16885

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16809: Test keep-web with s3cmd if available.
Tom Clegg [Fri, 25 Sep 2020 05:00:43 +0000 (01:00 -0400)]
16809: Test keep-web with s3cmd if available.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16809: Fix empty Host header value used in signature check.
Tom Clegg [Fri, 25 Sep 2020 04:42:01 +0000 (00:42 -0400)]
16809: Fix empty Host header value used in signature check.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16809: Improve signature error reporting/logging.
Tom Clegg [Fri, 25 Sep 2020 04:41:26 +0000 (00:41 -0400)]
16809: Improve signature error reporting/logging.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16267: implement review feedback.
Ward Vandewege [Fri, 25 Sep 2020 00:49:57 +0000 (20:49 -0400)]
16267: implement review feedback.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16264-add-r-dependencies' into master
Ward Vandewege [Thu, 24 Sep 2020 21:00:58 +0000 (17:00 -0400)]
Merge branch '16264-add-r-dependencies' into master

closes #16264

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16264: Merge branch 'master' into 16264-add-r-dependencies
Ward Vandewege [Thu, 24 Sep 2020 21:00:25 +0000 (17:00 -0400)]
16264: Merge branch 'master' into 16264-add-r-dependencies

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16827-fix-R-sdk' refs #16827
Peter Amstutz [Thu, 24 Sep 2020 20:58:40 +0000 (16:58 -0400)]
Merge branch '16827-fix-R-sdk' refs #16827

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16884: Add public_project permission link to test fixtures
Peter Amstutz [Thu, 24 Sep 2020 20:01:20 +0000 (16:01 -0400)]
16884: Add public_project permission link to test fixtures

This is the permission link that gives the all users and anonymous
users read access to public favorites.  It is added by database seeds,
but it also needs to be present in the fixtures.

refs #16884
refs #16811

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16827: Don't append '/' to requests with query params. Bump version
Peter Amstutz [Wed, 23 Sep 2020 21:50:14 +0000 (17:50 -0400)]
16827: Don't append '/' to requests with query params.  Bump version

Also remove package-cross loading with "source" that generated warnings.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16827: Update the generated API to Arvados 2.0
Peter Amstutz [Wed, 23 Sep 2020 20:40:55 +0000 (16:40 -0400)]
16827: Update the generated API to Arvados 2.0

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16827: Fix getFileNamesFromResponse
Peter Amstutz [Wed, 23 Sep 2020 20:17:09 +0000 (16:17 -0400)]
16827: Fix getFileNamesFromResponse

Update tests.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16267: switch to `arvados-server install -type test` for installing
Ward Vandewege [Wed, 23 Sep 2020 23:46:21 +0000 (19:46 -0400)]
16267: switch to `arvados-server install -type test` for installing
       dependencies.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16264: add R dependencies as Debian packages to lib/install/deps.go
Ward Vandewege [Thu, 24 Sep 2020 00:56:12 +0000 (20:56 -0400)]
16264: add R dependencies as Debian packages to lib/install/deps.go

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16850-s3-keycount'
Tom Clegg [Wed, 23 Sep 2020 14:33:52 +0000 (10:33 -0400)]
Merge branch '16850-s3-keycount'

fixes #16850

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoTweak database seeds so the reset-to-fixture API works
Peter Amstutz [Tue, 22 Sep 2020 21:15:19 +0000 (17:15 -0400)]
Tweak database seeds so the reset-to-fixture API works

refs #16811

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16811-public-favs' refs #16811
Peter Amstutz [Tue, 22 Sep 2020 20:32:54 +0000 (16:32 -0400)]
Merge branch '16811-public-favs' refs #16811

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16811: Make note about public favorites migration
Peter Amstutz [Tue, 22 Sep 2020 20:31:42 +0000 (16:31 -0400)]
16811: Make note about public favorites migration

Also add recommendation to back up database before upgrading.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch 'master' into 16811-public-favs
Peter Amstutz [Tue, 22 Sep 2020 19:57:34 +0000 (15:57 -0400)]
Merge branch 'master' into 16811-public-favs

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16809: Accept S3 reqs with same token as AccessKey and SecretKey.
Tom Clegg [Tue, 22 Sep 2020 18:59:14 +0000 (14:59 -0400)]
16809: Accept S3 reqs with same token as AccessKey and SecretKey.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16859-pdh-version' closes #16859
Peter Amstutz [Tue, 22 Sep 2020 18:30:40 +0000 (14:30 -0400)]
Merge branch '16859-pdh-version' closes #16859

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoTweak text saying which version of Ruby to install & add upgrade note
Peter Amstutz [Tue, 22 Sep 2020 17:20:51 +0000 (13:20 -0400)]
Tweak text saying which version of Ruby to install & add upgrade note

refs #16861

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16856-acr-disable-color' closes #16856
Peter Amstutz [Tue, 22 Sep 2020 17:12:09 +0000 (13:12 -0400)]
Merge branch '16856-acr-disable-color' closes #16856

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoUpdate our docs to state a minimum requirement of Ruby 2.5, since we
Ward Vandewege [Tue, 22 Sep 2020 15:52:35 +0000 (11:52 -0400)]
Update our docs to state a minimum requirement of Ruby 2.5, since we
don't test on 2.3 anymore.

closes #16868
refs #16861

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16809: Expand path-cleaning comment.
Tom Clegg [Tue, 22 Sep 2020 13:35:40 +0000 (09:35 -0400)]
16809: Expand path-cleaning comment.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16791-api-flaky-test-fix'
Lucas Di Pentima [Tue, 22 Sep 2020 12:49:13 +0000 (09:49 -0300)]
Merge branch '16791-api-flaky-test-fix'
Closes #16791

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16809: Accept S3 requests with V4 signatures.
Tom Clegg [Tue, 22 Sep 2020 03:56:39 +0000 (23:56 -0400)]
16809: Accept S3 requests with V4 signatures.

(UUID part of Arvados token as access key, secret part as secret key)

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16859: default include_old_versions: true for GET by PDH or UUID
Peter Amstutz [Mon, 21 Sep 2020 20:59:51 +0000 (16:59 -0400)]
16859: default include_old_versions: true for GET by PDH or UUID

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16831-fix-arvbox-bundler-errors' into master
Ward Vandewege [Mon, 21 Sep 2020 20:30:29 +0000 (16:30 -0400)]
Merge branch '16831-fix-arvbox-bundler-errors' into master

closes #16831

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16831: Merge branch 'master' into 16831-fix-arvbox-bundler-errors
Ward Vandewege [Mon, 21 Sep 2020 20:29:29 +0000 (16:29 -0400)]
16831: Merge branch 'master' into 16831-fix-arvbox-bundler-errors

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16856: Fix tests.
Peter Amstutz [Mon, 21 Sep 2020 20:13:13 +0000 (16:13 -0400)]
16856: Fix tests.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16856: Log the cluster being submitted to
Peter Amstutz [Mon, 21 Sep 2020 18:44:57 +0000 (14:44 -0400)]
16856: Log the cluster being submitted to

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16856: Make spurious msg "Using empty collection" debug log level
Peter Amstutz [Mon, 21 Sep 2020 18:33:17 +0000 (14:33 -0400)]
16856: Make spurious msg "Using empty collection" debug log level

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16856: Pass --disable-color, workbench log doesn't do color codes
Peter Amstutz [Mon, 21 Sep 2020 18:25:58 +0000 (14:25 -0400)]
16856: Pass --disable-color, workbench log doesn't do color codes

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoFix more golint warnings.
Ward Vandewege [Mon, 21 Sep 2020 02:16:52 +0000 (22:16 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoFix more golint warnings.
Ward Vandewege [Sat, 19 Sep 2020 14:51:25 +0000 (10:51 -0400)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoRename the ssh_executor package to sshexecutor, fix Golint warning.
Ward Vandewege [Thu, 17 Sep 2020 21:03:01 +0000 (17:03 -0400)]
Rename the ssh_executor package to sshexecutor, fix Golint warning.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16831: arvbox: bugfix: fix bundler version issue in documentation.
Ward Vandewege [Fri, 18 Sep 2020 21:06:41 +0000 (17:06 -0400)]
16831: arvbox: bugfix: fix bundler version issue in documentation.
       Upgrade images to Debian Buster. Clean up whitespace in the
       arvbox command.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16811: Add a test that system users/groups can't be deleted.
Peter Amstutz [Fri, 18 Sep 2020 23:21:09 +0000 (19:21 -0400)]
16811: Add a test that system users/groups can't be deleted.

Also tweak PublicFavoritesProject migration to use up/down instead of
change.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16791: Restores original deadline of 10 seconds on test.
Lucas Di Pentima [Fri, 18 Sep 2020 22:17:04 +0000 (19:17 -0300)]
16791: Restores original deadline of 10 seconds on test.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16838-probe-metrics' into master
Ward Vandewege [Fri, 18 Sep 2020 20:36:08 +0000 (16:36 -0400)]
Merge branch '16838-probe-metrics' into master

closes #16838

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16838: Merge branch 'master' into 16838-probe-metrics
Ward Vandewege [Fri, 18 Sep 2020 20:35:31 +0000 (16:35 -0400)]
16838: Merge branch 'master' into 16838-probe-metrics

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16791: Fixes audit log cleaning tests.
Lucas Di Pentima [Fri, 18 Sep 2020 20:18:57 +0000 (17:18 -0300)]
16791: Fixes audit log cleaning tests.

Log fixtures lacking the created_at field set in the past in combination
with incorrect testing made us believe the LogTest was working ok.
Specifically, LogTest#test_delete_old_audit_logs_in_thread was not doing
the waiting for the log entries to be eliminated, so there was a race
between the AuditLogs thread cleaning the records and the test teardown doing
the rollback producing the intermittent failure of
use_ownership_and_permission_links_to_determine_which_logs_a_user_can_see.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoFix wb1 bug preventing deletion of container requests & workflows
Peter Amstutz [Fri, 18 Sep 2020 19:09:23 +0000 (15:09 -0400)]
Fix wb1 bug preventing deletion of container requests & workflows

refs #16839

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16838: implement review feedback.
Ward Vandewege [Fri, 18 Sep 2020 18:40:11 +0000 (14:40 -0400)]
16838: implement review feedback.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16850: Add KeyCount field to S3 ListObjects response.
Tom Clegg [Fri, 18 Sep 2020 17:45:09 +0000 (13:45 -0400)]
16850: Add KeyCount field to S3 ListObjects response.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>