16809: Expand path-cleaning comment.
authorTom Clegg <tom@tomclegg.ca>
Tue, 22 Sep 2020 13:35:40 +0000 (09:35 -0400)
committerTom Clegg <tom@tomclegg.ca>
Tue, 22 Sep 2020 13:35:40 +0000 (09:35 -0400)
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

services/keep-web/s3_test.go

index 94a478f074b28f22d80b67b9acb6bc4070f4afee..9a3989f611a1190ffe4fc448774296cbf95c5b8a 100644 (file)
@@ -313,8 +313,10 @@ func (s *IntegrationSuite) testS3PutObjectFailure(c *check.C, bucket *s3.Bucket,
        s.testServer.Config.cluster.Collections.S3FolderObjects = false
 
        // Can't use V4 signature for these tests, because
-       // double-slash is incorrectly cleaned by goamz, resulting in
-       // a "bad signature" error.
+       // double-slash is incorrectly cleaned by the aws.V4Signature,
+       // resulting in a "bad signature" error. (Cleaning the path is
+       // appropriate for other services, but not in S3 where object
+       // names "foo//bar" and "foo/bar" are semantically different.)
        bucket.S3.Auth = *(aws.NewAuth(arvadostest.ActiveToken, "none", "", time.Now().Add(time.Hour)))
        bucket.S3.Signature = aws.V2Signature