arvados.git
3 months agoMerge branch '22053-collection-test'
Lisa Knox [Tue, 20 Aug 2024 20:14:50 +0000 (16:14 -0400)]
Merge branch '22053-collection-test'

closes #22053

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months ago22053: fixed collection test
Lisa Knox [Tue, 20 Aug 2024 20:07:51 +0000 (16:07 -0400)]
22053: fixed collection test

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months agoMerge branch '21898-info-button-behavior'
Lisa Knox [Tue, 20 Aug 2024 18:18:48 +0000 (14:18 -0400)]
Merge branch '21898-info-button-behavior'

closes #21898

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months agoMerge branch '21941-keep-web-link' refs #21941
Peter Amstutz [Tue, 20 Aug 2024 14:16:43 +0000 (10:16 -0400)]
Merge branch '21941-keep-web-link' refs #21941

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21941: Tweak menu item names 21941-keep-web-link
Peter Amstutz [Mon, 19 Aug 2024 19:54:59 +0000 (15:54 -0400)]
21941: Tweak menu item names

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '20272-description-label' refs #20272
Peter Amstutz [Mon, 19 Aug 2024 19:40:52 +0000 (15:40 -0400)]
Merge branch '20272-description-label' refs #20272

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '21944-work-launch-description' refs #21944
Peter Amstutz [Fri, 16 Aug 2024 14:56:06 +0000 (10:56 -0400)]
Merge branch '21944-work-launch-description' refs #21944

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '21990-log-timestamps'
Tom Clegg [Fri, 16 Aug 2024 14:34:47 +0000 (10:34 -0400)]
Merge branch '21990-log-timestamps'

fixes #21990

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months agoMerge branch '19982-spot-instance' refs #19982
Peter Amstutz [Fri, 16 Aug 2024 14:04:34 +0000 (10:04 -0400)]
Merge branch '19982-spot-instance' refs #19982

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21944: Fix typo 21944-work-launch-description
Peter Amstutz [Thu, 15 Aug 2024 19:55:53 +0000 (15:55 -0400)]
21944: Fix typo

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago19982: Add arv:failed_container_resubmitted property 19982-spot-instance
Peter Amstutz [Thu, 15 Aug 2024 19:29:19 +0000 (15:29 -0400)]
19982: Add arv:failed_container_resubmitted property

Will do a follow-up ticket to make use of this property in workbench.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21910: Update docs to reflect new behavior.
Tom Clegg [Wed, 14 Aug 2024 13:24:15 +0000 (09:24 -0400)]
21910: Update docs to reflect new behavior.

refs #21910

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21944: Allow HTML in the other places that display workflow descriptions
Peter Amstutz [Thu, 15 Aug 2024 18:10:08 +0000 (14:10 -0400)]
21944: Allow HTML in the other places that display workflow descriptions

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '21363-ubuntu2404-docs'
Brett Smith [Thu, 15 Aug 2024 17:19:51 +0000 (13:19 -0400)]
Merge branch '21363-ubuntu2404-docs'

Closes #21363, #22032, #22035.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21990: Restore timestamps to crunchstat, hoststat, arv-mount logs. 21990-log-timestamps
Tom Clegg [Thu, 15 Aug 2024 15:19:33 +0000 (11:19 -0400)]
21990: Restore timestamps to crunchstat, hoststat, arv-mount logs.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago19982: Remove arv_docker_clear_cache, which was already commented out
Peter Amstutz [Thu, 15 Aug 2024 14:56:31 +0000 (10:56 -0400)]
19982: Remove arv_docker_clear_cache, which was already commented out

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago19982: Fix tests, update docs
Peter Amstutz [Thu, 15 Aug 2024 14:41:20 +0000 (10:41 -0400)]
19982: Fix tests, update docs

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '22027-remove-themes-for-rails' refs #22027
Peter Amstutz [Thu, 15 Aug 2024 13:51:25 +0000 (09:51 -0400)]
Merge branch '22027-remove-themes-for-rails' refs #22027

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '21910-remove-api_client_id'
Tom Clegg [Wed, 14 Aug 2024 19:37:39 +0000 (15:37 -0400)]
Merge branch '21910-remove-api_client_id'

closes #21910

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21910: Update all "Authorization: OAuth2 ..." usage to "Bearer". 21910-remove-api_client_id
Tom Clegg [Wed, 14 Aug 2024 18:36:12 +0000 (14:36 -0400)]
21910: Update all "Authorization: OAuth2 ..." usage to "Bearer".

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21944: Fix tests
Peter Amstutz [Wed, 14 Aug 2024 18:24:35 +0000 (14:24 -0400)]
21944: Fix tests

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21910: Comment system root token fixture.
Tom Clegg [Wed, 14 Aug 2024 18:23:41 +0000 (14:23 -0400)]
21910: Comment system root token fixture.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago22027: Remove themes_for_rails 22027-remove-themes-for-rails
Peter Amstutz [Wed, 14 Aug 2024 17:03:07 +0000 (13:03 -0400)]
22027: Remove themes_for_rails

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21898: fixed e2e tests 21898-info-button-behavior
Lisa Knox [Wed, 14 Aug 2024 15:37:46 +0000 (11:37 -0400)]
21898: fixed e2e tests

* removed "shows details panel when clicking on the info icon" test entirely

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months ago21363: Update install dependencies for libcurl4t64 21363-ubuntu2404-docs
Brett Smith [Wed, 14 Aug 2024 14:16:27 +0000 (10:16 -0400)]
21363: Update install dependencies for libcurl4t64

We no longer support any distributions without libcurl4, so we can
remove that branch and let this become the new default.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21363: Remove libcurl4 from listed example gems_deps
Brett Smith [Wed, 14 Aug 2024 14:10:52 +0000 (10:10 -0400)]
21363: Remove libcurl4 from listed example gems_deps

This is no longer listed in arvados-formula in order to better support
distributions that call it libcurl4t64.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21363: Document that we now support Ubuntu 24.04
Brett Smith [Wed, 14 Aug 2024 14:09:55 +0000 (10:09 -0400)]
21363: Document that we now support Ubuntu 24.04

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21363: Clarify minimum version for RHEL 8 support
Brett Smith [Wed, 14 Aug 2024 14:09:28 +0000 (10:09 -0400)]
21363: Clarify minimum version for RHEL 8 support

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21898: changed context menu toggleDetailsPanel to openDetailsPanel
Lisa Knox [Wed, 14 Aug 2024 14:01:54 +0000 (10:01 -0400)]
21898: changed context menu toggleDetailsPanel to openDetailsPanel

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months ago21910: Merge branch 'main' into 21910-remove-api_client_id
Tom Clegg [Wed, 14 Aug 2024 13:16:06 +0000 (09:16 -0400)]
21910: Merge branch 'main' into 21910-remove-api_client_id

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21910: Trust system root token even if IssueTrustedTokens == false.
Tom Clegg [Wed, 14 Aug 2024 13:15:07 +0000 (09:15 -0400)]
21910: Trust system root token even if IssueTrustedTokens == false.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21898: aligned all info button behavior
Lisa Knox [Tue, 13 Aug 2024 18:18:46 +0000 (14:18 -0400)]
21898: aligned all info button behavior

* set all toggleDetailsPanel calls to use passed in uuid
* removed default '' param in toggleDetailsPanel that allowed the above bug to happen
* removed info button from main app bar

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months agoMerge branch '21811-side-favorites-test'
Lisa Knox [Tue, 13 Aug 2024 15:44:33 +0000 (11:44 -0400)]
Merge branch '21811-side-favorites-test'

closes #21811

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months ago21811: Merge branch 'main' into 21811-side-favorites-test 21811-side-favorites-test
Lisa Knox [Tue, 13 Aug 2024 15:11:04 +0000 (11:11 -0400)]
21811: Merge branch 'main' into 21811-side-favorites-test

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months ago21811: removed .only from favorites spec
Lisa Knox [Tue, 13 Aug 2024 15:04:24 +0000 (11:04 -0400)]
21811: removed .only from favorites spec

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months agoMerge branch '21814-contents-paging' refs #21814
Peter Amstutz [Tue, 13 Aug 2024 14:37:10 +0000 (10:37 -0400)]
Merge branch '21814-contents-paging'  refs #21814

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21814: Add test assertion that there are two different kinds of objects
Peter Amstutz [Tue, 13 Aug 2024 14:36:21 +0000 (10:36 -0400)]
21814: Add test assertion that there are two different kinds of objects

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21944: Move description to "advanced"
Peter Amstutz [Tue, 13 Aug 2024 01:01:13 +0000 (21:01 -0400)]
21944: Move description to "advanced"

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21944: Add title and description to workflow launch panel
Peter Amstutz [Mon, 12 Aug 2024 21:54:36 +0000 (17:54 -0400)]
21944: Add title and description to workflow launch panel

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago20272: Remove "optional" from label to encourage people to add a description. 20272-description-label
Peter Amstutz [Mon, 12 Aug 2024 20:26:04 +0000 (16:26 -0400)]
20272: Remove "optional" from label to encourage people to add a description.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21814: Simplify getting the count and expand comment 21814-contents-paging
Peter Amstutz [Mon, 12 Aug 2024 19:25:54 +0000 (15:25 -0400)]
21814: Simplify getting the count and expand comment

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21941: Remove "only"
Peter Amstutz [Mon, 12 Aug 2024 18:11:16 +0000 (14:11 -0400)]
21941: Remove "only"

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21941: Fix tests
Peter Amstutz [Mon, 12 Aug 2024 16:58:19 +0000 (12:58 -0400)]
21941: Fix tests

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21811:
Lisa Knox [Fri, 9 Aug 2024 14:27:16 +0000 (10:27 -0400)]
21811:

* added assertions suggested by reviewer

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

3 months ago21941: Separate Copy to Clipboard actions for UUID, PDH, and CWL keep: format
Peter Amstutz [Thu, 8 Aug 2024 14:46:06 +0000 (10:46 -0400)]
21941: Separate Copy to Clipboard actions for UUID, PDH, and CWL keep: format

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '22003-keep-web-and-wb2-redirect-parameter' refs #22003
Peter Amstutz [Wed, 7 Aug 2024 20:58:38 +0000 (16:58 -0400)]
Merge branch '22003-keep-web-and-wb2-redirect-parameter' refs #22003

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21814: Remove legacy undocumented 'last_object_class' parameter
Peter Amstutz [Mon, 5 Aug 2024 21:17:52 +0000 (17:17 -0400)]
21814: Remove legacy undocumented 'last_object_class' parameter

This was only ever used by workbench 1, was never documented, and has
no tests.  The option never was included in the Go SDK
'GroupContentsOptions' struct so I believe this means it has already
been the case for years that Controller would just ignore it.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21814: more efficiently handle count=none and offset > 0
Peter Amstutz [Mon, 5 Aug 2024 21:05:36 +0000 (17:05 -0400)]
21814: more efficiently handle count=none and offset > 0

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago19982: Add a table of contents to Arvados CWL extensions
Peter Amstutz [Mon, 5 Aug 2024 16:54:07 +0000 (12:54 -0400)]
19982: Add a table of contents to Arvados CWL extensions

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago19982: Add arv:PreemptionBehavior to docs.
Peter Amstutz [Mon, 5 Aug 2024 16:27:02 +0000 (12:27 -0400)]
19982: Add arv:PreemptionBehavior to docs.

Also add arv:SeparateRunner which was previously overlooked.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago19982: Preemption resubmit tests pass
Peter Amstutz [Mon, 5 Aug 2024 15:04:18 +0000 (11:04 -0400)]
19982: Preemption resubmit tests pass

Also updated some other tests to use "parameterized" testing decorator.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '21927-discovery-doc-test'
Tom Clegg [Wed, 31 Jul 2024 13:59:09 +0000 (09:59 -0400)]
Merge branch '21927-discovery-doc-test'

fixes #21927

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21927: Fix race condition in test. 21927-discovery-doc-test
Tom Clegg [Tue, 30 Jul 2024 16:52:04 +0000 (12:52 -0400)]
21927: Fix race condition in test.

Test was occasionally failing because the "wait for pending reqs, then
count reqs" step ran before the background refresh had progressed far
enough to be counted as a pending req.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21927: Fix test stub not waiting for holdReqs.
Tom Clegg [Tue, 30 Jul 2024 16:43:04 +0000 (12:43 -0400)]
21927: Fix test stub not waiting for holdReqs.

"Ensure requests are handled concurrently" feature was not working for
some of the test stanzas.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months agoMerge branch '21998-zoe-translates-keep-web-directory-listing-encode-url'
Tom Clegg [Tue, 30 Jul 2024 14:30:26 +0000 (10:30 -0400)]
Merge branch '21998-zoe-translates-keep-web-directory-listing-encode-url'

fixes #21998

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months agoMerge branch '21904-no-unqueueable-reqs'
Tom Clegg [Tue, 30 Jul 2024 12:59:57 +0000 (08:59 -0400)]
Merge branch '21904-no-unqueueable-reqs'

fixes #21904

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21998: gofmt. 21998-zoe-translates-keep-web-directory-listing-encode-url
Tom Clegg [Mon, 29 Jul 2024 19:33:45 +0000 (15:33 -0400)]
21998: gofmt.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21998: Fixup comments.
Tom Clegg [Mon, 29 Jul 2024 19:17:04 +0000 (15:17 -0400)]
21998: Fixup comments.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21998: Use http scheme if indicated by load balancer.
Tom Clegg [Mon, 29 Jul 2024 19:16:05 +0000 (15:16 -0400)]
21998: Use http scheme if indicated by load balancer.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21910: Update documentation to new config behavior.
Tom Clegg [Mon, 29 Jul 2024 15:48:56 +0000 (11:48 -0400)]
21910: Update documentation to new config behavior.

Now, the trust/no-trust decision is made when the token is presented,
rather than implicitly via api_client_id when a token is issued.

Also fix docs to use the correct config key: it's IssueTrustedTokens,
not TrustLoginTokens.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21910: Merge branch 'main' into 21910-remove-api_client_id
Tom Clegg [Mon, 29 Jul 2024 15:40:39 +0000 (11:40 -0400)]
21910: Merge branch 'main' into 21910-remove-api_client_id

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago19982: Trying to get testing going
Peter Amstutz [Fri, 26 Jul 2024 21:41:05 +0000 (17:41 -0400)]
19982: Trying to get testing going

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago19982: preemption behavior WIP
Peter Amstutz [Fri, 26 Jul 2024 20:30:26 +0000 (16:30 -0400)]
19982: preemption behavior WIP

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '21943-dir-output' refs #21943
Peter Amstutz [Fri, 26 Jul 2024 13:37:54 +0000 (09:37 -0400)]
Merge branch '21943-dir-output' refs #21943

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago19982: Applied patch of Alex's initial work on this
Peter Amstutz [Fri, 26 Jul 2024 13:34:56 +0000 (09:34 -0400)]
19982: Applied patch of Alex's initial work on this

There's another branch but it is out of date, so starting a new branch
here.

Original work on this feature was alex.coleman@curii.com, I'm picking
up where she left off.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months agoMerge branch '21993-wf-step-cancel' refs #21993
Peter Amstutz [Thu, 25 Jul 2024 21:47:55 +0000 (17:47 -0400)]
Merge branch '21993-wf-step-cancel' refs #21993

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21943: Fix bug and add integration test 21943-dir-output
Peter Amstutz [Thu, 25 Jul 2024 21:25:49 +0000 (17:25 -0400)]
21943: Fix bug and add integration test

The bug was caused by the fact that the path mapper de-duplicates file
references before doing the mapping, but also did not traverse
directory listings.  If the list of files was de-duplicated by
selecting the entries from the directory listing (given a choice of 2+
places a given file reference appears in output), but then the
directory listings were skipped later on, those files wouldn't be
included in the path map at all.

Now trims the directory listings while constructing the list of files
to path map, so if the file is referenced in directory listings in the
output, it isn't lost to the dedup behavior.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21943: Add test for files appearing multiple times in output
Peter Amstutz [Thu, 25 Jul 2024 18:23:14 +0000 (14:23 -0400)]
21943: Add test for files appearing multiple times in output

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago21993: Committed request with priority == 0 is treated as cancel 21993-wf-step-cancel
Peter Amstutz [Thu, 25 Jul 2024 14:44:13 +0000 (10:44 -0400)]
21993: Committed request with priority == 0 is treated as cancel

Now handles the case where a user cancels a container request before
it has a chance to run, which currently remains in the "Committed"
state rather than "Final".  This fixes the bug where the workflow
runner would be stuck forever.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 months ago22003: prevent redirect loop in Wb2 client-side redirect handler 22003-keep-web-and-wb2-redirect-parameter
Zoë Ma [Mon, 22 Jul 2024 13:10:43 +0000 (21:10 +0800)]
22003: prevent redirect loop in Wb2 client-side redirect handler

Check that the target URL is not empty before setting
window.location.href (browsing to new URL), because setting it to empty
effectively reloads the page and triggers the redirect handler again,
causing an endless loop.

Arvados-DCO-1.1-Signed-off-by: Zoë Ma <zoe.ma@curii.com>

3 months ago22003: Workbench2 and keep-web: better interoperability with redirect
Zoë Ma [Fri, 12 Jul 2024 13:27:09 +0000 (21:27 +0800)]
22003: Workbench2 and keep-web: better interoperability with redirect

keep-web: When sending an unauthenticated browser client to a redirect
to Wb2, encode the target URL path in the query part of the redirection
URL in the `Location` header. This avoids possible corrupted header and
confused client.

Workbench2:

- In redirection handler, more robust handling of the input target-path
  passed by the URL query part.
- In the "copy link to clipboard" action in the files panel of a
  collection view, when creating the URL for clipboard, better emulate
  the server-generated redirect URL (see above).

Overall, when working with redirects (either generating redirect URLs or
handling them on the client side), we're better prepared for paths that
may contain special characters.

Arvados-DCO-1.1-Signed-off-by: Zoë Ma <zoe.ma@curii.com>

3 months ago21998: Try to find original request's scheme in URL generated for wget.
Zoë Ma [Tue, 23 Jul 2024 10:34:04 +0000 (18:34 +0800)]
21998: Try to find original request's scheme in URL generated for wget.

In the "wget" example generated on the directory listing page, try to
make the scheme part in the URL argument closer to the original
request's, by using the value of "X-Forwarded-Proto" header if it's
valid.

Arvados-DCO-1.1-Signed-off-by: Zoë Ma <zoe.ma@curii.com>

3 months ago21998: Simplify percent-encoding of relative URLs in directory listing
Zoë Ma [Wed, 17 Jul 2024 16:45:07 +0000 (00:45 +0800)]
21998: Simplify percent-encoding of relative URLs in directory listing

In keep-web, generate less-verbose URLs in the href values on the
directory listing page by using the percent-encoding function
appropriate for paths.

Arvados-DCO-1.1-Signed-off-by: Zoë Ma <zoe.ma@curii.com>

3 months ago21998: properly percent-encode paths in keep-web directory listing page
Zoë Ma [Thu, 11 Jul 2024 17:05:06 +0000 (01:05 +0800)]
21998: properly percent-encode paths in keep-web directory listing page

Use percent-encoded form of the relative URLs as the value of "href"
attribute in directory listing page generated by keep-web

The "wget" command example shown on the page now has single-quotes
around the URL argument.

For testing involving complex URL or path patterns, use the HTML parser
provided by golang.org/x/net/html to scrape the directory listing page,
instead of using regular expressions that may get unwieldy.

Minor edits to the HTML template for compliance and ease of testing.

Arvados-DCO-1.1-Signed-off-by: Zoë Ma <zoe.ma@curii.com>

3 months agoMerge branch '21935-clean-pysdk-api'
Brett Smith [Wed, 24 Jul 2024 21:18:35 +0000 (17:18 -0400)]
Merge branch '21935-clean-pysdk-api'

Refs #21935.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21935: Mark internal arvados.keep classes as such 21935-clean-pysdk-api
Brett Smith [Wed, 24 Jul 2024 18:42:40 +0000 (14:42 -0400)]
21935: Mark internal arvados.keep classes as such

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21935: Rename SafeHTTPCache to ThreadSafeHTTPCache
Brett Smith [Wed, 24 Jul 2024 18:49:41 +0000 (14:49 -0400)]
21935: Rename SafeHTTPCache to ThreadSafeHTTPCache

This mirrors the name of ThreadSafeAPIClient and clarifies what it is
"safe" for.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21935/15397: Remove StreamFileReader
Brett Smith [Wed, 24 Jul 2024 18:12:36 +0000 (14:12 -0400)]
21935/15397: Remove StreamFileReader

Unused after earlier changes.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21935: Add upgrade note about PySDK reorganization
Brett Smith [Wed, 24 Jul 2024 18:04:06 +0000 (14:04 -0400)]
21935: Add upgrade note about PySDK reorganization

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

3 months ago21910: Fix markup.
Tom Clegg [Wed, 24 Jul 2024 13:22:34 +0000 (09:22 -0400)]
21910: Fix markup.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21910: Fix typo.
Tom Clegg [Wed, 24 Jul 2024 13:20:54 +0000 (09:20 -0400)]
21910: Fix typo.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months ago21910: Rescue displaced sentence.
Tom Clegg [Wed, 24 Jul 2024 13:19:00 +0000 (09:19 -0400)]
21910: Rescue displaced sentence.

Looks like the TrustLoginTokens section was accidentally inserted in
the middle of a section instead of between sections.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 months agoMerge branch '22005-s3-etag'
Tom Clegg [Tue, 23 Jul 2024 15:14:25 +0000 (11:14 -0400)]
Merge branch '22005-s3-etag'

fixes #22005

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

4 months ago22005: Add Etag to s3 response header. 22005-s3-etag
Tom Clegg [Tue, 23 Jul 2024 12:06:43 +0000 (08:06 -0400)]
22005: Add Etag to s3 response header.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

4 months agoMerge branch '21978-replace-files-docs'
Tom Clegg [Mon, 22 Jul 2024 18:51:44 +0000 (14:51 -0400)]
Merge branch '21978-replace-files-docs'

closes #21978

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

4 months agoProvide more guidance for using arvbox the first time.
Peter Amstutz [Fri, 12 Jul 2024 15:41:57 +0000 (11:41 -0400)]
Provide more guidance for using arvbox the first time.

When arvbox is ready, now provides more information about things that
need to be done before you log in to arvbox workbench.

Also add a workbench banner with text and links to the Arvados docs,
based on the playground banner.

no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 months ago21904: Remove LogCreateRequestFraction config. 21904-no-unqueueable-reqs
Tom Clegg [Mon, 22 Jul 2024 15:35:34 +0000 (11:35 -0400)]
21904: Remove LogCreateRequestFraction config.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

4 months ago21978: Streamline replace_files cross-reference markup 21978-replace-files-docs
Brett Smith [Mon, 22 Jul 2024 15:29:03 +0000 (11:29 -0400)]
21978: Streamline replace_files cross-reference markup

If we're linking to the section anyway, we can use less words and not
worry about whether it's "above" or "below."

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

4 months ago21904: Allow queueing "create log" requests.
Tom Clegg [Mon, 22 Jul 2024 15:08:42 +0000 (11:08 -0400)]
21904: Allow queueing "create log" requests.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

4 months ago21904: Remove obsolete test stub functionality (POST .../logs).
Tom Clegg [Mon, 22 Jul 2024 15:05:51 +0000 (11:05 -0400)]
21904: Remove obsolete test stub functionality (POST .../logs).

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

4 months ago21978: Broaden replace_files argument summary to match new features.
Tom Clegg [Mon, 22 Jul 2024 14:03:41 +0000 (10:03 -0400)]
21978: Broaden replace_files argument summary to match new features.

Also update "below" to "above" in text, to match the current location
of the replace_files section on the page.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

4 months ago21978: Note replace_files usage restrictions re federated clusters.
Tom Clegg [Mon, 22 Jul 2024 14:00:19 +0000 (10:00 -0400)]
21978: Note replace_files usage restrictions re federated clusters.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

4 months agoMerge branch '21907-cache-s3-token'
Brett Smith [Fri, 19 Jul 2024 19:39:31 +0000 (15:39 -0400)]
Merge branch '21907-cache-s3-token'

Closes #21907.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

4 months ago21907: Rename s3SecretCacheTidyInterval 21907-cache-s3-token
Brett Smith [Fri, 19 Jul 2024 17:23:41 +0000 (13:23 -0400)]
21907: Rename s3SecretCacheTidyInterval

For improved clarity.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

4 months ago21907: Make new functions and methods private
Brett Smith [Fri, 19 Jul 2024 17:23:22 +0000 (13:23 -0400)]
21907: Make new functions and methods private

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

4 months ago21907: Use an APIClientAuthorization pointer directly
Brett Smith [Fri, 19 Jul 2024 17:18:59 +0000 (13:18 -0400)]
21907: Use an APIClientAuthorization pointer directly

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

4 months ago21907: Lock mutex when looking up cached S3 secrets
Brett Smith [Fri, 19 Jul 2024 17:17:35 +0000 (13:17 -0400)]
21907: Lock mutex when looking up cached S3 secrets

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

4 months ago21907: Cache valid S3 secrets in keep-web
Brett Smith [Thu, 18 Jul 2024 20:32:47 +0000 (16:32 -0400)]
21907: Cache valid S3 secrets in keep-web

This improves performance by avoiding a call to
/arvados/v1/api_client_authorizations on each request.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

4 months agoMerge branch '22001-run-tests-py3'
Brett Smith [Wed, 17 Jul 2024 14:05:49 +0000 (10:05 -0400)]
Merge branch '22001-run-tests-py3'

Closes #22001.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

4 months ago22001: Install PySDK earlier in run-tests.sh 22001-run-tests-py3
Brett Smith [Wed, 17 Jul 2024 13:00:50 +0000 (09:00 -0400)]
22001: Install PySDK earlier in run-tests.sh

See comments for rationale.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>