14287: Omit false boolean params from API requests.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

diff --git a/sdk/go/arvados/client.go b/sdk/go/arvados/client.go
index e55cb82f2a353f95c1f57bfe168de48a852f619f..102018bb1280289efe923643c3db521dc509756d 100644 (file)
--- a/sdk/go/arvados/client.go
+++ b/sdk/go/arvados/client.go
@@ -203,6 +203,17 @@ func anythingToValues(params interface{}) (url.Values, error) {
                        urlValues.Set(k, v.String())
                        continue
                }
+               if v, ok := v.(bool); ok {
+                       if v {
+                               urlValues.Set(k, "true")
+                       } else {
+                               // "foo=false", "foo=0", and "foo="
+                               // are all taken as true strings, so
+                               // don't send false values at all --
+                               // rely on the default being false.
+                       }
+                       continue
+               }
                j, err := json.Marshal(v)
                if err != nil {
                        return nil, err