15306: Adds warning log message when parameter isn't boolean.
authorLucas Di Pentima <ldipentima@veritasgenetics.com>
Thu, 6 Jun 2019 16:55:19 +0000 (13:55 -0300)
committerLucas Di Pentima <ldipentima@veritasgenetics.com>
Thu, 6 Jun 2019 16:55:19 +0000 (13:55 -0300)
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

services/api/app/controllers/application_controller.rb

index 234e8018c0dc698a56e11303c81980a38cc7d5d7..30ee0787d060689ee91cb2ce136a116e02dbe18c 100644 (file)
@@ -166,8 +166,12 @@ class ApplicationController < ActionController::Base
   protected
 
   def bool_param(pname)
-    if params.include?(pname) && params[pname].is_a?(Boolean)
-      return params[pname]
+    if params.include?(pname)
+      if params[pname].is_a?(Boolean)
+        return params[pname]
+      else
+        logger.warn "Warning: received non-boolean parameter '#{pname}' on #{self.class.inspect}."
+      end
     end
     false
   end