3775: Add TODO comments in suspicious-looking collate_output corners.
authorTom Clegg <tom@curoverse.com>
Fri, 3 Oct 2014 14:17:07 +0000 (10:17 -0400)
committerTom Clegg <tom@curoverse.com>
Fri, 3 Oct 2014 14:17:07 +0000 (10:17 -0400)
sdk/cli/bin/crunch-job

index 24aca3314d24b31fed7b45d03e8c939120f1217d..04ff82f2a7866f89d0f1f5f5e32b0d9d6399cd35 100755 (executable)
@@ -1298,10 +1298,13 @@ sub collate_output
     if ($s->can_read(120)) {
       sysread($child_out, $joboutput, 64 * 1024 * 1024);
       chomp($joboutput);
+      # TODO: Ensure exit status == 0.
     } else {
       Log (undef, "timed out reading from 'arv-put'");
     }
   }
+  # TODO: kill $pid instead of waiting, now that we've decided to
+  # ignore further output.
   waitpid($pid, 0);
 
   return $joboutput;