8784: Fix test for latest firefox.

Given "http://host:99999/path", Firefox 54 returns an error
"SyntaxError: The URI is malformed" instead of trying to connect to
port 99999 and returning a network error. Changing 99999 to 0 produces
the try-and-fail behavior we want to test.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>

diff --git a/apps/workbench/test/integration/collection_upload_test.rb b/apps/workbench/test/integration/collection_upload_test.rb
index 552a9cd5e8fc53af4a484fbbd9b84798fc86f59a..f2a638f3164bb4fc2b5b47b39df5ea307a065e8a 100644 (file)
--- a/apps/workbench/test/integration/collection_upload_test.rb
+++ b/apps/workbench/test/integration/collection_upload_test.rb
@@ -92,11 +92,11 @@ class CollectionUploadTest < ActionDispatch::IntegrationTest
   test "Report network error" do
     need_selenium "to make file uploads work"
     use_token :admin do
   test "Report network error" do
     need_selenium "to make file uploads work"
     use_token :admin do

-      # Even if you somehow do port>2^16, surely nx.example.net won't
+      # Even if port 0 is a thing, surely nx.example.net won't

       # respond
       KeepService.where(service_type: 'proxy').first.
         update_attributes(service_host: 'nx.example.net',
       # respond
       KeepService.where(service_type: 'proxy').first.
         update_attributes(service_host: 'nx.example.net',

-                          service_port: 99999)
+                          service_port: 0)

     end
     visit page_with_token 'active', sandbox_path
 
     end
     visit page_with_token 'active', sandbox_path