13306: Additional dict item iteration improvements
authorEric Biagiotti <ebiagiotti@veritasgenetcs.com>
Fri, 1 Feb 2019 18:33:14 +0000 (13:33 -0500)
committerEric Biagiotti <ebiagiotti@veritasgenetcs.com>
Fri, 1 Feb 2019 18:33:14 +0000 (13:33 -0500)
Arvados-DCO-1.1-Signed-off-by: Eric Biagiotti <eric.biagiotti@gmail.com>

sdk/cwl/arvados_cwl/arvworkflow.py
sdk/cwl/arvados_cwl/crunch_script.py

index ff95041779f0e37d2a10113b7cf7d9146f9076f6..8e6bff4f04cb525106ee18a62cfb6146542f3c18 100644 (file)
@@ -3,6 +3,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 from past.builtins import basestring
+from future.utils import viewitems
 
 import os
 import json
@@ -137,7 +138,7 @@ class ArvadosWorkflowStep(WorkflowStep):
         runtimeContext = runtimeContext.copy()
         runtimeContext.toplevel = True  # Preserve behavior for #13365
 
-        builder = make_builder({shortname(k): v for k,v in list(joborder.items())}, self.hints, self.requirements, runtimeContext)
+        builder = make_builder({shortname(k): v for k,v in viewitems(joborder)}, self.hints, self.requirements, runtimeContext)
         runtimeContext = set_cluster_target(self.tool, self.arvrunner, builder, runtimeContext)
         return super(ArvadosWorkflowStep, self).job(joborder, output_callback, runtimeContext)
 
index d9a986663b83ec1eb79024181e89cbb87cd570ee..c886550d41606e60e04f0142e55519e5ea33c89a 100644 (file)
@@ -11,6 +11,7 @@
 # collection for this runner job.
 
 from past.builtins import basestring
+from future.utils import viewitems
 
 import arvados
 import arvados_cwl
@@ -63,7 +64,7 @@ def run():
             if "location" in v:
                 v["location"] = keeppath(v["location"])
 
-        for k,v in list(job_order_object.items()):
+        for k,v in viewitems(job_order_object):
             if isinstance(v, basestring) and arvados.util.keep_locator_pattern.match(v):
                 job_order_object[k] = {
                     "class": "File",