Add arv-put, a whput replacement built on the Python SDK.
authorTom Clegg <tom@clinicalfuture.com>
Thu, 28 Nov 2013 19:09:49 +0000 (11:09 -0800)
committerTom Clegg <tom@clinicalfuture.com>
Thu, 28 Nov 2013 21:51:51 +0000 (13:51 -0800)
refs #1646

sdk/cli/.gitignore
sdk/cli/Gemfile [new file with mode: 0644]
sdk/cli/Gemfile.lock [new file with mode: 0644]
sdk/cli/README.textile [new file with mode: 0644]
sdk/cli/Rakefile [new file with mode: 0644]
sdk/cli/bin/arv-put [new file with mode: 0755]
sdk/cli/test/test_arv-put.rb [new file with mode: 0644]

index 12cc8f3bd46587401fa91deec20867174a3b3b29..beb0627be7380d123214ad82578b61d3de9b0f74 100644 (file)
@@ -1 +1,2 @@
 arvados-cli*gem
+tmp
diff --git a/sdk/cli/Gemfile b/sdk/cli/Gemfile
new file mode 100644 (file)
index 0000000..c944bdb
--- /dev/null
@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+gem 'minitest'
+gem 'rake'
diff --git a/sdk/cli/Gemfile.lock b/sdk/cli/Gemfile.lock
new file mode 100644 (file)
index 0000000..afbc573
--- /dev/null
@@ -0,0 +1,12 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    minitest (5.0.8)
+    rake (10.1.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  minitest
+  rake
diff --git a/sdk/cli/README.textile b/sdk/cli/README.textile
new file mode 100644 (file)
index 0000000..f15980d
--- /dev/null
@@ -0,0 +1,11 @@
+Before running tests:
+
+* Set up environment variables: @ARVADOS_API_HOST@,
+  @ARVADOS_API_TOKEN@, @ARVADOS_API_HOST_INSECURE@
+* Run @bundle install@
+
+Running tests:
+
+<pre><code>
+  PYTHONPATH=../python bundle exec rake test
+</code></pre>
diff --git a/sdk/cli/Rakefile b/sdk/cli/Rakefile
new file mode 100644 (file)
index 0000000..cf4652f
--- /dev/null
@@ -0,0 +1,8 @@
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.libs << 'test'
+end
+
+desc 'Run tests'
+task default: :test
diff --git a/sdk/cli/bin/arv-put b/sdk/cli/bin/arv-put
new file mode 100755 (executable)
index 0000000..ebfc5cc
--- /dev/null
@@ -0,0 +1,160 @@
+#!/usr/bin/env python
+
+# TODO:
+# --md5sum - display md5 of each file as read from disk
+
+import argparse
+import os
+import sys
+
+parser = argparse.ArgumentParser(
+    description='Copy data from the local filesystem to Keep.')
+parser.add_argument('paths', metavar='path', type=str, nargs='+',
+                    help='Local file or directory.')
+parser.add_argument('--max-manifest-depth', type=int, metavar='N', default=-1,
+                    help="""
+Maximum depth of directory tree to represent in the manifest
+structure. A directory structure deeper than this will be represented
+as a single stream in the manifest. If N=0, the manifest will contain
+a single stream. Default: -1 (unlimited), i.e., exactly one manifest
+stream per filesystem directory that contains files.
+""")
+parser.add_argument('--as-stream', action='store_true',
+                    help="""
+Store the file content and display the resulting manifest on
+stdout. Do not write the manifest to Keep or save a Collection object
+in Arvados.
+""")
+parser.add_argument('--as-manifest', action='store_const',
+                    dest='as_stream', const=False, default=False,
+                    help="""
+Store the file data and resulting manifest in Keep, save a Collection
+object in Arvados, and display the manifest locator (Collection uuid)
+on stdout. This is the default behavior.
+""")
+parser.add_argument('--filename', type=str, default=None,
+                    help="""
+Use the given filename in the manifest, instead of the name of the
+local file. This is useful when "-" or "/dev/stdin" is given as an
+input file. It can be used only if there is exactly one path given and
+it is not a directory.
+""")
+group = parser.add_mutually_exclusive_group()
+group.add_argument('--progress', action='store_true',
+                   help="""
+Display human-readable progress on stderr (bytes and, if possible,
+percentage of total data size). This is the default behavior when
+stderr is a tty.
+""")
+group.add_argument('--no-progress', action='store_true',
+                   help="""
+Do not display human-readable progress on stderr, even if stderr is a
+tty.
+""")
+group.add_argument('--batch-progress', action='store_true',
+                   help="""
+Display machine-readable progress on stderr (bytes and, if known,
+total data size).
+""")
+
+args = parser.parse_args()
+
+if args.filename and (len(args.paths) != 1 or os.path.isdir(args.paths[0])):
+    parser.error("""
+--filename argument cannot be used when storing a directory or
+multiple files.
+""")
+
+# Turn on --progress by default if stderr is a tty.
+if (not (args.batch_progress or args.no_progress)
+    and os.isatty(sys.stderr.fileno())):
+    args.progress = True
+
+
+import re
+import arvados
+
+class CollectionWriterWithProgress(arvados.CollectionWriter):
+    def flush_data(self, *args, **kwargs):
+        if not getattr(self, 'display_type', None):
+            return
+        if not hasattr(self, 'bytes_flushed'):
+            self.bytes_flushed = 0
+        self.bytes_flushed += self._data_buffer_len
+        super(CollectionWriterWithProgress, self).flush_data(*args, **kwargs)
+        self.bytes_flushed -= self._data_buffer_len
+        if self.display_type == 'machine':
+            sys.stderr.write('%s %d: %d written %d total\n' %
+                             (sys.argv[0],
+                              os.getpid(),
+                              self.bytes_flushed,
+                              getattr(self, 'bytes_expected', -1)))
+        elif getattr(self, 'bytes_expected', 0) > 0:
+            pct = 100.0 * self.bytes_flushed / self.bytes_expected
+            sys.stderr.write('\r%dM / %dM %.1f%% ' %
+                             (self.bytes_flushed >> 20,
+                              self.bytes_expected >> 20, pct))
+        else:
+            sys.stderr.write('\r%d ' % self.bytes_flushed)
+    def manifest_text(self, *args, **kwargs):
+        manifest_text = (super(CollectionWriterWithProgress, self)
+                         .manifest_text(*args, **kwargs))
+        if getattr(self, 'display_type', None):
+            if self.display_type == 'human':
+                sys.stderr.write('\n')
+            self.display_type = None
+        return manifest_text
+
+if args.progress:
+    writer = CollectionWriterWithProgress()
+    writer.display_type = 'human'
+elif args.batch_progress:
+    writer = CollectionWriterWithProgress()
+    writer.display_type = 'machine'
+else:
+    writer = arvados.CollectionWriter()
+
+args.paths = [('/dev/stdin' if p=='-' else p) for p in args.paths]
+
+# Walk the given directory trees and stat files, adding up file sizes,
+# so we can display progress as percent
+writer.bytes_expected = 0
+for path in args.paths:
+    if os.path.isdir(path):
+        for filename in arvados.util.listdir_recursive(path):
+            writer.bytes_expected += os.path.getsize(
+                os.path.join(path, filename))
+    elif not os.path.isfile(path):
+        del writer.bytes_expected
+        break
+    else:
+        writer.bytes_expected += os.path.getsize(path)
+
+# Copy file data to Keep.
+for path in args.paths:
+    if os.path.isdir(path):
+        writer.write_directory_tree(path,
+                                    max_manifest_depth=args.max_manifest_depth)
+    else:
+        writer.start_new_stream()
+        writer.start_new_file(args.filename or os.path.split(path)[1])
+        with open(path, 'rb') as f:
+            while True:
+                buf = f.read(2**26)
+                if len(buf) == 0:
+                    break
+                writer.write(buf)
+
+if args.as_stream:
+    print writer.manifest_text(),
+else:
+    # Register the resulting collection in Arvados.
+    arvados.api().collections().create(
+        body={
+            'uuid': writer.finish(),
+            'manifest_text': writer.manifest_text(),
+            },
+        ).execute()
+
+    # Print the locator (uuid) of the new collection.
+    print writer.finish()
diff --git a/sdk/cli/test/test_arv-put.rb b/sdk/cli/test/test_arv-put.rb
new file mode 100644 (file)
index 0000000..7c8fc17
--- /dev/null
@@ -0,0 +1,125 @@
+require 'minitest/autorun'
+require 'digest/md5'
+
+class TestArvPut < Minitest::Test
+  def setup
+    begin
+      Dir.mkdir './tmp'
+      Dir.mkdir './tmp/empty_dir'
+    rescue Errno::EEXIST
+    end
+    File.open './tmp/empty_file', 'wb' do
+    end
+    File.open './tmp/foo', 'wb' do |f|
+      f.write 'foo'
+    end
+  end
+
+  def test_no_args
+    out, err = capture_subprocess_io do
+      assert_equal(false, arv_put,
+                   'arv-put without args exits non-zero')
+    end
+    assert_equal '', out
+    assert_match /^usage:/, err
+  end
+
+  def test_help
+    out, err = capture_subprocess_io do
+      assert_equal(true, arv_put('-h'),
+                   'arv-put -h exits zero')
+    end
+    assert_equal '', err
+    assert_match /^usage:/, out
+  end
+
+  def test_filename_arg_with_directory
+    out, err = capture_subprocess_io do
+      assert_equal(false, arv_put('--filename', 'foo', './tmp/empty_dir/.'),
+                   'arv-put --filename refuses directory')
+    end
+    assert_match /^usage:.*error:/m, err
+    assert_equal '', out
+  end
+
+  def test_filename_arg_with_multiple_files
+    out, err = capture_subprocess_io do
+      assert_equal(false, arv_put('--filename', 'foo',
+                                  './tmp/empty_file',
+                                  './tmp/empty_file'),
+                   'arv-put --filename refuses directory')
+    end
+    assert_match /^usage:.*error:/m, err
+    assert_equal '', out
+  end
+
+  def test_filename_arg_with_empty_file
+    out, err = capture_subprocess_io do
+      assert_equal true, arv_put('--filename', 'foo', './tmp/empty_file')
+    end
+    $stderr.write err
+    assert_match '', err
+    assert_equal "aa4f15cbf013142a7d98b1e273f9c661+45\n", out
+  end
+
+  def test_progress
+    out, err = capture_subprocess_io do
+      assert_equal true, arv_put('--progress', './tmp/foo')
+    end
+    assert_match /%/, err
+    expect_foo_manifest(out)
+  end
+
+  def test_batch_progress
+    out, err = capture_subprocess_io do
+      assert_equal true, arv_put('--batch-progress', './tmp/foo')
+    end
+    assert_match /: 0 written 3 total/, err
+    assert_match /: 3 written 3 total/, err
+    expect_foo_manifest(out)
+  end
+
+  def test_progress_and_batch_progress
+    out, err = capture_subprocess_io do
+      assert_equal(false,
+                   arv_put('--progress', '--batch-progress', './tmp/foo'),
+                   'arv-put --progress --batch-progress is contradictory')
+    end
+    assert_match /^usage:.*error:/m, err
+    assert_equal '', out
+  end
+
+  def test_read_from_dev_stdin
+    test_read_from_stdin(specify_stdin_as='/dev/stdin')
+  end
+
+  def test_read_from_stdin(specify_stdin_as='-')
+    out, err = capture_subprocess_io do
+      r,w = IO.pipe
+      wpid = fork do
+        r.close
+        w << 'foo'
+      end
+      w.close
+      assert_equal true, arv_put('--filename', 'foo', specify_stdin_as,
+                                 { in: r })
+      r.close
+      Process.waitpid wpid
+    end
+    $stderr.write err
+    assert_match '', err
+    expect_foo_manifest(out)
+  end
+
+  protected
+  def arv_put(*args)
+    system ['./bin/arv-put', 'arv-put'], *args
+  end
+
+  def expect_foo_manifest(out)
+    expect_manifest = ". #{Digest::MD5.hexdigest('foo')}+3 0:3:foo\n"
+    assert_equal(Digest::MD5.hexdigest(expect_manifest) +
+                 "+#{expect_manifest.length}\n",
+                 out)
+  end
+end