13934: Add comment to guard dispatch bugfix.
authorTom Clegg <tclegg@veritasgenetics.com>
Wed, 1 Aug 2018 16:56:31 +0000 (12:56 -0400)
committerTom Clegg <tclegg@veritasgenetics.com>
Wed, 1 Aug 2018 16:56:31 +0000 (12:56 -0400)
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

sdk/go/dispatch/dispatch.go

index c3d60309992c9368ba7a2d75586db58829c8f2c0..e0dc2eefda5e52e014ab8e57d5839bdf176ea362 100644 (file)
@@ -165,7 +165,13 @@ func (d *Dispatcher) checkForUpdates(filters [][]interface{}, todo map[string]*r
        offset := 0
        for {
                params["offset"] = offset
+
+               // This list variable must be a new one declared
+               // inside the loop: otherwise, items in the API
+               // response would get deep-merged into the items
+               // loaded in previous iterations.
                var list arvados.ContainerList
+
                err := d.Arv.List("containers", params, &list)
                if err != nil {
                        log.Printf("Error getting list of containers: %q", err)