18005: Fixes the bug.
authorLucas Di Pentima <lucas.dipentima@curii.com>
Wed, 11 Aug 2021 18:37:46 +0000 (15:37 -0300)
committerLucas Di Pentima <lucas.dipentima@curii.com>
Wed, 11 Aug 2021 19:11:37 +0000 (16:11 -0300)
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

services/api/app/models/collection.rb

index d1d5ace0c3bbf78e413e30c96828ff4a914504bc..1bbe8cc6614b2becdfeac1afef32cd8fcfb4beea 100644 (file)
@@ -150,7 +150,9 @@ class Collection < ArvadosModel
   def strip_signatures_and_update_replication_confirmed
     if self.manifest_text_changed?
       in_old_manifest = {}
-      if not self.replication_confirmed.nil?
+      # manifest_text_was could be nil when dealing with a freshly created snapshot,
+      # so we skip this case because there was no real manifest change. (Bug #18005)
+      if (not self.replication_confirmed.nil?) and (not self.manifest_text_was.nil?)
         self.class.each_manifest_locator(manifest_text_was) do |match|
           in_old_manifest[match[1]] = true
         end