9898: Change state transition error responses from 403 to 422.

diff --git a/services/api/app/models/arvados_model.rb b/services/api/app/models/arvados_model.rb
index f89e9f405946ddcb34d814c3fb953a34fb51497f..51673f7acb5764e87147745a8dcf7b63076b0b73 100644 (file)
--- a/services/api/app/models/arvados_model.rb
+++ b/services/api/app/models/arvados_model.rb
@@ -42,13 +42,13 @@ class ArvadosModel < ActiveRecord::Base
 
   class AlreadyLockedError < StandardError
     def http_status
-      403
+      422
     end
   end
 
   class InvalidStateTransitionError < StandardError
     def http_status
-      403
+      422
     end
   end
 

diff --git a/services/api/test/functional/arvados/v1/containers_controller_test.rb b/services/api/test/functional/arvados/v1/containers_controller_test.rb
index 04c66a71b2e68c6d6f956c585b391eac9d4056c1..45149b21d9fab05c927e2f72759edce2edebbaf5 100644 (file)
--- a/services/api/test/functional/arvados/v1/containers_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/containers_controller_test.rb
@@ -74,8 +74,8 @@ class Arvados::V1::ContainersControllerTest < ActionController::TestCase
 
   [
     [:queued, :lock, :success, 'Locked'],
-    [:queued, :unlock, 403, 'Queued'],
-    [:locked, :lock, 403, 'Locked'],
+    [:queued, :unlock, 422, 'Queued'],
+    [:locked, :lock, 422, 'Locked'],
     [:running, :lock, 422, 'Running'],
     [:running, :unlock, 422, 'Running'],
   ].each do |fixture, action, response, state|