15954: Fix style, handle errors first.
authorTom Clegg <tom@tomclegg.ca>
Tue, 10 Mar 2020 14:40:45 +0000 (10:40 -0400)
committerTom Clegg <tom@tomclegg.ca>
Tue, 10 Mar 2020 14:54:08 +0000 (10:54 -0400)
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

lib/boot/cmd.go

index 60955dfa0faccad76b47b513678ff171cde6050b..43b3ab6731462288fd6633b4dedc06b8c68363de 100644 (file)
@@ -77,12 +77,12 @@ func (bootCommand) RunCommand(prog string, args []string, stdin io.Reader, stdou
 
        super.Start(ctx, cfg)
        defer super.Stop()
-       if url, ok := super.WaitReady(); ok {
-               fmt.Fprintln(stdout, url)
-               // Wait for signal/crash + orderly shutdown
-               <-super.done
-               return 0
-       } else {
+       url, ok := super.WaitReady()
+       if !ok {
                return 1
        }
+       fmt.Fprintln(stdout, url)
+       // Wait for signal/crash + orderly shutdown
+       <-super.done
+       return 0
 }