21386: feedback cleanup Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii... 21386-project-loading-view
authorLisa Knox <lisaknox83@gmail.com>
Tue, 27 Feb 2024 18:53:07 +0000 (13:53 -0500)
committerLisa Knox <lisaknox83@gmail.com>
Tue, 27 Feb 2024 18:53:07 +0000 (13:53 -0500)
services/workbench2/src/components/data-explorer/data-explorer.tsx
services/workbench2/src/views-components/data-explorer/data-explorer.tsx
services/workbench2/src/views/search-results-panel/search-results-panel.tsx

index 36ae5fd6ed61eec249863c0186b612a9721ea914..ba710bc783e9ca6368c5355d042a3930e677af8b 100644 (file)
@@ -96,7 +96,7 @@ interface DataExplorerDataProps<T> {
     elementPath?: string;
     isMSToolbarVisible: boolean;
     checkedList: TCheckedList;
-    isNotFound?: boolean;
+    isNotFound: boolean;
 }
 
 interface DataExplorerActionProps<T> {
@@ -284,7 +284,7 @@ export const DataExplorer = withStyles(styles)(
                                 setCheckedListOnStore={setCheckedListOnStore}
                                 checkedList={checkedList}
                                 working={working}
-                                isNotFound={this.props.isNotFound || false}
+                                isNotFound={this.props.isNotFound}
                             />
                         </Grid>
                         <Grid
index 1a588b78e9ec177a7f144bdd178b83afa7cb1162..643949a20e0545169dac1aa6359705ccc6b86919 100644 (file)
@@ -39,7 +39,6 @@ const mapStateToProps = ({ progressIndicator, dataExplorer, router, multiselect,
         isMSToolbarVisible,
         checkedList: multiselect.checkedList,
         working,
-        isNotFound: dataExplorerState.isNotFound,
     };
 };
 
index 87e26d50a2a7f7bed08f16d5a8400722723438e2..0b69ff246add938a4be74251c7893fd2441701cf 100644 (file)
@@ -14,7 +14,6 @@ import { User } from "models/user";
 import { Config } from 'common/config';
 import { Session } from "models/session";
 import { toggleOne, deselectAllOthers } from "store/multiselect/multiselect-actions";
-import { SEARCH_RESULTS_PANEL_ID } from 'store/search-results-panel/search-results-panel-actions';
 
 export interface SearchResultsPanelDataProps {
     data: SearchBarAdvancedFormData;
@@ -22,7 +21,6 @@ export interface SearchResultsPanelDataProps {
     sessions: Session[];
     remoteHostsConfig: { [key: string]: Config };
     localCluster: string;
-    numberOfItems: number;
 }
 
 export interface SearchResultsPanelActionProps {
@@ -35,14 +33,11 @@ export interface SearchResultsPanelActionProps {
 export type SearchResultsPanelProps = SearchResultsPanelDataProps & SearchResultsPanelActionProps;
 
 const mapStateToProps = (rootState: RootState) => {
-    const { dataExplorer } = rootState;
-    const numberOfItems = dataExplorer[SEARCH_RESULTS_PANEL_ID].items.length;
     return {
         user: rootState.auth.user,
         sessions: rootState.auth.sessions,
         remoteHostsConfig: rootState.auth.remoteHostsConfig,
         localCluster: rootState.auth.localCluster,
-        numberOfItems,
     };
 };