7167: rename MakeArvadosClientWithConfig as New

diff --git a/sdk/go/arvadosclient/arvadosclient.go b/sdk/go/arvadosclient/arvadosclient.go
index cc99efdcf4b5deb327113780fdb8bf355163becf..af8bce4d4a7336cac0c66fb07292aaa203b4b0e6 100644 (file)
--- a/sdk/go/arvadosclient/arvadosclient.go
+++ b/sdk/go/arvadosclient/arvadosclient.go
@@ -102,11 +102,11 @@ func MakeArvadosClient() (ac ArvadosClient, err error) {
        config.APIHostInsecure = matchTrue.MatchString(os.Getenv("ARVADOS_API_HOST_INSECURE"))
        config.ExternalClient = matchTrue.MatchString(os.Getenv("ARVADOS_EXTERNAL_CLIENT"))
 
-       return MakeArvadosClientWithConfig(config)
+       return New(config)
 }
 
 // Create a new ArvadosClient, using the given input parameters.
-func MakeArvadosClientWithConfig(config APIConfig) (ac ArvadosClient, err error) {
+func New(config APIConfig) (ac ArvadosClient, err error) {
        ac = ArvadosClient{
                ApiServer:   config.APIHost,
                ApiToken:    config.APIToken,

diff --git a/tools/keep-rsync/keep-rsync.go b/tools/keep-rsync/keep-rsync.go
index 1f00a9fdf3a6cf53ed00d9f1719c4006df726d65..6bfbbacf9a506169ce0cb96b6e549bba52413746 100644 (file)
--- a/tools/keep-rsync/keep-rsync.go
+++ b/tools/keep-rsync/keep-rsync.go
@@ -137,13 +137,13 @@ var (
 // Initializes keep-rsync using the config provided
 func initializeKeepRsync() (err error) {
        // arvSrc from srcConfig
-       arvSrc, err = arvadosclient.MakeArvadosClientWithConfig(srcConfig)
+       arvSrc, err = arvadosclient.New(srcConfig)
        if err != nil {
                return
        }
 
        // arvDst from dstConfig
-       arvDst, err = arvadosclient.MakeArvadosClientWithConfig(dstConfig)
+       arvDst, err = arvadosclient.New(dstConfig)
        if err != nil {
                return
        }

diff --git a/tools/keep-rsync/keep-rsync_test.go b/tools/keep-rsync/keep-rsync_test.go
index ae80f450eef8601bc9d7b7b402189aa1110c2c52..4fdc6a8812787f890077a49f7b461f2fd62d56bc 100644 (file)
--- a/tools/keep-rsync/keep-rsync_test.go
+++ b/tools/keep-rsync/keep-rsync_test.go
@@ -5,7 +5,6 @@ import (
        "fmt"
        "io/ioutil"
        "os"
-       "regexp"
        "testing"
 
        "git.curoverse.com/arvados.git/sdk/go/arvadostest"