14576: Adjust query for admins that filters out trashed items
authorPeter Amstutz <pamstutz@veritasgenetics.com>
Tue, 4 Dec 2018 15:43:01 +0000 (10:43 -0500)
committerPeter Amstutz <pamstutz@veritasgenetics.com>
Tue, 4 Dec 2018 15:53:59 +0000 (10:53 -0500)
refs #14576

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

services/api/app/models/arvados_model.rb

index 4e7f8f0bf7b2672e0dc264022cd1d160e76d868c..30c4c486e923f0bb00f7fde28279672ee5c9df30 100644 (file)
@@ -274,9 +274,8 @@ class ArvadosModel < ActiveRecord::Base
       if !include_trash
         if sql_table != "api_client_authorizations"
           # Only include records where the owner is not trashed
-          sql_conds = "NOT EXISTS(SELECT 1 FROM #{PERMISSION_VIEW} "+
-                      "WHERE trashed = 1 AND "+
-                      "(#{sql_table}.owner_uuid = target_uuid)) #{exclude_trashed_records}"
+          sql_conds = "#{sql_table}.owner_uuid NOT IN (SELECT target_uuid FROM #{PERMISSION_VIEW} "+
+                      "WHERE trashed = 1) #{exclude_trashed_records}"
         end
       end
     else